Finneganmac mysterious static dictionaries | Official Unity Discord | Page 1

raven roost Dec 25, 2021, 5:46 AM

#

Also, I think it's high time we turned this into a thread.

plucky mural Dec 25, 2021, 5:46 AM

#

agreed

#

please god send help

raven roost Dec 25, 2021, 5:47 AM

#

Do you have Unity set up for IDE debugging?

plucky mural Dec 25, 2021, 5:47 AM

#

thats the little bug in the bottom right?

raven roost Dec 25, 2021, 5:47 AM

#

More than that. What IDE are you using? (Fancy text editor)

plucky mural Dec 25, 2021, 5:49 AM

#

raven roost More than that. What IDE are you using? (Fancy text editor)

Visual studio?

#

or is IDE something different

raven roost Dec 25, 2021, 5:50 AM

#

Okay, so you've probably already got most of you need. Yeah, just turn on the little bug, let it recompile, then start putting stops at every step of working with the dictionaries, then press the little play button at the top of Visual Studio.

#

What you're looking for the exact point at which things go wonky.

plucky mural Dec 25, 2021, 5:51 AM

#

How do you put in stops again? I have done this before I just forgot

raven roost Dec 25, 2021, 5:51 AM

#

Click on the empty space to the left of the code lines.

plucky mural Dec 25, 2021, 5:52 AM

#

uhhhhhh

raven roost Dec 25, 2021, 5:52 AM

#

VSC, but basically the same principle.

#

When you reach a break point, VS will let you check on the state of all your variables.

plucky mural Dec 25, 2021, 5:53 AM

#

I probably have to enable debugging in VS too aswell as unity dont I

raven roost Dec 25, 2021, 5:53 AM

#

Did you get VS as part of Unity?

plucky mural Dec 25, 2021, 5:54 AM

#

yea I have it setup to work with unity \

#

strange

#

maybe computer is haunted

raven roost Dec 25, 2021, 5:56 AM

#

Do you have this button?

#

That's the play button I was referring to.

plucky mural Dec 25, 2021, 5:56 AM

#

yup it says attach to unity

#

oh oh oh oh

raven roost Dec 25, 2021, 5:56 AM

#

Press that, and then if it doesn't start automatically, run the game from Unity.

plucky mural Dec 25, 2021, 5:57 AM

#

I just figured it out lol

#

i clicked the little one to the right of the play button and now its debugging

#

okay ill plot out the breakpoints

raven roost Dec 25, 2021, 6:02 AM

#

I'ma be back in a minute. Been at this for hours, gonna grab some food.

plucky mural Dec 25, 2021, 6:04 AM

#

please do, by all means you deserve it

raven roost Dec 25, 2021, 6:13 AM

#

Dinner roll acquired. On that note, tangzhong is an amazing technique and the bread it makes is delicious.

plucky mural Dec 25, 2021, 6:13 AM

#

noted

#

okay, so what exactly are we looking for in the breakpoints?

#

because they seem to be a pain in the ass to work with right now

raven roost Dec 25, 2021, 6:14 AM

#

Hm, well first we need something to track.

#

Guess first thing to verify is whether the dictionaries are the same, or different between players.

plucky mural Dec 25, 2021, 6:17 AM

#

how would we do that?

#

I can drop in my entire script if it helps lol

raven roost Dec 25, 2021, 6:17 AM

#

Might as well at this point.

plucky mural Dec 25, 2021, 6:17 AM

#

okay one sec

#

📎 iwannadie.txt

raven roost Dec 25, 2021, 6:19 AM

#

You know Discord will let you drop the file in and automatically syntax highlight it?

plucky mural Dec 25, 2021, 6:20 AM

#

📎 PlayerManager.cs

#

the more you know

raven roost Dec 25, 2021, 6:21 AM

#

Hm. Looks like ClientPredictionTick isn't called anywhere in this script.

plucky mural Dec 25, 2021, 6:22 AM

#

Yes its called by another script that uses logic from the networking solution i chose

#

I can just zip the entire project because at this point if you have nothing else to do and are willing to go that far to help then I will

raven roost Dec 25, 2021, 6:23 AM

#

Would be much better if it were a git repository. Or maybe just the scripts folder.

plucky mural Dec 25, 2021, 6:24 AM

#

Ill just send the whole thing why not

#

gimme a couple minutes

raven roost Dec 25, 2021, 6:24 AM

#

Please don't send the entire project via zip.

plucky mural Dec 25, 2021, 6:24 AM

#

Google drive?

raven roost Dec 25, 2021, 6:25 AM

#

Unity precompiles a bunch of crap with the project and it bloats the files up huge.

#

Just the assets folder or a script folder if you have it would be ideal, if you can't use git.

plucky mural Dec 25, 2021, 6:25 AM

#

Okay scripts folder its is.

raven roost Dec 25, 2021, 6:26 AM

#

Ah, good ol' double negative boolean. private bool dontLerp = false;

plucky mural Dec 25, 2021, 6:27 AM

#

thats what amateur programming does to a man

#

theres a couple so Ill just categorize them in discord

#

here is the player-scripts:

📎 KillPlayer.cs 📎 MeleeRange.cs 📎 Player.cs 📎 GroundCheck.cs

raven roost Dec 25, 2021, 6:29 AM

#

What happened to the server stuff?

#

Ohhh, you're getting spam-checked, methinks.

plucky mural Dec 25, 2021, 6:29 AM

#

ye ill send again

raven roost Dec 25, 2021, 6:29 AM

#

Try a zip instead.

plucky mural Dec 25, 2021, 6:29 AM

#

📎 ServerHandle.cs 📎 ServerSend.cs 📎 MessageExtensions.cs 📎 NetworkManager.cs

#

there it is

raven roost Dec 25, 2021, 6:35 AM

#

Trying very hard not to optimize while looking through this.

plucky mural Dec 25, 2021, 6:35 AM

#

and dont judge my comments either

raven roost Dec 25, 2021, 6:36 AM

#

My dude,
you have

#

two static dictionaries of players.

plucky mural Dec 25, 2021, 6:36 AM

#

oh please god no

raven roost Dec 25, 2021, 6:36 AM

#

One in Player.cs and one in PlayerManager.cs

#

Pick one, delete the other, and see what errors pop up.

plucky mural Dec 25, 2021, 6:38 AM

#

oh hold on

#

I think im not smart but in a different way

#

I think I sent you the files from the client

#

I meant to only send server files

#

let me check

#

Okay so PlayerManager is a client file

#

I did not mean to send that

#

Player.cs is the correct file

#

my bad lol

raven roost Dec 25, 2021, 6:43 AM

#

You may have just taught me something about dictionaries in foreach loops.

plucky mural Dec 25, 2021, 6:43 AM

#

how so?

raven roost Dec 25, 2021, 6:44 AM

#

foreach (Player player in Player.PlayerList.Values)
I've been using foreach(var keyValuePair in someDictoinary)

#

From which I'd have to extract the value/key if I just wanted one of them.

#

There are still a couple critical functions I can't find the callers of.
Spawn and ClientPredictionTick

plucky mural Dec 25, 2021, 6:47 AM

#

they are both a part of serverhandle

#

Spawn is line 24 and ClientPredictionTick is on 19

raven roost Dec 25, 2021, 6:49 AM

#

Ah, missed that one.

#

What exactly does fromClient.Id refer to?

plucky mural Dec 25, 2021, 6:53 AM

#

Gets the Id of the client that sent the packet

#

it should be the same as the player Id because it goes in order by when they connetced

raven roost Dec 25, 2021, 6:57 AM

#

So clientTick gets passed from a message, to ServerHandle, to Player. I can't track it earlier than that, so I don't know when it's generated.

#

My hunch is that the problem is there. The assumption that it will never generate the same number for a tick twice must be false.

#

...Though, then again, the actual bug suggests it's a different, much weirder problem.

plucky mural Dec 25, 2021, 6:59 AM

#

raven roost My hunch is that the problem is there. The assumption that it will never generat...

It can generate the same tick number

#

the client sends their position at each tick up from 0

#

and it counts up every frame per player

#

which probably isnt super efficient but thats how I built it

raven roost Dec 25, 2021, 7:01 AM

#

You know what, I think my early intuition was correct. I think this is a clientside problem.
Your client has two players on screen, right? Is there a guarantee it won't send ticks for both of them?

plucky mural Dec 25, 2021, 7:03 AM

#

for each client to send a message per player?

#

for example if theres two players connected each client will send a packet ending up with 4 messages?

#

is that what youre suggesting is happening

#

oh

#

I think thats what is happening

#

let me change it ill see if it worksx

raven roost Dec 25, 2021, 7:08 AM

#

I called it, if so. #archived-code-general message

plucky mural Dec 25, 2021, 7:15 AM

#

Well, It appears to be working now. I seriously cant thank you enough for 3 hours of your time on Christmas eve

raven roost Dec 25, 2021, 7:16 AM

#

One hour of Christmas eve.

#

Two hours Christmas, now.

plucky mural Dec 25, 2021, 7:16 AM

#

the secret santa we didnt deserve

raven roost Dec 25, 2021, 7:16 AM

#

But yeah, no problem. Coding is my jam, helping people with their code is also
my jam.

#

Or cranberry sauce, in this case.

plucky mural Dec 25, 2021, 7:17 AM

#

a true saint

#

Seriously thank you. Have an incredible christmas and 2022

raven roost Dec 25, 2021, 7:18 AM

#

And it of course all wouldn't be possible without the help of Unity

being such a trash engine >w<
'Cause I usually don't touch these channels unless I have a problem of my own. I try to return the favor for at least one person.

#

You are not that person, I just got super roped into this and wanted to figure it out.

plucky mural Dec 25, 2021, 7:19 AM

#

raven roost You are not that person, I just got super roped into this and wanted to figure i...

lol

raven roost Dec 25, 2021, 7:20 AM

#

Anyway, yeah, merry christmas, glad I could help, invest in learning software architecture, try Rust lang sometime, have a good night.

#Finneganmac mysterious static dictionaries