#[BUG] [IN-95879] EntitiesGraphicsSystem.OnPerformCulling bypasses safety when group doesn't run

1 messages · Page 1 of 1 (latest)

quick frigate
#

Report: IN-95879

TLDR: Disabling PresentationSystemGroup or EntitiesGrpahicsSystem the OnPerformCulling will continue to execute every frame and will try to read entity data without dependency being passed to it.

quick frigate
# 
m_CullingJobDependency = JobHandle.CombineDependencies(m_EntitiesGraphicsRenderedQueryRO.GetDependency(), m_CullingJobDependency);

var emitDrawCommandsDependency = emitDrawCommandsJob.ScheduleWithIndirectList(visibilityItems, 1, m_CullingJobDependency);```

i've 'fixed' it locally by feeding the actual filter dependency into the emit job
stable shale
#

Thanks, we'll get this fixed

#

...oh, I read further down; is this already fixed in EG 1.4.7?

onyx sky
#

this is related to a bug i'm fixing that latios reported where onperformculling itself does not check safety

#

but i think this is a separate problem

quick frigate
#

Just to confirm the 1.4.7 change did not fix my error here

#

Didn't think it would from looking at it, but thought I would confirm

stable shale
#

@onyx sky is sorting things out with the graphics team, but it'll get fixed one way or another. Your workaround looks fine in the meantime. Thanks for the report!

quick frigate
#

@onyx sky can i confirm this wasn't fixed in 1.4.9?

#

(well i can confirm it wasn't fixed in 1.4.9, i just want to check it wasn't meant to be)