#[BUG] WithDisabled and EnabledRefRW adds wrong dependency in IJobEntity

1 messages · Page 1 of 1 (latest)

marble yoke
# 
        [WithDisabled(typeof(ActiveCancelDuration))]
        [BurstCompile]
        private partial struct CancelJob : IJobEntity
        {
            private static void Execute(EnabledRefRW<ActiveCancelDuration> activeCancelDuration)
            {
                activeCancelDuration.ValueRW = true;
            }
        }```

Generates this query

```cs
            DefaultQuery = 
                entityQueryBuilder
                    .WithDisabled<global::BovineLabs.Reaction.Data.ActiveCancelDuration>()
                    .Build(ref state);```

But this should be generating .WithDisabledRW

@steel glacier
marble yoke
#

Will make a bug report on weekend

clever pike
#

No need, I've already filed a bug internally (assigned to @steel glacier)

hidden crest
#

Could this be why I get an error about duplicate components when using a EnabledRefRW+RefRW for the same component even though that's supposed to be fixed according to the changelog, but I'm also using a WithDisabled attribute?

clever pike
#

Possibly; I'll ask the dev who made that fix if that case should be handled

hidden crest
clever pike
#

Unfortunately not, sorry; it didn't quite make the release cutoff. There will most likely be a bugfix release for 1.2 soon, and if so it would be included there.