[Bug] Having `UNITY_EDITOR` in assembly define causes it's systems to be stripped out of a build

[stiff rover]

Basically I had a define SERVER || UNITY_EDITOR, that resulted in all systems in that assembly to throw couldn't be found in the SystemRegistry. (This is likely a bug in an ILPostprocessor.) when world was created.
SERVER define was set for sure.
Simply removing || UNITY_EDITOR helped.

@frigid sinew

[shrewd stratus]

that is highly confusing

(not your description, the result)

[stiff rover]

code responsible for collection of system for SystemBaseRegistry is simply using Defines.Contains("UNITY_EDITOR") for it's logic

thus such unexpected bug

[shrewd stratus]

oh is this on the assembly def

not the script?

[stiff rover]

yes

[shrewd stratus]

hmm was this added recently

because i have
BL_DEBUG || UNITY_EDITOR

on my debug assemblies

and it worked up to quite recently

i don't recall testing in say 2-3 months though

well i do it the other way around but i can't imagine that matters

that is certainly annoying if broke now

[stiff rover]

JobReflectionDataPostProcessor.cs, line 159

[shrewd stratus]

this works fine for me, all my debug systems loaded fine in a build

[shrewd stratus]

are you sure that's right?

because constraints aren't defines

[stiff rover]

not sure how to check

but as I removed UNITY_EDITOR it's all fixed

[frigid sinew]

yeah sounds like a legit bug to me

filed internally

[shrewd stratus]

Yeah it's definitely really weird and I'm not doubting your results, just couldn't repo it myself (which is good for me). There is a chance my debug systems just don't hit the requirement for this to break.

[stiff rover]

hmm, what if you try to build via script, but add BL_DEBUG as additional define from build options, isntead of specifying it in player settings