Desperate Fight with a NRE | Official Unity Discord | Page 1

umbral spoke Sep 5, 2023, 3:40 AM

#

NullReferenceException: Object reference not set to an instance of an object
QueenPheromone.Start () (at Assets/_Scripts/AntBehavior/Pheromones/QueenPheromone.cs:24)
PheromoneMachine.Initialize (System.Collections.Generic.List`1[T] pheromones) (at Assets/_Scripts/AntBehavior/PheromoneMachine.cs:34)
Ant.AssignCaste (Caste caste) (at Assets/_Scripts/AntRelated/Ant.cs:107)
Colony.InitializeQueen () (at Assets/_Scripts/AntRelated/Colony.cs:89)
Colony.Awake () (at Assets/_Scripts/AntRelated/Colony.cs:36)
UnityEngine.Object:Instantiate(GameObject)
World:CreateColony() (at Assets/_Scripts/World.cs:90)
World:Create(Vector3) (at Assets/_Scripts/World.cs:38)
GameManager:Start() (at Assets/_Scripts/Managers/GameManager.cs:24)

#

https://gdl.space/mizabadela.cs

prime saffron Sep 5, 2023, 3:42 AM

#

umbral spoke NullReferenceException: Object reference not set to an instance of an object Que...

You didn't even include the script in which the error is happening

umbral spoke Sep 5, 2023, 3:42 AM

#

Sorry I'm working on it

#

It's very complex. I thought I had it all

prime saffron Sep 5, 2023, 3:43 AM

#

Just give the one script with the error for now

#

Pasting them all into one paste isn't that helpful since we lose line numbers

#

Include everything so the line numbers line up

umbral spoke Sep 5, 2023, 3:44 AM

#

https://gdl.space/acolivunub.cpp

prime saffron Sep 5, 2023, 3:44 AM

#

You cut out the using directives

umbral spoke Sep 5, 2023, 3:45 AM

#

https://gdl.space/viluzanati.cpp

prime saffron Sep 5, 2023, 3:45 AM

#

And the end of the script

umbral spoke Sep 5, 2023, 3:45 AM

#

Yes, sorry, I meant to close the brackets, the other parts aren't relevant

prime saffron Sep 5, 2023, 3:46 AM

#

The error is here
Debug.Log("Machine: " + machine.ToString())

#

this means machine is null

umbral spoke Sep 5, 2023, 3:46 AM

#

Yes I know the error, I've traced it all the way back. That's why I was including the other scripts

#

But I have been searching for hours on why its null

#

lol

prime saffron Sep 5, 2023, 3:46 AM

#

This means _ant.AntBehaviorMachine; is null

umbral spoke Sep 5, 2023, 3:46 AM

#

correct

#

So the sequence goes: Colony calls InitializeQueen() which creates a new Queen which calls Ant.OnStart

prime saffron Sep 5, 2023, 3:47 AM

#

Good chance that Ant.OnStart hasn't run yet

#

Or you overrided that and forgot to call the base function

umbral spoke Sep 5, 2023, 3:48 AM

#

Queen.Start calls base.OnStart()

#

It is in the first link

#

So is the OnStart method

prime saffron Sep 5, 2023, 3:49 AM

#

umbral spoke So is the `OnStart` method

InitializeQueen() happens in Awake

#

That will run before Start

#

So Queen.Start won't have run yet

umbral spoke Sep 5, 2023, 3:50 AM

#

But then why has the error-throwing code run??

prime saffron Sep 5, 2023, 3:50 AM

#

Even more so because _queen = Instantiate(_queenPrefab).GetComponent<Queen>() is happening

umbral spoke Sep 5, 2023, 3:50 AM

#

Bc the way I see the code, that code shouldn't get run until Queen.Start goes

prime saffron Sep 5, 2023, 3:50 AM

#

umbral spoke But then why has the error-throwing code run??

Because you're calling it

prime saffron Sep 5, 2023, 3:51 AM

#

umbral spoke NullReferenceException: Object reference not set to an instance of an object Que...

From this stack trace you can see QueenPheromone.Start is being called as a result of Colony.Awake()

#

Note that's not a Monobehaviour start it's just a function you're calling called Start

umbral spoke Sep 5, 2023, 3:52 AM

#

Oh let me include the PheromoneMachine code

prime saffron Sep 5, 2023, 3:52 AM

#

Not really needed

#

Seems the error is clear now to me

umbral spoke Sep 5, 2023, 3:52 AM

#

But that is the script that actually calles QueenPheromone.Start

prime saffron Sep 5, 2023, 3:52 AM

#

So?

umbral spoke Sep 5, 2023, 3:52 AM

#

or am I not seeing a line of code that calls QueenPheromone.Start?

prime saffron Sep 5, 2023, 3:52 AM

#

The stack trace already shows that

umbral spoke Sep 5, 2023, 3:52 AM

#

I don't see that

prime saffron Sep 5, 2023, 3:53 AM

#

So I don't need to see the code

#

I know it's happening

umbral spoke Sep 5, 2023, 3:53 AM

#

prime saffron From this stack trace you can see QueenPheromone.Start is being called as a resu...

Yeah but the way I read the code, it seems like Ant.OnStart should get balled before Queen.AssignCaste?

prime saffron Sep 5, 2023, 3:53 AM

#

umbral spoke NullReferenceException: Object reference not set to an instance of an object Que...

Look at the stack trace you shared. It shows the whole stack of functions being called

umbral spoke Sep 5, 2023, 3:54 AM

#

Yes, I've been scouring them up and own for the source of the problem LOL

prime saffron Sep 5, 2023, 3:54 AM

#

I just pointed out though?

umbral spoke Sep 5, 2023, 3:54 AM

#

lol that does not mean i understand

prime saffron Sep 5, 2023, 3:54 AM

#

The machine isn't assigned until Start runs on the Queen

#

You're calling a function on the Queen that assumes it has already been called

#

Before it does

umbral spoke Sep 5, 2023, 3:55 AM

#

oh i think I understand now

prime saffron Sep 5, 2023, 3:56 AM

#

_queen = Instantiate(_queenPrefab).GetComponent<Queen>();
        _queen.AssignColony(this);
        _queen.AssignCaste(casteQ);

umbral spoke Sep 5, 2023, 3:56 AM

#

So this is not a monobehavior, which means start doesn't get called

#

which is what you said

prime saffron Sep 5, 2023, 3:56 AM

#

No

#

The opposite

umbral spoke Sep 5, 2023, 3:56 AM

#

oh it's still a monobehavior for inheriting from ant?

prime saffron Sep 5, 2023, 3:56 AM

#

You are calling that start function manually inside AssigbCaste

prime saffron Sep 5, 2023, 3:56 AM

#

umbral spoke oh it's still a monobehavior for inheriting from ant?

Queen is

umbral spoke Sep 5, 2023, 3:57 AM

#

so Start does get called when it is created

prime saffron Sep 5, 2023, 3:57 AM

#

But Start runs later

#

No

#

Awake does

#

And OnEnable

#

Start runs much later

umbral spoke Sep 5, 2023, 3:57 AM

#

After all awakes?

prime saffron Sep 5, 2023, 3:57 AM

#

More like, right before its first Update

#

Could even be next frame

umbral spoke Sep 5, 2023, 3:57 AM

#

AH including after Colony's awake??

#

got it

prime saffron Sep 5, 2023, 3:58 AM

#

Other scripts aren't really relevant here

umbral spoke Sep 5, 2023, 3:58 AM

#

jesus fuck

prime saffron Sep 5, 2023, 3:58 AM

#

You're instantiating the queen

umbral spoke Sep 5, 2023, 3:58 AM

#

I shouldn't be doing it in Awake?

prime saffron Sep 5, 2023, 3:58 AM

#

By the time Instantiate returns, Awake and OnEnable on the Queen will have run

#

So you can assume they have run right after Instantiate

#

But Start will not

#

You should just do the Queen's initialization in Awake or make a custom function that initializes it and call that after Instantiate

umbral spoke Sep 5, 2023, 4:00 AM

#

My quick fix was to move the base.OnStart() call to Queen.Awake

#

The problem is that I have a large number of different objects that all need to be meshing together, and I think I need to organize that better.

#

Or time it better somehow

#Desperate Fight with a NRE