Incorrectly generated code when using a generic with SystemAPI.GetBufferTypeHandle | Official Unity Discord | Page 1

manic canyon Aug 10, 2023, 9:57 PM

#

If use SystemAPI.GetBufferTypeHandle on a generic that is constrained to IBufferElementData I can call the SystemAPI function fine in my code, but it incorrectly emits state.GetComponentTypeHandle in TypeHandle.__AssignHandles, which means the source generated file throws a compile error.

#

@crimson wyvern

#

crimson wyvern Aug 10, 2023, 9:59 PM

#

@ornate tulip

manic canyon Aug 10, 2023, 9:59 PM

#

Ah, my bad. I wasn't sure who was responsible for this 👍

crimson wyvern Aug 10, 2023, 9:59 PM

#

yeah dani is the systemapi/codegen guy

#

i generally am more on the stuff his stuff calls into, ish

ornate tulip Aug 10, 2023, 10:16 PM

#

Well, fudge, that's impractical, I found the faulty line.. don't currently have time, but if you ping me next week I'll make sure to fix it 😅

manic canyon Aug 10, 2023, 10:27 PM

#

ornate tulip Well, fudge, that's impractical, I found the faulty line.. don't currently have ...

It's not a huge deal obviously since you can just use SystemState, just wanted to let you know

#

I'll try and remember to ping you though 😅

manic canyon Aug 15, 2023, 2:02 PM

#

@ornate tulip here is the late ping 👍

#

There's also some other source generation issues I found with generics

#

If you request a type handle of a component with multiple generic arguments, this happens

#

Not exactly sure what happened here, but I'm guessing it's related

#Incorrectly generated code when using a generic with SystemAPI.GetBufferTypeHandle