Burst Compilation failing with reason 'Unknown' | Official Unity Discord | Page 1

junior goblet Aug 9, 2023, 4:47 PM

#

This is the log message:

Failed to find entry-points:
Burst.Compiler.IL.CompilerExceptionAssemblyResolution: Unable to resolve type `Schnozzle.AI.Data.IExecutionContext`1<Schnozzle.UseCase.Inputs.BasicAIInputType>. Reason: Unknown.`
  at Burst.Compiler.IL.Helpers.CecilExtensions.StrictResolve (Mono.Cecil.TypeReference typeReference) [0x0003b] in <532a8a169e6a4953b5d9a4c213b71772>:0 
  at Burst.Compiler.IL.Server.EntryPointMethodFinder.FindEntryPoints (System.String[] rootAssemblyNames, Burst.Compiler.IL.Hashing.CacheRuntime.HashCacheAssemblyStore assemblyStore, Burst.Compiler.IL.AssemblyLoader assemblyLoader, Burst.Compiler.IL.NativeCompilerOptions options, Burst.Compiler.IL.Server.ProfileDelegate profileCallback, System.Boolean includeRootAssemblyReferences, System.Boolean splitTargets) [0x00662] in <532a8a169e6a4953b5d9a4c213b71772>:0 
  at Burst.Compiler.IL.Server.CompilerServer.FindMethods (Burst.Compiler.IL.Server.CompilationRequest request, Burst.Compiler.IL.Server.Caching.CacheManager cacheManager, Burst.Compiler.IL.CompilerStatistics stats) [0x000f5] in <532a8a169e6a4953b5d9a4c213b71772>:0 
  at Burst.Compiler.IL.Server.CompilerServer+<>c__DisplayClass17_0.<Compile>b__0 (Burst.Compiler.IL.Server.Caching.CacheManager cacheManager) [0x00000] in <532a8a169e6a4953b5d9a4c213b71772>:0 
  at Burst.Compiler.IL.Server.CompilerServer+<>c__DisplayClass26_0`1[TResult].<RunTask>b__0 () [0x00145] in <532a8a169e6a4953b5d9a4c213b71772>:0 
  at Burst.Compiler.IL.Server.CompilerServer.RunTask[TResult] (Burst.Compiler.IL.Server.TargetKey target, System.String taskName, System.String[] assemblyFolders, System.Threading.CancellationToken cancellationToken, System.Func`2[T,TResult] function) [0x00131] in <532a8a169e6a4953b5d9a4c213b71772>:0 
  at Burst.Compiler.IL.Server.CompilerServer.Compile (Burst.Compiler.IL.Server.CompilationRequest request, Burst.Compiler.IL.Server.CompilationMessageStreamer streamer, System.Threading.CancellationToken cancellationToken) [0x0017f] in <532a8a169e6a4953b5d9a4c213b71772>:0 

While compiling job:
TypeManager.Initialize took: 132ms
Mono: successfully reloaded assembly
- Finished resetting the current domain, in  1.938 seconds
Domain Reload Profiling: 2744ms
    BeginReloadAssembly (518ms)
        ExecutionOrderSort (0ms)
        DisableScriptedObjects (29ms)
        BackupInstance (0ms)
        ReleaseScriptingObjects (0ms)
        CreateAndSetChildDomain (379ms)
    RebuildCommonClasses (21ms)

empty basin Aug 9, 2023, 4:48 PM

#

to start with you might as well try burst 1.8.8, because e.g. - Fix compiler crash when compiling different assemblies that define methods or types with the exact same name and namespace

junior goblet Aug 9, 2023, 4:52 PM

#

It doesn't seem to have thrown an error yet, ill try instantiating the generic system and jobs

empty basin Aug 9, 2023, 4:54 PM

#

there are not a ton of examples of it happening internally; it's pretty much either a) when somebody was working on a compilation pipe and screwed it up, or b) burst was asked to burst a parameter type that was crazy in some way

junior goblet Aug 9, 2023, 4:54 PM

#

Yeah I'm assuming I'm just doing something that's not allowed, this has a lot of generics

#

When registering the job it throws an error now

#

📎 message.txt

empty basin Aug 9, 2023, 4:55 PM

#

paste your system declaration? just the top line with the struct

#

and then the registergeneric lines

junior goblet Aug 9, 2023, 4:55 PM

#

[assembly: RegisterGenericSystemType(
    typeof(AIExecutionSystem<
        GameContext,
        DecisionSetBuffer<GameContext, BasicAIInputType>,
        BasicAIInputType
    >)
)]
[assembly: RegisterGenericSystemType(
    typeof(AIExecutorJob<
        GameContext,
        DecisionSetBuffer<GameContext, BasicAIInputType>,
        BasicAIInputType
    >)
)]

empty basin Aug 9, 2023, 4:56 PM

#

errr AIExecutorJob is a system, despite being named job?

junior goblet Aug 9, 2023, 4:56 PM

#

🙃

#

copy paste

empty basin Aug 9, 2023, 4:56 PM

#

i may have forgotten to guard against trying to register non-systems as systems

junior goblet Aug 9, 2023, 4:56 PM

#

Still throws an error though

empty basin Aug 9, 2023, 4:57 PM

#

wait so what does it look like now

junior goblet Aug 9, 2023, 4:57 PM

#

📎 message.txt

#

[assembly: RegisterGenericSystemType(
    typeof(AIExecutionSystem<
        GameContext,
        DecisionSetBuffer<GameContext, BasicAIInputType>,
        BasicAIInputType
    >)
)]

[assembly: RegisterGenericJobType(
    typeof(AIExecutorJob<
        GameContext,
        DecisionSetBuffer<GameContext, BasicAIInputType>,
        BasicAIInputType
    >)
)]

empty basin Aug 9, 2023, 4:57 PM

#

ok, and paste top line of AIExecutionSystem?

junior goblet Aug 9, 2023, 4:57 PM

#

    public partial struct AIExecutionSystem<TExecutionContext, TDecisionSetBuffer, TEnum> : ISystem
        where TExecutionContext : unmanaged, IExecutionContext<TEnum>
        where TDecisionSetBuffer : unmanaged, IDecisionSetBuffer<TExecutionContext, TEnum>
        where TEnum : unmanaged, Enum

empty basin Aug 9, 2023, 4:58 PM

#

oh dear

junior goblet Aug 9, 2023, 4:58 PM

#

Yep

#

I think I'm just going to abandon this idea

#

Too many generics

#

Trying to write this so it can live in an assembly above the game code

empty basin Aug 9, 2023, 4:58 PM

#

i imagine you could make it work but it'd be surprising to me if it was worth it

junior goblet Aug 9, 2023, 4:58 PM

#

And it's making it very difficult

#

Any idea why it's failing though?

#

Just so I can avoid whatever that is when writing code

empty basin Aug 9, 2023, 5:00 PM

#

i haven't the foggiest

junior goblet Aug 9, 2023, 5:00 PM

#

I just started writing this today in a completely separate unity project, I can send it to you if you want. Otherwise Ill just scrap it and try to re-write it some other way

empty basin Aug 9, 2023, 5:01 PM

#

oh crap

#

i bet this is just my fault for not converting some crap into other stuff when i was supposed to

junior goblet Aug 9, 2023, 5:01 PM

#

It failed on 1.8.7 as well though

empty basin Aug 9, 2023, 5:01 PM

#

no not to do with burst

#

i just emitted some bad bad stuff

#

please hold

#

i bet this is a 1-2 line fix

#

internalize the entities package

#

and then edit Packages/com.unity.entities/Unity.Entities.CodeGen/ISystemPostProcessor.cs

#

starting line 185 or so there should be wrapperName = specializedSystemType.FullName.Replace('/', '_') .Replace('`', '_') .Replace('.', '_') .Replace('<', '_') .Replace('>', '_') + "_" + name;

#

which is replacing all these different characters that aren't supposed to be in names with '_'

junior goblet Aug 9, 2023, 5:04 PM

#

Alright, give me a sec

#

I found it, but what should I change it to?

empty basin Aug 9, 2023, 5:05 PM

#

change it to this: wrapperName = specializedSystemType.FullName.Replace('/', '_') .Replace('`', '_') .Replace('.', '_') .Replace(',', '_') .Replace(' ', '_') .Replace('=', '_') .Replace('-', '_') .Replace('<', '_') .Replace('>', '_') + "_" + name;

junior goblet Aug 9, 2023, 5:09 PM

#

That seems to have worked, at least I don't get a compile error anymore

empty basin Aug 9, 2023, 5:09 PM

#

awesome

junior goblet Aug 9, 2023, 5:10 PM

#

I get a different error now but it's probably not related

empty basin Aug 9, 2023, 5:10 PM

#

👍

junior goblet Aug 9, 2023, 5:10 PM

#

Are you not allowed to use EntityQueryBuilder.WithAll<> on an aspect?

empty basin Aug 9, 2023, 5:10 PM

#

dunno anything about aspects

#

@delicate sierra tends to know those things probably

junior goblet Aug 9, 2023, 5:11 PM

#

Yep, I'll ask them

#

Thanks for the help on fixing this ❤️

empty basin Aug 9, 2023, 5:11 PM

#

np! will try to get this in a patch release

junior goblet Aug 9, 2023, 5:12 PM

#

What was the issue? The commas in the type declerations?

empty basin Aug 9, 2023, 5:12 PM

#

yeah

#

i was supposed to convert them to something else and i didnt'

delicate sierra Aug 9, 2023, 5:12 PM

#

Ayooo, one sec, I'll read

empty basin Aug 9, 2023, 5:12 PM

#

don't read the whole thing @delicate sierra

#

just the aspect bit

junior goblet Aug 9, 2023, 5:12 PM

#

delicate sierra Ayooo, one sec, I'll read

None of the stuff that was written has todo with the last question

#

I can also open a separate thread

empty basin Aug 9, 2023, 5:12 PM

#

#1138876097912635533 message

#

just that bit

delicate sierra Aug 9, 2023, 5:13 PM

#

junior goblet Are you not allowed to use ``EntityQueryBuilder.WithAll<>`` on an aspect?

Argh gotcha, inside or just query for an aspect? As I think we added WithAspect

junior goblet Aug 9, 2023, 5:14 PM

#

delicate sierra Argh gotcha, inside or just query for an aspect? As I think we added WithAspect

My bad, I missed the (new?) WithAspect builder method

delicate sierra Aug 9, 2023, 5:14 PM

#

As for using it inside an aspect, that entirely depends on where you're calling it from, given you would need either a System or an EntityManager to build the query 😅

delicate sierra Aug 9, 2023, 5:14 PM

#

junior goblet My bad, I missed the (new?) WithAspect builder method

No problem!

junior goblet Aug 9, 2023, 5:15 PM

#

empty basin awesome

The system also appears correctly in the system viewer so everthing seems to be working 👍

#

I'll close this

delicate sierra Aug 9, 2023, 5:16 PM

#

I will say, nice to see people still tagging me, now that I'm less active in here than I used to be 👀 (don't hesitate to reach out)

junior goblet Aug 9, 2023, 5:17 PM

#

haha

junior goblet Aug 9, 2023, 5:17 PM

#

delicate sierra Argh gotcha, inside or just query for an aspect? As I think we added WithAspect

~~Is there a reason the generic parameter in WithAspect isn't constrained to IAspect?~~

#

nevermind I'm blind, it is

delicate sierra Aug 9, 2023, 5:17 PM

#

junior goblet ~~Is there a reason the generic parameter in ``WithAspect`` isn't constrained to...

It isn't o.o

#

Good, I would think it were xD

junior goblet Aug 9, 2023, 5:17 PM

#

I was looking at WithAll which has no constraints

delicate sierra Aug 9, 2023, 5:17 PM

#

Yeah that makes sense

junior goblet Aug 9, 2023, 5:18 PM

#

I guess analyzers would help here with making less mistakes, since you cant constraint it to not aspects, but it's probably not a huge deal

#

Since it's immediately noticeable

delicate sierra Aug 9, 2023, 5:20 PM

#

Yuppp, but I feel like there's so many cool and nice analyzer tool things we can do in the future, tho I'm sure Rider will come there before us xD

junior goblet Aug 9, 2023, 5:22 PM

#

Yeah rider has a few cool things already

delicate sierra Aug 9, 2023, 5:22 PM

#

E.g. they accidentally made the partial check analysis a few days after I did 😆

#Burst Compilation failing with reason 'Unknown'