I cant push the enemy because its following me | Official Unity Discord | Page 1

trail sorrel Jul 29, 2023, 10:07 PM

#

so I am trying to disable following script (https://hatebin.com/umptthqpmp)
when Im trying to push enemy it doesnt go away
disablingscript(https://hatebin.com/pmszfabtrw)

trail sparrow Jul 29, 2023, 10:39 PM

#

trail sorrel so I am trying to disable following script (https://hatebin.com/umptthqpmp) when...

Test this while in play mode.
Set your inspector to Debug mode.
Pause when the enemy script should be disabled.
Select the enemy object, and see if the script is indeed disabled, via the inspector.

trail sorrel Jul 29, 2023, 10:42 PM

#

it is not disabling as I can see

trail sparrow Jul 29, 2023, 10:45 PM

#

Alright, before proceeding, there is a minor naming convention issue.

private GameObject GameObject;
//..
public GameObject gameobject;

That practice is very discouraged, as it easily leads to confusion.
While it is possible, it is rarely practical, especially when others read it.
This would be better:

private GameObject _other;
//..
public GameObject Other;

#

Now, inside ScriptFalse()

    private void ScriptFalse()
    {
        Other.GetComponent<EnemyMovement>().enabled = false;
        Debug.Log("Disabled EnemyMovement for: " + Other.name); // Add this <--
    }

trail sorrel Jul 29, 2023, 10:51 PM

#

trail sparrow Alright, before proceeding, there is a minor naming convention issue. ```cs pri...

are you correcting or should I add one more

trail sparrow Jul 29, 2023, 10:51 PM

#

Correcting your existing variable names.

trail sorrel Jul 29, 2023, 10:51 PM

#

I have only one here

trail sparrow Jul 29, 2023, 10:52 PM

#

There are two scripts.

trail sorrel Jul 29, 2023, 10:53 PM

#

okay I did things you said playing

trail sparrow Jul 29, 2023, 10:53 PM

#

playing?

#

to be clear: The scripts are to be changed before entering Play Mode.

trail sorrel Jul 29, 2023, 10:55 PM

#

trail sparrow to be clear: The scripts are to be changed **before** entering Play Mode.

I did it like that but I wrote wrong

trail sparrow Jul 29, 2023, 10:55 PM

#

ok

#

Any progress?

trail sorrel Jul 29, 2023, 10:59 PM

#

Its like blinking

#

        if (physicsPickupScript != null && physicsPickupScript.hold == true)
        {
            ScriptFalse();
            if (Input.GetKeyDown(KeyCode.F))
            {
                ScriptFalse();
                
            }
        }```

#

I changed this like that

#

just tried

#

still enables it even when hold is true

#

Its getting enabled and disabled repeatedly while I am holding

trail sparrow Jul 29, 2023, 11:17 PM

#

Ah yes, I see why

#

    private void Update()
    {
        if (physicsPickupScript != null && physicsPickupScript.hold == true)
        {
            ScriptFalse(); // <--- This will always run when Hold == true. 
            if (Input.GetKeyDown(KeyCode.F))
            { 
                Invoke("ScriptTrue", 2);
            }
        }

        if (physicsPickupScript != null && physicsPickupScript.hold == false)
        {
            Invoke("ScriptTrue",2); 
        }
    }

@trail sorrel

#

wait, that's not right

#

(it's late here)

#

Can you show the pickup script?

#

PS: It's beyond midnight here, and if you don't respond fast, I'll probably get distracted.

trail sorrel Jul 29, 2023, 11:25 PM

#

trail sparrow Can you show the pickup script?

https://hatebin.com/grqrikacsc

trail sparrow Jul 29, 2023, 11:34 PM

#

Alright.
Since the SomeScript is depending on another script's hold property, things could get difficult to debug.
Instead of polling with complex if-chains, it's possible to simplify this by calling Public methods on other scripts, ultimately allowing them to control themselves, instead of each other.

Before I continue, are you following a tutorial?
@trail sorrel

trail sorrel Jul 29, 2023, 11:34 PM

#

I followed

#

but not right now

trail sparrow Jul 29, 2023, 11:36 PM

#

if you're done with the tutorial, that is fine
if not, it might cause trouble later

trail sorrel Jul 29, 2023, 11:36 PM

#

I'm done

#

hold is true but it enables and disables did the debug.log in somescript

trail sparrow Jul 29, 2023, 11:38 PM

#

I'm making assumptions of how your game works, so correct me if I'm wrong.

In your PhysicsPickup script you have a Raycast.
In that raycast (if it hits), you can do hit.gameObject.TryGetComponent<EnemyMovement>(out EnemyMovement enemy)

trail sorrel Jul 29, 2023, 11:40 PM

#

which line do you mean 55?

trail sparrow Jul 29, 2023, 11:41 PM

#

there is only one Raycast in the entire script

#

yes

#

Then you can make a Public method in the EnemyMovement script
and use that if the raycast hits.

trail sorrel Jul 29, 2023, 11:43 PM

#

should I add hit.gameObject.TryGetComponent<EnemyMovement>(out EnemyMovement enemy) under if or in the pharanthesis

trail sparrow Jul 29, 2023, 11:45 PM

#

if (Raycast(...)) // True when hitting something. 
{
    // This only happens if the Raycast hits a collider. 
}

#

inside the { brackets }

trail sorrel Jul 29, 2023, 11:46 PM

#

But I still need to add the hold variable I think

#

because shouldnt it disable the script when I look at the enemy

trail sparrow Jul 29, 2023, 11:47 PM

#

There are more things to do, yes.

#

If I understand your code correctly,
void grav() should reverse the process

#

Though it's a bit tricky to follow what happens.

trail sorrel Jul 29, 2023, 11:52 PM

#

you mean like = !usegravity

trail sparrow Jul 29, 2023, 11:52 PM

#

I mean the method itself

#

grav()

#

btw all methods should be PascalCase()

#

private fields should be _camelCase prefixed with

trail sorrel Jul 29, 2023, 11:53 PM

#

I didnt know it thanks

trail sparrow Jul 29, 2023, 11:53 PM

#

_

#

and Properties should be PascalCase, but never the same name as its type

trail sorrel Jul 29, 2023, 11:54 PM

#

where do I get the name hit

trail sparrow Jul 29, 2023, 11:54 PM

#

local variables (inside methods) have camelCasing without _

trail sparrow Jul 29, 2023, 11:55 PM

#

trail sorrel where do I get the name hit

RaycastHit hit is normal convention
While yours is named different, I made the example with simply hit

trail sorrel Jul 29, 2023, 11:57 PM

#

what is mine called if you can see , I dont know much about this raycast thing

trail sparrow Jul 29, 2023, 11:57 PM

#

did you not write this code yourself?

trail sorrel Jul 29, 2023, 11:58 PM

#

I took it from the tutorial

trail sparrow Jul 29, 2023, 11:58 PM

#

link the tutorial

trail sorrel Jul 29, 2023, 11:58 PM

#

I got the picking up and then wrote other one myself

#

I dont remember but I think

trail sparrow Jul 29, 2023, 11:59 PM

#

Are the variable names from the tutorial?

trail sorrel Jul 30, 2023, 12:00 AM

#

https://www.youtube.com/watch?v=zgCV26yFAiU&ab_channel=Rytech

YouTube

Rytech

How to Make a Physics Pickup System in Unity in 3 Minutes

In this video, I go over how you can make a physics pickup system in Unity in 3 Minutes.

Join my Discord! ► https://discord.gg/jrRJgfBz2y

#UnityTutorials #Unity3D

-= Music =-

Music: Dopamine
Artist : DZGRIMX
link to the video: https://youtu.be/3S6uyNk9HpY
channel: https://www.youtube.com/channel/UCB...

▶ Play video

#

probably some of them

trail sorrel Jul 30, 2023, 12:02 AM

#

trail sparrow Are the variable names from the tutorial?

I dont remember if I changed some of them

trail sparrow Jul 30, 2023, 12:02 AM

#

trail sorrel I dont remember if I changed some of them

I just watched half. It's from the tutorial.

#

I'm sure it gets the desired result, but that tutorial has no idea of C# naming convention, which makes it a bad tutorial.
There's enough to learn, so we don't need confusion 😆

trail sorrel Jul 30, 2023, 12:06 AM

#

trail sparrow I'm sure it gets the desired result, but that tutorial has no idea of C# naming ...

I have no idea too, thats the reason I didnt notice 😆

trail sparrow Jul 30, 2023, 12:09 AM

#

So anyway, the tutorial assumes people know how Raycasts work.

Raycast has a number of different overloads.
https://docs.unity3d.com/ScriptReference/Physics.Raycast.html

out RaycastHit is in some of them.

out means it's not an argument the method absorbs, but an argument to which a result is given.
RaycastHit contains information about the hit

RaycastHit hit;
if(Raycast(..., out hit, ...))
{
    Debug.Log(hit.gameObject.name)
}

Can also be written like this, to avoid an unnecessary line of code.

if(Raycast(..., out RaycastHit hit, ...))
{
    Debug.Log(hit.gameObject.name)
}

#

so if the Raycast actually hits something, everything in the if-statement will run

#

hit doesn't exist outside the if-statement, unless you declare it, like the first example

trail sorrel Jul 30, 2023, 12:13 AM

#

                    if (Physics.Raycast(CameraRay, out hit, PickupRange, PickupMask))
                    {
                        hit.gameObject.TryGetComponent<EnemyMovement>(out EnemyMovement enemy);
                        CurrentObject = hit.rigidbody;
                        CurrentObject.useGravity = false;
                    }``` I get 'RaycastHit' does not contain a definition for 'gameObject' and no accessible extension method 'gameObject' accepting a first argument of type 'RaycastHit' could be found (are you missing a using directive or an assembly reference?) on the line starting with hit

#

is it because I havent got a gameObject

trail sparrow Jul 30, 2023, 12:15 AM

#

https://docs.unity3d.com/ScriptReference/RaycastHit.html

#

Minor mistake from my side.
RaycastHit doesn't directly reference gameObject.
But you can get it from either collider, rigidbody or transform

trail sorrel Jul 30, 2023, 12:16 AM

#

👍

trail sparrow Jul 30, 2023, 12:16 AM

#

name also exists on all those, so gameObject isn't necessary

#

Next:
private Rigidbody CurrentObject;
should be changed into
private EnemyMovement CurrentObject;

trail sorrel Jul 30, 2023, 12:22 AM

#

                    if (Physics.Raycast(CameraRay, out hit, PickupRange, PickupMask))
                    {
                        if (hold == true)
                        {
                            hit.rigidbody.TryGetComponent<EnemyMovement>(out EnemyMovement enemy);
                            
                        }``` its like that now

trail sparrow Jul 30, 2023, 12:22 AM

#

EnemyMovement should implement a public method named GetPickedUp()
And a method named GetDropped()

run CurrentObject.GetPickedUp() from the raycast if-statement
run CurrentObject.GetDropped() from grav()

trail sorrel Jul 30, 2023, 12:23 AM

#

I should get the disabling line under hit.rigidbody.TryGetComponent<EnemyMovement>(out EnemyMovement enemy);
right

trail sparrow Jul 30, 2023, 12:23 AM

#

not sure about 'disabling line', but I'll make it clear in a sec

#

if (Raycast...) 
{
    hit.rigidbody.TryGetComponent<EnemyMovement>(out EnemyMovement enemy);
    if (enemy) 
    {
        enemy.GetPickedUp();
        CurrentObject = enemy;
    }
}

trail sorrel Jul 30, 2023, 12:26 AM

#

is enemy here gameobjects name

trail sparrow Jul 30, 2023, 12:27 AM

#

it's the same gameobject, but different component

#

While this current code example uses the EnemyMovement component,
that is going to be changed last, so that any type of script can be picked up, if implemented.

trail sorrel Jul 30, 2023, 12:29 AM

#

is there something about the enemys name in hierarchy there?

trail sparrow Jul 30, 2023, 12:29 AM

#

What do you mean?

trail sorrel Jul 30, 2023, 12:29 AM

#

trail sparrow What do you mean?

like I got 2 enemies

#

one of them is Enemy other one is Enemy (1)

trail sparrow Jul 30, 2023, 12:30 AM

#

their names mean nothing in this code

#

the only reason we used Debug.Log(name) earlier, was to confirm which object was being hit

trail sorrel Jul 30, 2023, 12:31 AM

#

hit.rigidbody.TryGetComponent<EnemyMovement>(out EnemyMovement enemy);
Cannot implicitly convert type 'EnemyMovement' to 'UnityEngine.Rigidbody'

#

what do you reccomend after hit in first line here

trail sparrow Jul 30, 2023, 12:32 AM

#

hit.transform.gameObject

#

not rigidbody 😅

trail sorrel Jul 30, 2023, 12:32 AM

#

trail sparrow hit.transform.gameObject

okay trying

#

                            if (enemy)
                            {
                                enemy.GetPickedUp();
                                CurrentObject = enemy;
                            }
                        }
                        CurrentObject = hit.transform;
                        CurrentObject.useGravity = false;```
is this true?

#

Cannot implicitly convert type 'UnityEngine.Transform' to 'UnityEngine.Rigidbody'
Cannot implicitly convert type 'EnemyMovement' to 'UnityEngine.Rigidbody'

trail sparrow Jul 30, 2023, 12:35 AM

#

No. This is:

if (Raycast...) 
{
    hit.transform.gameObject.TryGetComponent<EnemyMovement>(out EnemyMovement enemy);
    if (enemy) 
    {
        enemy.GetPickedUp();
        CurrentObject = enemy;
    }
}

#

useGravity will be moved to the EnemyMovement script, inside GetPickedUp() and GetDropped()

trail sorrel Jul 30, 2023, 12:36 AM

#

okay

#

CurrentObject = hit.transform;
CurrentObject.useGravity = false;
so deleting these

trail sparrow Jul 30, 2023, 12:37 AM

#

yes, it should look exactly like what I posted, minus the simplified raycast

trail sorrel Jul 30, 2023, 12:38 AM

#

Cannot implicitly convert type 'EnemyMovement' to 'UnityEngine.Rigidbody'

trail sparrow Jul 30, 2023, 12:38 AM

#

If you don't want to delete, you can
Comment by selecting the lines and pressing CTRL + K + C
Uncomment by CTRL + K + U

trail sorrel Jul 30, 2023, 12:38 AM

#

trail sorrel `Cannot implicitly convert type 'EnemyMovement' to 'UnityEngine.Rigidbody'`

CurrentObject = enemy;

trail sparrow Jul 30, 2023, 12:39 AM

#

go to the declaration of CurrentObject, and change its type from Rigidbody to EnemyMovement

#

This is the declaration:

private Rigidbody CurrentObject;

trail sorrel Jul 30, 2023, 12:41 AM

#

okay I changed it get some errors

#

about functions

#

Getpickedup ,usegravity ,velocity and position

trail sparrow Jul 30, 2023, 12:43 AM

#

Hm. I didn't consider the FixedUpdate, sec

#

go to the EnemyMovement script and create the public methods GetPickedUp() and GetDropped()

trail sorrel Jul 30, 2023, 12:46 AM

#

trail sparrow go to the EnemyMovement script and create the public methods GetPickedUp() and G...

okay I did

trail sparrow Jul 30, 2023, 12:47 AM

#

Hm, I'm not sure I have the brainpower to work through this obstacle right now.
But we can work around it.
My idea was to limit direct control to each class for itself, and keep other interactions via methods.
You can probably fix that later, but it might Not be necessary.

#

So to work around it, change CurrentObject back to Rigidbody
and I'll rewrite the Raycast

#

below the declaration of CurrentObject
make a private EnemyMovement CurrentMovement;

#

if (Raycast...) 
{
    hit.transform.gameObject.TryGetComponent<EnemyMovement>(out EnemyMovement enemy);
    if (enemy) 
    {
        enemy.GetPickedUp();
        CurrentObject = hit.rigidbody;
        CurrentMovement = enemy;
    }
}

trail sorrel Jul 30, 2023, 12:50 AM

#

I got no errors now

trail sparrow Jul 30, 2023, 12:51 AM

#

Good.
Then add

CurrentMovement.GetDropped();

into grav()

trail sorrel Jul 30, 2023, 12:52 AM

#

Getdropped and getpickedup are still empty

trail sparrow Jul 30, 2023, 12:52 AM

#

as well as

CurrentMovement = null;

trail sorrel Jul 30, 2023, 12:53 AM

#

trail sparrow as well as ```cs CurrentMovement = null; ```

to grav?

trail sparrow Jul 30, 2023, 12:53 AM

#

yes

#

at the end

trail sorrel Jul 30, 2023, 12:53 AM

#

👍

trail sparrow Jul 30, 2023, 12:56 AM

#

In EnemyMovement add a private bool _canMove = true;
In GetPickedUp() set _canMove = false;
in GetDropped() set _canMove = true;

in FixedUpdate() add this line at the top:

if (_canMove == false) return;

#

if that statement is true, the rest of FixedUpdate won't be run, because it returns early

#

thus cancelling the movement
just as effectively as disabling the script should
but more flexible, as we can still do things with the script

trail sorrel Jul 30, 2023, 12:58 AM

#

The name '_canMove' does not exist in the current context

trail sparrow Jul 30, 2023, 12:59 AM

#

The first instruction up there

#

In EnemyMovement add a private bool _canMove = true;

trail sorrel Jul 30, 2023, 12:59 AM

#

trail sparrow if that statement is true, the rest of FixedUpdate won't be run, because it retu...

that makes sense

trail sorrel Jul 30, 2023, 12:59 AM

#

trail sparrow > In EnemyMovement add a **private bool _canMove = true;**

I did

trail sparrow Jul 30, 2023, 1:00 AM

#

post the full script

trail sorrel Jul 30, 2023, 1:00 AM

#

enemy movemnt

trail sparrow Jul 30, 2023, 1:00 AM

#

yes

trail sorrel Jul 30, 2023, 1:00 AM

#

https://hatebin.com/sujtvyvqiq

trail sparrow Jul 30, 2023, 1:01 AM

#

Alright. No errors?

#

I think it should be ready for testing now.

trail sorrel Jul 30, 2023, 1:02 AM

#

trail sorrel The name '_canMove' does not exist in the current context

I got this one

trail sparrow Jul 30, 2023, 1:02 AM

#

Hm. It is there, though.

#

Copy the error and post it here.

trail sorrel Jul 30, 2023, 1:03 AM

#

Assets\PhysicsPickup.cs(113,13): error CS0103: The name '_canMove' does not exist in the current context

#

if (_canMove == false) return;

#

ohh

trail sparrow Jul 30, 2023, 1:03 AM

#

it shouldn't be in that script
That line is supposed to be inside EnemyMovement.FixedUpdate()

trail sorrel Jul 30, 2023, 1:04 AM

#

I forgot about fixed update in enemymovement

trail sparrow Jul 30, 2023, 1:04 AM

#

Good stuff.
Try it out now, and see if it all works or not.

trail sorrel Jul 30, 2023, 1:04 AM

#

trying

#

okay I can throw it properly

#

when I throw it doesn walk anymore

trail sparrow Jul 30, 2023, 1:06 AM

#

Hm. Post your Pickup script.

trail sorrel Jul 30, 2023, 1:06 AM

#

trying one more time

#

https://hatebin.com/fnejdqddof

trail sparrow Jul 30, 2023, 1:08 AM

#

so when you throw the enemy, it doesn't follow the player anymore
but it was moving before picking it up?

trail sorrel Jul 30, 2023, 1:08 AM

#

trail sparrow so when you throw the enemy, it doesn't follow the player anymore but it was mov...

yeah

trail sparrow Jul 30, 2023, 1:09 AM

#

Did this somehow work before my changes?

trail sorrel Jul 30, 2023, 1:10 AM

#

trail sparrow Did this somehow work before my changes?

like I couldnt throw just dropping it

#

and it was following

trail sparrow Jul 30, 2023, 1:10 AM

#

hm ok

trail sorrel Jul 30, 2023, 1:11 AM

#

We have nothing about SomeScript right?

#

so I can remove it from enemy

trail sparrow Jul 30, 2023, 1:11 AM

#

trail sorrel We have nothing about SomeScript right?

Yeah, that one was 100% replaced by these changes.

#

inside GetDropped()
try setting velocity to Vector3.zero

#

might not work, due to the throwing.
I'm not sure what comes first.

#

actually, now I realize

#

kinematic

#

hm, maybe that's not it

trail sorrel Jul 30, 2023, 1:14 AM

#

trail sparrow inside GetDropped() try setting velocity to Vector3.zero

should I try this

trail sparrow Jul 30, 2023, 1:15 AM

#

yes, do try and see if it helps

trail sorrel Jul 30, 2023, 1:15 AM

#

like rigidbody.velocity

trail sparrow Jul 30, 2023, 1:15 AM

#

yes

trail sorrel Jul 30, 2023, 1:16 AM

#

    {
        _canMove = true;
        rb.velocity = new Vector3(0, 0, 0);
    }```

trail sparrow Jul 30, 2023, 1:16 AM

#

Vector3.zero also works

trail sorrel Jul 30, 2023, 1:17 AM

#

after I throw

#

when I press e one more time

#

enemy starts moving

#

maybe thats because somescript I didnt remove it

trail sorrel Jul 30, 2023, 1:19 AM

#

trail sorrel maybe thats because somescript I didnt remove it

no it isnt

#

_canmove gets false but doesnt get true till I pick enemy

#

up

trail sparrow Jul 30, 2023, 1:21 AM

#

that's the opposite of what should happen 🤔

#

code looks good on my side.
Did you update anything?

#

add a Debug.Log() to GetDropped()

#

add one to GetPickedUp() as well

trail sorrel Jul 30, 2023, 1:26 AM

#

when I drop enemy it resumes following

#

but when I throw it doesnt

#

it calls get dropped function only when I press e

#

thats the reason I think

trail sparrow Jul 30, 2023, 1:27 AM

#

Sounds good. Let's stare at some code.

#

Line 99 in PhysicsPickup

#

I need a few moments to come up with how this should be.
The enemy needs a GetThrown() method

trail sorrel Jul 30, 2023, 1:30 AM

#

If you are tired we can continue later you said it is midnight

trail sparrow Jul 30, 2023, 1:31 AM

#

In the EnemyMovement script, on the top or bottom, add the following:

private enum EnemyState
{
    Moving,
    NotMoving,
    Thrown
}

#

Do you know about enums?

trail sorrel Jul 30, 2023, 1:31 AM

#

I have never heard about them

trail sparrow Jul 30, 2023, 1:31 AM

#

trail sorrel If you are tired we can continue later you said it is midnight

I'm on fire right now, and the end is near in sight.

#

enums are numbers disguised as text

#

private enum EnemyState
{
    Moving = 1,
    NotMoving = 2,
    Thrown = 3
}

trail sorrel Jul 30, 2023, 1:32 AM

#

oh okay

trail sparrow Jul 30, 2023, 1:32 AM

#

they can have any number
the numbers are mostly important for other things

#

Since the Enemy will have more than two states,
it will be much more easy to keep track of the code logic, if we use a switch (aka state machine)

#

private EnemyState _state;

private void FixedUpdate()
{
    switch (_state)// Autocomplete here, and it should create the entire switch
}

#

do Not delete anything yet

trail sorrel Jul 30, 2023, 1:36 AM

#

which script

trail sparrow Jul 30, 2023, 1:36 AM

#

EnemyMovement

trail sorrel Jul 30, 2023, 1:36 AM

#

ok

trail sparrow Jul 30, 2023, 1:38 AM

#

in case it doesn't autocomplete, like it didn't for me just now

switch (_state)
{
    case EnemyState.Moving:
        // All the existing FixedUpdate() code goes here, minus the first line that returns
        break;
    case EnemyState.NotMoving:
        break;
    case EnemyState.Thrown:
        break;
}

#

However

#

instead of placing the code directly in the switch

#

make a method

#

and call it from the switch

#

(much more readable)

trail sorrel Jul 30, 2023, 1:39 AM

#

The type or namespace name 'EnemyState' could not be found (are you missing a using directive or an assembly reference?)

#

I got this error

trail sparrow Jul 30, 2023, 1:40 AM

#

private enum EnemyState _state;

#

and you need to create the enum

#

private enum EnemyState
{
    Moving = 1,
    NotMoving = 2,
    Thrown = 3
}

#

Note: EnemyState might be a bad word. It could be InternalState.

trail sorrel Jul 30, 2023, 1:40 AM

#

okay got rid of it

trail sorrel Jul 30, 2023, 1:41 AM

#

trail sparrow Note: EnemyState might be a bad word. It could be InternalState.

no problem

trail sorrel Jul 30, 2023, 1:43 AM

#

trail sparrow in case it doesn't autocomplete, like it didn't for me just now ```cs switch (_s...

should it be _state

trail sparrow Jul 30, 2023, 1:44 AM

#

the variable name, yes

trail sorrel Jul 30, 2023, 1:44 AM

#

because I got an error

#

The name '_state' does not exist in the current context

trail sparrow Jul 30, 2023, 1:44 AM

#

This was supposed to be declared:

private EnemyState _state;

trail sorrel Jul 30, 2023, 1:45 AM

#

I thout we made something wrong about a line but it was a different line

#

now codes okay

trail sparrow Jul 30, 2023, 1:45 AM

#

Good. Have you moved all the code from FixedUpdate() into a separate method?

#

(minus the switch)

trail sorrel Jul 30, 2023, 1:46 AM

#

// All the existing FixedUpdate() code goes here, minus the first line that returns

#

I put them here

trail sparrow Jul 30, 2023, 1:47 AM

#

trail sorrel Jul 30, 2023, 1:48 AM

#

where should I put the first line that returns

trail sparrow Jul 30, 2023, 1:48 AM

#

switch (_state)
{
    case EnemyState.Moving:
        Moving();
        break;
    case EnemyState.NotMoving:
        NotMoving();
        break;
    case EnemyState.Thrown:
        BeingThrown();
        break;
}

trail sparrow Jul 30, 2023, 1:48 AM

#

trail sorrel where should I put the first line that returns

delete or comment it out
this switch replaces its purpose

trail sorrel Jul 30, 2023, 1:50 AM

#

okay I deleted

trail sparrow Jul 30, 2023, 1:51 AM

#

Now, make sure all the movement code is in Moving() or some other named method.
Make NotMoving() even though it's more like DoNothing() right now.
And BeingThrown() is going to have the new code I'll provide

trail sorrel Jul 30, 2023, 1:52 AM

#

you mean following right by movement code

trail sparrow Jul 30, 2023, 1:52 AM

#

well, yes, that is a good distinction

trail sorrel Jul 30, 2023, 1:53 AM

#

what did you meant by Make NotMoving()

#

creating a new

trail sparrow Jul 30, 2023, 1:53 AM

#

just make an empty method, in case you ever need to add some code there

trail sorrel Jul 30, 2023, 1:53 AM

#

okay

trail sparrow Jul 30, 2023, 1:54 AM

#

those methods should be Private

#

Now, add a bool, or rename the previous one we used to: _isFalling

trail sorrel Jul 30, 2023, 1:57 AM

#

trail sparrow Now, add a **bool**, or rename the previous one we used to: _isFalling

do you mean canmove by previous bool

trail sparrow Jul 30, 2023, 1:58 AM

#

then make void OnCollisionEnter
(it should auto-complete the rest)

Inside that, we need to detect when the Enemy should start following again.
Usually by detecting that something in the Ground layer was hit.
Does your game have a Ground layer?

trail sorrel Jul 30, 2023, 2:00 AM

#

its in ui layer

trail sorrel Jul 30, 2023, 2:00 AM

#

trail sparrow then make **void OnCollisionEnter** (it should auto-complete the rest) Inside...

didnt autocomplete

trail sparrow Jul 30, 2023, 2:00 AM

#

you're using the UI Layer as the Ground layer?

trail sorrel Jul 30, 2023, 2:00 AM

#

trail sparrow you're using the UI Layer as the Ground layer?

I dont remember why i did it

trail sparrow Jul 30, 2023, 2:01 AM

#

Probably best to dedicate a separate layer, or use Default layer

#

UI as ground is confusing 😆

#

Does this appear to you?

trail sorrel Jul 30, 2023, 2:02 AM

#

okay it did

#

I copied it

#

thats why i think

trail sparrow Jul 30, 2023, 2:02 AM

#

ok

#

ANyway, keep UI as ground for now

#

To reduce the amount of chaos

#

I take it the Ground objects are already in the UI Layer?

trail sorrel Jul 30, 2023, 2:04 AM

#

there is only a plain as ground

#

in ui layer

trail sparrow Jul 30, 2023, 2:05 AM

#

ok

#

Are you familiar with LayerMask?

public LayerMask _groundLayer; // Choose layer(s) in the inspector.

trail sorrel Jul 30, 2023, 2:08 AM

#

I used once

trail sparrow Jul 30, 2023, 2:08 AM

#

it's essentially a sequence of bits (00110101)
an On/Off bit for each of the 32 layers in Unity

#

It can have none, all, or any combination of layers.

#

Add that variable to your script.

trail sorrel Jul 30, 2023, 2:10 AM

#

added and chose ui in inspector

trail sparrow Jul 30, 2023, 2:11 AM

#

Then, inside OnCollisionEnter()

if (collision.collider.gameObject.layer == _groundLayer)
{
    _isFalling = false; // Declare this also, in the script (private bool)
}

trail sorrel Jul 30, 2023, 2:11 AM

#

okay

trail sparrow Jul 30, 2023, 2:12 AM

#

then, add _isFalling to the if-statement

if (_isFalling && collision.collider.gameObject.layer == _groundLayer)

#

Now, in GetThrown() add

_isFalling = true;

#

Finally, in the three Public methods:

// GetPickedUp()
_state = EnemyState.NotMoving;

// GetDropped()
_state = EnemyState.Moving; 

// GetThrown()
_state = EnemyState.BeingThrown; 
_isFalling = true; // already added

#

and in Awake() set _state = EnemyState.Moving

#

After this, test \o/

trail sorrel Jul 30, 2023, 2:22 AM

#

Maybe I did something wrong but

#

I cant

#

pick up enemies

trail sparrow Jul 30, 2023, 2:23 AM

#

are all the scripts Saved?

trail sorrel Jul 30, 2023, 2:23 AM

#

yes

trail sparrow Jul 30, 2023, 2:23 AM

#

Post them.

trail sorrel Jul 30, 2023, 2:24 AM

#

https://hatebin.com/quujyaaqps

#

https://hatebin.com/tknppnsuwl

trail sparrow Jul 30, 2023, 2:27 AM

#

check the PickupMask

trail sorrel Jul 30, 2023, 2:28 AM

#

its on pickup layer

trail sparrow Jul 30, 2023, 2:28 AM

#

and the enemy is also?

trail sorrel Jul 30, 2023, 2:28 AM

#

yes

trail sparrow Jul 30, 2023, 2:29 AM

#

Disable the EnemyMovement component of one enemy.
See if that one can be picked up.

#

it can be done while in Play mode

trail sorrel Jul 30, 2023, 2:31 AM

#

trail sparrow Disable the EnemyMovement component of one enemy. See if that one can be picked...

no I cant

#

pick it up

trail sparrow Jul 30, 2023, 2:33 AM

#

Any errors?

trail sorrel Jul 30, 2023, 2:34 AM

#

no

#

I have a pickable barrel

#

and cant pick it up

#

too

trail sparrow Jul 30, 2023, 2:35 AM

#

Ok. Let me go through my instructions and your scripts.

trail sorrel Jul 30, 2023, 2:39 AM

#

Man I have to sleep can you please write if you see something I dont know how to thank you for your help

trail sparrow Jul 30, 2023, 2:40 AM

#

Alright. I'll see what I can find.
You're welcome o/

#

Looks like you removed an ending bracket.
FixedUpdate() is inside void Update() in Pickup

#

Add } before FixedUpdate
and remove the last } at the bottom of the script

#

then CTRL + K + D to auto-correct indentation (for entire script)

trail sorrel Jul 30, 2023, 2:43 AM

#

Probably thats the wrong thing

#

Thanks bro

trail sparrow Jul 30, 2023, 2:43 AM

#

Let me know when it works o/

trail sparrow Jul 30, 2023, 2:58 AM

#

Once the script is complete, there is one last milestone.
This current solution will work for EnemyMovement, but we can make it work for any script we want.

By declaring an interface, these can be implemented by any other class.

public interface IInteractable
{
    public void GetPickedUp();
    public void GetDropped();
    public void GetThrown();
}

Like so:

public class EnemyMovement : MonoBehaviour, IInteractable  // <-- Add IInteractable in declaration

And be used like so:

private IInteractable CurrentMovement;
//..
hit.transform.gameObject.TryGetComponent<IInteractable>(out IInteractable enemy);

#

And however the class implements the behavior, is up to the class itself.

trail sorrel Jul 30, 2023, 11:00 AM

#

everything is good but when I throw them or drop them they dont follow me

#

maybe thats because they are lying down and cant stand up

#

I freezed the rotation of enemys and tried

#

but that didnt work

#

        {
            case EnemyState.Moving:
                Moving();

                break;
            case EnemyState.NotMoving:
                break;
            case EnemyState.Thrown:
                GetThrown();
                break;
        }```should I delete GetThrown(); here

trail sparrow Jul 30, 2023, 11:30 AM

#

Alright. Post your updated scripts.

trail sparrow Jul 30, 2023, 11:30 AM

#

trail sorrel ```switch (_state) { case EnemyState.Moving: ...

GetThrown should be Public, and is indeed not supposed to be in the switch.
It is accessed only via the Pickup script

trail sorrel Jul 30, 2023, 11:32 AM

#

https://hatebin.com/qamrqfimag

#

https://hatebin.com/akszwsvlda

#

I changed some in physicspickup

trail sparrow Jul 30, 2023, 12:08 PM

#

Being a bit distracted here btw, but starting to look now.

#

Ah yes, looks like I didn't do everything with _isFalling and the State

#

might not need the bool

#

in EnemyMovement
copy the switch from FixedUpdate, into OnCollisionEnter
Remove the Moving() method from it.
Move the existing code in OnCollisionEnter into the Thrown state

#

Then replace this

_isFalling = false; // Declare this also, in the script (private bool)

With that

_state = EnemyState.Moving;

#

That might be all.

#

_isFalling can then be completely removed.

#

I expect that will work, but if not, then I have time right now, or in 7 hrs.

#

private void OnCollisionEnter(Collision collision)
{
    switch (_state)
    {
        case EnemyState.Moving:
            break;
        case EnemyState.NotMoving:
            break;
        case EnemyState.Thrown:
            if (collision.collider.gameObject.layer == _groundLayer)
            {
                _state = EnemyState.Moving;
            }
            break;
    }
}

#

Optional:
Instead of setting the state directly to EnemyState.Moving,
you could make a new state EnemyState.Recovering
to add a delay from when it hits the ground, to when it starts moving.

trail sorrel Jul 30, 2023, 12:24 PM

#

should I delete the switch in fixedupdate

trail sparrow Jul 30, 2023, 12:24 PM

#

no

#

that remains just as it was

#

the switch is so other code can also be state-specific

#

It's a good way to control complex code.

#

bool _canMove can be removed

trail sorrel Jul 30, 2023, 12:31 PM

#

I did a debug.log in OnCollisionEnter

#

but it doesnt detect the collision

trail sparrow Jul 30, 2023, 12:32 PM

#

is your game 3D or 2D?

trail sorrel Jul 30, 2023, 12:32 PM

#

3d

trail sparrow Jul 30, 2023, 12:33 PM

#

and the objects have Rigidbody, not Rigidbody2D?

trail sorrel Jul 30, 2023, 12:33 PM

#

yeah

#

floor doesnt have one

trail sparrow Jul 30, 2023, 12:34 PM

#

that's fine. Only one of the colliders needs a rigidbody, for a collision event to occur

trail sorrel Jul 30, 2023, 12:34 PM

#

enemys have

trail sparrow Jul 30, 2023, 12:34 PM

#

as they should, for movement

#

Screenshot the object hierarchy, while selecting the object with the EnemyMovement script

trail sorrel Jul 30, 2023, 12:35 PM

#

I changed something

trail sparrow Jul 30, 2023, 12:35 PM

#

Tell me which object has the Collider

trail sorrel Jul 30, 2023, 12:36 PM

#

trail sorrel Jul 30, 2023, 12:38 PM

#

trail sparrow Tell me which object has the Collider

enemies have capsule, floor have box collider

#

player has box too

trail sparrow Jul 30, 2023, 12:38 PM

#

ok. Screenshot the Enemy prefab hierarchy

trail sorrel Jul 30, 2023, 12:39 PM

#

components?

trail sparrow Jul 30, 2023, 12:39 PM

#

I want to see all the objects contained within

#

not the components yet

trail sorrel Jul 30, 2023, 12:41 PM

#

only enemy is contained in enemys hierarchy

trail sparrow Jul 30, 2023, 12:41 PM

#

ah so it's only one object. simple, ok.

#

Have you changed anything since yesterday, which I did not specify?

trail sorrel Jul 30, 2023, 12:44 PM

#

                            {
                                CurrentObject = hit.rigidbody;
                                CurrentObject.useGravity = false;
                            }
                            else
                            {
                                hit.transform.gameObject.TryGetComponent<EnemyMovement>(out EnemyMovement enemy);
                                if (enemy)
                                {
                                    enemy.GetPickedUp();
                                    CurrentObject = hit.rigidbody;
                                    CurrentMovement = enemy;
                                }
                            }```

#

I only changed this

#

it detects collision

#

I saw I wrote debug.log to wrong place

trail sparrow Jul 30, 2023, 12:51 PM

#

Ok. Post your scripts again.

trail sorrel Jul 30, 2023, 12:51 PM

#

both?

#

https://hatebin.com/duuzqytavd

#

https://hatebin.com/hejwobhkra

trail sparrow Jul 30, 2023, 1:04 PM

#

trail sorrel maybe thats because they are lying down and cant stand up

Is the enemy rotation 0,0,0 by default?

trail sorrel Jul 30, 2023, 1:04 PM

#

yes

trail sparrow Jul 30, 2023, 1:09 PM

#

inside OnCollisionEnter()
in the Thrown > if groundlayer
Add another line below _state = EnemyState.Moving;

rb.rotation = Quaternion.Euler(0,0,0);

@trail sorrel

#

Note that when using Rigidbody for movement, we should not use Transform to move/rotate, because that would be bypassing the physics system

#

Use Inspector Debug mode, to see the Enemy's state while testing

trail sorrel Jul 30, 2023, 1:13 PM

#

I played but didnt see anything change

trail sparrow Jul 30, 2023, 1:14 PM

#

Request:
Screenshot the scene, when the enemy has landed, but is not moving.
Have the Enemy object selected, so I can see all the script's values via the inspector.

trail sorrel Jul 30, 2023, 1:16 PM

#

okay

#

its on not moving

#

and never see thrown there

trail sparrow Jul 30, 2023, 1:17 PM

#

inside GetThrown()
add Debug.Break()

#

not pause, but break*

#

it will Pause the editor

trail sorrel Jul 30, 2023, 1:18 PM

#

no nothing happens when I throw

#

it throws but game doesnt pause

trail sparrow Jul 30, 2023, 1:22 PM

#

in the code you shared, it seems you haven't added GetThrown() in the Pickup script

trail sorrel Jul 30, 2023, 1:22 PM

#

trail sparrow in the code you shared, it seems you haven't added GetThrown() in the Pickup scr...

yeah I just checked it and yeah

trail sparrow Jul 30, 2023, 1:23 PM

#

should be placed below Line 107 somewhere

trail sorrel Jul 30, 2023, 1:24 PM

#

how should write it tried enemy.Getthrown

trail sparrow Jul 30, 2023, 1:25 PM

#

enemy.GetThrown()

trail sorrel Jul 30, 2023, 1:25 PM

#

current.getthrown gets no errors

trail sparrow Jul 30, 2023, 1:25 PM

#

actually

#

private EnemyMovement CurrentMovement;

#

so CurrentMovement.GetThrown();

trail sorrel Jul 30, 2023, 1:26 PM

#

I think it works

#

paused the game

trail sparrow Jul 30, 2023, 1:26 PM

#

:D

#

alright, remove the Debug.Break() (or comment out)

#

or just, for now, Unpause the Editor

#

so you can see the rest

trail sorrel Jul 30, 2023, 1:27 PM

#

but now It just stays on thrown

trail sparrow Jul 30, 2023, 1:28 PM

#

Does it log the ground when hitting it?

#

    private void OnCollisionEnter(Collision collision)
    {
        Debug.Log(gameObject.name);
        switch (_state)
        {
            case EnemyState.Moving:
                break;
            case EnemyState.NotMoving:
                break;
            case EnemyState.Thrown:
                if (collision.collider.gameObject.layer == _groundLayer)
                {
                    Debug.Log("Collided with Ground"); // <-- Add this.
                    _state = EnemyState.Moving;
                }
                break;
                
        }
    

        
    }

#

add that debug log

trail sorrel Jul 30, 2023, 1:28 PM

#

added

trail sparrow Jul 30, 2023, 1:29 PM

#

check the inspector

#

is ground layermask still good?

#

oh wait

#

My mistake. Layer index != LayerMask

trail sorrel Jul 30, 2023, 1:31 PM

#

I have to be somewhere like around past 50 I should close pc a few minutes later

trail sorrel Jul 30, 2023, 1:31 PM

#

trail sparrow My mistake. Layer index != LayerMask

which line

trail sparrow Jul 30, 2023, 1:31 PM

#

    public static bool HasLayerInMask(LayerMask layerMask, int layerIndex)
    {
        return (layerMask & (1 << layerIndex)) != 0;
    }

#

sec

#

add that method to your Pickup script

#

if (HasLayerInMask(_groundLayer, collision.collider.gameObject.layer))
{
    Debug.Log("Collided with Ground");
    _state = EnemyState.Moving;
}

trail sorrel Jul 30, 2023, 1:33 PM

#

where am I adding this

trail sparrow Jul 30, 2023, 1:33 PM

#

#1134970394319794318 message

#

it replaces the existing if-statement regarding layers

trail sorrel Jul 30, 2023, 1:35 PM

#

👍

trail sparrow Jul 30, 2023, 1:35 PM

#

LayerMask uses a sequence of bits internally, so the integer it represents, is not the same as a Layer's index, but the sum of all bits/layers enabled in the mask 🤦‍♂️

#

Anyway.
You can read more about LayerMask at a later time.
https://github.com/Rovsau/LayerMask-Explained

GitHub

GitHub - Rovsau/LayerMask-Explained

Contribute to Rovsau/LayerMask-Explained development by creating an account on GitHub.

trail sorrel Jul 30, 2023, 1:36 PM

#

bro it worked thank you so much

trail sparrow Jul 30, 2023, 1:36 PM

#

trail sorrel bro it worked thank you so much

Awesome!

trail sorrel Jul 30, 2023, 1:36 PM

#

🙏

trail sparrow Jul 30, 2023, 1:36 PM

#

There are 2-3 small things I wish to do before we part ways.

#

Now that your code works, you should look into simplifying it, so you can understand it later.
We're not doing that right now. You can mention me in Official for that purpose later.

The pickup script has a lot of nesting

if (true) 
    if (true)
        if (true)...etc

Nesting is not good for humans to read, so we usually nest max 3 times, and reduce everything to methods.
If you are able to do that, it's much more maintainable.
And to improve it even better, you could make the Pickup script have States as well.

#

Not that I think you want to do that after all this 😂
But it's a thought.

trail sorrel Jul 30, 2023, 1:41 PM

#

trail sparrow Not that I think you want to do that after all this 😂 But it's a thought.

Not in this script but i will use your advices for my future scripts thanks

trail sparrow Jul 30, 2023, 1:41 PM

#

Next: Rewrite Pickup script to work with IInteractable instead of the EnemyMovement class itself.
The interface needs to be declared outside the class itself, so it is accessible to other classes.
Usually, an interface has its own file.

trail sorrel Jul 30, 2023, 1:44 PM

#

I will take a look at interfaces it was the first time I heard them when you said

trail sparrow Jul 30, 2023, 1:44 PM

#

And lastly, your Pickup script is directly modifying the EnemyMovement script, instead of using methods of the Enemy itself.
It works now, so no reason to care, but in the future, try to let each script run its own mechanics, at outside request.

#

That is all.

#

GOOD WORK

#

Have a nice day UnityChanThumbsUp

#I cant push the enemy because its following me