#Unity devs, you can boost the world bootstrap with little cleaning

1 messages · Page 1 of 1 (latest)

lofty magnet
#

Hi 🙂

There is an unnecessary sorting of systems between managed & unmanaged in DefaultWorldInitialization.AddSystemToRootLevelSystemGroupsInternal bootstrap.

In the screen managedTypes & unmangedTypes are not used in the rest of the method.

Even this line can be an assert, no ?


if (!TypeManager.IsSystemTypeIndex(stype))```
image.png
#

Unity devs, you can boost the world bootstrap with little cleaning

loud moth
#

i don't completely follow. which sort are you saying doesn't need to happen?

dusk pivot
#

oh i've seen this as well

#

it has like legacy code in the bootstrap that isn't used anymore

#

it no longer uses these 2 lists

lofty magnet
#

yup

severe wraith
#

I think they meant sorting as in separating the two lists

dusk pivot
#

from memory these lists were used in 0.51 for creating componentsystembase and isystem through differnet paths
these days they are just passed as a single collection to
var allSystemHandlesToAdd = world.GetOrCreateSystemsAndLogException(systemTypesOrig, Allocator.Temp);
so aren't used anymore