how would you suggest I do that | Official Unity Discord | Page 1

proper comet Apr 18, 2023, 2:15 PM

#

lemme write a little something up

#

what defines a quest right now?

#

the kind of fish, the number of fish, the XP reward...

teal timber Apr 18, 2023, 2:15 PM

#

so theres a random amount which is set

#

between 2 values

#

per fish

#

then a random amount of quests, maxinum of 3

#

and then the XP reward

#

proper comet Apr 18, 2023, 2:17 PM

#

does each kind of fish have its own range of minimum and maximum # of fish to catch?

#

or is it the same range for everyone

teal timber Apr 18, 2023, 2:18 PM

#

currently its the same

proper comet Apr 18, 2023, 2:18 PM

#

so you really just need to know a list of all the kinds of fish that exist

#

and then make quests by picking a fish + count + xp reward

teal timber Apr 18, 2023, 2:19 PM

#

currently only 3 fish, but over the next week ill be adding a tonne more

#

I would like the script to be alot simpler to setup...

proper comet Apr 18, 2023, 2:19 PM

#

do you have a Fish class or something?

teal timber Apr 18, 2023, 2:19 PM

#

In my fish script, I have a enum list with the different fish

proper comet Apr 18, 2023, 2:19 PM

#

and prefabs of the different kinds of fish

teal timber Apr 18, 2023, 2:20 PM

#

^

proper comet Apr 18, 2023, 2:20 PM

#

so there's just one fish prefab?

#

and you set the kind of fish

teal timber Apr 18, 2023, 2:20 PM

#

Currently yes

#

1 script, with multiple pre-fabs with different models really

#

then I select the fish type on the editor

proper comet Apr 18, 2023, 2:20 PM

#

okay, so there are multiple prefabs

teal timber Apr 18, 2023, 2:20 PM

#

and it changes all their stats

proper comet Apr 18, 2023, 2:21 PM

#

you've said that there's only one prefab and that there are multiple prefabs :p

teal timber Apr 18, 2023, 2:21 PM

#

lol, Currently I only have 1 fish ahaha

proper comet Apr 18, 2023, 2:21 PM

#

is the plan, eventually, to have many prefabs, each of which is configured to be a certain kind of fish?

teal timber Apr 18, 2023, 2:21 PM

#

Yep

proper comet Apr 18, 2023, 2:22 PM

#

okay, so we'll roll with that

#

so, here's my suggestion

#

give the quest controller a List<Fish>

#

this will let you make a list of prefabs with a Fish component

#

maybe public List<Fish> fishChoices;

#

now, we need to store our quest data

#

you could create a struct to hold the data

#

[System.Serializable]
public struct Quest {
  public Fish fish;
  public int count;
  public int xp;
}

teal timber Apr 18, 2023, 2:23 PM

#

So what does a struct do?

proper comet Apr 18, 2023, 2:23 PM

#

a struct is similar to a class

#

it can hold many fields, and can have methods

#

the big distinction is that it's a value -- so if you do this...

#

public List<Quest> quests = new();
quests[0] = new Quest();
Quest myQuest = quests[0];
myQuest.fish = someFish;

...quests[0] will still have no fish

#

you made a copy when you got the quest out

#

It might be a little more convenient to just make a it a class, really

#

it's not like you're processing thousands of quests per frame and need the better performance a struct can give you :p

teal timber Apr 18, 2023, 2:24 PM

#

this seems very complicated ahaha

proper comet Apr 18, 2023, 2:25 PM

#

so, let's go with a class

#

[System.Serializable]
public class Quest {
  public Fish fish;
  public int count;
  public int xp;
}

#

so, we have this bag of data

#

fish + count + xp

teal timber Apr 18, 2023, 2:25 PM

#

yep

proper comet Apr 18, 2023, 2:25 PM

#

can you have two quests for the same fish?

teal timber Apr 18, 2023, 2:25 PM

#

Nope

proper comet Apr 18, 2023, 2:26 PM

#

okay, so we can make things easier to work with

#

Dictionary<Fish, Quest>

#

this is a dictionary that lets you store a quest, identified by a fish prefab

#

or, maybe

#

Dictionary<FishKind, Quest>

where FishKind is whatever that enum is

#

what did you call the enum?

teal timber Apr 18, 2023, 2:27 PM

#

Lemme check

proper comet Apr 18, 2023, 2:27 PM

#

proper comet `Dictionary<FishKind, Quest>` where `FishKind` is whatever that enum is

this would be better to use

#

otherwise you'd be associating a quest with a specific fish

#

like, literally one specific fish in the lake

#

which is less convenient :p

teal timber Apr 18, 2023, 2:27 PM

#

proper comet Apr 18, 2023, 2:27 PM

#

bingo

#

so

#


public class Quest {
  public int count;
  public int xp;
}

Dictionary<FishType, Quest> quests = new();

quests[FishType.GoldFish] = new Quest() {
  count = 10,
  xp = 30
};

#

we now have one quest

#

it wants us to catch 10 fish and will give 30 xp

teal timber Apr 18, 2023, 2:29 PM

#

that looks good

proper comet Apr 18, 2023, 2:29 PM

#

so here's the neat part

#

let's say you have a function that you run when you catch a fish

#

public void CatchFish(Fish fish) {
  if(quests.ContainsKey(fish.fishtype)) {
    quests[fish.fishtype].count -= 1;
    if (quests[fish.fishtype].count == 0) {
       Debug.Log("Quest done!");
       quests.Remove(fish.fishtype);
    }
  }
}

#

when you catch a fish, you check if there is a quest for it

#

if there is, you reduce the count by 1

#

then, if the count is 0, you remove the quest

#

you'd give the player XP there

#

this way, no matter how many kinds of fish you have, that's all you have to write

teal timber Apr 18, 2023, 2:31 PM

#

proper comet ```cs public void CatchFish(Fish fish) { if(quests.ContainsKey(fish.fishtype))...

So what does a dictionary actually do and hold?

proper comet Apr 18, 2023, 2:31 PM

#

you do the same thing for every kind of fish

#

a dictionary stores a value that you look up with a key

#

Dictionary<string, int> would let you do something like dict["hello"] = 123;

#

It's a good replacement for code that looks like this:

#

int goldfishCount = 3;
int tunaCount = 5;
int lobsterCount = 7;

#

instead

teal timber Apr 18, 2023, 2:32 PM

#

yeah, makes sense

proper comet Apr 18, 2023, 2:32 PM

#

counts[FishType.GoldFish] = 3;

#

etc.

#

now you don't need to add a whole new variable to add a new kind of fish

teal timber Apr 18, 2023, 2:32 PM

#

My fish script is a mess ahaha, its handling pretty much everything as I couldnt target 1 particular pre-fab from the other scripts

proper comet Apr 18, 2023, 2:32 PM

#

so that's the quest-completion side

#

quest-generation is also pretty simple

#

pick a fish type

#

then, store a new quest in the dictionary

teal timber Apr 18, 2023, 2:35 PM

#

hm

proper comet Apr 18, 2023, 2:35 PM

#

here's how I'd pick a random fish kind (it's mildly scary)

#

List<FishType> fishTypes = new();

foreach (FishType fishType in System.Enum.GetValues(typeof(FishType)))
  fishTypes.Add(fishType);

int index = Random.Range(0, fishTypes.Count);
FishType chosen = fishTypes[index];

#

don't worry if that foreach line looks really weird (it is)

#

enums are a little funky

teal timber Apr 18, 2023, 2:37 PM

#

How long have you been coding for?

proper comet Apr 18, 2023, 2:37 PM

#

a decade-ish :p

teal timber Apr 18, 2023, 2:37 PM

#

damn, I can tell ahaha

proper comet Apr 18, 2023, 2:37 PM

#

a few years in C#

teal timber Apr 18, 2023, 2:37 PM

#

Ive been coding for around 6 months

proper comet Apr 18, 2023, 2:37 PM

#

System.Enum.GetValues takes an enum type and tells you all of the valid values

#

after that foreach loop runs, fishTypes will have every single FishType value in it

#

so, you can then pick a random item from the list

teal timber Apr 18, 2023, 2:38 PM

#

alright, so I know that my script is probably a mess, but it works so imma stick with it...

#

But

proper comet Apr 18, 2023, 2:38 PM

#

and, to expand on that a bit

teal timber Apr 18, 2023, 2:38 PM

#

How would I check whether all the tasks have been completed, then refresh them

#

I need to check whether they are active too

proper comet Apr 18, 2023, 2:38 PM

#

List<FishType> fishTypes = new();

foreach (FishType fishType in System.Enum.GetValues(typeof(FishType)))
  fishTypes.Add(fishType);

while(fishTypes.Count > 0) {
  int index = Random.Range(0, fishTypes.Count);
  FishType chosen = fishTypes[index];
  quests[chosen] = new Quest() {
    count = 5,
    xp = 5
  };
  fishTypes.Remove(chosen);
}

#

this would create a quest for every single kind of fish

proper comet Apr 18, 2023, 2:39 PM

#

teal timber How would I check whether all the tasks have been completed, then refresh them

what makes a quest active?

teal timber Apr 18, 2023, 2:39 PM

#

if the boolean goldfishQuest is true

#

so the first if statement is telling me the quest has been completed and its a active quest

proper comet Apr 18, 2023, 2:40 PM

#

are you asking how you'd do this when you store quests in a dictionary?

teal timber Apr 18, 2023, 2:41 PM

#

nah if I were to do it my way

proper comet Apr 18, 2023, 2:41 PM

#

it seems like you already check if the quest is active, then

teal timber Apr 18, 2023, 2:41 PM

#

Not sure if I wanna jump into doing dictionarys ahaha

teal timber Apr 18, 2023, 2:41 PM

#

proper comet it seems like you already check if the quest is active, then

but how would I merge all 3 statements together

proper comet Apr 18, 2023, 2:42 PM

#

oh, you want to check if all the quests are done

#

well, you could have a counter

teal timber Apr 18, 2023, 2:42 PM

#

As I need to check whether all the active tasks have been compoleted

proper comet Apr 18, 2023, 2:42 PM

#

in each if block, increment the counter

teal timber Apr 18, 2023, 2:42 PM

#

proper comet well, you could have a counter

ah makes sense

#

yep ok

#

ill try that

#

I crashed my unity, Think I added a loop somewhere lol

proper comet Apr 18, 2023, 2:42 PM

#

if you do want to try switching to a dictionary, every place where you repeat yourself 3 times will be replaced with a single block of code

#

(or 4 times, or 5 times, or ...)

teal timber Apr 18, 2023, 2:44 PM

#

#

This shoulddddd work

#

right?

proper comet Apr 18, 2023, 2:45 PM

#

wrong order

teal timber Apr 18, 2023, 2:45 PM

#

wait no, cause its in update

proper comet Apr 18, 2023, 2:45 PM

#

you increment completed after checking it

teal timber Apr 18, 2023, 2:45 PM

#

and its in update currently, so will continue updating and adding 1

proper comet Apr 18, 2023, 2:45 PM

#

well, you should reset completed to 0 at the start

#

otherwise completing 1 quest would get the counter to 3 after 3 frames

teal timber Apr 18, 2023, 2:46 PM

#

teal timber

so where should I put this, cause it cant go in update right?

proper comet Apr 18, 2023, 2:46 PM

#

it should definitely go in update

#

you should just reset the counter each time

teal timber Apr 18, 2023, 2:46 PM

#

so how would I call it once?

#

oh i see

#

so i set it to 0

#

then it adds the 3

proper comet Apr 18, 2023, 2:47 PM

#

yep

teal timber Apr 18, 2023, 2:47 PM

#

then it gets set to 0 straight away

#

#

In each of the loop of the update method, it should set the value completed to 0. It will then add 1 depending whether a quest is completed if its a active quest. It will then check if the number of quests complete is equal to the number of active quests, if it is, it will refresh the quests.

proper comet Apr 18, 2023, 2:52 PM

#

yep, that sounds reasonable to me

teal timber Apr 18, 2023, 2:53 PM

#

#

So weird my unity freezes if i tick all of them

#

it should just call the same thing as whats in start method..

teal timber Apr 18, 2023, 2:55 PM

#

proper comet yep, that sounds reasonable to me

any ideas

#

I think I know why

#

nope.. crashed again

proper comet Apr 18, 2023, 2:59 PM

#

Show me your whole script

#

!code

tepid bobcatBOT Apr 18, 2023, 3:00 PM

#

Posting code

📃 Large Code Blocks
Large code blocks should be posted as links to services like:
https://gdl.space/, https://paste.ofcode.org/, https://hatebin.com/
https://paste.myst.rs/, https://hastebin.com/

📃 Inline Code
Surround code with three backquotes. Not quotation marks.
To get C# formatting the first line should only contain cs or csharp.
Add a comment with a line number if there is an error message.
```cs
// Your code here
```
Do not share screenshots of code unless requested.

teal timber Apr 18, 2023, 3:02 PM

#

alright

#

https://hatebin.com/bdacygybvj

teal timber Apr 18, 2023, 3:05 PM

#

proper comet Show me your whole script

Did that link work?

proper comet Apr 18, 2023, 3:07 PM

#

hm, there's nothing obvious that would go into an infinite loop

#

which is what will freeze the editor

teal timber Apr 18, 2023, 3:08 PM

#

thats weird, I just refreshed the tasks fine, then when there was a full set of tasks, I did it again, and it froze

proper comet Apr 18, 2023, 3:08 PM

#

oh

#

you don't set goldfishQuest back to false

#

so it will be trying to add quests forever

#

it will think it has already made a quest for all three kinds of fish

#

so it'll never succeed at creating a quest

teal timber Apr 18, 2023, 3:09 PM

#

ah

#

Well spotted

#

thanks!

#

Also 1 last quick questiomn

#

I added a toon shader to my project a while back

#

#

Ive had to warnings in my console and im not sure how to fix them

#

any ideas?

#

#

Ahh and how would I update this? As its not in update.

#

should I set progress1.text to a value then update that value

#

Ill try taht

#

that

#

hm

proper comet Apr 18, 2023, 3:32 PM

#

teal timber

I dunno about that.

proper comet Apr 18, 2023, 3:32 PM

#

teal timber should I set progress1.text to a value then update that value

int x = 1;
Progress1.text = x + "/" + 3;
x = 2;

#

this will not change the text

#

this is where it starts to get really annoying to have all this hard-coded stuff, you see :p

#

you're gonna have tons of duplicate code

teal timber Apr 18, 2023, 3:40 PM

#

#

fixed :)

#

moved it into update

#how would you suggest I do that