Hey I need some help please The code for | Official Unity Discord | Page 1

crimson tulip Jan 25, 2023, 4:12 PM

#

How about a thread 🙂

astral knoll Jan 25, 2023, 4:13 PM

#

perfect ❤️

#

so,

crimson tulip Jan 25, 2023, 4:13 PM

#

So, can you explain which line of code on what script is actually firing the error? I just got confused by all those parts 😄

astral knoll Jan 25, 2023, 4:15 PM

#

here I can collect and even use all the items. Each item in the inventory above has a scriptable Object attached. At this point everything is already in the dictionary so now when I click on the weapon it goes to the equip slot at the bottom. Then the weapon needs to spawn in the characters hands.

#

#

all I need to do is read the ScriptableObject attached to the inventory slot to read the prefab.
Then instantiate the prefab into the charactes hand.

I do this in the first file I have shared.
https://gdl.space/zuyazubuna.cpp

And then the error appears

crimson tulip Jan 25, 2023, 4:17 PM

#

on line?

astral knoll Jan 25, 2023, 4:17 PM

#

on line 49 to 53 that I commented out

crimson tulip Jan 25, 2023, 4:18 PM

#

Okay, just super simple question. Did you forget to assign a itemPrefab on one SO? 😉

astral knoll Jan 25, 2023, 4:18 PM

#

ahahahah No XD

crimson tulip Jan 25, 2023, 4:18 PM

#

Could have been 😄

astral knoll Jan 25, 2023, 4:18 PM

#

cause it pops up in the video for half a second

crimson tulip Jan 25, 2023, 4:19 PM

#

wait, it pops up?

astral knoll Jan 25, 2023, 4:19 PM

#

yes.

crimson tulip Jan 25, 2023, 4:19 PM

#

can you debug.log instantiatedItem.transform please?

astral knoll Jan 25, 2023, 4:19 PM

#

sure

#

#

I've even added my own debug to ensure I have the scriptableObject attached. Something is weird here.

crimson tulip Jan 25, 2023, 4:22 PM

#

the selected log is the one of transform?

#

and if you now alter the position, it bugs out?

#

wait, the code is not the issue there. It is running fine. the log gets hit with "item is now equipped"

astral knoll Jan 25, 2023, 4:22 PM

#

well it bugs out regardless. when I remove the code alltogther it's fine again

#

Ya

#

it's super weird

#

crimson tulip Jan 25, 2023, 4:23 PM

#

select the stacktrace again of your error pls

astral knoll Jan 25, 2023, 4:23 PM

#

have a look at second 04

#

3 and 4 sorry

crimson tulip Jan 25, 2023, 4:24 PM

#

yeah, I did. can you select your error and show the stacktrace?

astral knoll Jan 25, 2023, 4:24 PM

#

I am more than happy to jump into a voice channel if you are comfortable

#

sure 1 sec

#

crimson tulip Jan 25, 2023, 4:25 PM

#

InventoryManager line 43, what is this doing again

astral knoll Jan 25, 2023, 4:25 PM

#

#

Adding

crimson tulip Jan 25, 2023, 4:25 PM

#

and cant go voice, hopping back and forth with clients on google meet 😄

astral knoll Jan 25, 2023, 4:25 PM

#

wait!

#

that might be it!

crimson tulip Jan 25, 2023, 4:25 PM

#

yep...

astral knoll Jan 25, 2023, 4:26 PM

#

when equipping the item It tries to add it again and it can't becase this time there was no item collected

#

hmmmm

crimson tulip Jan 25, 2023, 4:26 PM

#

also do not call your object gameObject, because gameObject is already representing your actual gameObject the component is attached to 😉

#

ohhh, and on next line you try to get the component, but on the wrong gameObject I guess ? 😄

#

But if you say line 43, then either the dict or the itemCollected might be null

astral knoll Jan 25, 2023, 4:27 PM

#

in what class sorry ?

crimson tulip Jan 25, 2023, 4:27 PM

#

astral knoll

right here

astral knoll Jan 25, 2023, 4:28 PM

#

Ah, that does seem right but It still does not make sense to me. Why would the only differnce be me isntantiating a game Object and me just equipping it break things.

#

check this out:

#

Removing this

#

I can now equip the weapon

#

and use it

crimson tulip Jan 25, 2023, 4:30 PM

#

What? Are you instantiating it two times? 😄

astral knoll Jan 25, 2023, 4:30 PM

#

#

so now the millioin dollar question is, why on earth can I not just add the gameObject to the world. 😂

crimson tulip Jan 25, 2023, 4:31 PM

#

Is your item doing something on generating it?

astral knoll Jan 25, 2023, 4:32 PM

#

no, my thought process would be, I pick up the item
It gets added to the inventory slot where a copy of the scriptableObject also is stored. Upon equipping the item, pass the SO to the instantiation code to get the prefab to spawn it into the players hands.

#

#

To me this should be simple right ? but yet I am having a hard time with it

crimson tulip Jan 25, 2023, 4:34 PM

#

I am wondering why you do all that casting

#

your iteamScriptableObject is already type of Item

astral knoll Jan 25, 2023, 4:34 PM

#

Oh, I have item SO as the parent and then I have a weapon SO, throwable SO , consumable SO

crimson tulip Jan 25, 2023, 4:34 PM

#

itemScriptableObject.itemPrefab should be enough to call

astral knoll Jan 25, 2023, 4:35 PM

#

I just pass in the generic SO and cast to item or weapon or consumable

crimson tulip Jan 25, 2023, 4:35 PM

#

(Item) should be enough

astral knoll Jan 25, 2023, 4:35 PM

#

Okay. Well, let me give this another try by removing the casting and then see what happens

crimson tulip Jan 25, 2023, 4:36 PM

#

and can you do this, without any var and stuff. just instantiate and see what happens

Instantiate(itemPrefab, GameObject.Find("Hand.R").transform, true);

astral knoll Jan 25, 2023, 4:36 PM

#

Sure. Let me try that quick

#

That works but I don't see it pop into the world

#

crimson tulip Jan 25, 2023, 4:43 PM

#

astral knoll

did you check your ahdn transform, is it there somehow?

#

like in the hierarchy?

astral knoll Jan 25, 2023, 4:48 PM

#

Hold up! It is there!!!!

#

🥳

crimson tulip Jan 25, 2023, 4:48 PM

#

😄

#

now lets revert back to your code and see, what could be the issue

#

so what was your current code thats working?

astral knoll Jan 25, 2023, 4:49 PM

#

ahahaha this is pretty funny

crimson tulip Jan 25, 2023, 4:50 PM

#

That is far off 😄

astral knoll Jan 25, 2023, 4:50 PM

#

at 0. 0 .0

crimson tulip Jan 25, 2023, 4:50 PM

#

Wait, your inspector says x = 520

#

because you dont set it to vector3.zero yet?

astral knoll Jan 25, 2023, 4:51 PM

#

🤨

#

crimson tulip Jan 25, 2023, 4:51 PM

#

I am confused by your setup 😄

astral knoll Jan 25, 2023, 4:52 PM

#

I am confused by my setup!

#

😂

crimson tulip Jan 25, 2023, 4:52 PM

#

Okay, anyway. lets see what happens if we set the localposition to zero 😄

astral knoll Jan 25, 2023, 4:53 PM

#

XD alright

crimson tulip Jan 25, 2023, 4:53 PM

#

GameObject instantiatedItem = Instantiate(itemScriptableObject.itemPrefab, GameObject.Find("Hand.R").transform, true);
instantiatedItem.transform.localPosition = Vector3.zero;

astral knoll Jan 25, 2023, 4:53 PM

#

In my defence this is the first big project I am tackeling and I have a devlog series up on the tubes about everything I have so far .

#

I can't store the instantiated object as a gameObject strangely enough

crimson tulip Jan 25, 2023, 4:55 PM

#

Oh nice, always cool to see the progress on a project 🙂

#

do you get an error?

astral knoll Jan 25, 2023, 4:55 PM

#

#

so that might have been the issue

crimson tulip Jan 25, 2023, 4:56 PM

#

what the heck, why cant you get an gameobject back from instantiate 😄

astral knoll Jan 25, 2023, 4:56 PM

#

The returned item is a object

#

I need to cast it for me to get a Go

crimson tulip Jan 25, 2023, 4:56 PM

#

Weird, feels like I never used unity on the simplest things right now 😄

astral knoll Jan 25, 2023, 4:57 PM

#

I'm doing it fine in the inventory manager for the item slots

crimson tulip Jan 25, 2023, 4:57 PM

#

What is your itemPrefab? what type, its gameobject or item?

astral knoll Jan 25, 2023, 4:58 PM

#

it's a transform 😕

#

No

#

GameObject

#

crimson tulip Jan 25, 2023, 4:59 PM

#

Things start to get super weird here 😄

astral knoll Jan 25, 2023, 5:00 PM

#

The prefab attached to the SO

#

maybe I should just remove everything I don't need and try again

crimson tulip Jan 25, 2023, 5:01 PM

#

what if you instantiate as GameObject, does this work at least?

astral knoll Jan 25, 2023, 5:01 PM

#

so cast to type

#

let me try

crimson tulip Jan 25, 2023, 5:01 PM

#

Just make var to GameObject and cast it and see if you get the error again

#

Gotta go in some minutes unfortunately, but will remain in this thread and check later. I wait for your response about the casting tho 😄

astral knoll Jan 25, 2023, 5:02 PM

#

😒 Don't judge, I can instantiate as GameObject.. would help if I passed in the right type of SO though ....

crimson tulip Jan 25, 2023, 5:03 PM

#

😄

astral knoll Jan 25, 2023, 5:03 PM

#

here you go : https://www.youtube.com/channel/UCXBRt4DewvNqZYH93DOLzeA

YouTube

Garreth Dean

Hi there! My name is Garreth Dean, and I'm an aspiring indie game developer. I'm a huge fan of playing games and I really want to push past my limits to produce a game I can be proud of. On my channel, I typically showcase my current projects and also how I make them. If you're interested in learning more about the current game I am developing, ...

#

That worked btw but

#

OMG

crimson tulip Jan 25, 2023, 5:04 PM

#

subscribed btw, but what? 😄

astral knoll Jan 25, 2023, 5:05 PM

#

DUde the other script worked and because it attached to my arm the character was triggering the pickup script and because it was instantiated without a gameobject you get the error.. Check this out hahah

#

hahahah I can't believe this

#

the code was working all along. It was my dumb ss not using a clean gameObject

#

😅

crimson tulip Jan 25, 2023, 5:06 PM

#

Yeah, using vars can just lead to missing casting and recognition of wrong types 😄 I try to avoid var as much as I can 😄

#

You might wanna simplify your script if possible at some point 😄 Alrighty, gotta go, time for some dad duties over here. see ya later 🙂

astral knoll Jan 25, 2023, 5:07 PM

#

Thank you so much. I hope to talk again soon

#

keep safe and thanks again

crimson tulip Jan 25, 2023, 5:07 PM

#

Same to you and always a pleasure to help. Happy developing 🙂

astral knoll Jan 25, 2023, 5:08 PM

#

🥳 Real MVP

astral knoll Jan 25, 2023, 9:50 PM

#

Hey, going to just drop this here . I am struggeling to get the rotation and position correct of the weapon I spawn. I can't get it to spawn into the hand correctly

crimson tulip Jan 26, 2023, 7:17 AM

#

I am sure, thats a minor issue. And putting something in the correct position will hunt you across game dev anyway, so I would not avoid that 😉

#Hey I need some help please The code for