#↕️┃editor-extensions | Official Unity Discord | Page 38

lucid hedge Jan 20, 2019, 11:15 PM

#

Maybe I'm overriding the default button style somewhere?

#

I might found out once I clean up this code :p

visual stag Jan 20, 2019, 11:27 PM

#

I've tested it with the style not assigned and it seems to work so i assume you've done that unless you have a version with a bug

#

as it does use the button style assigned to the current skin

lucid hedge Jan 20, 2019, 11:29 PM

#

Yeah I suspect that's the case. And I don't think it's a version specific bug since I've had this bug on a lot of versions in both 2017.x and 2018.x

#

@visual stag do you know if UIElements already has an API for custom inspectors?

#

or is it only windows

visual stag Jan 20, 2019, 11:37 PM

#

There is now a root exposed to add to in inspectors I think

#

but it may be 2019.1 only, I'm honestly not suuuure but it shouldn't be too hard to find out

#

I thiiiink you override CreateInspectorGUI

#

and I assume you just return a root VisualElement yourself and it gets added to the root

#

perhaps because they don't want you modifying the inspector by exploring around from the root (you can't stop me!)

wispy delta Jan 21, 2019, 4:20 AM

#

Is there a way to recreate the rotation controls that is on the transform inspector? I tried using EditorGUILayout.PropertyField() on a Quaternion but got this

📎 unknown.png

visual stag Jan 21, 2019, 4:30 AM

#

for a start you can use EditorGUILayout.PropertyField(property, true); to draw something for now

#

otherwise you have to draw it manually with a Vector3Field or a MultiFloatField

#

if you want to you can look at the internal quaternion field for the transform inspector at UnityEditor.TransformRotationGUI.RotationField which is "fun"

visual stag Jan 21, 2019, 5:04 AM

#

just to add to that - you can use a PropertyAttribute and PropertyDrawer combo to avoid making an editor and create some reuse for the quaternion field

wispy delta Jan 21, 2019, 5:06 AM

#

I just found TransformUtils.GetInspectorRotation and TransformUtils.SetInspectorRotation which lets you get/set a transform's rotation based on a Vector3 like how the inspector does it. Unfortunately I don't have a transform, *I wish I could just get the resulting quaternion that the transform would end up being assigned

#

I guess it needs some additional transform info? If not, changing this method to just return a Quaternion would be a nice refactor

visual stag Jan 21, 2019, 5:08 AM

#

I'd just use quaternionValue.eulerAngles

#

and then set it back with Quaternion.Euler()

wispy delta Jan 21, 2019, 5:09 AM

#

I used that a while ago, but I feel like I remember it getting janky occasionally

#

it would always change the y axis to be -89.999 or something like that

visual stag Jan 21, 2019, 5:10 AM

#

Yeah, I usually do some magical rounding

wispy delta Jan 21, 2019, 5:10 AM

#

Oh wait, here's the source for the methods:

public static class TransformUtils
    {
        public static Vector3 GetInspectorRotation(Transform t)
        {
            return t.GetLocalEulerAngles(t.rotationOrder);
        }

        public static void SetInspectorRotation(Transform t, Vector3 r)
        {
            t.SetLocalEulerAngles(r, t.rotationOrder);
        }
    }

#

not so fancy after all

visual stag Jan 21, 2019, 5:10 AM

#

well, those are internal

wispy delta Jan 21, 2019, 5:11 AM

#

oh 😦

visual stag Jan 21, 2019, 5:11 AM

#

(and also use transform values)

wispy delta Jan 21, 2019, 5:11 AM

#

ah yes. damn

#

ok, so I'm diving into property drawers for the first time and am not sure of the best to add undo/redo support. I know how to do it for other stuff, but I'm not sure how to do it for a SerializedProperty

[CustomPropertyDrawer (typeof (Quaternion))]
public class QuaternionPropertyDrawer : PropertyDrawer
{
    private Vector3 euler;
    private bool initialized = false;

    public override void OnGUI (Rect position, SerializedProperty property, GUIContent label)
    {
        if (!initialized)
        {
            euler = property.quaternionValue.eulerAngles;
            initialized = true;
        }

        EditorGUI.BeginChangeCheck ();
        euler = EditorGUI.Vector3Field (position, label, euler);
        if (EditorGUI.EndChangeCheck ())
        {
            property.quaternionValue = Quaternion.Euler (euler);
            // how/where do I register undo?
        }
    }
}

visual stag Jan 21, 2019, 5:23 AM

#

it should support it automatically

#

because it is a SerializedProperty

wispy delta Jan 21, 2019, 5:24 AM

#

oh I see the issue, it is supporting undo, but the inspector isnt redrawing for some reason

#

I'm not doing anything different than in the rest of my functioning custom inspectors

public override void OnInspectorGUI ()
{
    base.OnInspectorGUI ();

    EditorGUILayout.PropertyField (properties.Position, content.Position);
    EditorGUILayout.PropertyField (properties.Rotation, content.Rotation);
    EditorGUILayout.PropertyField (properties.Scale, content.Scale);

    serializedObject.ApplyModifiedProperties ();
    EditorApplication.QueuePlayerLoopUpdate ();
}

visual stag Jan 21, 2019, 5:26 AM

#

you shouldn't need the Property Fields as base.OnInspectorGUI should draw them now

wispy delta Jan 21, 2019, 5:26 AM

#

Nope, nevermind. It's the code that's not updating its euler value. That's what I get for copy/pasting forum posts.

visual stag Jan 21, 2019, 5:27 AM

#

but yeah, also I was wondering what the initialized thing did

wispy delta Jan 21, 2019, 5:28 AM

#

i guess it was doing something nice? with the all the initialization stuff removed, I get the weird values of yore

📎 2019-01-20_23-28-08.mp4

#

So I see what it's doing. It makes sure to get the correct initial rotation value, and from then on it doesn't convert back from quaternion to euler. So when I undo, the euler is out of sync

visual stag Jan 21, 2019, 5:31 AM

#

I usually just round the values slightly before I write them after an inspector change

wispy delta Jan 21, 2019, 5:33 AM

#

I'll give that a shot. Although if I could somehow serialize and register undo with the euler angle as well as the rotation I could get it to work perfectly. but that sounds like a rabbit hole I shouldnt enter

#

What precision do you typically round at?

visual stag Jan 21, 2019, 5:36 AM

#

I don't remember, I don't have an example on hand, usually it doesn't take much

wispy delta Jan 21, 2019, 5:37 AM

#

ok coolio

visual stag Jan 21, 2019, 5:40 AM

#

if that doesn't work well enough, you can always do an angle check between the cached Vector3 and the current eulerAngles, and only update it when the angle changes past a significance value

wispy delta Jan 21, 2019, 7:15 AM

#

I've got a custom window that draws a list of buttons, but there seems to be a minimum width that the enclosing layout will shrink to. Here's my abbreviated gui code (you can see the issue in the short vid below)

private void OnGUI ()
{
    scrollPosition = EditorGUILayout.BeginScrollView (scrollPosition);

    EditorGUILayout.Space ();

    // draw auto add toggle here

    EditorGUILayout.Space ();

    // draw add deformable button here

    EditorGUILayout.Space ();

    // draw buttons here

    EditorGUILayout.EndScrollView ();

    Repaint ();
}

📎 2019-01-21_01-09-41.mp4

#

When I set the min width of the scroll view:
scrollPosition = EditorGUILayout.BeginScrollView (scrollPosition, GUILayout.MinWidth (150));
I end up with this clipping:

📎 unknown.png

visual stag Jan 21, 2019, 7:34 AM

#

I think it's another control and not the scroll view

#

it's the Toggle Left

#

add GUILayout.MinWidth(0) to the ToggleLeft and it should be good

#

just offhandedly, is there a reason to constantly repaint this window?

wispy delta Jan 21, 2019, 7:39 AM

#

Not sure, I wrote this a while ago. The lists of buttons is generated via reflection using custom attributes so maybe it was to redraw when the list changes. There's probably a better solution since I'm only doing the reflection call in OnEnable

visual stag Jan 21, 2019, 7:39 AM

#

You can likely remove the repaint call then :)

#

I saw this and thought of your work btw https://twitter.com/TocoGamescom/status/1087041873854844929

David Hagemann (Available for Commissions) (@TocoGamescom)

Looks like I'm finally getting somewhere with the waves brush https://t.co/hmjGe5k9Wv

Likes

641

▶ Play video

wispy delta Jan 21, 2019, 7:42 AM

#

wooah! that looks amazing!

#

so I set the min width to zero, but had no luck. maybe im doing something funky where i abbreviated the code with comments?
https://hastebin.com/vowiwigumu.cs

visual stag Jan 21, 2019, 7:44 AM

#

give me a mo'

#

add the same to the label

wispy delta Jan 21, 2019, 7:48 AM

#

you're a god! thanks a mil

📎 2019-01-21_01-47-49.mp4

visual stag Jan 21, 2019, 7:53 AM

#

There's two debuggers for editor UI (that I didn't use to problem solve this, but might help in the future), 2019.1 has both visible under Analysis, 2018.3 only has the UIElements one. But you can reach the IMGUI one with cs if (GUILayout.Button("GUI Debugger")) GetWindow(Type.GetType("UnityEditor.GUIViewDebuggerWindow,UnityEditor")).Show();

#

Might help in future :+1:

wispy delta Jan 21, 2019, 7:56 AM

#

ooh very nice! thanks!

whole steppe Jan 21, 2019, 1:37 PM

#

 using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PathFollower : MonoBehaviour
{

    public GameObject[] PathNode;
    public float MoveSpeed;
    float Timer;
    static Vector3 endPosition;
    int CurrentNode;
    private Vector3 startPosition;


    // Use this for initialization
    void Start()
    {
        //PathNode = GetComponentInChildren<>();
        CurrentNode = 0;
        CheckNode();
    }

    void CheckNode()
    {
        Timer = 0;
        startPosition = this.transform.position;
        Debug.Log("StartPos: " + startPosition);
        endPosition = PathNode[CurrentNode].transform.position;
    }

    // Update is called once per frame
    void FixedUpdate()
    {

        Timer += Time.deltaTime * MoveSpeed;

        if (this.transform.position == endPosition)
        {
            if (CurrentNode < PathNode.Length - 1)
            {
                CurrentNode++;
                CheckNode();
            }
        }
        else
        {
            this.transform.position = Vector3.Lerp(startPosition, endPosition, Timer);
           
        }
    }
}
    ```

#

im moving objects from node to node, but they get stuck

visual stag Jan 21, 2019, 1:41 PM

#

you cannot compare two floating point values with an equality

#

unless they have been assigned completely manually compare them with Mathf.Approximately

whole steppe Jan 21, 2019, 1:42 PM

#

I dont get it

visual stag Jan 21, 2019, 1:42 PM

#

ie. Mathf.Approximately((this.transform.position - endPosition).sqrMagnitude, 0)

whole steppe Jan 21, 2019, 1:42 PM

#

thanks lemme try

#

else section right?

visual stag Jan 21, 2019, 1:43 PM

#

replace the interior of the if (this.transform.position == endPosition)

whole steppe Jan 21, 2019, 1:44 PM

#

K

#

they going into the ground now

#

@visual stag how to make 3 players follow a specific path that is split into 5 empty game objects

visual stag Jan 21, 2019, 1:48 PM

#

you can also replace this.transform.position == Timer with Timer >= 1

#

because that's literally what the lerp is doing

whole steppe Jan 21, 2019, 1:49 PM

#

k

#

doesnt work u know any other ways to do it

visual stag Jan 21, 2019, 1:51 PM

#

do you ever increment CurrentNode

#

oh wait I see it

whole steppe Jan 21, 2019, 1:51 PM

#

wdym

visual stag Jan 21, 2019, 1:53 PM

#

I can't really help any more, perhaps someone else will have the time. Just remember you can't assume floats are the same, just approximately the same. And also lerp takes a 0-1 value so if the value you pass it is 1 or greater you're at the destination

whole steppe Jan 21, 2019, 1:53 PM

#

K thanks for the help

whole steppe Jan 21, 2019, 2:55 PM

#


using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PathFollower : MonoBehaviour
{

    public GameObject Positions;
    public float MoveSpeed = 2;
    float Timer;
    static Vector3 endPosition;
    public int index = 1;
    private Vector3 startPosition;


    // Use this for initialization
    void Start()
    {
        //PathNode = GetComponentInChildren<>();
        CheckNode();
    }

    void CheckNode()
    {
        Timer = 0;
        startPosition = this.transform.position;
        Debug.Log("StartPos: " + startPosition);
        endPosition = Positions.transform.GetChild(index).transform.position;
    }

    // Update is called once per frame
    void FixedUpdate()
    {
        Debug.Log(index);
        Timer += Time.deltaTime * MoveSpeed;

        //Debug.Log(" X: " + this.transform.position.x + " - " + endPosition.x);
        //Debug.Log(" Y: " + this.transform.position.y + " - " + endPosition.y);
        //Debug.Log(" Z: " + this.transform.position.z + " - " + endPosition.z);

        if (Mathf.Approximately(this.transform.position.x, endPosition.x) &&
            Mathf.Approximately(this.transform.position.z, endPosition.z)
            )
        {
            Debug.Log("Hi");
            // If the player reaches the target position
            if (index < Positions.transform.childCount - 1)
            {
                Debug.Log("I'm here");
                index++;
                CheckNode();
            }
        }
        else
        {
            this.transform.position = Vector3.Lerp(startPosition, endPosition, Timer);
           
        }
    }
}

void cedar Jan 21, 2019, 4:01 PM

#

usually for more than a few lines of code, you'll want to use something like https://hastebin.com 😉

minor marlin Jan 21, 2019, 6:00 PM

#

@brisk canopy @wispy delta Found this : http://antondoe.blogspot.com/2016/08/serialization-with-polymorphism-and.html It references the original page I found on Serialization Best Practices but the example file link seems to work after exiting Unity, if your interested

Serialization with Polymorphism and Inheritance in Unity

In this article, I would like to share my experience in serialization of classes with inheritance and polymorphism in Unity. If you have s...

lucid hedge Jan 21, 2019, 6:02 PM

#

has anyone used this new scene view tools API in 2019.1?

#

📎 unknown.png

lucid hedge Jan 21, 2019, 6:21 PM

#

hmm I think you can't do anything custom in that scene view window

#

it just displays all the custom editor tools you've made for the toolbar on top

#

pretty neat

lucid hedge Jan 21, 2019, 8:53 PM

#

I'm wondering

#

You know Asset Forge

#

https://www.youtube.com/watch?v=BQlJtkro3zU

YouTube

Hugefatman

Asset Forge Tutorial: Everything In 6 Minutes Or Less (1.3)

1.5 speed is pretty slick. Can't wait for Asset Forge 2.0! -Asset Forge: https://assetforge.io/

▶ Play video

#

It's made in Unity

#

📎 unknown.png

#

and it's like a whole standalone exe window

#

I don't get how they made this...

#

If anyone could give me a clue

#

Is it like a 'game' they made with a recreation of the scene view and added a GUI?

#

and then build it to get an exe?

#

I think that's the case

wispy delta Jan 21, 2019, 9:09 PM

#

I don't think they're running editor gui controls at runtime. I mean..for the most part they could, using the legacy gui system, but they could have easily made all the controls with ugui as well

#

You could ask kenney (the dev) on twitter, he might respond

surreal quest Jan 21, 2019, 9:10 PM

#

He's also on this server

lucid hedge Jan 21, 2019, 9:10 PM

#

Yeah just asked him on twitter 😃

#

It's indeed not an editor extension like I thought

#

I thought it ran on top on the unity scene view window or something, but it's really like a game they built but then the game is a tool :p

#

Gonna try this out for some projects, seems really fun to do and you have a lot of freedom

#

So yeah I guess this is not really editor scripting :p

zealous ice Jan 22, 2019, 11:35 AM

#

Is there any free plugin/add-on that allows to push update to itch.io with one press? Do I need to create my own?

wispy delta Jan 22, 2019, 8:23 PM

#

Is there a better way to make a "toggle row" like this? My current implementation is kinda a mess. I have 6 GUIStyles: left-on, left-off, mid-on, mid-off...etc. I draw each button with a different style depending on it's toggle state and whether its on the side or middle of the row. The background, when it is toggled on, is just a 2x2 blue png which (if you look closely) does't quite match the style of the "off" state.

📎 2019-01-22_14-17-02.mp4

#

The buttons just change an enum that is used for filtering. So it's essentially an enum field with all options displayed in a row

if (GUILayout.Button (content.AllFilter, filter == FilterCategory.All ? styles.ToggleButtonOnLeft : styles.ToggleButtonOffLeft, GUILayout.MinWidth (0)))
{
    Undo.RecordObject (this, "Changed Filter Category");
    filter = FilterCategory.All;
}
else if...

waxen sandal Jan 22, 2019, 8:33 PM

#

https://docs.unity3d.com/ScriptReference/GUILayout.Toolbar.html ?

wispy delta Jan 22, 2019, 8:45 PM

#

pretty much perfect thanks. is there a way to make it use smaller buttons? right now it's using the big ones, but the small ones I was using, EditorStyles.miniButton(Left/Mid/Right), were better for conserving space

📎 unknown.png

waxen sandal Jan 22, 2019, 8:51 PM

#

Not sure, would have to check the default styles

#

Or make your own

wispy delta Jan 22, 2019, 9:02 PM

#

I actually came up with a nice solution. I have an array of GUIContent called "FilterToolbar." It matches the number of options in the enum, FilterCategory. I loop through the array and draw toggles with my own style (in this case, the collection of miniButton styles.) The toggle's bool value is set to whether or not the current index in the loop is equal to the current enum value. The toggle's content is set to the content in the array at the current index.

using (new EditorGUILayout.HorizontalScope ())
{
    var categoryCount = content.FilterToolbar.Length;
    for (int i = 0; i < categoryCount; i++)
    {
        if (GUILayout.Toggle ((int)filter == i, content.FilterToolbar[i], (i == 0) ? EditorStyles.miniButtonLeft : (i == categoryCount - 1) ? EditorStyles.miniButtonRight : EditorStyles.miniButtonMid))
        {
            Undo.RecordObject (this, "Changed Category Filter");
            filter = (FilterCategory)i;
        }
    }
}

#

📎 2019-01-22_15-02-58.mp4

lucid hedge Jan 22, 2019, 10:17 PM

#

@wispy delta maybe not what you want, but just wanted to show you that you can also put them in a grid or something

#

📎 proxy.png

#

I use GUILayout.SelectionGrid for this

#

and you say 'pretty much perfect thanks. is there a way to make it use smaller buttons? right now it's using the big ones, but the small ones I was using, EditorStyles.miniButton(Left/Mid/Right), were better for conserving space'

#

but you can pass on a style into the guilayout.toolbar too

#

like this

#

ToolBarIndex = GUILayout.Toolbar(ToolBarIndex, menuOptions, new GUIStyle("LargeButton"));

wispy delta Jan 22, 2019, 10:19 PM

#

Yea, I didn't think passing a style to it would work since behind the scenes it uses 3 styles (left, right, middle). I guess it just doesn't differentiate between the sides if you use the overload that sends a guistyle?

lucid hedge Jan 22, 2019, 10:21 PM

#

Yeah I've had issues with the styles

#

but if I pass new GUIStyle("LargeButton") onto it

#

it works

#

could try a smaller button too

#

like

#

(GUIStyle)"EditModeSingleButton" or (GUIStyle)"minibutton"

minor marlin Jan 22, 2019, 11:12 PM

#

how do I convert a bool to json? JsonUtility.ToJson(value, true) just returns {} no matter if it's true or false

slate pecan Jan 22, 2019, 11:27 PM

#

a standalone bool doesn't make sense in json

wispy delta Jan 22, 2019, 11:43 PM

#

tldr: Is there a way to get Unity to save a reference to a different mesh on a MeshFilter when the scene is saved?

I'm working on a tool that deforms meshes (bend, twist etc). One problem I'm running into is how much space each deformed mesh takes up. Each mesh obviously has to be unique to be rendered, but that results in large scene file sizes when there are lots of deformed meshes. Would there be a way to switch the deformed mesh back to the original one when the scene or prefab is saved? I'm already serializing a reference to the original mesh, so regenerating the deformed mesh isn't a problem.

#

Here's the data I'm storing. (you don't have to read the whole thing, it's just there for reference) As you can see, I'm not serializing the dynamic mesh (the one that gets rendered). So all I need to do is trick Unity into serializing the MeshFilter with a reference to the original mesh rather than the dynamic one.

// Stores the original shared mesh that other objects may be using.
// Must be serialized so that if the Deformable that encapsulates this class is duplicated the reference won't be broken.
[SerializeField, HideInInspector]
public Mesh OriginalMesh;

/// <summary>
/// References the copy of the original mesh that processed data is applied to.
/// Once this class is initialized, this is the mesh that will be used by MeshFilter.
/// </summary>
public Mesh DynamicMesh;

/// <summary>
/// Stores either a MeshFilter or SkinnedMeshRenderer and abstracts access to it.
/// </summary>
public MeshTarget Target;

/// <summary>
/// Stores original mesh data in NativeArrays for fast processing and multithreading.
/// </summary>
public NativeMeshData OriginalNative;

/// <summary>
/// Stores current mesh data in NativeArrays for fast processing and multithreading.
/// </summary>
public NativeMeshData DynamicNative;

// Must be serialized so that if the Deformable that encapsulates this class is duplicated the reference won't be broken.
[SerializeField, HideInInspector]
private bool initialized;

/// Stores the original state of the mesh before any changes were made.
private ManagedMeshData originalManaged;

/// We can't directly transfer from a NativeArray to a mesh, so this is used as a middle-ground. 
/// The transfer goes like this: Native Data -> Managed Data (this) -> Mesh
private ManagedMeshData dynamicManaged;

prisma chasm Jan 23, 2019, 12:29 AM

#

are you cloning the mesh prior to manipulating it?

wispy delta Jan 23, 2019, 12:45 AM

#

Yea. I instantiate a copy and assign it to the mesh filter. Any changes to mesh data are sent to the cloned mesh, not the original

prisma chasm Jan 23, 2019, 12:53 AM

#

Let me play this back to you
1.) I have an FBX I import into my project
2.) I create a prefab from that FBX that has a meshfilter on it
3.) I run the Beans magic tool on that prefab.
4.) Tool looks for a mesh filter and instantiates MeshFilter.mesh
5.) Tool assigns MeshFilter.mesh to the clone
6.) Tool manipulates the mesh
7.) Tool reassigns MeshFilter.mesh back to the original
8.) Saving the scene winds up saving the wrong mesh back?

wispy delta Jan 23, 2019, 1:15 AM

#

1-7 is correct, but saving the scene saves the instantiated mesh as you'd expect. however i don't need it to save every unique mesh, if it saves the original mesh I can generate the unique one at runtime and make the file size smaller

#

right now if I duplicate 20 default unity spheres and apply my script to them they become 20 unique meshes rather than 20 references to the same mesh

prisma chasm Jan 23, 2019, 1:23 AM

#

have you taken a look at .sharedMesh?

wispy delta Jan 23, 2019, 1:27 AM

#

Sorry I should have corrected #5. I'm using sharedMesh

prisma chasm Jan 23, 2019, 1:28 AM

#

got it

wispy delta Jan 23, 2019, 1:31 AM

#

in an ideal world there would be some callback and I could do something like this
onBeforeSerialize += () => Target.sharedMesh = OriginalMesh;
or

private void OnBeforeSerialize ()
{
    Target.sharedMesh = OriginalMesh;
}

grim monolith Jan 23, 2019, 3:52 AM

#

If I understand your issue correctly you can use AssetModificationProcessor.OnWillSaveAssets there you can change the mesh to the default one

#

https://docs.unity3d.com/ScriptReference/AssetModificationProcessor.OnWillSaveAssets.html

light vault Jan 23, 2019, 10:16 AM

#

Heehee https://twitter.com/alexanderameye/status/1087636683426852869?s=19

Alexander Ameye (@alexanderameye)

In Unity 2019.1 alpha, there is a new EditorTools API.
I should probably find a good use for this, but for now it
works as a de-stressing tool that shows me kittens :)

https://t.co/r2OLBxdAIj

@unity3d #madewithunity #unitytips https://t.co/RUejKZxINy

Retweets

159

Likes

564

▶ Play video

visual stag Jan 24, 2019, 10:21 AM

#

https://twitter.com/vertexxyz/status/1088380802491023361

Thomas Ingram (@vertexxyz)

In Unity 2019.1 alpha, there is a new EditorTools API.
Improved kittens!

Thanks @alexanderameye and @superpig ;)
https://t.co/J7nfyZu8PX

@unity3d #madewithunity #unitytips https://t.co/RIjCuz7Qv7

▶ Play video

crisp jetty Jan 24, 2019, 11:46 AM

#

Glorious.

wispy delta Jan 25, 2019, 8:11 PM

#

I'm using ReorderableList (a popular repo on github) and when I add multiple objects to the list I get an error that says:
The operation is not possible when moved past all properties (Next returned false) I'm not really sure what that means. What is it referring to in "moving past properties?"

So I started looking into the SerializedProperty class, and I found the method CountRemaining. So you can count how many remaining properties there are? What does that even mean? The documentation says, "Note that calling this method will move the property forward to the end of the SerializedObject."...like wut?

#

Why does the order or positions of properties matter in a SerializedObject?

spark zodiac Jan 25, 2019, 8:34 PM

#

Anybody with a lot of insight into editor Handles?

Is there any built-in shortcut to determine when a Handles.FreeMoveHandle is being hovered over by the mouse, or if it has been clicked but not dragged? They change color under these circumstances, so they're being detected, but they don't become a GUIUtility.hotControl until they're actually being moved, and the editor won't register any change until then either.

I need Handles.FreeMoveHandle and Handles.Button functionality from a single handle, and have been struggling to find a clean way to do it :/

visual stag Jan 25, 2019, 8:54 PM

#

@wispy delta the serialized property class is an Enumerator, so it has MoveNext, Current, Reset. It's not an indexable format like an array of a list. So similar to linq extensions for collections that don't have a counter the Count Remaining function will call move next until it returns false

#

Ending up at the end of the property

#

There's a reorderable list that just works built in that just takes a little amount of work to set up in a custom editor

#

In the case of a serialized property if you pass true to the Next function it will iterate through sub properties, so I assume Count Remaining also has this distinction

#

Ah no, it uses hasVisibleChildren to make that distinction

wispy delta Jan 25, 2019, 9:21 PM

#

@visual stag thanks for the explanation, that makes more sense now. I'm still not sure why I'm getting an error though. If I have a single object selected and add a new element it works fine, but if I have multiple objects selected and add a new element, I get an error pointing at this method in the ReorderableList class:

private float GetElementHeight(SerializedProperty element) {

    if (getElementHeightCallback != null) {

        return getElementHeightCallback(element) + ELEMENT_HEIGHT_OFFSET;
    }
    else {
        // the line below is where the error points
        return EditorGUI.GetPropertyHeight (element, GetElementLabel (element, elementLabels), IsElementExpandable (element)) + ELEMENT_HEIGHT_OFFSET;
    }
}

If I deselect and then reselect the objects, the new element(s) are displayed normally. Are there any common "gotchas" that could occur when calling EditorGUI.GetPropertyHeight or are there any other possible issues you see? My drag and drop area gui is pretty straightforward, it returns a list of components that were dropped onto it, which are then added to the list. so i think the issue *isn't there

📎 2019-01-25_15-14-18.mp4

visual stag Jan 25, 2019, 11:05 PM

#

I'm not sure, I've never used this extension for reorderable lists before 🤷 If their iterator sucks it seems to not be checking whether there is a valid element, and MoveNext gets called in this situation and they continue running code once it returns false

#

I'm not sure if theres a way to check whether the element is valid once you have it...

#

maybe propertyPath is empty or something, not sure. I don't think I can help with the specifics of the bug

wispy delta Jan 25, 2019, 11:25 PM

#

Gotcha, well thanks for pointing me in the right direction. I'll figure it out eventually

wispy delta Jan 26, 2019, 8:05 PM

#

@visual stag I ditched the other dudes reorderable list implementation and you were right, it's pretty easy to make my own version. Unfortunately, I have the same error with my version; however, I actually know what's going on in my code. The error points to the first FindPropertyRelative call I make when drawing an element of the array. Is there some sort of check I need to make? I put a break point on the code and element's property isn't null - so I'm not sure why I can't access a child property.

list.drawElementCallback += (Rect rect, int index, bool isActive, bool isFocused) =>
{
    // get property of current item in array
    var elementProperty = list.serializedProperty.GetArrayElementAtIndex (index);
    // get the element's "active" bool
    var activeProperty = elementProperty.FindPropertyRelative (ACTIVE_PROP); // error here
    // get the element's deformer reference
    var deformerProperty = elementProperty.FindPropertyRelative (DEFORMER_PROP);
   
    ...

visual stag Jan 26, 2019, 11:09 PM

#

if your structure layout is like:

List<Element> ...;
... Element {
    public bool active;
    public Deformer deformer;
}```

#

then it should just work

#

perhaps you should null check the elementProperty's value just in case

#

if it's an Object then you can null check the objectReferenceValue property

wispy delta Jan 26, 2019, 11:13 PM

#

yea i've got it as a struct

[System.Serializable]
public struct DeformerElement
{
    public Deformer Deformer;
    public bool Active;

    public DeformerElement (Deformer deformer, bool active = true)
    {
        Deformer = deformer;
        Active = active;
    }
    ...

I just added a null check to the elementProperty and it still hit the error, so I guess it isn't null

#

It's not even getting to the deformer property, which is the only reference value

visual stag Jan 26, 2019, 11:14 PM

#

yeah but the property will be returned even if the object is null

wispy delta Jan 26, 2019, 11:15 PM

#

Oh I see, lemme give it a try

#

So objectReferenceValue will always be null because it's a struct

visual stag Jan 26, 2019, 11:17 PM

#

I don't often work with structures that are not inheriting from Object or one of the base types supported by SP

#

which may be where your problems are arising from

#

I think there are some extension methods that use reflection into the serialized object to discover properties using the propertyPath seeing as it's not really supported

wispy delta Jan 26, 2019, 11:21 PM

#

I'm just not sure why it only stops working when I have multiple objects selected

visual stag Jan 26, 2019, 11:25 PM

#

surely your code for adding stuff to the list with a drag and drop is custom?

wispy delta Jan 26, 2019, 11:25 PM

#

Yea, but it literally just adds to the list

visual stag Jan 26, 2019, 11:26 PM

#

the bug gets caused with that action though, so you'd think it'd be related to it?

wispy delta Jan 26, 2019, 11:27 PM

#

Yea good point, but when I click off and click back on they are drawn normally.

visual stag Jan 26, 2019, 11:27 PM

#

what happens if you do (perhaps in debug mode) remove an array element from the list but keep it unassigned

wispy delta Jan 26, 2019, 11:28 PM

#

remove the reference to a deformer on one of the elements?

visual stag Jan 26, 2019, 11:28 PM

#

just an entire DeformerElement

wispy delta Jan 26, 2019, 11:30 PM

#

it gets removed without any errors

📎 2019-01-26_17-30-01.mp4

visual stag Jan 26, 2019, 11:30 PM

#

yeah but that actually resizes the list, I mean nullify an element

#

which you'd have to do in debug mode

wispy delta Jan 26, 2019, 11:31 PM

#

im not sure if i can, since it's a struct

visual stag Jan 26, 2019, 11:32 PM

#

ah, true, god I have't worked with structs in a list with serialised properties ever, sorry :/

wispy delta Jan 26, 2019, 11:32 PM

#

no worries

whole steppe Jan 28, 2019, 1:28 PM

#

I have a box collider and if the camera leaves it I want to make it fall

#

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class FallDown : MonoBehaviour
{
    public Rigidbody rb;
    [Range(1,30)] public float speed;

    private void OnTriggerExit(Collider other)
    {
        if(other.tag == "MainCamera")
        {
            rb.useGravity = true;
        }
    }
}

hushed stirrup Jan 28, 2019, 4:23 PM

#

make sure the Camera has a collider and kinematic rigidbody on it too

#

though #⚛️┃physics would probably be a more appropriate place to ask :)

past gull Jan 28, 2019, 5:48 PM

#

guys, anyone having issues with the editor in 2018.3.3? each time I change a field and save the scene it reimports stuff, not sure what, but wasn't happening in 2018.3.2, I just updated

#

mmm it is happening in 2018.3.2 too... maybe something changed in my config

trail dawn Jan 28, 2019, 5:54 PM

#

Question about custom icons.

I have some icons inside the the Gizmo folder that are correctly updating the icons of Scriptable Objects. However, this is only working for SO's that directly inherit the script:

State : Scriptable Object > Create State (Works)

StateDecision : Scriptable Object > Create Decision : State Decision > Create Decision (Doesn't work)

#

Does anyone know f it's possible to hook up the icons?

past gull Jan 28, 2019, 5:59 PM

#

(ok, forget what I said, I just restarted my laptop and now it works fine.... :S)

coarse tree Jan 28, 2019, 9:27 PM

#

Is there a way for an editor to create a GameObject and then make that the selected object in the scene?

visual stag Jan 28, 2019, 10:20 PM

#

@coarse tree Selection.gameObjects = new []{new GameObject()};

#

that's written off the top of my head, but you should get the idea

coarse tree Jan 28, 2019, 10:23 PM

#

Ah, thanks @visual stag !

visual stag Jan 28, 2019, 10:48 PM

#

@trail dawn Similar to assigning gizmos to GameObjects the menu exists on scripts, perhaps using that menu on all your related script types will give the icons to the SO's you need

whole steppe Jan 29, 2019, 9:34 AM

#

I want to move something forward with Vector3.smoothDamp

#

CameraRig.transform.forward = Vector3.SmoothDamp(transform.position, CameraRig.transform.forward, ref velocity, smoothTime);

waxen sandal Jan 29, 2019, 9:35 AM

#

Not sure why this is in #↕️┃editor-extensions

#

Either way you shouldn't set the forward, you should set the position

#

And you probably want to use the position from your camerarig as current position

#

And I wouldn't use forward from the camera rig as target position

#

Use a world space position instead

whole steppe Jan 29, 2019, 9:56 AM

#

thanks

waxen sandal Jan 31, 2019, 8:05 AM

#

Is there a way to give priority to the label of a property field so that it tries to get the most space? Rather than this?

📎 unknown.png

visual stag Jan 31, 2019, 9:09 AM

#

use the https://docs.unity3d.com/ScriptReference/GUILayoutOption.html options to guide it into a better default

#

or use them to set the size of the label based on the text (which you can calculate using GUIStyle's CalcSize and a couple of other ways)

waxen sandal Jan 31, 2019, 9:29 AM

#

You don't really have that option with PropertyField

#

As you aren't manually drawing the label/input field

visual stag Jan 31, 2019, 9:33 AM

#

Well, I'd separate it into two controls

#

the property field and the label. The internal usage of PrefixLabel just isn't playing nice with that length of text ):

#

also I've never tried this, so I don't know if it would work but perhaps EditorGUIUtility.labelWidth is a thing you can set temporarily to override the prefix label width?

#

if it does work, you can set it back to 0 to regain the default value

waxen sandal Jan 31, 2019, 9:38 AM

#

Yeah the latter is what I'm thinking

hushed stirrup Jan 31, 2019, 5:04 PM

#

@waxen sandal PropertyField obeys https://docs.unity3d.com/ScriptReference/EditorGUIUtility-labelWidth.html

#

there's a handful of our editors that set that to something larger at the beginning of their OnInspectorGUI

waxen sandal Jan 31, 2019, 5:05 PM

#

Yeah, I figured that out. Got it working semi decently now

#

Thanks though 😄

wispy delta Jan 31, 2019, 11:10 PM

#

I found a workaround for the error when adding multiple elements to a ReorderableList. Rather than adding the elements directly to the list, I add them through the property like so:

public void Add (DeformerElement element)
{
    var listProperty = list.serializedProperty;
    var newProperty = listProperty.GetArrayElementAtIndex (list.serializedProperty.arraySize++);
    newProperty.FindPropertyRelative ("Active").boolValue = element.Active;
    newProperty.FindPropertyRelative ("Deformer").objectReferenceValue= element.Deformer;
}

This is great for the drag n drop gui, but I also have an editor window that lets you add deformers to the lists of selected object. The issue is that it's a custom window. Custom windows don't come with the builtin serializedObject field like CustomEditors do. Is there a way to get access to all the selected serialized objects from an editor window?

#

If there was I could do something like:

for each (serialized object in serialized objects)
    if serialized object has deformer list property
        add element to deformer list property

visual stag Feb 1, 2019, 12:01 AM

#

what do you mean by selected SerializedObjects?

#

you can go SerializedObject sO = new SerializedObject(object);

#

and cache them from whatever you want

wispy delta Feb 1, 2019, 12:14 AM

#

I didn't know I could do that, guess I'll just create a serialized object based off every component in Selection.gameObjects

wispy delta Feb 1, 2019, 6:57 AM

#

Still getting the error. What exactly does serializedObject.Update() do? I assumed it syncs the serialized object's values with the actual values on the class. But now I'm not sure because I'm calling it and then failing to find properties that should be there.

visual stag Feb 1, 2019, 7:17 AM

#

yes it does

wispy delta Feb 1, 2019, 7:18 AM

#

Is there an emote that shows someone's head exploding in a mix of confusion and frustration?

visual stag Feb 1, 2019, 7:18 AM

#

what's the error again?

wispy delta Feb 1, 2019, 7:18 AM

#

InvalidOperationException: The operation is not possible when moved past all properties (Next returned false)

visual stag Feb 1, 2019, 7:18 AM

#

the emote is Unity

wispy delta Feb 1, 2019, 7:18 AM

#

haha u right

visual stag Feb 1, 2019, 7:19 AM

#

and it refers to newProperty.FindPropertyRelative ("Active")?

wispy delta Feb 1, 2019, 7:19 AM

#

Yea

#

I stepped through my code that adds the components to the list and it's literally there in memory, just not in the property

visual stag Feb 1, 2019, 7:19 AM

#

can you increment the array size before you get it

#

or do you want it like that, it's a weird way of doing it

#

it should be ++list.serializedProperty.arraySize, surely

#

or does that evaluate fine... I think we're into the parts of the language I just do to be safe 😛

wispy delta Feb 1, 2019, 7:21 AM

#

I'd like to not have to deal with adding elements to the list via the property and I feel like that's a reasonable goal haha. That bit of code where I added it through the property was just me grasping for straws. It worked for the drag and drop code, it just didn't work from the editor window for some reason

visual stag Feb 1, 2019, 7:22 AM

#

well, what's your code like now?

wispy delta Feb 1, 2019, 7:22 AM

#

Back to normal. I add the elements to the actual list and then the properties don't exist

#

I made a video for a forum post earlier today where I walk through the problem. I don't expect anyone (including you) to feel the need to watch it, but I'll post it here in case someone is bored enough to want to watch it
https://youtu.be/lZL3PBXMiRE

YouTube

Beans

Serialized Property Bug

▶ Play video

waxen sandal Feb 1, 2019, 7:26 AM

#

SerializedObject.Update should take the data from the class and "import" it to the SerializedObject, ApplyModifiedProperties does it the other way around from SO to the class

visual stag Feb 1, 2019, 7:27 AM

#

when you call DoLayoutList you surround it in a UpdateIfDirtyOrScript and ApplyModifiedProperties

#

or surround the relevant SO code in that

#

in your video you don't seem to apply after calling DoLayoutList which could cause issues

#

I don't think it'd be relevant to your current problem, but it's something to watch out for

wispy delta Feb 1, 2019, 7:34 AM

#

Yea, still get the error. And I just call ApplyModifiedProperties once at the bottom on OnInspectorGUI since I assume there won't be an instance in which multiple properties are changed that depend on each other

visual stag Feb 1, 2019, 7:35 AM

#

it could be screwing with you somewhat, can you move it to directly after DoLayoutList

wispy delta Feb 1, 2019, 7:35 AM

#

Yea, still an error 😦

#

But if there's any other stuff that's assumed I've done correctly, don't assume it haha

wispy delta Feb 1, 2019, 9:40 AM

#

@visual stag solved it! somehow the object is not being registered as dirty so serialiedObject.Update isn't doing anything. He found the method SerializableObject.SetIsDifferentCacheDirty(). If serializedObject.Update is called after that method, the serializedObject is actually updated. So be warned, if you are changing fields directly, calling Update on the SO may not do anything and you'll have to call SetIsDifferentCacheDirty()

visual stag Feb 1, 2019, 9:41 AM

#

but that only seemed to be happening with the multi selected situation... so who really knows what the right circumstances to call it is? We can only stay safe in these trying times Unity

velvet moon Feb 1, 2019, 7:51 PM

#

Hi, does anyone know if something like this works with the cache server? https://docs.unity3d.com/2019.1/Documentation/Manual/DefaultPresetsByFolder.html

#

we made our own custom solution based on json files, to setup import settings for sprites automatically by folder (compression, pack, pixels per unit, etc)

#

but unity in their cache server documentation say that you can't have assets that depend on other assets for configuration, because the cache server wont know

green shoal Feb 1, 2019, 7:59 PM

#

hey, I'm having an issue using the EditorGUILayout.Toggle, whenever I try to use the overloaded method with GUIContent and GUIStyle it does not recognize the way I called the method, it says my arguments are invalid and keeps trying to run as a overloaded method with only the bool and all else being GUILayoutOption.
Am I doing something wrong or is the overloaded method obsolete? I do exactly as the tooltip says, I have some prints in case it is needed

wispy delta Feb 1, 2019, 8:44 PM

#

@green shoal can you show some code?

green shoal Feb 1, 2019, 8:58 PM

#

@wispy delta
GUIContent shortContent = new GUIContent("Type of Effect", "leave true for short and false for long");
GUILayoutOption options;
options = GUILayout.Width(30);
alvo.shortOrLong = EditorGUILayout.Toggle(shortContent, alvo.shortOrLong, EditorStyles.boldFont, options);

this is the part where I got the issue, alvo being the reference for the script selected in the editor

wispy delta Feb 1, 2019, 8:59 PM

#

just formatting this rq so i can read it better

GUIContent shortContent = new GUIContent("Type of Effect", "leave true for short and false for long");
GUILayoutOption options;
options = GUILayout.Width(30);
alvo.shortOrLong = EditorGUILayout.Toggle(shortContent, alvo.shortOrLong, EditorStyles.boldFont, options);

#

boldFont isn't a style

#

@green shoal you need to create a style and set its font to boldFont. There isn't an overload that lets you set the font directly

green shoal Feb 1, 2019, 9:05 PM

#

I tried so beacuse of this part where it worked just fine, I'll look and try not using it

📎 unknown.png

wispy delta Feb 1, 2019, 9:07 PM

#

you're using boldLabel not boldFont

green shoal Feb 1, 2019, 9:12 PM

#

damn, I've been stuck in this for some time now and didn't notice

#

thanks

wispy delta Feb 1, 2019, 9:12 PM

#

haha i thought i was going crazy for a second too

green shoal Feb 1, 2019, 9:15 PM

#

I hate when this happens, thanks for the help, I just fixed it and almost cried

wispy delta Feb 1, 2019, 9:15 PM

#

haha np 👌

wispy delta Feb 1, 2019, 9:45 PM

#

So I created an Assembly Definition file inside the root folder that contains all my code, added my dependencies, ticked "Allow 'unsafe code'" (because I have some unsafe methods) and hit apply.
Now every time I select a gameobject in the scene that has custom editor inside my code folder, I get some weird error that tells me my editor needs to derive from ScriptableObject.
Instance of DeformableEditor couldn't be created. The script class needs to derive from ScriptableObject and be placed in the Assets/Editor folder. Not sure what I'm doing wrong here

📎 unknown.png

#

📎 unknown.png

wispy delta Feb 1, 2019, 10:18 PM

#

I restarted Unity and that appears to have fixed it...weird

lucid hedge Feb 1, 2019, 10:41 PM

#

I have an enum and depending on the choice, different options appear under it. Is there an easy way to make the switching 'smooth' and not instant

#

so the options appear gradually

somber oxide Feb 1, 2019, 11:20 PM

#

I might be going insane (it's happened before), but UnityEditor.Timeline doesn't seem to exist?

wispy delta Feb 1, 2019, 11:21 PM

#

@lucid hedge animate the options? i don't think its possible with the builtin enum property drawer. You'll likely have to make your own, but it shouldn't be too hard. You store the enum's SerializedProperty and draw only the serializedProperty.enumNames that you want and then set serialiedProperty.enumValueIndex when you select one.

somber oxide Feb 1, 2019, 11:22 PM

#

I'm trying to make an example for the new "Refresh" method for TimelineEditor, the docs say that it exists in UnityEditor, but I get errors when I try it out.

somber oxide Feb 2, 2019, 12:02 AM

#

Huh, maybe it needs to be in an Editor folder and not just within a UNITY_EDITOR define?

visual stag Feb 2, 2019, 1:30 AM

#

@wispy delta separate your codebase into two Assembly Definitions, an Editor and Runtime

#

make sure the toggles are correctly set up for the platforms

#

and make sure the editor refers to the runtime

#

you can see examples of this in almost all other packages

wispy delta Feb 2, 2019, 1:48 AM

#

Now that I actually give it thought you're right, noone threads their editor files amongst their runtime files. While it makes it quick to find a script's editor, I can't easily put them in separate assemblies

visual stag Feb 2, 2019, 1:49 AM

#

Why so?

wispy delta Feb 2, 2019, 1:51 AM

#

Cuz it groups scripts based on the folder with the asmdef. I have runtime and editor code all under the same folder

visual stag Feb 2, 2019, 1:53 AM

#

If you just create two root folders, Runtime and Editor and move your editor folder's contents that's it

fresh yoke Feb 2, 2019, 1:53 AM

#

^

#

I prefer that too

#

plus it makes it so much easier to work with asmdefs

#

you also need that kind of structure if you do packages for packman as they don't support special editor folder there (meaning you need to define the editor only things either in asmdef or in code itself)

wispy delta Feb 2, 2019, 1:54 AM

#

That'll be my folder structure from now on 👍

#

Right now my repo includes the Packages, ProjectSettings and Assets folder. Should I bite the bullet now and create a new repo with my codes folder as the root? Or is there a better alternative? I'd like to be able to use my git repo through the package manager

fresh yoke Feb 2, 2019, 2:00 AM

#

PM itself doesn't have handy "refresh" button for git changes if you use the git functionality from it

#

just something to keep in mind

visual stag Feb 2, 2019, 2:01 AM

#

bite the bullet sooner rather than later 🤷

fresh yoke Feb 2, 2019, 2:01 AM

#

but nothing prevents you from putting local package to your project and still putting the package alone in git repo

#

I'm huge fan of the package thing, it just helps keeping everything cleaner

#

but it can require quite some changes, depending what's been done there

#

if you had direct paths to Asset folder on includes etc, they need to be converted to another format etc

visual stag Feb 2, 2019, 2:03 AM

#

I have been structuring mine as having a root folder with multiple packages in it because I sometimes have example packages and test packages and I only want one repo, but it doesn't currently work like that directly with packman, but it's not difficult to pull a repo to a location and reference it so I figure that's fine for now

#

people who have direct paths are monsters anyway

fresh yoke Feb 2, 2019, 2:04 AM

#

it depends, on some shader code, it does give more clarity

visual stag Feb 2, 2019, 2:04 AM

#

ah shaders are terrible at references though which makes it somewhat unavoidable

fresh yoke Feb 2, 2019, 2:04 AM

#

I have an example for that

visual stag Feb 2, 2019, 2:05 AM

#

at least in C# you can rely on the AssetDatabase to search for data

#

and then never specifying where it is exactly

fresh yoke Feb 2, 2019, 2:05 AM

#

older Unity versions didn't support new Packages/packagename/yourfile paths on shaders, only on c#

visual stag Feb 2, 2019, 2:05 AM

#

with shaders you've gotta do relative path stuff

fresh yoke Feb 2, 2019, 2:05 AM

#

so to convert Alloy to package format, I had to do this crap: https://github.com/0lento/Alloy/commit/67ebf5e5bbf5b1607b03bd37dafd0b6c37d8c306#diff-eb096de359fed036f03f2a515d30b7d4L173

GitHub

Convert Alloy 4.3.0 into Package · 0lento/Alloy@67ebf5e

visual stag Feb 2, 2019, 2:05 AM

#

yee

fresh yoke Feb 2, 2019, 2:05 AM

#

it's hideous 😄

visual stag Feb 2, 2019, 2:06 AM

#

sucks when you want to move a thing either way

fresh yoke Feb 2, 2019, 2:06 AM

#

sure, but in packages you don't really restructure it as often

visual stag Feb 2, 2019, 2:06 AM

#

at least with the AssetDatabase you can not think about it

fresh yoke Feb 2, 2019, 2:06 AM

#

it's different if you place something in assets folder

visual stag Feb 2, 2019, 2:06 AM

#

depends what you're doing hahaha

fresh yoke Feb 2, 2019, 2:06 AM

#

because everyone seems to have their own idea on how assets folder items should be structured :p

visual stag Feb 2, 2019, 2:07 AM

#

I was making a package for a long time and every major restructure I was glad I didn't have any shaders to worry about 😛

fresh yoke Feb 2, 2019, 2:07 AM

#

yeah, I'd avoid direct paths if possible

#

there's also one thing on PM that isn't implemented

#

it's not a thing most people need

visual stag Feb 2, 2019, 2:08 AM

#

if I run into a goddamn public asset that has path references like "Assets/MyTerribleAsset/Thing.foo" I immediately modify or delete their code

fresh yoke Feb 2, 2019, 2:08 AM

#

but it totally lacks a thing that will give you full system path for the packages root folder

wispy delta Feb 2, 2019, 5:47 AM

#

@visual stag Sorry for they delay, I didn't run into another chance to respond while I was at work.
How should I handle external code dependencies? For instance, I'm using someone else's spline solution. I have it under a folder called "Vendor" and it has it's editor code alongside runtime code. Should I put it in another asmdef called "DeformDependencies" or something? Or should I create a separate VendorEditor folder and move the spline editor code over there?

visual stag Feb 2, 2019, 5:48 AM

#

I'd probably create an assmdef for them

#

it's a separate API and not dependent on you, so it's clearer (and faster) if you refer to their assembly separately

wispy delta Feb 2, 2019, 5:50 AM

#

Sounds good, thanks 👍

wispy delta Feb 2, 2019, 6:18 AM

#

What's the best folder to put editor resources in? I was looking through the special folders list and none of them seemed quite right. Anything I put in the Resources folder will be included in builds. Editor Default Resources would be a good folder, but there can only be one and it has to be in the root of the Assets folder. Right now I created a folder called EditorResources. I put settings scriptable objects and default meshes in there and then load them with AssetDatabase

visual stag Feb 2, 2019, 6:19 AM

#

I just load stuff via the AssetDatabase and put it where I want to

wispy delta Feb 2, 2019, 6:21 AM

#

I was afraid that was the best solution. Ideally I'd like people to be able to move the tool in a separate folder if they're one of the people that works directly out of their Assets folder rather than creating a sub folder for their project, but I guess they'll just have to deal

visual stag Feb 2, 2019, 6:22 AM

#

Don't use direct paths, I'll find you a method

#

public static T LoadAssetOfType<T>(string contains = null, SearchFilter searchAssets = SearchFilter.All, Action error = null, Action success = null) where T : Object
{
    bool allowScriptAssets = typeof(T) == typeof(MonoScript);
    
    T t = null;
    string[] assetGUIDs = AssetDatabase.FindAssets($"t:{typeof(T).Name}", GetSearchDirs(searchAssets));
    foreach (var assetGUID in assetGUIDs) {
        string assetPath = AssetDatabase.GUIDToAssetPath(assetGUID);
        if (string.IsNullOrEmpty(assetPath) || !allowScriptAssets && assetPath.EndsWith(".cs") || contains != null && !Path.GetFileName(assetPath).Contains(contains)) continue;
        t = AssetDatabase.LoadAssetAtPath<T>(assetPath);
        break;
    }

    if (t == null)
        error?.Invoke();
    else
        success?.Invoke();

    return t;
}

#

You might want one that returns a bool and outs a T

#

but something like that works

#

public enum SearchFilter
{
    All,
    Assets,
    Packages
}```

#

static string[] GetSearchDirs(SearchFilter searchAssets)
{
    string[] searchDirs;
    switch (searchAssets) {
        case SearchFilter.All:
            searchDirs = new[] {"Assets", "Packages"};
            break;
        case SearchFilter.Assets:
            searchDirs = new[] {"Assets"};
            break;
        case SearchFilter.Packages:
            searchDirs = new[] {"Packages"};
            break;
        default:
            throw new ArgumentOutOfRangeException(nameof(searchAssets), searchAssets, null);
    }

    return searchDirs;
}```

#

I forgot how big it was lol

wispy delta Feb 2, 2019, 6:24 AM

#

That's nice and meaty, but it looks mega handy. So do I just give it a filename and some extra search options and it finds the file?

visual stag Feb 2, 2019, 6:25 AM

#

that's the intention, I've had to change it every few versions so it might need some tweaking

#

and as I said, it'd probably be better as a Try-style

wispy delta Feb 2, 2019, 6:27 AM

#

Does it work with folders alongside the name? Could I doLoadAssetOfType<Mesh> ("BuiltinMeshes/DefaultMesh")? If not, I'd be worried someone else could easily have an asset of the same type and name

visual stag Feb 2, 2019, 6:27 AM

#

HHmmmrm, don't think so, but you could modify it easily

#

I usually just make my asset names more specific

#

like DeformerDefaultMesh or something

#

but either way works

wispy delta Feb 2, 2019, 6:28 AM

#

Yea I guess I could also compensate with specific names. That doesn't seem too bad

#

And it would let people override my assets more easily if they wanted to

visual stag Feb 2, 2019, 6:28 AM

#

I also have a version that is LoadAssetsOfType, but you can figure out how to make it build a list 😛

wispy delta Feb 2, 2019, 6:29 AM

#

Yea this super helpful, thanks

#

I'm look for but don't see a way to add packman dependencies. For instance, I just moved my code into a new project to create a new repo and my asmdef files are missing references to burst and mathematics. Is this possible yet?

visual stag Feb 2, 2019, 6:37 AM

#

you can add dependencies with the package.json file

#

it even has an editor now

#

so modify it in the inspector

#

(might be 2019 only)

wispy delta Feb 2, 2019, 6:38 AM

#

Does that have to be in the project root tho?

visual stag Feb 2, 2019, 6:38 AM

#

In the package root, yes

#

again, other packages are good examples

wispy delta Feb 2, 2019, 6:39 AM

#

Bummer, I was hoping I could create dependencies from within the tool's folder so that I could just drop it in a project without it losing references

visual stag Feb 2, 2019, 6:39 AM

#

basically you want two references, the package.json file which sets up the package dependencies, and the assembly definitions which set up the assembly dependencies

#

it being a package enables all this though?

#

Like, once this is set up you should be able to add the package to any project and it'll set everything up automatically

wispy delta Feb 2, 2019, 6:40 AM

#

I misunderstood, and you were right I should have looked at how burst was setup

wispy delta Feb 2, 2019, 7:22 AM

#

got it working! this is super cool. I'm not really sure how to handle different versions, but I'm guessing that'll be solved automatically once hosted repos are better supported

visual stag Feb 2, 2019, 10:22 AM

#

@bronze mason is the Type for your editor window a bit weird, like generic or something?

bronze mason Feb 2, 2019, 10:23 AM

#

I don't think so

#

It's just a regular editor window

visual stag Feb 2, 2019, 10:24 AM

#

if you Resources.FindObjectsOfTypeAll does it return your window type at all?

bronze mason Feb 2, 2019, 12:21 PM

#

@visual stag it seems like it doesn't

#

Nevermind, I did another thing

visual stag Feb 2, 2019, 12:22 PM

#

hah what?

bronze mason Feb 2, 2019, 12:23 PM

#

Had to check

#

I'm doing T[] windows = Resources.FindObjectsOfTypeAll<T>(); and it seems like it's not finding any

#

(or they're null)

visual stag Feb 2, 2019, 12:24 PM

#

the GetWindow method uses that resources method internally, so if your window isn't being discovered by it then it will create another window

bronze mason Feb 2, 2019, 12:24 PM

#

Ok, good to know

#

It seems like it will mostly create another instance when the window that was just created is not focused

visual stag Feb 2, 2019, 12:25 PM

#

like, immediately created? Or was never focused to begin with?

bronze mason Feb 2, 2019, 12:27 PM

#

If I create the window, remove focus & try to get it again, it usually ignores the current unfocused instance and creates another one

visual stag Feb 2, 2019, 12:27 PM

#

are you just using a MenuItem?

bronze mason Feb 2, 2019, 12:27 PM

#

Not for this one that I'm creating

#

It's more like a popup window

visual stag Feb 2, 2019, 12:35 PM

#

by removing focus I assume you're just getting another window?

#

or, calling Focus on another existing one

#

the only thing I can imagine is that either your window is somehow not registering as loaded, or that you're managing to run the code before it is

#

if the window is being opened from InitializeOnLoad for example, it might be worth using EditorApplication.delayCall just to make sure it's not missing some important thing unity needed to do for some reason

#

as is surprisingly often a thing I need to do

wispy delta Feb 2, 2019, 8:17 PM

#

Is there a way to tell if your code is under the Packages folder? All my code that creates/loads settings and other assets won't work when installed via packman because it does everything relative to the Assets folder

wispy delta Feb 2, 2019, 8:55 PM

#

Although I guess I shouldn't store per project settings/assets in the Packages folder anyways right? Because if I did, any changes to the files would be overriden the next time the package is updated or synced with the source files.

#

I didn't like how TextMeshPro imports default assets and settings into the assets folder, but now I understand why

wispy delta Feb 2, 2019, 10:35 PM

#

One issue I'm running into is how hard a package's file path can be to find.
If you add a package on disk Unity literally just references it (ie: it doesn't get copied over)
If the package is made by Unity, it is put under YourProjectName/Library/PackageCache/name@version.
If the package you add is a hosted repo it get's put under YourProjectName/Library/PackageCache/name@some-commit-hash-here
All-in-all I've been unable to find a way for a custom package to load it's own assets

visual stag Feb 3, 2019, 12:27 AM

#

My solution I posted earlier had the way to do it built-in?

#

And also if you use https://mvi.sh/notes/ I have a note on both AssetDatabase.FindAssets and AssetDatabase.LoadAssetAtPath

#

the one on LoadAssetAtPath is:
If you're trying to load an asset from a Package the relative path is "Packages/com.example.example/...", regardless of the 'real' location of the package files.

#

Per-project settings do need to be instantiated into the Assets directory, you are correct

wispy delta Feb 3, 2019, 5:05 AM

#

Good to hear. Also this website is great, I'd never heard of it in my 5ish years if Unity sleuthing

#

And I'll test this if you havent already, but I wasn't sure if your LoadAssetOfType method would work if the package was referenced on disk since the files arent actually copied under the project directory

visual stag Feb 3, 2019, 5:10 AM

#

If the package is installed the assets are in the database

lucid hedge Feb 3, 2019, 2:30 PM

#

So I have these colorfields

#

📎 unknown.png

#

but I want to adjust the space to them

#

so I created a custom GUIStyle

#

            {

                margin = new RectOffset(0, 0, 2, 2),
            };
            ```

#

but how do I pass this new guistyle into the colorfield?

#

colors[3] = EditorGUILayout.ColorField(GUIContent.none, colors[3], false, false, false, GUILayout.Width(18));

#

so basically how do I override the space between the colorfields

lucid hedge Feb 3, 2019, 3:06 PM

#

same goes for EditorGUILayout.ObjectField

#

how do I style it?

waxen sandal Feb 3, 2019, 3:41 PM

#

You kinda can't

#

You can change the default style

#

Those controls are made up of multiple controls and styles

#

So you can't just have one style that changes it

#

Either make your own, change the default styles, or live with it

lucid hedge Feb 3, 2019, 3:43 PM

#

alright

#

thanks

waxen sandal Feb 3, 2019, 3:43 PM

#

At least, that is as far as I know

lucid hedge Feb 3, 2019, 4:53 PM

#

https://gfycat.com/HarmoniousSpiffyChimpanzee

Gfycat

IwBux3Z3G6

▶ Play video

#

managed to create a nice material editor

#

palette

#

and I can change the margins how I want since it's a custom made style

waxen sandal Feb 3, 2019, 8:16 PM

#

https://i.imgur.com/e9YiX4b.png

Imgur

lucid hedge Feb 3, 2019, 9:46 PM

#

So I know this has something to do with serialization and maybe editorprefs but I'd like to know what's the best way to do this. I have an editor window with fields, but when I close the window and open it up again, the variables reset. How do I save the state the window was closed in?

lucid hedge Feb 3, 2019, 10:19 PM

#

because even if I add

#

[System.Serializable]

#

to my class

#

and [SerializeField] to a private variable

#

it's not saving. When I close the editor window and then open it again, it's reset

river bolt Feb 3, 2019, 10:21 PM

#

so I haven't done what you're trying to do but there is an editor script I use regularly that does

#

https://gist.github.com/Mikilo/b3451047b463c40e5a6474c3602542eb

Gist

Unity Editor Scene Camera FPS Improver

Unity Editor Scene Camera FPS Improver. GitHub Gist: instantly share code, notes, and snippets.

#

looks like you want to call EditorPrefs.Set* in OnDestroy()?

lucid hedge Feb 3, 2019, 10:22 PM

#

I'm gonna check out the script!

#

hmm

#

Editorprefs don't support color fields though right?

river bolt Feb 3, 2019, 10:24 PM

#

no idea, sorry

#

it should as it's just 4 floats and floats are serializable/blittable

lucid hedge Feb 3, 2019, 10:24 PM

#

and also using editor prefs will put the variables in a custom menu under preferences right?

#

I really just have these variables in my editor window

#

📎 unknown.png

#

and they reset to their default values when I close/reopen it

#

Hmm I looked at another editor tool from someone and they don't seem to save the previous state of the variables either

#

I'm just gonna add a preference entry, I know how to do that

#

but not for all variables

#

and @river bolt as you can see, no built in support for color fields

#

📎 unknown.png

#

as you said I can just floats though

wispy delta Feb 3, 2019, 10:59 PM

#

Could you just save and load a scriptable object?

grim monolith Feb 3, 2019, 10:59 PM

#

@lucid hedge Unless they have modified how it works no, you need to create your editor window for the preferences section

lucid hedge Feb 3, 2019, 11:00 PM

#

yeah I could work with a scriptable object I'm pretty sure but it's not worth it for this tool I think

#

just gonna add in some preference entries

#

btw @grim monolith

#

what assets do you have, you're a publisher right?

grim monolith Feb 3, 2019, 11:02 PM

#

Yes, https://assetstore.unity.com/publishers/28547

Rotary Heart - Asset Store

I am a programmer and indie game developer. I started in a company in Puerto Rico called Ai.Robotix Corporation. I currently am programmer lead assistant in Razor Edge Games. My goal is to provide easy to use assets that can help develop any game.Visit my website

lucid hedge Feb 3, 2019, 11:02 PM

#

great, ty

wispy delta Feb 3, 2019, 11:02 PM

#

@lucid hedge those icons are nice. Did you make them or do you have a site you get them from?

lucid hedge Feb 3, 2019, 11:03 PM

#

from flaticon

grim monolith Feb 3, 2019, 11:03 PM

#

np

#

Yeah flaticon has pretty good icons

lucid hedge Feb 3, 2019, 11:03 PM

#

you need to mention the artist though , I just do it in my asset store description but I'm not sure if that's enough

wispy delta Feb 3, 2019, 11:03 PM

#

Ok cool I'll check them out. I'm struggling with making my own

lucid hedge Feb 3, 2019, 11:04 PM

#

Flaticon has some nice icons, definitely for the new 2019 editor theme

#

however I find that these icons go very well with Unity too

#

https://www.fatcow.com/free-icons

3926 Free "Farm-Fresh Web Icons" by FatCow Web Hosting

Free Farm-Fresh web icons set includes both 16 and 32 pixel versions. Images have been saved in PNG format on transparent background for your convenience. Download and enjoy this enormous free icons set designed by FatCow - a leading provider of web hosting for individuals an...

#

Bolt, the visual scripting tool uses those icons for almost everything

wispy delta Feb 3, 2019, 11:05 PM

#

I was actually wondering what icons they used, they look great

lucid hedge Feb 3, 2019, 11:05 PM

#

📎 unknown.png

#

the icons fit in nicely imo

#

looks pretty native

#

surforge is one of my favorite UI's too

#

📎 85d6c4f4-f26e-4133-9364-f9c9daa138b7.png

wispy delta Feb 4, 2019, 9:18 PM

#

@visual stag
Not sure how I didn't realize this, but while we got drag n drop working; adding items to the lists from the custom editor window doesn't work.

The drag n drop code works because it's in the custom editor and we have access to serializedObject. The window doesn't have access to the serializable object used by the custom inspector, so the properties fall out of sync when items are added.

I needed a reference to the serializedObject used by the custom inspector, so I ended up creating a static list in the custom editor that holds serialized objects. The custom editor adds and removes itself from the list in OnEnable/OnDisable. After the window adds items to the lists I run this code:

foreach (var so in DeformableEditor.SerializedObjects)
{
    so.SetIsDifferentCacheDirty ();
    so.Update ();
}

I'm curious of your thoughts on my approach. Does this seem like this best way to solve the problem, or is there a more elegant solution?

visual stag Feb 4, 2019, 10:34 PM

#

It should just apply after charges and update if dirty always

#

There should be no need to access other scriptable objects

#

Having applied, the start of the next gui loop should have an update if dirty and it'll just refresh from the target object

green shoal Feb 4, 2019, 10:37 PM

#

hey, does someone know if there is a way to limit how much listeners can be added to an event in the inspector? I struggled just to add the event to inspector, now I'm really lost on what to do

visual stag Feb 4, 2019, 10:43 PM

#

A UnityEvent? You could just trim it in OnValidate

lucid hedge Feb 4, 2019, 10:43 PM

#

lolz

#

ExportPalette();

#

oops

#

📎 BD55BE64-B274-4191-8A14-2A1C187F67B2.png.jpg

#

so ExportPalette creates a scriptableobject

#

I didn't put it in the brackets haha

#

so it was in OnGUI 😮

#

all those new scriptable objects :p

#

Unity crashed

visual stag Feb 4, 2019, 10:55 PM

#

pretty expected to be honest

lucid hedge Feb 4, 2019, 11:01 PM

#

it was a typo

wispy delta Feb 4, 2019, 11:04 PM

#

@visual stag Are you talking about the custom editor window? There's nothing for it to "apply." It just loops through Selection.gameObjects and adds the newly created Deformer to any Deformables it finds on those selected game objects. It is running into the issue where the Deformable inspector's serializedObject's properties don't match the actual values in the class and it isn't marked as dirty. We solved this with the drag n drop code by calling serializedObject.SetIsDifferentCacheDirty (), however in the case of the custom editor window, it doesn't have access to the serializedObject so it can't just call serializedObject.SetIsDifferentCacheDirty () after making changes to the list.

#

Apologies if I'm misunderstanding something

visual stag Feb 4, 2019, 11:05 PM

#

I'll take a look at your project again and see if I can get my head around it, sorry. It really should "just work" 😛

#

though first Rider shall update

lucid hedge Feb 4, 2019, 11:52 PM

#

Managed to create a nice palette system for my prefab painter 😃 First time using scriptable objects

#

https://gfycat.com/WildSmartCutworm

Gfycat

ulh37tH8uv

▶ Play video

visual stag Feb 4, 2019, 11:59 PM

#

Use colours much closer to white for buttons and they'll look a lot nicer!

#

I'm pleased that it all works though, custom editors are the best

lucid hedge Feb 5, 2019, 12:00 AM

#

oh yeah definitely!

grim monolith Feb 5, 2019, 12:00 AM

#

Yeah, using scriptable objects really makes stuff easier

lucid hedge Feb 5, 2019, 12:00 AM

#

this is an old editor tool that I'm revisiting

#

I try to never use colored buttons now

wispy delta Feb 5, 2019, 1:41 AM

#

is there a reason all the gui scopes are classes, but the disabled scope has a class and struct version?

#

EditorGUI.DisabledGroupScope is a class
EditorGUI.DisabledScope is a struct

visual stag Feb 5, 2019, 1:44 AM

#

no idea, I'd have thought they all should have been structs but who knows, there's some inheritance in DisabledGroupScope that might enable better debugging if not disposed

#

the docs mention that DisabledScope is preferrable

#

I also like that the DisabledGroupScope example doesn't even use it lol

wispy delta Feb 5, 2019, 2:20 AM

#

haha that's great

wispy delta Feb 5, 2019, 3:42 AM

#

got the deformable's scene gui to draw transform tool handles for the selected deformer as well

📎 2019-02-04_21-40-30.mp4

wispy delta Feb 5, 2019, 4:09 AM

#

handy lil function will let you draw your own transform tool and lets you change the handle scale (helpfulfor preventing your custom transform handles from being hidden behind unity handles)

public static void TransformToolHandle (Transform target, float scale = 1f)
{
    var matrix = Matrix4x4.Scale (Vector3.one * scale);

    var newPosition = matrix.inverse.MultiplyPoint3x4 (target.position);
    var newRotation = target.rotation;
    var newScale = target.localScale;

    using (new Handles.DrawingScope (matrix))
    using (var check = new EditorGUI.ChangeCheckScope ())
    {
        switch (Tools.current)
        {
            case Tool.Move:
                if (Tools.pivotRotation == PivotRotation.Local)
                    newPosition = Handles.PositionHandle (matrix.inverse.MultiplyPoint3x4 (target.position), target.rotation);
                else
                    newPosition = Handles.PositionHandle (matrix.inverse.MultiplyPoint3x4 (target.position), Quaternion.identity);
                break;
            // rotation handle doesn't differentiate between local/global pivot mode b/c you'd have to persist the last rotation used 
            // in global mode and reset it whenever the object was reselected or the pivot mode changed.
            case Tool.Rotate:
                newRotation = Handles.RotationHandle(target.rotation, matrix.inverse.MultiplyPoint3x4 (target.position));
                break;
            case Tool.Scale:
                newScale = Handles.ScaleHandle (target.localScale, matrix.inverse.MultiplyPoint3x4 (target.position), target.rotation, HandleUtility.GetHandleSize (target.position));
                break;
        }
        if (check.changed)
        {
            Undo.RecordObject (target, "Changed Transform");
            target.SetPositionAndRotation (matrix.MultiplyPoint3x4 (newPosition), newRotation);
            target.localScale = newScale;
        }
    }
}

lucid hedge Feb 5, 2019, 10:32 AM

#

I'd like to display an object field on the blank space on that toolbar

#

📎 unknown.png

#

but EditorGUILayout.ObjectField does not take a GUIStyle parameter.. so I can't pass some toolbar style onto it

#

what can I do?

#

📎 unknown.png

#

this doesn't look too great

lucid hedge Feb 5, 2019, 10:58 AM

#

replaced it with an OpenFilePanel

#

will do the trick

gloomy chasm Feb 5, 2019, 4:31 PM

#

I just updated to 2018.3.4 from 2018.0f2. And unless I am dumb, is the bug where a prefab will not save changes of fields from a custom inspector still there?

wispy delta Feb 5, 2019, 5:46 PM

#

I'm on 2018.3.4 with tons of custom inspectors and they're all saving correctly @gloomy chasm

zealous ice Feb 5, 2019, 5:46 PM

#

@gloomy chasm // Have you marked it as dirty? That might be a reason

wispy delta Feb 5, 2019, 5:47 PM

#

If you're using property fields, make sure you call serializedObject.ApplyModifiedProperties ()

#

when you finish modifying properties

zealous ice Feb 5, 2019, 5:48 PM

#

And if you're not using property fields, make sure to mark objects as dirty

gloomy chasm Feb 5, 2019, 7:08 PM

#

@zealous ice oh, no. That is what it is a bet...
Is there an example of how to use it? I am having a bit of trouble finding one atm.

zealous ice Feb 5, 2019, 7:10 PM

#

Maybe try doing something like GameObject.MarkAsDirty

#

https://docs.unity3d.com/ScriptReference/EditorUtility.SetDirty.html

wispy delta Feb 5, 2019, 8:36 PM

#

@gloomy chasm are you using property fields or are you modifying the targets array directly

gloomy chasm Feb 5, 2019, 8:54 PM

#

@wispy delta what do you mean?

wispy delta Feb 5, 2019, 9:00 PM

#

can you show me some of your editor code?

gloomy chasm Feb 5, 2019, 9:29 PM

#

Yeah, sorry for the delay. @wispy delta

public override void OnInspectorGUI()
    {
         base.OnInspectorGUI();

        if (saveObject.IsPrefab)
        {
            GUILayout.BeginHorizontal();
            EditorGUILayout.LabelField("Prefab Name", saveObject.PrefabName);
            if (GUILayout.Button("Update", GUILayout.Width(50)))
            {
                saveObject.PrefabName = saveObject.name; 
            }           
            GUILayout.EndHorizontal();
        }
    ```

wispy delta Feb 5, 2019, 9:30 PM

#

where/how are you assigning saveObject

gloomy chasm Feb 5, 2019, 9:30 PM

#

SaveObject saveObject;

    private void OnEnable()
    {
        saveObject = target as SaveObject;
    }

wispy delta Feb 5, 2019, 9:32 PM

#

Ok so you aren't using property fields - you are modifying the target directly. That's totally fine, but do be aware that it will take some extra work to get your code to support editing multiple objects at once and you'll have to mark the object as dirty when you make changes.

gloomy chasm Feb 5, 2019, 9:33 PM

#

How is it done most of the time? That is how all the examples on the docs are done.

wispy delta Feb 5, 2019, 9:36 PM

#

A lot of the docs on editor code is really bad. Before i type up an example, is SaveObject.PrefabName a field or property?

gloomy chasm Feb 5, 2019, 9:37 PM

#

property

wispy delta Feb 5, 2019, 9:51 PM

#

To do custom editors I'd use PropertyFields. They work directly off of the serialized data and handle multi-object selection and undoing without you having to do anything.

Here's a simple example. You could write it more cleanly to cache properties, but it gets the point across.

public override void OnInspectorGUI ()
{
    // serializedObject is a class built in to custom editors. They hold all the serialized properties.
    // Whenever you start changing properties you wanna make sure the serializedObject is up-to-date with
    // the actual target's values, so call this method.

     serializedObject.UpdateIfRequiredOrScript ();

    // Now that the serializedObject is in-sync you can draw safely draw properties

    // We can call FindProperty so search the serializedObject for a SerializedProperty with some name.
    // Remember that while it is called a SerializedProperty, it (ironically) cannot be a property and must be a 
    // field b/c Unity doesn't serialized properties. I'm assuming your backing field is called "prefabName" in this 
    // example.

    var prefabName = serializedObject.FindProperty ("prefabName");

    // Now that we've got a property, we can draw it with PropertyField(). This draws controls for the property 
    // as if the field was draw by the default editor.

    EditorGUILayout.PropertyField (prefabName);
    
    // Once you are done modifying properties, you need to make sure to apply the modified property 
    // back to the actual targets. It's as simple as calling this method:

    serializedObject.ApplyModifiedProperties ();
}

gloomy chasm Feb 5, 2019, 9:55 PM

#

Oh, I see. Thank you so much @wispy delta!
I do have a question though. How would I go about editing a property from within the script? Or if I didn't want to use the default drawer for a property?

wispy delta Feb 5, 2019, 9:57 PM

#

"editing a property from within the script" do you mean through the editor or from the actual target script?

gloomy chasm Feb 5, 2019, 9:58 PM

#

like in the code I pasted where I am setting the PrefabName property to be the name of the GameObject.

wispy delta Feb 5, 2019, 10:00 PM

#

SerializedProperty holds properties for all of it's supported value types so you could just do someProperty.stringValue = someOtherString;

#

As for overriding how it *functions you can use the default property drawer and then modify the value like so

/// <summary>
/// Draws a property field for a float and prevents it from going below min.
/// </summary>
public static void MinField (SerializedProperty value, float min)
{
    EditorGUILayout.PropertyField (value);
    value.floatValue = Mathf.Max (value.floatValue, min);
}

Or you can create a custom property drawer https://docs.unity3d.com/ScriptReference/PropertyDrawer.html

#

Some builtin Editor GUI methods support property fields, like EditorGUILayout.Slider

#

There are downsides to using serialized properties tho. As you can see, you are modifying fields only. This is frustrating when you have a backing field and a public property with a custom get/set. You'll have to mirror the property functionality with your editor code because you cannot modify the field via the public property.

gloomy chasm Feb 5, 2019, 10:14 PM

#

Field seems to need to have [SerializeField]. Is that right?

wispy delta Feb 5, 2019, 10:15 PM

#

It needs to be serialized yes.

#

If you don't want it drawn by the default inspector you can add [HideInInspector] to the field

gloomy chasm Feb 5, 2019, 10:16 PM

#

Okay, yeah. Thank you so much for your help!

wispy delta Feb 5, 2019, 10:17 PM

#

no problem 👍

green shoal Feb 6, 2019, 4:02 AM

#

I've been trying to go around having a slot for choosing a method in another script but couldn't, is there a way to do that? I managed to get the object to my script, I need to find the methods it can run and make them selectable, how can I do that? I can't find anything like that on the documentation

wispy delta Feb 6, 2019, 4:43 AM

#

UnityEvent?

green shoal Feb 6, 2019, 4:45 AM

#

so no other way around that EditorGUI.PropertyField ?

#

I was trying to use a delegate instead, I made the Object selecting box, but couldn't find a way to get it's scripts/components, there is only a method for gameObjects, wich I can't use as I'll be getting scriptable object's methods, if all goes wrong I'll put a huge warning not to select more than one method, but I really did not want to.

wispy delta Feb 6, 2019, 4:52 AM

#

you could check out the source for the unity event drawer and try and make your own https://github.com/Unity-Technologies/UnityCsReference/blob/54dd67f09e090b1ad5ba1f55886f327106406b0c/Editor/Mono/Inspector/UnityEventDrawer.cs

green shoal Feb 6, 2019, 4:53 AM

#

Oh, I didn't know that you could find those, thanks a lot, I'll try it

wispy delta Feb 6, 2019, 4:54 AM

#

yea all the c# code is on unity's github for reference. a lot of it is just bindings to c++ code, but it's still super helpful

green shoal Feb 6, 2019, 5:20 AM

#

I looked into it, looks like this is the class that has easier code to do that:
https://github.com/Unity-Technologies/UnityCsReference/blob/73f36bfe71b68d241a6802e0396dc6d6822cb520/Editor/Mono/GUI/ReorderableList.cs

GitHub

Unity-Technologies/UnityCsReference

Unity C# reference source code. Contribute to Unity-Technologies/UnityCsReference development by creating an account on GitHub.

#

I'll try it later, but posted the way I think it needs to go in case someone find it useful. Thanks a lot, you reaaaally helped me there

wispy delta Feb 6, 2019, 5:24 AM

#

glad i could help haha but I'm not sure what a reorderable list has to do with selecting a method on an object?

visual stag Feb 6, 2019, 8:45 AM

#

@edgy aspen is your custom editor for a monobehaviour?

#

Surely you want to be using the monobehaviour to store data

edgy aspen Feb 6, 2019, 8:46 AM

#

yes

visual stag Feb 6, 2019, 8:46 AM

#

what kind of data is resetting? Do you have editor-only data that you're configuring?

edgy aspen Feb 6, 2019, 8:47 AM

#

I have dropdowns

#

a couple of dropdowns and I use them for generating child objects according to these information

#

(also, I want to show a list of child objects in a list on the editor, how can I do this?)

visual stag Feb 6, 2019, 8:48 AM

#

get your target object's transform, iterate through the children in the GUI and show them in a GUI.enabled = false; ObjectField

#

if your information is completely irrelevant to the monobehaviour's state you could have a ScriptableObject settings asset, or use EditorPrefs, or statically keep some data on hand

#

each has downsides and upsides

#

you can also subscribe to EditorApplication.hierarchyChanged to only update the children list from earlier when the hierarchy changes

edgy aspen Feb 6, 2019, 8:54 AM

#

the dropdown change is irrevelant to the children 😄 I just asked another question

visual stag Feb 6, 2019, 8:54 AM

#

yeah, I'm interleaving two answers 😆

edgy aspen Feb 6, 2019, 8:54 AM

#

lol, thanks a lot. I'm digging the editor scripting these days and it's kinda fun, but lots of unknowns to me

visual stag Feb 6, 2019, 8:55 AM

#

s'all good, very happy to see more editors and less terrible UI/UX

edgy aspen Feb 6, 2019, 8:55 AM

#

👍

wispy delta Feb 6, 2019, 8:56 AM

#

any idea why foldouts react visually to clicks all over but don't actually toggle unless you click right on the carrot?

📎 2019-02-06_02-55-05.mp4

visual stag Feb 6, 2019, 8:56 AM

#

probably because my implementation sucks LUL

wispy delta Feb 6, 2019, 8:56 AM

#

this is my implementation, default foldout haha

visual stag Feb 6, 2019, 8:57 AM

#

Oh yeaaaaaah

wispy delta Feb 6, 2019, 8:57 AM

#

just with a changed style and a rect drawn behind

public static bool Foldout (bool foldout, string text)
{
    var toggleRect = GUILayoutUtility.GetRect (1, EditorGUIUtility.singleLineHeight);
    EditorGUI.DrawRect (toggleRect, DeformEditorGUIUtility.EditorHighlightColor);
    EditorGUI.LabelField (toggleRect, text, EditorStyles.centeredGreyMiniLabel);
    using (new EditorGUI.IndentLevelScope ())
        return EditorGUI.Foldout (toggleRect, foldout, GUIContent.none);
}

visual stag Feb 6, 2019, 8:58 AM

#

is this on your latest commit?

#

I have had trouble with indentation and some editor controls before, it could be that perhaps

wispy delta Feb 6, 2019, 8:59 AM

#

no, and trust me its nothing you did it's happens with the default dropdown

📎 2019-02-06_02-58-40.mp4

visual stag Feb 6, 2019, 8:59 AM

#

I'm also not sure if foldouts do actually work if you don't click the foldout itself

#

is there any case where they do with any other part of the UI?

#

either way, they're one of the most fiddly editor controls you can work with to be honest

wispy delta Feb 6, 2019, 9:01 AM

#

yea i just made a default int array and it worked normally

visual stag Feb 6, 2019, 9:02 AM

#

ah yeah it does, hmm

#

there is a toggleOnLabelClick parameter

#

pass true and the foldout will work 👍

wispy delta Feb 6, 2019, 9:05 AM

#

perfect!

#

I'm going through and trying to recreate the stuff you did because I was trying to fix a couple things and got pretty lost. If i can recreate it from scratch I'll know for sure I understand how you did it

visual stag Feb 6, 2019, 9:08 AM

#

A lot of my implementations there come from the foldout implementation you see in places like the PostProcessLayer

#

@edgy aspen If you're using data from the MonoBehaviour either use SerializedProperty and SerializedObject functions (+SerializedObject.ApplyModifiedProperties) or Undo.RecordObject, otherwise the data will reset. Otherwise the previously mentioned options are the way to go

#

Also @wispy delta, there is a SerializedProperty.isExpanded field you could use to serialize the expanded state of some of these properties if relevant (just something to keep in mind)

wispy delta Feb 6, 2019, 9:16 AM

#

Cool I'll check that out

#

just realized im gonna get to enjoy buying unity pro for a month just so i can test all my custom editors with the dark skin. i wish they had a feature where you could turn on dark skin but it wouldn't let you interact with anything or something.

#

some sort of developer preview mode

#

I've been avoiding custom controls as much has possible. no custom coloring anywhere

visual stag Feb 6, 2019, 9:29 AM

#

I imagine a time where UIElement rules the world and we can have magenta and sea green editors

wispy delta Feb 6, 2019, 9:30 AM

#

I haven't messed around with it yet, would you say its the future of editor scripting?

#

I feel like anything is the future compared to imgui lel

visual stag Feb 6, 2019, 9:30 AM

#

It's the future of a lot of it, yes

#

I personally really enjoy the ease of IMGUI

#

but UIElement is much more flexible and powerful

#

just you get to deal with CSS's terrible pain points

#

with a unique Unity twist

wispy delta Feb 6, 2019, 9:32 AM

#

Yea I was gonna say it'll probably be out of the frying pan and into the fire haha. I'm just now starting to get a handle of the imgui quirks, but I am sooo bad at html/css

visual stag Feb 6, 2019, 9:32 AM

#

I'm personally going to create all my editors from here out with UIElement, if you're aiming 2019.1 and above it's the thing to do

#

Before then, don't do eeeet

wispy delta Feb 6, 2019, 9:34 AM

#

Idk when Unity will even let me post my asset on the store, it's completely dependent on the burst, mathematics and job system all of which are in "early access." Do they even allow packages with dependencies on experimental packages?

#

If I can't even put it on the asset store till 2019.x I might as well start rewriting everything for UIElements rn

visual stag Feb 6, 2019, 9:35 AM

#

no idea 🤷 I cannot wait until it has proper package support, it should be happening any time now if it hasn't already (did I miss this?)

#

I do wonder when it's worth switching from IMGUI if you're not doing anything wild

#

if IMGUI works and you've got it implemented, why change?

wispy delta Feb 6, 2019, 9:37 AM

#

yea i'd imagine elements requires a bit more setup initially

#

and yea rewriting something that already works to be "cool" isn't the best reason

#

i'd be the unity posterboy tho - using literally all of unity's new tech in a single asset

#

just need to figure out how to implement ml agents into mesh deformation 🤔

visual stag Feb 6, 2019, 9:38 AM

#

missing ECS, sorry not worth the time 😛

wispy delta Feb 6, 2019, 9:38 AM

#

haha

#

you're right tho, that's their big boy

visual stag Feb 6, 2019, 9:39 AM

#

what is life (without preview packages)?

wispy delta Feb 6, 2019, 9:40 AM

#

just waiting for them to release a new mesh class or at least change the current mesh class so I can send native data straight to it without having to copy to a "middleman" managed array first

visual stag Feb 6, 2019, 9:42 AM

#

what does all the GetNativeVertexBufferPtr stuff do

#

is that only native plugins

wispy delta Feb 6, 2019, 9:49 AM

#

I asked lotte about it on twitter and she said, "It’s something I never looked in to- in theory we should be able to wrap the native pointer- but what’s actually in it is dependant on mesh setup and on graphics api- it’s hella complex and probably not worth it xD"

visual stag Feb 6, 2019, 9:50 AM

#

Well, if it's super relevant to you you could put in the effort to wrap it and I assume get a speed boost. But it does seem like a huge bloody investment that'd be lovely to just have be a simple function

wispy delta Feb 6, 2019, 9:52 AM

#

yea. and tbh i am not skilled enough to mess with that. i understand pointers and memory, but not enough to use them without oversight. i crashed unity so many times just trying to memcpy from a managed vector3 array to a native float3 array

visual stag Feb 6, 2019, 9:53 AM

#

perhaps a graphics nutjob will find your thing and make a PR 🤷

wispy delta Feb 6, 2019, 9:53 AM

#

here's hoping, probably not gonna be making this open source unless it doesn't sell well though

lucid hedge Feb 6, 2019, 6:18 PM

#

@wispy delta you fixed the issues with foldouts?

#

because if not I have some code for ya

#

📎 unknown.png

wispy delta Feb 6, 2019, 6:25 PM

#

@lucid hedge I got it working, but send it my way anyways I wanna see how you did it

lucid hedge Feb 6, 2019, 6:27 PM

#

            generalFold = BeginFold("General", generalFold);
            if (generalFold)
            {
                EditorGUILayout.PropertyField(ladderMaterialProp, new GUIContent("Material"));
                EditorGUILayout.PropertyField(widthProp, new GUIContent("Width"));
                EditorGUILayout.PropertyField(heightProp, new GUIContent("Height"));
            }
            EndFold();```

#

is what I do for every section

#

        {
            EditorGUI.indentLevel++;
            EditorGUILayout.BeginVertical(boxStyle);
            GUILayout.Space(3);
            foldState = EditorGUI.Foldout(EditorGUILayout.GetControlRect(),
                foldState, foldName, true, foldoutStyle);
            if (foldState) GUILayout.Space(3);
            return foldState;
        }```

#

        {
            GUILayout.Space(3);
            EditorGUILayout.EndVertical();
            GUILayout.Space(0);
            EditorGUI.indentLevel--;
        }```

#

this for the foldoutstyle

#


        static GUIStyle foldoutStyle
        {
            get
            {
                if (_foldoutStyle == null)
                {
                    _foldoutStyle = new GUIStyle(EditorStyles.foldout);
                    _foldoutStyle.font = EditorStyles.boldFont;
                }

                return _foldoutStyle;
            }
        }```

#

and the boxstyle is Editorstyles.helpBox

wispy delta Feb 6, 2019, 7:23 PM

#

nice! I went ahead and converted it to a scope so you don't have to call EndFold()

public class FoldoutContainerScope : System.IDisposable
{
    private static GUIStyle containerStyle;
    private static GUIStyle labelStyle;

    static FoldoutContainerScope ()
    {
        containerStyle = new GUIStyle (containerStyle);
        labelStyle = new GUIStyle (EditorStyles.foldout);
        labelStyle.font = EditorStyles.boldFont;
    }

    public bool isOpen;
    private readonly string text;

    public FoldoutContainerScope (ref bool isOpen, string text)
    {
        this.isOpen = isOpen;
        this.text = text;
        EditorGUI.indentLevel++;
        EditorGUILayout.BeginVertical (EditorStyles.helpBox);
        GUILayout.Space (3);
        isOpen = EditorGUI.Foldout (EditorGUILayout.GetControlRect (), isOpen, text, true, labelStyle);
    }

    public void Dispose ()
    {
        GUILayout.Space (3);
        EditorGUILayout.EndVertical ();
        EditorGUI.indentLevel--;
    }
}

Now you can just do this:

using (var foldout = new FoldoutContainerScope (ref showFoldout, "Foldout Name"))
{
    if (foldout.isOpen)
        // draw gui here
}

grim monolith Feb 6, 2019, 7:45 PM

#

The only yhing I would add is toggleOnLabelClick to true. IMO it makes the use of toggles more user friendly

wispy delta Feb 6, 2019, 7:46 PM

#

pretty sure it is set to true already

#

any thoughts on this debug dropdown. not sure which style i should go with (or if either looks good enough)

#

📎 unknown.png

#

📎 unknown.png

wispy delta Feb 6, 2019, 8:30 PM

#

📎 unknown.png

grim monolith Feb 6, 2019, 8:38 PM

#

Aaa yeah my bad, the code on the dicord app is really hard to follow

wispy delta Feb 6, 2019, 9:39 PM

#

No worries. I agree it's had to read, especially when word wrap kicks in

wispy delta Feb 6, 2019, 11:40 PM

#

is there a way to create an editor layout inside a rect?
I'm making a custom property drawer and instead of manually splitting the rect into smaller rects for each field I'd like to use EditorGUILayout methods

visual stag Feb 6, 2019, 11:41 PM

#

https://docs.unity3d.com/ScriptReference/GUILayout.AreaScope.html

wispy delta Feb 6, 2019, 11:44 PM

#

I tried using that, but I couldn't get it to work

public override void OnGUI (Rect rect, SerializedProperty property, GUIContent label)
{
    using (new EditorGUI.PropertyScope (rect, label, property))
    {
        var activeProperty = property.FindPropertyRelative ("active");
        var componentProperty = property.FindPropertyRelative ("component");

        using (new GUILayout.AreaScope (rect))
        {
            using (new GUILayout.HorizontalScope ())
            {
                if (componentProperty.objectReferenceValue != null)
                    activeProperty.boolValue = EditorGUILayout.Toggle (activeProperty.boolValue, Content.Toggle);
                EditorGUILayout.ObjectField (componentProperty, GUIContent.none);
            }
        }
    }
}

#

I thought GUILayout and EditorGUILayout might not mix, but I use GUILayout.Button along with EditorGUILayouts all the time

visual stag Feb 6, 2019, 11:46 PM

#

can you put the brackets for the area scope there, it's weird not seeing them

wispy delta Feb 6, 2019, 11:47 PM

#

yea haha, just edited it

#

for context, this is what it looks like

📎 unknown.png

#

no errors, i just don't see any gui getting drawn

visual stag Feb 6, 2019, 11:48 PM

#

well, then the question is where is rect

#

if you draw a Rect where rect is does it draw in that place?

wispy delta Feb 6, 2019, 11:50 PM

#

yea

#

📎 unknown.png

visual stag Feb 6, 2019, 11:50 PM

#

can you use the GUIViewDebuggerWindow to figure out were stuff is?

wispy delta Feb 6, 2019, 11:52 PM

#

do you have that snippet handy that creates the window, i cant find it

visual stag Feb 6, 2019, 11:52 PM

#

((EditorWindow)Type.GetType("UnityEditor.GUIViewDebuggerWindow,UnityEditor"))``` etc

#

I've had issues with Areas a lot, but I never remember what fixes the issues or whether i just end up using rects 😛

#

and drawing GUILayout inside of a ReorderableList is one of the ones that I've had the most difficulty with in the past

wispy delta Feb 6, 2019, 11:58 PM

#

weird it doesn't look like its being drawn

📎 2019-02-06_17-58-04.mp4

visual stag Feb 6, 2019, 11:58 PM

#

yeah, I think I've had this issue and I've just used rects

wispy delta Feb 6, 2019, 11:59 PM

#

ah well nbd. i'd just never used areas before so i wanted to make sure i was using them correctly

visual stag Feb 6, 2019, 11:59 PM

#

yeah you are, it's just I think reorderable lists do not support layout for specific reasons

wispy delta Feb 7, 2019, 12:00 AM

#

wonder if its something to do with rects being dragged around. idk how a layout could handle that

#

but an error would have been nice

visual stag Feb 7, 2019, 12:00 AM

#

I think it may be due to the inability to nest GUILayout.BeginArea

#

and the ReorderableList class uses it already

wispy delta Feb 7, 2019, 12:01 AM

#

gotcha

visual stag Feb 7, 2019, 12:05 AM

#

Hm, it seems it doesn't, but I have definitely had this issue and there are lots of people saying they've reported bugs and giving various reasons. Either way, consider ReorderableList not compatible ):

wispy delta Feb 7, 2019, 12:58 AM

#

@visual stag what are your thoughts on Editor.CreateCachedEditor()? I'm calling the method in the drawElementCallback if the current element's index == the list's selected index. Is that an ok way to use it? It seems to be working well, but I wanna make sure I'm not leaking editors like crazy or something.

#

creating the editor everytime it draws solves all of the bugs i was running into earlier (from what i can tell)

list.drawElementCallback += (Rect rect, int index, bool isActive, bool isFocused) =>
{
    var elementProperty = list.serializedProperty.GetArrayElementAtIndex (index);
    EditorGUI.PropertyField (rect, elementProperty);

    // get the current element's component property
    var componentProperty = elementProperty.FindPropertyRelative ("component");
    // and the property's object reference
    var component = componentProperty.objectReferenceValue;
    // if the current element is selected
    if (index == list.index && component != null)
    {
        // create it's editor and draw it
        Editor.CreateCachedEditor (component, null, ref selectedComponentEditor);
        selectedComponentEditor.OnInspectorGUI ();
    }
    else
        UnityEngine.Object.DestroyImmediate (selectedComponentEditor, true);
};

visual stag Feb 7, 2019, 2:01 AM

#

it's great, I should have used it and thought about it, but I got hung up on something else 👍

#

you still have to ensure you clean up when disposing of the editor though

wispy delta Feb 7, 2019, 2:06 AM

#

ok cool. i wasn't doing that so i'll make sure to make the list editor disposable

gray burrow Feb 7, 2019, 2:18 PM

#

Anyone know if it's possible to inject SetPass data into the profiler?

#

Seems like unity doesn't catch it from the graphics API so it's just added in managed somewhere

#

I have a native rendering plugin which is showing as having 0 setpass calls so I need to flag them for the user

green shoal Feb 7, 2019, 5:57 PM

#

I FINALLY GOT IT

📎 unknown.png

#

damn, now it is just missing the parameters

waxen sandal Feb 7, 2019, 5:59 PM

#

Oh my git

green shoal Feb 7, 2019, 6:09 PM

#

I'm having issues with getting the components from the Object if it is not a monoScript, the way around it was to instantiate get all the reference needed and then destroy the object, I'll try to find a better solution

wispy delta Feb 7, 2019, 7:53 PM

#

@green shoal if you're trying to get all the methods of a type in the editor, use reflection

green shoal Feb 7, 2019, 7:56 PM

#

I'm using, I'm having trouble with getting anything from a Object, I tried loading it from the assetmanager to see if it was easier, but didn't get anywhere.
For now I'm at least trying to make it work with monoScripts so I have something solid, but the parameters are giving me another headache, I should've started with inspectors before than when I really needed it

#

got the parameters, I hardcoded the seven types I need (float, bool, int, string, vector3, vector2, audioClip), and got some not so good dependencies on the original class, but it works for what I need, not the best but I'm reaaaally happy that I finally have something

📎 unknown.png

wispy delta Feb 7, 2019, 8:17 PM

#

not sure if this solves what you're trying to do, but i made an example on dotnetfiddle for how to get all the methods of a type https://dotnetfiddle.net/#&togetherjs=kI2qw5ojBc

#

The example prints the names of all the methods in the ExampleObject class to the console @green shoal

#

not sure why the link was trying to create a session or whatever, never used this site before

green shoal Feb 7, 2019, 8:23 PM

#

Im using this, the BindingFlags.DeclaredOnly limits to whatever you used in your class so no inherited methods.
I sent the code but the message didn't go, I don't use discord so I have no idea of what happened

📎 unknown.png

#

the problem is here, I need this to get the reference:
functionCaller.objectReferenceValue = (Object)EditorGUILayout.ObjectField("Function Location", functionCaller.objectReferenceValue, typeof(Object), true);

#

but, Object can't give you its components

#

I was trying to make it a gameObject but by doing so it send the gameObject to the scene

wispy delta Feb 7, 2019, 8:26 PM

#

where are you getting the object reference from? what is the functionLocation's type?

#

oh i see, it's just an object field

#

well make it's required type GameObject and then you can get all of it's components and get all of the methods

green shoal Feb 7, 2019, 8:29 PM

#

yeah, I figured I would end up needing to do so, I was reluctant bc I'm using a lot of scriptable objects in my project so I can make my team write all the dialogs and assign the npc's sprites

wispy delta Feb 7, 2019, 8:30 PM

#

Well you could still leave it as an Object and just check if (thing is GameObject || thing is ScriptableObject)

#

There's probably a better way, but that's all that's coming to mind right now

#

if it's a scriptable object, you can get the methods directly off of the type, otherwise cast it to a GameObject and get all the components and get each component's methods

green shoal Feb 7, 2019, 8:34 PM

#

I'll fix everything up first and then will do that, I'm getting a lot of reference errors because I'm not used to coding inspector. If I check for Objects, MonoScripts and ScriptableObjects it will be fine I think

green shoal Feb 7, 2019, 10:25 PM

#

is there a way to make a textField like when you don't make a custom editor and put [TextArea] abova a serialized string?

wispy delta Feb 7, 2019, 10:53 PM

#

https://docs.unity3d.com/ScriptReference/EditorGUILayout.TextArea.html

green shoal Feb 7, 2019, 11:41 PM

#

thought for some reason it was some display only, like label field

wispy delta Feb 8, 2019, 12:37 AM

#

Is there a way to get all of these buttons in this horizontal layout to be flush to one another? as the layout expands and contracts they'll randomly have 1px of spacing between neighbors

📎 2019-02-07_18-35-41.mp4

visual stag Feb 8, 2019, 12:48 AM

#

use a GUILayout.Toolbar perhaps

#

might be able to kinda hack the usage to function like a button

wispy delta Feb 8, 2019, 12:56 AM

#

That'll be my backup plan. The reason I don't wanna use it is because it either does the big buttons, or you pass it a single style that it uses for all the buttons, so I couldn't have the smooth corners on the outer buttons.

visual stag Feb 8, 2019, 12:59 AM

#

if you pass in EditorStyles.miniButton does it not?

#

I have seen usage of something like new GUIStyle("LargeButton") have the curved outer buttons, so I'm fairly sure it's possible to pass alternate styles that perform in that way

wispy delta Feb 8, 2019, 1:04 AM

#

Ah you're right it does work. Idk how it knows to use miniButtonLeft and miniButtonRight just from me passing it miniButton as a style.

visual stag Feb 8, 2019, 1:05 AM

#

    midStyle = (GUI.skin.FindStyle(name + mid) ?? style);
    firstStyle = (GUI.skin.FindStyle(name + first) ?? midStyle);
    lastStyle = (GUI.skin.FindStyle(name + last) ?? midStyle);

is how it does it

wispy delta Feb 8, 2019, 1:05 AM

#

haha very nice job unity

#

Only annoying thing is it doesn't reserve space for each button as well. Not sure why, I'm not using any GUILayoutOptions *in either version

📎 2019-02-07_19-04-43.mp4

visual stag Feb 8, 2019, 1:06 AM

#

maybe it just treats them all the same size if a toolbar

#

there is a GUI.ToolbarButtonSize parameter

wispy delta Feb 8, 2019, 1:11 AM

#

kinda better? it doesn't stretch to fill the layout anymore tho. i tried adding GUILayout.ExpandWidth (true) but that didn't do anything

📎 2019-02-07_19-09-46.mp4

visual stag Feb 8, 2019, 1:11 AM

#

Unity you can never win

wispy delta Feb 8, 2019, 1:11 AM

#

haha yea. i'll look at the cs reference and see if i can make my own version

visual stag Feb 8, 2019, 1:13 AM

#

oh great, FitToContents seems to do no layout distribution

ashen oasis Feb 8, 2019, 1:14 AM

#

So this was something I posted in the Unity slack earlier (before I knew about the Discord). I suspect the Discord has a much higher usage base, so curious if any of you know the proper way to do this:

So when I have code like this:

           ```foreach(EnemyHierarcyPiece piece in SelectedArmorConfig.HierarchyPieceList)
           {
               piece.GraphPositionRect = GUI.Window(piece.HierarchyID, piece.GraphPositionRect, WindowFunction, "Box1");
           }```

How do I detect which is the currently selected window? I can see that selecting the window highlights it visually, but not finding a way to detect which window is visually highlighted....

Seems like the only real way is to watch for mouse input up then store the selected window..
if ((Event.current.button == 0) && (Event.current.type == EventType.MouseUp)) SetSelectedNode(windowID);

wispy delta Feb 8, 2019, 1:15 AM

#

just gonna format this a lil better for ya

foreach(EnemyHierarcyPiece piece in SelectedArmorConfig.HierarchyPieceList)
{
    piece.GraphPositionRect = GUI.Window(piece.HierarchyID, piece.GraphPositionRect, WindowFunction, "Box1");
}

if ((Event.current.button == 0) && (Event.current.type == EventType.MouseUp))
    SetSelectedNode(windowID);

ashen oasis Feb 8, 2019, 1:16 AM

#

Much nicer. 10x the pretty, thank you lol.

wispy delta Feb 8, 2019, 1:34 AM

#

yea I may be wrong, but all the node based code i've seen has had to handle all input from scratch (ie Event.current)
It'd probably be easier to make a node class that stores its own rect and has a draw/processinput method and loop through all of them in some manager

ashen oasis Feb 8, 2019, 1:42 AM

#

That's exactly what I did for my Node/Graph engine for Unity, lol

#

I saw this and thought, "Hey maybe Unity can already do this... kinda?"

#

That's kind of frustrating tbh. Clearly Unity knows which window object is selected since it changes the styling...

#

I'll put in an engine request ticket. "Method or property that can return the ID of the currently selected GUI.Window"

wispy delta Feb 8, 2019, 1:53 AM

#

So does GUILayout.Area just straight-up not work in the editor?
I've got this dead simple code and the button doesnt draw

var rect = EditorGUILayout.GetControlRect ();
EditorGUI.DrawRect (rect, Color.red);
using (new GUILayout.AreaScope (rect))
{
    GUI.Button (rect, "Please work");
}

📎 unknown.png

#

I know the area doesn't make sense in this example, but the button should draw anyways

visual stag Feb 8, 2019, 1:55 AM

#

GUILayout.AreaScope is for GUILayout controls

wispy delta Feb 8, 2019, 1:55 AM

#

doesn't work with GUILayout.Button either

#

📎 2019-02-07_19-57-43.mp4

visual stag Feb 8, 2019, 2:00 AM

#

during EventType Layout GetControlRect will return a tiny rect, which is what will then be used for the AreaScope during layout

#

so if you debug rect it'll be tiny during Layout

#

and that's likely where your button is

wispy delta Feb 8, 2019, 2:03 AM

#

So do i need to store a rect member in the class and only change it if the event type isn't layout?

#

how do you handle this quirk?

visual stag Feb 8, 2019, 2:09 AM

#

that is one way of doing it, but basically combining two layout structures isn't a thing IMGUI wants to do

wispy delta Feb 8, 2019, 2:14 AM

#

then maybe this isn't a rabbit hole i should jump down. this is literally all just so i can make the buttons in a horizontal layout group be perfectly flush. Ii could probably just set the horizontal margins to -1 or something

visual stag Feb 8, 2019, 2:15 AM

#

you probably already know, but there are two passes, and the first pass will involve registering all the controls for layout, the second is drawing them. The first Layout pass will register the first rect and the area, but then the area will have been passed that rect and ultimately fail, so you have to do that double buffer solution. Really the workaround is to literally calculate the rect yourself or layout a rect which is then served by GUI controls that are rendered in Repaint

#

so either you have a literal rect passed to a Layout control, or a Layout control passing its rect to a GUI (Repaint) control

#

or the double buffer (which presents its own issues)

#

this is one of the benefits of UIElement 😛

#

you can sorta glean a lot of stuff from https://blogs.unity3d.com/2015/12/22/going-deep-with-imgui-and-editor-customization/

#

You generally don't have to think about this crap until something isn't visible and you wonder why 😑

wispy delta Feb 8, 2019, 2:20 AM

#

yea I didn't know about that but was starting to suspect something along those lines after seeing repaint and layout as event types. it'll probably be a long while before a get a full understanding of how the whole system works, i'll probably have switched over to ui elements before then lol

visual stag Feb 8, 2019, 2:20 AM

#

It's an interesting switch because you build the UI once and then update it when things change

#

instead of having this persistent OnGUI update-like loop

wispy delta Feb 8, 2019, 2:21 AM

#

Yea, I'm curious how it plugs into serialized objects/properties

visual stag Feb 8, 2019, 2:22 AM

#

same way, just make a new PropertyField(prop);

somber oxide Feb 8, 2019, 2:25 AM

#

Is it possible to extend the Timeline window like you would a custom inspector?

visual stag Feb 8, 2019, 2:25 AM

#

in part

somber oxide Feb 8, 2019, 2:25 AM

#

I was thinking of making a "Refresh" button for ease.

visual stag Feb 8, 2019, 2:25 AM

#

what would that do... just untick and retick preview?

somber oxide Feb 8, 2019, 2:26 AM

#

It's using the new Refresh function from 2018.3

wispy delta Feb 8, 2019, 2:27 AM

#

@visual stag yup, I just decreased the left and right margins on the button styles and they don't have the pixel gap anymore haha. no need for an elegant solution

visual stag Feb 8, 2019, 2:35 AM

#

@somber oxide so, I do not think you can extend the actual TimelineWindow itself, but there is a way you can achieve this - but it's only for madmen (like me).
You could make a class that detects when the TimelineWindow is active and make sure it has a UIElement button injected into its rootVisualContainer at the right place in the UI.
But this is wild stuff 😛

somber oxide Feb 8, 2019, 2:37 AM

#

You just gained MORE of my interest.

#

I love it.

visual stag Feb 8, 2019, 2:38 AM

#

you can see an example of such nonsense here https://github.com/vertxxyz/EditorToolsKittens

#

(https://twitter.com/vertexxyz/status/1088380802491023361)

somber oxide Feb 8, 2019, 2:39 AM

#

ah, so EditorTools are 2019 only?

visual stag Feb 8, 2019, 2:39 AM

#

yeah, but the EditorTools part is irrelevant

#

you'd have to use the experimental UIElements API because it's only not experimental in 2019

#

but the general concepts are the same

somber oxide Feb 8, 2019, 2:40 AM

#

I've been going through the UIElements just recently!

#

Thanks!

visual stag Feb 8, 2019, 2:43 AM

#

also mine injects into the panel, you want the rootVisualContainer, which you may be able to get easily by just getting the internal rootVisualContainer from the EditorWindow itself

#

so a whole bunch of reflection can be avoided

#

a lot of what I had to do was to do with wanting to inject into any panel in the UI, seeing as you know where you want it to go it should be simplified

somber oxide Feb 8, 2019, 2:49 AM

#

How do you get the image into that mess of characters?

visual stag Feb 8, 2019, 2:50 AM

#

a mystery 👻

#

string assetPath = AssetDatabase.GetAssetPath(textureToConvert);
byte[] imageData = System.IO.File.ReadAllBytes(assetPath);
outputString = System.Convert.ToBase64String(imageData);```
mystery solved

somber oxide Feb 8, 2019, 2:57 AM

#

Oh snap you can do that within Unity?

#

So now the question is, why do that?

visual stag Feb 8, 2019, 2:58 AM

#

sure, it's not a good idea and I've done it for memes (https://github.com/richard-fine/unity-ArasIsWatchingYou)

#

5 year old memes

wispy delta Feb 8, 2019, 4:28 AM

#

I'm running into some funkiness with indented property drawers. The second instance of the drawer should be indented. You can see "Update" and "Iterations" are indented, so why not the drawer?

In this pic I added some debug rects:
blue = outline of rect sent to property drawer
red = toggle rect
green = object field rect

📎 unknown.png

#

The weirdest part is, if I increase the indent level, the object field gets pushed towards the right but the rect that it's drawn with (green) stays the same size

#

Here's an indent level increase of 4

📎 unknown.png

#

Here's the property drawer code (with the debug rects stripped). I don't think I'm doing anything weird, but I honestly dont know anymore when it comes to imgui
https://hastebin.com/kacuwimire.cs

visual stag Feb 8, 2019, 4:45 AM

#

you will find the EditorGUI controls themselves implement the indent

#

for example ObjectField uses a PrefixLabel which implements and returns an indented rect

#

you basically have to implement it yourself with EditorGUI.indentLevel * 15f

#

there are also some controls that poorly handle indentation (or don't at all), so you have to watch out for them too

wispy delta Feb 8, 2019, 4:48 AM

#

Ok good to know. I just found the method EditorGUI.IndentedRect which isn't in the scripting reference for some reason. Do you know if it indents the rect once, or for each indent level?

#

I can test if you don't know off the top of your head

visual stag Feb 8, 2019, 4:50 AM

#

that method will return a nicely indented rect

#

if you provide it to controls that indent they will indent additionally

wispy delta Feb 8, 2019, 4:53 AM

#

perfect.
this is still gonna be some frustrating code tho haha. the object field gets indented automatically within the provided rect, but the toggle doesnt, but the object field rect is based on the toggle rect. so I need to use the indented rect for the toggle, unindent it, and use the unindented version of the toggle rect for the object field rect

#

💪 Unity3d 🤜

visual stag Feb 8, 2019, 4:55 AM

#

sadly that's GUI programming with Unity 😛

bitter mural Feb 8, 2019, 10:57 PM

#

Ok so I have water that is only generated once the game is loaded
Is there a way to like generate a cube where the water is in the editor only for reference or

forest vortex Feb 8, 2019, 11:19 PM

#

https://docs.unity3d.com/ScriptReference/Gizmos.html

#

you can use Gizmos class to draw all kinds of shapes in editor view

rose bobcat Feb 9, 2019, 1:30 AM

#

Hello all. Does anyone know if I can change the name of a layer by code?

forest vortex Feb 9, 2019, 1:32 AM

#

i don't think you can, a layer name is pretty much an editor abstraction.

#

it's really the number that is used most places.

#

there might be something in the editor class to do it though

whole furnace Feb 9, 2019, 1:33 AM

#

I've seen assets which create new layers with the names they need

#

so renaming should be possible as well

#

(in editor)

rose bobcat Feb 9, 2019, 1:36 AM

#

Yeah, just trying to do a config script in editor.

forest vortex Feb 9, 2019, 1:36 AM

#

https://forum.unity.com/threads/adding-layer-by-script.41970/

Unity Forum

Adding Layer by script?

Hi All

Is it possible at all to add layers by script to the Layer Manager, Iam not seeing any obvious ways of doing it.

Chris

#

yeah it's through the tag manager

#

you can modify the serialized object that way

rose bobcat Feb 9, 2019, 1:42 AM

#

hmm, I was hoping Unity would have added something official by now. thanks.

rose bobcat Feb 9, 2019, 2:06 AM

#

Another one for y'all. I'm trying to set a gameobjects layer to one that doesn't yet exist so I can catch the layer and ask the devs to make sure to run the config script I mentioned. I'm unable to catch the error it's throwing. Any thoughts?
gameObject.layer = LayerMask.NameToLayer("nonexistant layer");
the uncatchable (?) error: "A game object can only be in one layer. The layer needs to be in the range [0...31]"

whole furnace Feb 9, 2019, 2:10 AM

#

https://docs.unity3d.com/ScriptReference/LayerMask.NameToLayer.html

#

"Returns -1 if not found."

#

-1 is not in the range 0-31

rose bobcat Feb 9, 2019, 2:17 AM

#

haha, thanks.

bitter mural Feb 9, 2019, 5:05 AM

#

So, is editor scripting mainly used as making development easier and adding more features?

#

There’s so much to learn in unity and it’s so overwhelming

forest vortex Feb 9, 2019, 5:06 AM

#

yeah that's pretty much what it's for.

#

You don't have to try to learn everythign at once. I didn't even touch editor scripting until a year into unity.

bitter mural Feb 9, 2019, 5:07 AM

#

Ok

forest vortex Feb 9, 2019, 5:08 AM

#

and then at first it was just to make custom component panels for some scripts i wrote

green shoal Feb 10, 2019, 8:01 PM

#

I want to draw a box with rounded edges here, but I've been reading the documentation and I have no Idea how to do so without drawing it in the wrong place.

📎 unknown.png

wispy delta Feb 10, 2019, 8:34 PM

#

@green shoal start a vertical layout group and pass the group EditorStyles.alertBox as a guistyle

#

whoops, it'sEditorStyles.helpBox

#

using (new EditorGUILayout.VerticalLayoutScope (EditorStyles.helpBox))
{
    // draw gui that should be within the box here
}

#

If you just want the texture, you can do EditorGUIUtility.FindTexture ("helpbox");

#

Here's what it looks like where I'm using it

📎 unknown.png

green shoal Feb 10, 2019, 8:48 PM

#

thanks, it worked just as I needed 😄

green shoal Feb 11, 2019, 1:10 AM

#

I lost some hours trying to find a way of handling a string[][] with SerializedProperty, is it not possible at all?

#

whenever I try to string.GetArrayElementAtIndex() it returns an error of nullReferenceException

visual stag Feb 11, 2019, 1:18 AM

#

are multi dimensional arrays even serializable by Unity

#

or do they just not display in the inspector at all

#

usually one and the other are the same 😛

wispy delta Feb 11, 2019, 1:22 AM

#

@green shoal just store all the values in a 1d array
you can initialize it like

string[] values = new string[width * height];

to access a 2d index you can do:

var value = values[x * height + y];

visual stag Feb 11, 2019, 1:23 AM

#

The core of the problem here is that Unity will not serialize a multi dimensional array so SerializedProperty has nothing to find, there are multiple ways (one being the above) to make alternate structures

#

you can also make an ISerializationCallbackReceiver, make a sub structure, there might be more ways

green shoal Feb 11, 2019, 1:26 AM

#

I thought of doing like that, but isn't it wasting a lot of memory? I'm using it to build a system of narrative, it has a lot of objects with this script, if there is an array with a lot of string[1] and another string[30] will it not be just a lot of memory thrown away?

visual stag Feb 11, 2019, 1:27 AM

#

do it like:

[Serializable]
struct Sentence {
    public string[] Words;
}
public Sentence[] Sentences;

then

#

that way it's also much clearer, and your structure can have more content in it later

green shoal Feb 11, 2019, 1:29 AM

#

wow, good solution, when editing the serializedProperty I just need to put (sentence) before it right?

visual stag Feb 11, 2019, 1:32 AM

#

SerializedProperty sentences = serializedObject.FindProperty("Sentences")
SerializedProperty sentence = sentences.GetArrayElementAtIndex(x);
SerializedProperty words = sentence.FindPropertyRelative("Words");
SerializedProperty word= sentences.GetArrayElementAtIndex(y);```

#

you could use a PropertyField to draw any of them

#

and make a PropertyDrawer for a Sentence or something 🤷

#

(obviously my example names are placeholders)

green shoal Feb 11, 2019, 1:34 AM

#

I'm so relieved right now, thanks a lot, I'll do it

visual stag Feb 11, 2019, 1:35 AM

#

Ah, I edited it to use FindPropertyRelative where appropriate, but yeah 👍 no worries

waxen sandal Feb 11, 2019, 9:53 AM

#

I'm trying to create an area(GUILayout.BeginArea) in an reordable list item however the items aren't being drawn at the correct position

#

Looks like they're drawn at the beginning of the inspector behind other elements

#

Any ideas why?

visual stag Feb 11, 2019, 10:05 AM

#

you cannot use areas inside reorderable list

#

it's just a limitation of them

#

Beans and I went over this earlier this week, it's probably searchable if you want more deets

waxen sandal Feb 11, 2019, 10:06 AM

#

Ugh, so I can't get guilayout working in them?

visual stag Feb 11, 2019, 10:06 AM

#

nope

waxen sandal Feb 11, 2019, 10:06 AM

#

Rip

waxen sandal Feb 11, 2019, 2:09 PM

#

I guess you can't render a style in a GUILayoutGroup as selected?

#

I want to scale an element to the size of my layout group and draw behind the items in it ._.

visual stag Feb 11, 2019, 10:29 PM

#

Not sure what you mean, but you can style scopes

#

And if that's not enough you can get the rect from the scope and draw whatever you want there

waxen sandal Feb 12, 2019, 7:25 AM

#

I know you can get the with GetLastRect but then your only option is to draw on top of it

#

I figured it out in a different way but it isn't ideal

visual stag Feb 12, 2019, 7:32 AM

#

using (EditorGUILayout.VerticalScope scope = new EditorGUILayout.VerticalScope())
{
    // Use scope.rect to draw something
    // then draw other content here
}```

waxen sandal Feb 12, 2019, 7:36 AM

#

Thought I tried that

#

This is amazing

#

Thanks!

worthy swan Feb 13, 2019, 12:32 AM

#

is it possible to set the active tilemap in the tile palette editor window by script?

daring zephyr Feb 13, 2019, 1:06 AM

#

Hi there! I would like to share a Scriptable Object post.

http://bit.ly/2N09KbH

visual stag Feb 13, 2019, 1:07 AM

#

@worthy swan https://gist.github.com/vertxxyz/b83926d59a08126ab73cacd9f9f3f085

Gist

A function I wrote for setting the active Tilemap via code.

A function I wrote for setting the active Tilemap via code. - TilemapExtensions.cs

worthy swan Feb 13, 2019, 1:08 AM

#

you are a legend vertx

daring zephyr Feb 13, 2019, 1:08 AM

#

What do you think about wraping GUILayout & EditorGUILayout?

http://bit.ly/2I9UvhC

visual stag Feb 13, 2019, 1:09 AM

#

just use GUILayout.HorizontalScope()

worthy swan Feb 13, 2019, 1:10 AM

#

such shameless self promotion haha

forest vortex Feb 13, 2019, 1:11 AM

#

there's also #archived-unitytips

daring zephyr Feb 13, 2019, 1:11 AM

#

Why? Just want to share some post I made talking about edior 😕

worthy swan Feb 13, 2019, 1:12 AM

#

I appreciate the articles nonetheless, couldve been a single message though

daring zephyr Feb 13, 2019, 1:13 AM

#

Sorry, just wanted to share

worthy swan Feb 13, 2019, 1:14 AM

#

no problem always good to share knowledge

visual stag Feb 13, 2019, 1:14 AM

#

you can wrap links in < > and they become a bit less obnoxious without the preview

worthy swan Feb 13, 2019, 1:14 AM

#

oh I didn't know that, that's handy

daring zephyr Feb 13, 2019, 1:24 AM

#

Sorry, just wanted to share

forest vortex Feb 13, 2019, 1:25 AM

#

it's all good

daring zephyr Feb 13, 2019, 1:26 AM

#

Messages edited, thanks @visual stag

gleaming zenith Feb 13, 2019, 7:38 AM

#

Hey guys. Has anyone of you a deeper understanding of the unity serialization? I try to serialize classes in my external dll (in the plugins folder) but unity crashes (out of memory) when trying to serialize my classes. Is there any way to debug / log this?

wispy delta Feb 13, 2019, 7:39 AM

#

@visual stag is probably your guy

visual stag Feb 13, 2019, 7:39 AM

#

external DLL? hell no 😛

#

I assume you've looked at the log files

wispy delta Feb 13, 2019, 8:31 AM

#

I was reading the animation style guide for King of the Hill and it got me thinking - I wonder if Unity has some sort of internal style/usability guide that all their editors have to adhere to. If so, it would be cool to see that released so people could design their tools/extensions to better match Unity's vision for their own editor GUI.

visual stag Feb 13, 2019, 8:35 AM

#

I wish they did. Whenever I design custom UI I'm always trying to adhere to what I think best matches their internal style

candid mist Feb 13, 2019, 9:46 AM

#

Is it a good idea to create instances of scriptableobjects that don't get saved as an asset through an editor script? I have something like:

public abstract class Effect:ScriptableObject
{
    public abstract void DoEffect();
}

public class DamageEffect:Effect
{
    public override void DoEffect()
{
    //snip
}
}
public class Skill:ScriptableObject
{
    List<Effect> effects;
}

And then the editor script creates instances of DamageEffect and puts it in the effects list in skill directly, without saving the SO as an asset.

#

The only reason Effect is even a scriptableobject is because inherited classes don't serialise otherwise so it feels very hacky to me

visual stag Feb 13, 2019, 9:48 AM

#

It's fine to my knowledge, you're just losing out a bit on the benefits of it being an asset, but if it's working well without those benefits (seeing as you justified with "the only reason" I imagine this is the case) then should be good 👍

candid mist Feb 13, 2019, 9:50 AM

#

hmm alright

#

It just feels weird since I'm practically using the abstract Effect class as an interface

#

It doesn't really save any data

wanton ridge Feb 13, 2019, 9:51 AM

#

Since that's the only real way to handle inheritance, I'm pretty sure that's fine. Non-asset scriptable objects can serialize as values within other classes, so you should be good. I do something similar for some one-off level logic.

candid mist Feb 13, 2019, 9:52 AM

#

Actually wait it does have some data nvm

idle perch Feb 13, 2019, 12:26 PM

#

Hey! Anyone happen to remember how I can change the value of a serialized variable that's in the scene from an editor script?

#

nvm I think I found it

topaz heath Feb 13, 2019, 12:41 PM

#

How can i make a custom debug class that is called throughout my code gracefully not be compiled to a build.

crystal raven Feb 13, 2019, 12:41 PM

#

You can use #if UNITY_EDITOR to wrap the whole class

topaz heath Feb 13, 2019, 12:42 PM

#

okay thanks, will any code calling methods in that wrapped class have their method calls stripped so they dont blow up?

crystal raven Feb 13, 2019, 12:43 PM

#

you need two wrap them with the #if too

topaz heath Feb 13, 2019, 12:43 PM

#

😦

crystal raven Feb 13, 2019, 12:43 PM

#

or make a dummy class

#

    {
#if USE_CHEATS

        if ( Instance == null || !Instance.UseCheats || Instance.All == null )
            return false;

        return Instance.All.Contains( option );

#else
                return false;  
#endif
    }```

#

That way the methods will still work in the build too

topaz heath Feb 13, 2019, 12:46 PM

#

got it. thanks.

wanton ridge Feb 13, 2019, 1:03 PM

#

Alternatively, you can also use the ConditionalAttribute. This means that any time the method is called, it's ignored unless that compiler flag is set. This tells the compiler to actually remove the code that calls the method, and it only works if the method returns void. This leaves the method itself and it's class around around so that things like reflection can work, so that may still be handy for you. Example:

public class DebugManager
{
    [Conditional("DEBUG")]
    public static void DoSomething()
    {
        Debug.Log("I did something in DEBUG!");
    }

    [Conditional("DEBUG"), Conditional("USE_CHEATS")]
    public static void SuperCheat()
    {
        //Cheat really hard
    }
}

//Elsewhere
DebugManager.DoSomething(); //Will only actually call if the DEBUG flag is set
DebugManager.SuperCheat(); //Will only call if the DEBUG flag OR the USE_CHEATS flag is set. If neither are set, then the call is omitted.

Note that I'm not sure if methods ran as parameters still run, for example:

DebugManager.DoSomething(Player.Kill()); //Does the player still get killed?

crystal raven Feb 13, 2019, 1:06 PM

#

Didn't know about that attribute, thanks 😃

wanton ridge Feb 13, 2019, 1:13 PM

#

It's a pretty subtle thing. There a bunch of really handy attributes that nobody knows about that can really aid debugging. DebuggerDisplay is one that comes to mind for Visual Studio users

crystal raven Feb 13, 2019, 1:19 PM

#

Ok, that's cool too

topaz heath Feb 13, 2019, 3:18 PM

#

thats really cool thanks @wanton ridge

#

the indent behavior on #if directives in visual studio was driving me crazy :S

dusky plover Feb 13, 2019, 3:28 PM

#

Wait wait wait, am I missing something? To my knowledge, we can't SET compiler flags in a Unity project, can we?

visual stag Feb 13, 2019, 3:37 PM

#

you can in project settings or using assembly definition features

daring zephyr Feb 13, 2019, 3:38 PM

#

Hit enter when you set one and you will see the recompiling

dusky plover Feb 13, 2019, 3:50 PM

#

You mean the scripting define symbols?

daring zephyr Feb 13, 2019, 4:03 PM

#

Yes, there

#

📎 unknown.png

#

After setting up that you can go to your code and use #if MY_DEFINE

dusky plover Feb 13, 2019, 4:41 PM

#

But that's been around forever. lol I wonder where I read before that it wasn't possible.

#

Thanks 😃

worthy swan Feb 13, 2019, 5:08 PM

#

thanks again @visual stag, I finally got active tilemap switching (somewhat) automated now 👌

📎 2019-02-13_18-03-48.mp4

mental wind Feb 13, 2019, 10:27 PM

#

Anyone know why adding a GUIStyle to a label moves it up a few pixels? anything i can do about it?

#

this seems to happen even if I make a brand new GUIStyle and don't modify it at all

wispy delta Feb 13, 2019, 11:04 PM

#

Default label style just had a builtin margin/padding i'd imagine

#

You're losing that when you make a new one

visual stag Feb 13, 2019, 11:19 PM

#

@worthy swan sweet! That alone appears to speed up workflow a ton! I wonder what the solution would be if they built it into the tool. Perhaps numbered slots that uses the new shortcut API...

worthy swan Feb 13, 2019, 11:29 PM

#

it really does make things easier, and no more painting on the wrong layer

#

the way I solved it is by having the valid target tilemaps be equal to the name of the selected ruletile, flushing the painttargetcache and invoking autoselectpainttarget when picking a new tile from the palette

#

curious when the script will break though, doesn't feel super safe using reflection 😛 but it works that's what matters

visual stag Feb 13, 2019, 11:38 PM

#

you'll likely have to update it through versions, I was afraid when I sent it to you that we'd be on versions too different 😛

worthy swan Feb 13, 2019, 11:39 PM

#

I used the unity csreference repo as reference, is that one actually kept up to date?

visual stag Feb 13, 2019, 11:40 PM

#

I usually use ILSpy on whatever version I'm working on

#

or I let Rider decompile something specific - but I think Rider's decompiler is less accurate with names sometimes, though still majorly helpful

worthy swan Feb 13, 2019, 11:41 PM

#

oh I should check those out

mental wind Feb 13, 2019, 11:48 PM

#

oh, thanks @wispy delta ! that was very helpful

worthy swan Feb 13, 2019, 11:49 PM

#

oh man I should've known about this sooner

#

navigating/search in ILSpy is already better than on github

visual stag Feb 13, 2019, 11:50 PM

#

yeah, it's pretty much always open if I'm working on editor stuff to be honest

craggy kite Feb 14, 2019, 12:00 AM

#

the same decompiler in rider is also available standalone as dotpeek

proud yarrow Feb 14, 2019, 12:22 AM

#

anyone have any strong feels about when custom inspectors / widgets do this kinda thing?

#

📎 unknown.png

worthy swan Feb 14, 2019, 12:22 AM

#

hahahaha

proud yarrow Feb 14, 2019, 12:22 AM

#

i'm making a help system and the user can specify a custom button but if they don't, that's one way it can inject a help button into there

worthy swan Feb 14, 2019, 12:22 AM

#

it looks like it's photoshopped on

proud yarrow Feb 14, 2019, 12:23 AM

#

yah i wanted it to loook supah-custom

#

like 'woah, fancy'

worthy swan Feb 14, 2019, 12:23 AM

#

ahh I get that

proud yarrow Feb 14, 2019, 12:23 AM

#

but i dunno, in one way this kinda weird stuff generally annoys me

#

so i'm trying to find a balance

forest vortex Feb 14, 2019, 12:23 AM

#

i don't hate it. i think it looks unique.

worthy swan Feb 14, 2019, 12:23 AM

#

but, in my opinion, it should just look like an editor script

proud yarrow Feb 14, 2019, 12:24 AM

#

well it kinda ratchets onto other peoples editor scripts

#

it's a help system

worthy swan Feb 14, 2019, 12:24 AM

#

I just prefer having as little visual 'noise' so to speak in tools/ui

forest vortex Feb 14, 2019, 12:24 AM

#

then it's probably good it uses a commonly available but unused spot

#

hopefully won't interfere with custom editor interfaces

proud yarrow Feb 14, 2019, 12:25 AM

#

📎 unknown.png

#

you can override the placement

worthy swan Feb 14, 2019, 12:25 AM

#

neat

proud yarrow Feb 14, 2019, 12:25 AM

#

so custom editor can say 'dont show a button, i'll show the button'

#

that's editable within the inspector too

#

you can add / edit entries

#

and it can export C# code you paste into your editor script to bake the docs in there permanently

#

then the user can disable further edits if they want

#

now i kinda want a little of that photoshopped look on my main UI tho 🤔

#

gloss is addictive

visual stag Feb 14, 2019, 12:29 AM

#

I made a searchable documentation window based on code because I was making an editor extension with many packages and it kept evolving and getting refactored. Was difficult to keep up with the changes on a wiki

proud yarrow Feb 14, 2019, 12:29 AM

#

ikr? that's why i made this

#

it's just easier to update if it's all in the inspector

visual stag Feb 14, 2019, 12:29 AM

#

https://github.com/vertxxyz/nDocumentation if you want to take a look (it's highly specific and 2019 only)

#

I wouldn't advise to use mine unless you're wild, but it's a good project to look at for UIElement and a potential structure I feel

worthy swan Feb 14, 2019, 12:30 AM

#

wish there were more screenshots!

proud yarrow Feb 14, 2019, 12:30 AM

#

can you edit the doc pages inside the inspector?

visual stag Feb 14, 2019, 12:31 AM

#

nope

proud yarrow Feb 14, 2019, 12:31 AM

#

📎 unknown.png

#

mine does

visual stag Feb 14, 2019, 12:31 AM

#

yours is definitely more flexible in that manner 😃

#

I decided that making mine in code would help me ensure refactoring forced documentation changes

proud yarrow Feb 14, 2019, 12:32 AM

#

📎 unknown.png

#

📎 unknown.png

#

which generates something like this:

#

https://hatebin.com/hwarfmaubg

visual stag Feb 14, 2019, 12:35 AM

#

oh, I thought perhaps it would stay in scriptable objects or something

proud yarrow Feb 14, 2019, 12:35 AM

#

to add this to a component you just create a file like this in the editor folder:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEditor;

[CustomEditor(typeof(PersistenceManager))]
public class PersistenceManagerEditor : EditorWithHelpSystem {
}

#

no before it gets baked into the source it serializes user edits as a binary file

#

which is pretty much fine as is, but for redistributed components it seems like, might as well bake it in there

#

thinking about adding a basic search to it, kinda lacking in that way now