Glimwood Tangle marked as incomplete despite finishing Zarude quest | PokéClicker | Page 1

elfin juniper Jun 10, 2023, 5:41 PM

#

I'm not sure what caused this, but it's nothing to do with Flowering Celebi

shut verge Jun 10, 2023, 5:47 PM

#

huh, weird

wooden lake Jun 10, 2023, 5:56 PM

#

I think it actually may be Flowering Celebi after all. The temp battle is showing as undefeated but the quest is complete and you've caught it.

willow elk Jun 10, 2023, 5:57 PM

#

Right, the CSS calculator checks tempbattles... MegaThonk

wooden lake Jun 10, 2023, 5:59 PM

#

Yeah, the temp battle has ObtainedPokemonRequirement('Flowering Celebi') as the completeRequirement so it no longer appears after catching it, but because it was caught after the battle time ran out it didn't count as a completion. Huh, has this never come up before?

willow elk Jun 10, 2023, 6:00 PM

#

First time seeing that. I guess it should only check for incomplete accessible tempbattles, lul.

wooden lake Jun 10, 2023, 9:57 PM

#

Not sure if we should also include an update function to set the temp battle as completed if the player has the 'mon or if it just doesn't matter

willow elk Jun 10, 2023, 9:59 PM

#

Well, if we exclude non accessible incomplete contents from the calculation, we fix the bug for anything which would get stuck in the same situation, updating the tempbattle statistics would not matter anymore.

wooden lake Jun 10, 2023, 10:01 PM

#

Yeah, I'm just debating on whether it's worth doing. Don't know if it might ever effect anything in the future

willow elk Jun 10, 2023, 10:02 PM

#

I would not bet on that, but we never know. lul

wooden lake Jun 10, 2023, 10:02 PM

#

In the unlikely event something gets added that requires that temp battle to be defeated lol

willow elk Jun 10, 2023, 10:03 PM

#

There is a quest step for that ! Much more reliable requirement.

wooden lake Jun 10, 2023, 10:08 PM

#

True

#

I might just do it to be safe anyway

#

What are the other temp battles where this could occur? Suicune is one, right?

willow elk Jun 10, 2023, 10:11 PM

#

Suicune, Red Gyarados.

#

I do not know which one else.

#

Then, it also needs to be fixed for future occurrences, lol. I mean, if we are doing that, we should also prevent that specific case to happen.

#

That affects tempbattles tagged as non trainer battles, right ?
If so : Suicune 6, Red Gyarados, Kecleon 1-3, Kubfu, Flowering Celebi, Regigigas, Alpha Kricketune, Dialga (Origin) 2, Palkia (Origin) 2, Giratina (Origin), Tornadus 3, Thundurus 3, Landorus 3 could trigger such bug, lul.

willow elk Jun 15, 2023, 1:04 PM

#

Wait, why was the original message actually deleted ?

wooden lake Jun 15, 2023, 1:12 PM

#

🤷

#

I completely forgot to PR the color overlay fix

willow elk Jun 15, 2023, 1:34 PM

#

I was about to make one, lol.

#

Do you want to push yours ?

#Glimwood Tangle marked as incomplete despite finishing Zarude quest