#💬 Laird DazMukyʹs Feedback
clever thunderBOT
ember ibex
tyty ye my names are wonky
glass raven
i'd probably clean them up a bit otherwise it is hard to understand your code, and harder for the mods to rank you
pcall(function()
bodygy.CFrame = CFrame.new(bodygy.Parent.CFrame.p,bodygy.Parent.CFrame.p + ((camera.CFrame.LookVector * Vector3.new(1,0,1)).Unit))
end)
interesting pcall here, care to explain?
ember ibex
jst to remove an error
frozen oxide
?
glass raven
frozen oxide
jst to remove an error
what error?
new comment system that the mods made is rlly helpful so far
ember ibex
its just a warning that would flag up
cause of the renderstepped
wrapping in pcall got rid of it
was just for debugging
lol
glass raven
i think this shows some pretty strong concepts, but you need to work on your code quality a bit:
- naming conventions
- using context action service or at least UIS events rather than uis:IsKeyDown
- use the renderstepped event rather than a while loop with a RenderStepped:Wait()
- less branching, you have a 4 if statements for different keys that do similar things
- look into using more guard clauses
but yeah if you do all that I think you are probably s2
ember ibex
i am using render stepped 🙂
frozen oxide
bruhh
frozen oxide
yeah
glass raven
in either case it is bad programming
frozen oxide
and ur not rlly indexing anything
that you would need to wait for
except for the char
glass raven
yea
glass raven
Use
RunService.RenderStepped:Connect(function()
-- code
end)
instead of
glass raven
i am using render stepped 🙂
^^
frozen oxide
also i think ur using extra variables
they're kind of the same thing
if fly is false then ur not flying
u won't need another one set to true
glass raven
i can't tell because the naming is so vague
glass raven
yeah it is definitely in that s1-s2 boundary
but i'd say there needs to be better cleanliness for s2
but baha may disagree who knows
glass raven
if he hasn't already been pinged by @ember ibex
iron horizon
Pretty solid s1. Has quite a bit of work to get any higher though.
ember ibex
what counts as an s2 or s3 what is the criteria ?
ember ibex
i see
well i will take any ranking u guys think i am at the level of
just wanted to check what others were doing and the types of scripts get u to 2-3-4 etc
iron horizon
Typically for scripting we look at your use of Lua, cleanliness & structure of code, and bonus points for interesting/difficult problems
glass raven
just wanted to check what others were doing and the types of scripts get u to 2-...
this was my s2 submission, I would say it is a low-mid s2 script
#📜︱scripting message
frozen oxide
this was my s2 submission, I would say it is a low-mid s2 script
https://discord...
damn
that's nice
i still hate metatables tho
so confusing for me
ember ibex
yea lerping camera using object oriented programming very nice
glass raven
it applies some advanced concepts, but is overengineered and fairly pointless
frozen oxide
it applies some advanced concepts, but is overengineered and fairly pointless
welp
mine was a lot worse
frozen oxide
lol
glass raven
his code is less convoluted than yours
frozen oxide
cause its doing less than mine
it is but u still need to clean stuff up
ember ibex
its not about how pretty code looks
glass raven
it does less, but it does it in a clearer way
ember ibex
its about how it operates
glass raven
its not about how pretty code looks
it is very much about how it looks
frozen oxide
yeah
ember ibex
u will never see it
glass raven
and how it operates as well
ember ibex
its a common trap programmers fall into they care more about how it looks
if it does the job it does the job
frozen oxide
it's the other way around lol
frozen oxide
if it does the job it does the job
other ppl can't help if there's a bug
frozen oxide
plus u won't be able to fix it urself
glass raven
I would argue @frozen oxide 's code operates better than yours since yours has lots of issues, lots of waiting, misuse of loops in place for more precise runservice events, unneccessary branching &c.
glass raven
you arent using it correctly
ember ibex
main flying loop is renderstepped
glass raven
yes you should not be using a loop to run code every frame
connect a function to the renderstepped event instead
ember ibex
that does the same thing
glass raven
nope, since code takes time to execute, your loop isnt running it every frame
it will likely skip frames
ember ibex
i need the loop to run as its applying velocity at a set rate of .1 ticks in the wait() for smooth flying when holding the key down for wasd movement for flying
glass raven
you should do that every frame, using deltaTime from the renderstepped event to dynamically determine the velocity to apply
instead of hardcoding in .1 in a wait() (which won't precisely run every .1 seconds anyways)
glass raven
..
ember ibex
not really sure what you mean
glass raven
you aren't using it that's my point
ember ibex
starting to think this was a mistake
frozen oxide
renderstepped is delta time dud
u gotta use it tho
glass raven
me too
ember ibex
i will stick with my rank 1 i personally think rank 1 should be for basic scripting with remote events and cloning objects
rank 2 should be more advanced stuff with tables and loops
user input service
make no real difference if you do it script ver or oop unless ur scaling up to massive scale
its all done on client cause movement is replicated to server
my logic is more sound i belive
its 30/s script performance with no impact on server
loop turns off if u land
glass raven
well you can argue with baha then, based on the historical standards of rankings on this server I don't think your code is s2
ember ibex
if i simply added it into a module script with a constructor and returned the gyro cframe and cleaned up the code names it would probs get s3
but it functions the same
regardless if i do it that way
its using deltatime
its just more steps involved with passing data around
works fine on client
glass raven
if i simply added it into a module script with a constructor and returned the gy...
@iron horizon can you please explain to laird how incorrect this is
ember ibex
its true tho classes and oop are used so u dont need to replicate code for bigger systems like weapons etc
makes no difference if its for 1 thing
just more fluff to make it look better
syntax wize
cant make a new object each time somone flys its very much a loop on or off.
iron horizon
for one thing, you should remove your testing code when you've got it working
ember ibex
i feel that u guys focus on the wrong things
the core logic is sound
who cares if the spelling of a variable is bad
i can just change it
makes no logical different to the code operating.
i can pass parameters around into functions and back again and use meta tables and module scripts to simulate oop and classes but the logic would remain the same i feel its worthy of a 2 at least
1 is beginner
more beginners dont even know what a remote is
seems not that fair
unless i make a lightning module or something i would never be put above a 2
lol
bezier curves etc
i am worthly more than a 1
kekw
its ok tho
iron horizon
Well, it does sound like you know a decent amount, so I'll go ahead and give you 2
ember ibex
ttyty
iron horizon
but the ratings isn't completely about what you can do, but how well you can do it.
ember ibex
well thats true how would i go about improving to get a 3 ?
like ai systems or full on inventory rpg systems ?
iron horizon
post a lot of work
ember ibex
will do 🙂
iron horizon
And yes, things like organization and conventions do make a big deal
ember ibex
noted 🙂 i was lazy with this code
iron horizon
your logic works, but there's better ways of doing it
ember ibex
i just did not want to be a 1
beginner =/ lol
2 i am fine with
u guys should add in a 5th rank
iron horizon
lol, 4 ranks is already too many
ember ibex
starter - beginner - intermediate - advanced - pro ?
iron horizon
it goes beginner - intermediate - advanced - expert
iron horizon
Not saying this is the best code in the world, in fact some of it's pretty old, but here's my github: https://github.com/dmforeacre/RobloxScripts
iron horizon
Here's the end result: #🔥︱featured message
ember ibex
yea thats very nice stuff i can see why that would be considered level 4
able to understand complex mathmatics and polynomials and actually create a grid and threads for that
bit out of my reach cause i dont study the maths side of things mostly
i need to get better at the OOP stuff i know how it operates and its use cases i just need to get used to the metatable / modulescript setup in lua to work with it
wish it just had normal static typed language like c
could inherit and everything
well i suppose you can
just round about ways of doing that
ember ibex
OHHH dam yea lua U
ember ibex
i 100% forgot about that
yea metatables tho
LOLOL
it confuses me sometimes
cause it does not look like a normal class you would see in c# or java
the __index and my brain is just like na
i constantly look for the lazy way to do it
lolol
iron horizon
Yeah, I actually hate metatables
ember ibex
whats the best script u have ever made u rekon ?
iron horizon
Possibly my object randomizer plugin. That code is included in my github, but it's the one that's a year old lol.
ember ibex
i know this is a big question to ask but what are the main things to look for when anti exploit scripting in terms of what not to do
is it best practise to keep things in serverstorage and clone out
and do most stuff on client for performance and protect the remote events ?
a quick top 5 list of things would be great then i will leave u in pease
peace
and i can research the rest
iron horizon
I'd recommend making sure you check any exploitable information that can be sent through remote events to the server
anything that happens on the client is out of your control so there's no point trying to protect that, and they can't access the server
so focus on the remotes
ember ibex
kk will do 🙂 ty for everything i will be back in future with posts hopefully start improving the level 3 stages
iron horizon
gl 🙂