rng system

[violet lily]

hopefully you guys get the memo of what im trying to get at here

[vagrant steeple]

well if chance is a number

youre trying to loop thro a number

i assume you wanted to grab its value but not loop thro it

[violet lily]

yes

[vagrant steeple]

so just dont loop thro attribute

its just a number

[violet lily]

yeah ik i fixed it later on

i done a bit of changing but now im only getting uncommons and commons

im not good at math

to be coding this

[vagrant steeple]

what are your attributes set to? also u should prob set roll variable inside the function not on global scope

[violet lily]

every folder within rarities has a chance attribute set to it, common is 90, mythic is 0.01

and the rest is self explanatory

[vagrant steeple]

whats value of uncommon

[violet lily]

40

[vagrant steeple]

yea thats your problem

roll is 0-100

and common is 90, uncommon 40

so thats 130!

you cant ever get higher ones

[violet lily]

yikes..

fair enough, what do i do to fix it

as i said

im not good at math so i have no idea what to set the chances to

[vagrant steeple]

set the roll variable inside function, but first calculate total chances of all

[violet lily]

i mostly used chatgpt and i regret doing that because i want to learn by myself; not by an ai bot

[vagrant steeple]

so sum all chances

then just randomize from 0 to sum

[violet lily]

am i on the right path

[vagrant steeple]

almost, just make a variable that holds the sum of chances

just do something like

  total = 0
  for _, chance in rarities do
  total += chance:GetAttribute("chance")
end

then roll from 0 to total

and then keep your previous code u had

[violet lily]

i noticed you didnt use ipairs

do i not need it?

[violet lily]

ive basically done that i think

[vagrant steeple]

you dont

[violet lily]

oh

good to know

[vagrant steeple]

it really doesnt do anything

[violet lily]

fair enough

good to know aswell

[vagrant steeple]

not really

look

[violet lily]

yes

im looking

[vagrant steeple]

go back to this rng logic
BUT do the chance fix so u dont loop over number

and

before that code in same function

SUM all the chances

so another for loop

[vagrant steeple]

something like this

then roll

[violet lily]

chance fix meaning the code you sent as an example?

[vagrant steeple]

the original error you had, where u tried to use loop in number

[violet lily]

have i done it now

this looks correct

[rich thorn]

why don't u not use Random.new()?

[violet lily]

completely forgot about that, ive never used it aswell

[rich thorn]

try it

[vagrant steeple]

you dont rly need to

[vagrant steeple]

almost but

youre using same variable for 2 things

\

use something like total or totalchancefor the first loop and inside math.random

or just reset the variable back to 0 after roll and before loop

[violet lily]

so i lowkey didnt know what you meant but i asked gpt and he basically returned the same code, but changed the currentchance in the first loop to something different

i didnt change it because i had no idea what to change it to and i didnt think it really mattered if i did

and it worked aswell

[vagrant steeple]

you just used same variable for 2 diffrent counters

[violet lily]

i know its what i just said

[vagrant steeple]

it would bug out if you used same for SUM and then never reset it to 0 and use to to check what you rolled

[vagrant steeple]

glad it works

[violet lily]

yeah ive realised that now

thank you for the help

[violet lily]

😄

do you have any tips for coding

[vagrant steeple]

print,print and once again print

[violet lily]

for like remembering and like starting thinking logically more

[violet lily]

i used to do that

but i just stopped

also wkizi should i feel grief because im using chatgpt instead of learning by myself

[rich thorn]

@violet lily the more you code the more you get better