#Unreadable Code From Employer

1 messages · Page 1 of 1 (latest)

iron hollow
#

How does your code look? Is it readable? Can someone else read it and understand what's happening and be able to trace every line of code? I just applied for a scripting position at some dude's small game, his scripter isn't able to work for a while. He gave me some VERY easy tasks to do like add another start menu, create team spawns, inventory. The only issue is, the code is absolutely unreadable for me. The code's style changes like every script, from capitalizing variables and using indentation, to just no capitals and no indentation at all. There's over 35 module scripts in the entire game, and I can't trace a single :FireServer() to any server sided scripts. It's like they tried to add a firewall to their code. Am I just lacking in my abilities, or is this just genuinely a lost cause? Personally, when I write code I use proper variable names and I don't use 6 module scripts just to make a menu screen. Help?
I'm considering just sending the dude his money back because I just cant work with the code. For example: there is a double nested module script that is supposedly in charge of the team change ui. The script fires and event to the server, but there is ONE server script in the whole game, and I can't find any links between that and any of the events. Everything is buried in a module with improper variable names?

vernal swift
#

Did u say 35 modules? what game is it?

iron hollow
#

It's a mostly finished prison game, pretty generic

#

I'm not sure why, but there's modules for stuff like "Camera", even though the game doesnt have a custom camera?

vernal swift
#

The code code style changes obv shows that the past scripter uses AI

#

If he pays you low, it'd not be worth it buddy 🙂

#

So u gotta use fastsearch

#

I think the keybind is Ctrl + Shift + F?

#

then u search :FireServer

#

It searches through all script

#

the past scripter is likely s1-s2

iron hollow
#

It's not like the code looks dumb, its that it looks way too complicated than necessary. How would you structure a UI main menu script?

vernal swift
#

well it depends, what kind of main menu you want

iron hollow
#

A very simple one, literally just select a team and then spawn in

vernal swift
#

then a single module script is enough

iron hollow
#

cause the menu for that same type of menu can be traced to like 4 different modules

#

ok ok, thanks

vernal swift
#

a ui menu mostly take 1-2 modules

#

except complexs like inventory ui or more

#

it'll take atleast 3 modules

iron hollow
#

alright, this one is literally just selecting your player, and choosing a team 😭

vernal swift
#

goodluck reading those scripts elaborate

iron hollow
#

nah im just gonna send the money back

#

preciate you

bleak plinth
vernal swift
#

i'd never continue to work on other people shit though

bleak plinth
#

that comes up a lot - 14 year olds hiring 18 year old volunteer scripters to make the game for them, the scripter quits, the 14 year old can't do anything, and so they hire you to clean up

#

but yea, you're just lacking in ability

#

even a bad codebase can be worked with if you're half decent

vernal swift
#

XD

iron hollow
#

I looked at the job, the issue isnt the actual job itself, it should be the easiest thing in the world. I wish I could send the code but I signed an NDA :/ Is it really normal for programmers to wrap a single two-frame Ui in 11 module scripts? Is that just something I have to start doing?

iron hollow
bleak plinth
#

so ya the ability is just tracing

#

ctrl+shift+f bro

#

it that simpel

vernal swift