Optimizing Game With Modules

[hoary spade]

Hi I am trying to optimize my game with modules on the client side.

I often need to access the player gui so I am constantly passing player as one of the parameters for my Init() function. Is this the right thing to do? I'm also initializing my variables in the init() function, is that fine?

This way seems to remind me of intializing vairables in a java constructor, which I like.

Please give me honest constructive feed back, thank you!

[tame osprey]

why odnt u create variable

local player = game.Players.LocalPlayer

[hoary spade]

I did in the loader and then passed it when i require the modules. I believe u can only do that in a local script and not module. (let me know if im wrong)

reference this pic

this is what my layout looks like

[little reef]

i don't think you need to pass the player parameter on localscripts

and initializing the variables in the init() function i think you have to do this only in variables that you have to update

this is not wrong but i don't think it is a good practice

especially when you need to use many variables in a code

you'll need to start one by one, and that will be unnecessary work in my opinion

[hoary spade]

i’m not sure if i understand u

[eager flame]

** You are now Level 3! **

[hoary spade]

i’m passing the player because i need to access the player’s PlayerGui and the only reason i initialize the variables in the init() is because of an event listener might be created before the variables and instantiated

[little reef]

yeah that´s right but as the first guy said idk why you just don't use

local player = game.Players.LocalPlayer

[hoary spade]

can i even run that on module scripts?

thought u can only use LocalPlayer on local scripts

[little reef]

if the module script is being called by localscripts yeah

[hoary spade]

oh fr

i didn’t know that

because it’s been required by a local script

[little reef]

yeah the modulescript can be localscript and normal script

it depends on where are you require them

[hoary spade]

oooooooh

that makes sense ty

[tame osprey]

you can in module scripts rhat are loades by local scripts do

local player = game.Players.LocalPlayer

[slender stream]

idk what your game is about but I will add this;
if for whatever reason you reset your character or your character dies you have to initiate the module scripts inside a CharacterAdded function again as modules can only be required once and you need to initiate some variables inside the CharacterAdded function again aswell due to the 'player.Character' not existing after resetting

plus - if you have :Connect functions inside the CharacterAdded function you must also disconnect those functions if your player resets as well. just use CharacterRemoving to disconnect them.. This is because nested :Connect functions will double fire if you don't disconnect them.