How do i optimize this?

[loud herald]

I want to have every model spin at the same speed but it drops the fps from 240 to 120

(Vehicle is just a model)

Code:

                    while task.wait() do
                        vehicle:PivotTo(vehicle.WorldPivot * CFrame.fromEulerAnglesXYZ(math.rad(0), math.rad(-0.5), math.rad(0)))
                    end
                end)```

[trail drift]

try updating them all in 1 big loop maybe

instead of a while loop for each

also try runservice

[charred nacelle]

Try runservice.renderstepped

[loud herald]

i will try that

[loud herald]

i tried using runserver.renderstepped but it didnt do anything, ill try and get everything into a big loop and see if that works

[charred nacelle]

local RunService = game:GetService("RunService")

RunService.RenderStepped:Connect(function()
-- code goes here
end)

[charred nacelle]

Did you set it up like this

Heartbeat is probably better to use but if you want it to update every frame use renderstepped

[trail drift]

if u have a very long list of cars

u might have to change it so that it only updates the ones that are visible

[loud herald]

yes

[trail drift]

so if the car guis go like 1,2,3,4,5,6,7,8,9,10 .. and the current car in the middle is 5 then only rotate 4,5,6

u get what i mean

[loud herald]

yeah, but i dont know how to check for visible frames

[trail drift]

like i said

[charred nacelle]

You there is no way

[loud herald]

and im going for jailbreaks old spinning animation on their car spawning from 2019

[trail drift]

any change after

1 loop

[charred nacelle]

You must do some math based on the frame sizes

[loud herald]

im failing math

jk

i dunno how i would do that tho

[trail drift]

lets try an easier solution

limit the update rate

[loud herald]

?

[trail drift]

every 5 frame instead of 1 maybe

[loud herald]

:O

[charred nacelle]

Just multiple by the frame size and margine

[loud herald]

i can try that

[trail drift]

so just an os.clock check

[loud herald]

yes but that arises another issue, how would i know the specific frames shown?

[charred nacelle]

Or runservice.heartbeat

[trail drift]

ok ok

how did u do the

frames on the bottom going from left to right

right to left

[loud herald]

scrollingframe

[trail drift]

lemme see if theres api

[loud herald]

with horizontal canvas

dang my internet takes like 5 seconds to send a message

😭

[charred nacelle]

Ik there's a way I would have to go check

[loud herald]

ill check documentation site whilst you do that

[trail drift]

print

CanvasPosition

while u scroll

see if that changes

[charred nacelle]

local scroll = -- your ScrollingFrame

scroll:GetPropertyChangedSignal("CanvasPosition"):Connect(function()
print("Scroll X:", scroll.CanvasPosition.X)
print("Scroll Y:", scroll.CanvasPosition.Y)
end)

Try that

[trail drift]

ye ok

gah i think we'll have to do some math

[trail drift]

ok i got an idea

[loud herald]

?

[trail drift]

divide screen's x size by the size of a cars frame's x size we get the amount of car frames we see in the screen at a time say this value is CarAmount
say CurrentIndex is 1
every time canvasposition's x position changes by the amount of a car frames x size change currentindex by 1
update cars from CurrentIndex - CarAmount/2 to CurrentIndex + CarAmount/2
this assumes cars are placed in a list

[loud herald]

the cars are placed in a viewport that lies here

[trail drift]

wait

show ur whole update code rq

[loud herald]

ScrollingFrame -> ViewportFrame -> Model

[loud herald]

cant send it

too long of a message

[trail drift]

no not the whole

just the

renderstepped inside

[loud herald]

ah

this?

vehicle.Parent = template
vehicle:PivotTo(CFrame.new(Vector3.new(0,0,0)) * CFrame.fromEulerAngles(math.rad(0),math.rad(180),math.rad(0)))

            game:GetService("RunService").Heartbeat:Connect(function()
                if template.Visible == false then return end
                vehicle:PivotTo(vehicle.WorldPivot * CFrame.fromEulerAnglesXYZ(math.rad(0), math.rad(-0.5), math.rad(0)))
            end)
            
            local tempString = vehicle.Name
            W9f408f5de:FireServer("ReturnOwnedGarageItems", game.Players.LocalPlayer, tempString)

[trail drift]

didnt u turn it into 1 loop?

[loud herald]

i havent gotten the chance yet

[trail drift]

do that

[loud herald]

ive been respondin lol

aight

[trail drift]

when the gui opens connect a renderstepped connection

have a list of vehicle models

loop thro the list and update

[loud herald]

so in a singular renderstepped, i go through all the items and make them spin?

[limber thunder]

** You are now Level 5! **

[loud herald]

yay lvl 5

im more yellow

[trail drift]

yes

[loud herald]

i changed it but the fps still drops

        local testList = {}
        
        for _,model in SpawningFrame.VehicleList:GetDescendants() do
            if model:IsA("Model") and model.Parent:IsA("ViewportFrame") then
                table.insert(testList, model)
            end
        end
        
        game:GetService("RunService").RenderStepped:Connect(function()
            if SpawningFrame.Visible == false then return end
            
            for i=1, #testList do
                local vehicle = testList[i]
                vehicle:PivotTo(vehicle.WorldPivot * CFrame.fromEulerAnglesXYZ(math.rad(0), math.rad(-0.5), math.rad(0)))
            end
        end)

[trail drift]

ok

i gotta eat i will be back in like

30 mins

meanwhile check out

os.clock and try to limit the rate

[trail drift]

also this

[loud herald]

changed it to do that

        game:GetService("RunService").RenderStepped:Connect(function()
            if SpawningFrame.Visible == false then return end
            
            for i=1, #testList do
                local vehicle = testList[i]
                vehicle:PivotTo(vehicle.WorldPivot * CFrame.fromEulerAnglesXYZ(math.rad(0), math.rad(-0.5), math.rad(0)))
            end
        end)

it still drops fps

im thinking of making the spinning into an animation t loops but idk how i would do that

using the tween service to move to a rotation would just find the quickest route of doing that

[trail drift]

alright im back

ok first

hmm

i think the core solution would be to only update those visible honestly

[loud herald]

yeah

the issue im thinking abt in your example is the fact theres gaps between the items

[trail drift]

oh ye that could cause problems

hmm

[loud herald]

which could make the one on the edge which is visible not spin

who knew a spinning car would cause this huge issue

[trail drift]

aa wait

[loud herald]

?

[trail drift]

https://create.roblox.com/docs/reference/engine/classes/WorldRoot#BulkMoveTo

there we go

[loud herald]

holy crap

it just moves all of them like its one thing

[trail drift]

though its not for models

which is annoying

gah

[loud herald]

GOD DANG IT

wait

[trail drift]

wait

[loud herald]

it uses cframe

[trail drift]

print position of

vehicle 1 and 2 for me

[loud herald]

worldpivot is a cframe

[trail drift]

like are the

positions same

[loud herald]

uh

[trail drift]

or are they diff for each vehicle

[loud herald]

oh

they shouldnt but i can check

[trail drift]

ye check that rq

[loud herald]

they are the same

it prints the same positon 20 times (the amount of vehicles i have) then its positon print is different

[trail drift]

ok nice

then we can do

local LastUpdate = os.clock()
local UpdateRate = 0.1
local CF = vehicle.WorldPivot
game:GetService("RunService").RenderStepped:Connect(function()
if SpawningFrame.Visible == false then return end
if os.clock() - LastUpdate >= UpdateRate then

    CF = CF * CFrame.fromEulerAnglesXYZ(math.rad(0), math.rad(-0.5), math.rad(0))
    for i,v in testList do
        v:PivotTo(CF)
    end
    
end

end)

try this

ah mb

local LastUpdate = os.clock()
local UpdateRate = 0.1
local CF = vehicle.WorldPivot
game:GetService("RunService").RenderStepped:Connect(function()
if SpawningFrame.Visible == false then return end
if os.clock() - LastUpdate >= UpdateRate then
LastUpdate = os.clock()
CF = CF * CFrame.fromEulerAnglesXYZ(math.rad(0), math.rad(-0.5), math.rad(0))
for i,v in testList do
v:PivotTo(CF)
end

end

end)

[loud herald]

?

[trail drift]

there we go forgot something

fixed it

try this

[loud herald]

brb

back

so

i would like to give news

it changed the fps

not in a good way ;-;

this is what the imported version you gave me looks like

        game:GetService("RunService").RenderStepped:Connect(function()
            if SpawningFrame.Visible == false then return end
            
            for i=1, #testList do
                local vehicle = testList[i]
                local LastUpdate = os.clock()
                local UpdateRate = 0.1
                local CF = vehicle.WorldPivot
                game:GetService("RunService").RenderStepped:Connect(function()
                    if SpawningFrame.Visible == false then return end
                    if os.clock() - LastUpdate >= UpdateRate then
                        LastUpdate = os.clock()
                        CF = CF * CFrame.fromEulerAnglesXYZ(math.rad(0), math.rad(-0.5), math.rad(0))
                        for i,v in testList do
                            v:PivotTo(CF)
                        end

                    end

                end)
            end
        end)

i had to put it there cuz vehicle is not defined outside the for loop

[heavy cradle]

import every model into blender, export it back into studio as solid fbx

's

and spin them

[trail drift]

noo not like that

[heavy cradle]

less part count

[trail drift]

that will make it worse

[loud herald]

😭

[trail drift]

do not put it inside

the loop

i sent u the loop itself

[heavy cradle]

what

[loud herald]

theres a reason the cars arent a solid model ;-;

[heavy cradle]

what

dont tell me so they can drive

[loud herald]

the sections need the colors to be able to be customized

[loud herald]

YES

[heavy cradle]

they need to drive in the viewport frame 🙏

[loud herald]

i am not taking a model and putting it through blender to pull back a solid model for every single car i add to my game bro

[heavy cradle]

then optimize the fucking script

[limber thunder]

** You are now Level 6! **

[loud herald]

what do you think im trying to do

this whole chat is based on optimization

read the title bro ;-;

[heavy cradle]

why are you useing renderstepp

js tween it

[loud herald]

ok

[loud herald]

it uses the worldpivot since origin is read only

        game:GetService("RunService").RenderStepped:Connect(function()
            if SpawningFrame.Visible == false then return end
            
            for i=1, #testList do
                local vehicle = testList[i]
                
                local tweenservice = game:GetService("TweenService")
                local info = TweenInfo.new(1, Enum.EasingStyle.Linear, Enum.EasingDirection.Out)
                
                local prop = {
                    WorldPivot = vehicle.WorldPivot * CFrame.fromEulerAnglesXYZ(math.rad(0), math.rad(-180), math.rad(0))
                }
                
                local anim = tweenservice:Create(vehicle, info, prop)
                anim:Play()
            end
        end)

[trail drift]

if u do it the tween way

do not

put it in rendersevice

just make 1 tween and play it for each car

no need for a loop

[loud herald]

for i=1, #testList do
local vehicle = testList[i]

            local tweenservice = game:GetService("TweenService")
            local info = TweenInfo.new(1, Enum.EasingStyle.Linear, Enum.EasingDirection.Out)

            local prop = {
                WorldPivot = vehicle.WorldPivot * CFrame.fromEulerAnglesXYZ(math.rad(0), math.rad(-360), math.rad(0))
            }

            local anim = tweenservice:Create(vehicle, info, prop)
            anim:Play()
        end

it doesnt move the vehicle at all

just changes the world pivot

[glass moat]

why dont u just rotate the camera of viewportframe instead of rotating the model

[loud herald]

the camera is offset i dunno how i would do that

and i suck at math

wait

WAIT

i got an idea

[glass moat]

u change the camera orientation and position

[loud herald]

yeah thats why i said i suck at math, the position would need to be determined

but

i got idea

[glass moat]

AI exists

[loud herald]

i dont wanna use ai

i wanna learn ;-;

[glass moat]

U cant learn if u cant progress, if u use AI wisely and learn how it work, u'd progress

even seniors use AI , it's not a biggie as long u understand what does it do