Why isn't this variable being incremented by 1?

[true flame]

LOCAL SCRIPT

while(true) do
    
    totalStancePoints = char:GetAttribute("StancePoints")
    
    
    if totalStancePoints == nil then
        totalStancePoints = 4
    end
    
    totalStancePoints += 1
    if totalStancePoints > 4 then
        totalStancePoints = 4
    end
    
    warn(totalStancePoints)
    
    setStancePoints:FireServer(totalStancePoints)
    updateStanceGUIEvent:Fire(totalStancePoints)
    
    task.wait(1)
end

SERVER SCRIPT
setStancePoints function:

local rs = game:WaitForChild("ReplicatedStorage")
local setStancePoints = rs.SetStancePoints

local stateManager = require(rs.StateManager)

setStancePoints.OnServerEvent:Connect(function(plr, number)
    
    stateManager.SetPermState(plr, "StancePoints", number)
    
end)

MODULE SCRIPT
stateManager function:

function module.SetPermState(plr, stateKey, value)

    plr:SetAttribute(stateKey, value)
    
end

File Locations:

[gritty yoke]

Both client and server get their own versions of StateManager when they require it. They do not share it. Two copies, not the same one

[true flame]

so they dont communicate together?

[gritty yoke]

Nope

[latent dock]

Aren't you supposed to use setattribute?

[true flame]

but im calling the server script to call stateManager, so the attribute gets changed there, then I get the wanted attribute by doing plr/char:GetAttribute()
or does that change nothing?

[true flame]

ill try that

might just be complicating my life here

[latent dock]

From my knowledge getattributes = 4 doesn't create the attribute or change it

[white crane]

They fire a remote to change it

[true flame]

doesn't change anything

[white crane]

Although just taking the raw value from remote is bottom 1 ideas

Exploiters finna have a field day with this one

[latent dock]

I was talking about your local script

I don't think totalstancepoints = 4 would work.

[white crane]

They're firing a remote to set the attribute

[true flame]

i dont understand script security that much, it's my first game and all i know about it is give little to nothing to the client and all to the server

[gritty yoke]

Rule #1 is you can't trust what the client is giving the server, so you have to validate what they send to ensure it makes sense.

So the best thing to do is have as little situations as is needed where the client has to send things

[white crane]

Doing everything on server isn't necessarily good

[true flame]

aaaaaaaaaaahh okay

[latent dock]

Isn't firing a remote event every second inefficient when everything in the local script can be done on server

[true flame]

i need the player but i dont know how i would get the player in a server script

wait

starterplayerscripts would prolly work no?

[white crane]

Depends where the script is

[latent dock]

For _ players on players:getplayers

Assuming you already made players

[true flame]

wdym

[white crane]

He's saying to iterate through all players and run the function on server

[true flame]

OHHH okay yeah

i could actually

[latent dock]

local Players = game:GetService("Players") -- Get the Players service

for _, player in Players:GetPlayers() do -- Loop through each player
    print(player.Name) -- Print the name of the current player
end

Ik it's ai but I don't have access to my computer rn

[true flame]

would sending data from the server to the client as bad as sending data from the client to the server?

[fair quarry]

** You are now Level 9! **

[white crane]

Attributes automatically replicate

[true flame]

ah

[elder sand]

exploiters and cheaters are gonna love your game setStancePoints:FireServer(9999999999)