Issue with chat tags

[solid epoch]

I have a very good idea of chat tags but for some reason I just cant get this right. It replaces the players name.

local MarketplaceService = game.MarketplaceService
local ReplicatedStorage = game.ReplicatedStorage
local TextChatService = game.TextChatService
local Players = game.Players

local event = ReplicatedStorage:WaitForChild("TagEvent")

TextChatService.OnIncomingMessage = function(message)
    if not message.TextSource or not message.TextSource.UserId then
        return
    end
    
    local properties = Instance.new("TextChatMessageProperties")

    local plr = Players:GetPlayerByUserId(message.TextSource.UserId)
    if not plr then return end

    print("Made it past checks")

    local tags = {}

    if plr:GetAttribute("VIP") then
        table.insert(tags, "VIP")
    end

    if plr:GetAttribute("Donator") then
        table.insert(tags, "Donator")
    end

    if #tags == 1 then
        local tag = "["..tags[1].."]"
        properties.PrefixText = "["..tags[1].."]"
    elseif #tags == 2 then
        properties.PrefixText = "["..tags[1].."] ["..tags[2].."]"
    end
    
    return properties
end

[rain moss]

https://create.roblox.com/docs/chat/examples/group-chat-tags

[solid epoch]

replaces my name

[rain moss]

im not chatgpt

[rain moss]

do your homework

[solid epoch]

Im looking at the code and im doing it fine its just replacing my username

[rain moss]

let's workshop that for a second - so you say your code is fine, yes?

[solid epoch]

yep. Seems like it would work like the one on the forum

[rain moss]

but at the same time it's not fine because it shouldn't be replacing your username, correct?

[solid epoch]

and thats why im asking for help. I have no idea whats going wrong. It looks fine

[rain moss]

just work with me on this - so it's not fine because it shouldn't be replacing your username, yes?

[solid epoch]

Yes. I meant it looks fine mb

[rain moss]

so.. how can your code be both fine and not fine at the same time? schrodinger's script? wot

[delicate loom]

can u just help the guy?

golly

[solid epoch]

Exactly 😭

[rain moss]

go for it

[delicate loom]

i am here for help to but just cus someone dosent know how code workds dosent mean u gotta be rude about it

[solid epoch]

Pro scripters when a new scripter asks for help in a scripting help channel

https://tenor.com/view/angry-thiago-mad-angry-fist-emoji-gif-17761307

[rain moss]

i realize you don't understand what i'm trying to do with this, but i dont see this as rude

"my code is fine, but it's also not working" is a factual impossibility. the first step to fixing your code is accepting that it is not fine.

[delicate loom]

ngl ur reminding me of a dad whos teaching his son a leson bc he stole a piece of candy

[rain moss]

if you want to call that rude, well, idk what to tell you 🤷

[delicate loom]

ok i apoligize rude was taking it too far

[solid epoch]

Well ik something is wrong its just it looks fine and the devforum doesnt explain anything really

[rain moss]

attention to detail is extremely important, so is debugging

like if you put a capital where you shouldn't, that can break things. if you leave out some small punctuation, it can break things

[solid epoch]

Ive spent a hour on this. I just need someone to tell me whats wrong so I can learn from it in the future

[delicate loom]

cosmic thinks the code is fine but he dosent know if it is or isnt so hes asking if the the code is wrong or something else is wronng is that right?

oh i type slow mb

[solid epoch]

if I never get a answer ill just give up since ive spent hours tryna debug it.

[rain moss]

that's a really simple question to answer - is the code working? then it is fine. is it not working? not fine.

[rain moss]

perhaps one of the most important things you can learn from this is reducing the problem. the docs page i linked gives you an example of doing chat tags. try that example. if that works for you, then you have a starting point of working out why that works and yours does not.

[delicate loom]

thats not ture i made a menu but it didnt work because it didnt have the same parent as the button to open it so in that case it wouldnt be the code

[solid epoch]

I am not spending another hour rewriting it. I just want to know why it went wrong.

[rain moss]

you couldn't ask for an easier process of this reduction - just take the docs-given working code. under most other circumstances, you have to remove stuff from your code until you get down to the crux of it

[solid epoch]

Then I can understand for my future stuff so im doing to not do it again 😭

[rain moss]

here's what i did. i took the example from the docs, and added one line: print(message.PrefixText). that would not have taken you an hour. ```lua
local Players = game:GetService("Players")
local TextChatService = game:GetService("TextChatService")

TextChatService.OnIncomingMessage = function(message: TextChatMessage)
print("prefix text:",message.PrefixText)
local textSource = message.TextSource
if textSource then
local player = Players:GetPlayerByUserId(textSource.UserId)
if player then
if player:GetAttribute("IsVIP") == true then
local overrideProperties = Instance.new("TextChatMessageProperties")
overrideProperties.PrefixText = "[VIP] " .. message.PrefixText
return overrideProperties
end
end
end

return nil

end```

this snippet is purely the docs code + the print i added.

i threw it in a localscript in starterplayerscripts and checked the output.

not so hard this debugging this now is it?

and when i read the output, would you look at that. it's my name!!

[solid epoch]

My system is much different then this

[silk jungle]

** You are now Level 15! **

[rain moss]

why pick on the prefixtext? well, that's the only thing about the message your code is changing. looks like you set the prefix, whereas in the docs, it appends to the prefix with [vip] .. existing_prefix_text

[rain moss]

that's exactly why i'm saying to take the example from the docs - reduce the problem - eliminate all possible causes, remove any possible interference to make process of elimination faster and easier.

and the reason why i'm focusing on this is because if you don't learn how to do that, you are going to have a hard time coding in the future. reliance on asking for help is not practical in the long term.

so instead of just giving you an answer, i showed you how to reach the answer for yourself.

[solid epoch]

alr

[rain moss]

if you want to consider that rude, well, not much more i can do to help you short of doing everything for you like i did by giving you the answer just now 🤷

coz believe it or not, giving out direct answers without showing how i came to that answer, is not helpful. it just makes you more and more dependent on asking for help instead of solving your own problems

[rain moss]

and by doing so, actually helping people instead of spoonfeeding answers, i'm told that i am being rude. i really don't know why i bother anymore

[solid epoch]

I actually just suck at debugging its not even funny atp 😭

I actually just cant spot whats wrong. Is there any ways I can improve or.

[rain moss]

well i hope you have learned at least one new technique today for debugging. reduce the problem. take existing working code and compare it to yours, look for the smaller details, always print your outputs. never assume you know what the code is doing. always check what it is actually doing via prints or breakpoints etc

coz a simple print of the prefixtext before and after you change it would have answered your question before you asked it ;o