can someone tell me how to fix or fix my leaderstats savedata script? | Roblox Studio Community | Page 1

midnight kraken Aug 12, 2025, 10:07 AM

#

local dataStore = game:GetService("DataStoreService")
local data = dataStore:GetDataStore("Stats")
game.Players.PlayerAdded:Connect(function(Player)
local leaderstats = Instance.new("Folder")
leaderstats.Name = "leaderstats"
leaderstats.Parent = Player

local Cash = Instance.new("IntValue")
Cash.Name = "Cash"
Cash.Parent = leaderstats

local worlds = Instance.new("IntValue")
worlds.Name = "Worlds"
worlds.Parent = leaderstats

local coinValue = data:GetAsync(Player.UserId.."Cash")
local WorldsValue = data:GetAsync(Player.UserId.."worlds")

if coinValue ~= nil then
    Player.leaderstats.Cash.Value = coinValue
end
if WorldsValue ~= nil then
    Player.leaderstats.Worlds.Value = WorldsValue
end

end)

game.Players.PlayerRemoving:Connect(function(Player)

local sucess, errorMsg = pcall(function()
    data:SetAsync(Player.UserId.."Cash", Player.leaderstats.Cash.Value)
    data:SetAsync(Player.UserId.."Worlds", Player.leaderstats.worlds.value)
end)
if errorMsg then
    print("error")
end

end)

cursive jewel Aug 12, 2025, 10:12 AM

#

Im not a scripting expert but maybe its something to do with the values like the cash and your world.

stuck veldt Aug 12, 2025, 10:16 AM

#

I haven't looked into the script much but I pasted it into roblox studio

#

You have a syntax error at line 32

#

Missing the capital letters on "worlds" and "value".

cursive jewel Aug 12, 2025, 10:17 AM

#

oo i got a stupid question have you enabled api

stuck veldt Aug 12, 2025, 10:17 AM

#

^

tiny pond Aug 12, 2025, 10:18 AM

#

local dataStore = game:GetService("DataStoreService")
local data = dataStore:GetDataStore("Stats")

game.Players.PlayerAdded:Connect(function(player)
local leaderstats = Instance.new("Folder")
leaderstats.Name = "leaderstats"
leaderstats.Parent = player

local cash = Instance.new("IntValue")
cash.Name = "Cash"
cash.Value = 0  -- Default value
cash.Parent = leaderstats

local worlds = Instance.new("IntValue")
worlds.Name = "Worlds"
worlds.Value = 0  -- Default value
worlds.Parent = leaderstats

-- Load data with error handling
local success, cashValue = pcall(function()
    return data:GetAsync(player.UserId.."-Cash")
end)

local worldsSuccess, worldsValue = pcall(function()
    return data:GetAsync(player.UserId.."-Worlds")
end)

-- Apply loaded data if successful
if success and cashValue ~= nil then
    player.leaderstats.Cash.Value = cashValue
end

if worldsSuccess and worldsValue ~= nil then
    player.leaderstats.Worlds.Value = worldsValue
end

end)

game.Players.PlayerRemoving:Connect(function(player)
pcall(function()
data:SetAsync(player.UserId.."-Cash", player.leaderstats.Cash.Value)
data:SetAsync(player.UserId.."-Worlds", player.leaderstats.Worlds.Value) -- Capitalized 'W'
end)
end)

#

@midnight kraken

#

midnight kraken Aug 12, 2025, 10:26 AM

#

@tiny pond pasted and still not working

#

@cursive jewel yes i enabled api

tiny pond Aug 12, 2025, 10:26 AM

#

midnight kraken <@1353981361685270528> pasted and still not working

Wait brochacho

#

midnight kraken Aug 12, 2025, 10:27 AM

#

and disabled other script

#

old leaderstats

tiny pond Aug 12, 2025, 10:30 AM

#

midnight kraken and disabled other script

K so i did it but its lowk long imma send it in three part

#

local dataStore = game:GetService("DataStoreService")
local data = dataStore:GetDataStore("PlayerStats") -- Changed name to avoid conflicts

-- Throttle variables to prevent datastore limits
local lastSaveTime = {}
local minSaveInterval = 30 -- Seconds between saves

game.Players.PlayerAdded:Connect(function(player)
-- Create leaderstats folder
local leaderstats = Instance.new("Folder")
leaderstats.Name = "leaderstats"
leaderstats.Parent = player

-- Create Cash value
local cash = Instance.new("IntValue")
cash.Name = "Cash"
cash.Value = 0
cash.Parent = leaderstats

-- Create Worlds value
local worlds = Instance.new("IntValue")
worlds.Name = "Worlds"
worlds.Value = 0
worlds.Parent = leaderstats

#

-- Load data with retries and error handling
local function loadData()
local success, err = pcall(function()
-- Use combined key to minimize requests
local combinedData = data:GetAsync(player.UserId.."-AllStats")

        if combinedData then
            if combinedData.Cash then
                player.leaderstats.Cash.Value = combinedData.Cash
            end
            if combinedData.Worlds then
                player.leaderstats.Worlds.Value = combinedData.Worlds
            end
        else  -- Try legacy keys if combined doesn't exist
            local cashValue = data:GetAsync(player.UserId.."-Cash")
            local worldsValue = data:GetAsync(player.UserId.."-Worlds")
            
            if cashValue then
                player.leaderstats.Cash.Value = cashValue
            end
            if worldsValue then
                player.leaderstats.Worlds.Value = worldsValue
            end
        end
    end)
    
    if not success then
        warn("DATA LOAD ERROR for "..player.Name..": "..tostring(err))
        -- Retry after delay
        task.wait(math.random(2, 5))
        loadData()
    else
        print("Data loaded for "..player.Name)
    end
end

-- Delay initial load to prevent throttling
task.wait(1)
loadData()

end)

#

-- Save data function
local function savePlayerData(player)
-- Skip if recently saved
if lastSaveTime[player.UserId] and (os.time() - lastSaveTime[player.UserId] < minSaveInterval) then
return
end

local success, err = pcall(function()
    -- Combine data into single table
    local combinedData = {
        Cash = player.leaderstats.Cash.Value,
        Worlds = player.leaderstats.Worlds.Value
    }
    
    data:SetAsync(player.UserId.."-AllStats", combinedData)
    lastSaveTime[player.UserId] = os.time()
end)

if not success then
    warn("DATA SAVE ERROR for "..player.Name..": "..tostring(err))
else
    print("Data saved for "..player.Name)
end

end

-- Save on player leaving
game.Players.PlayerRemoving:Connect(function(player)
savePlayerData(player)
end)

-- Auto-save every 5 minutes
while task.wait(300) do -- 5 minutes
for _, player in ipairs(game.Players:GetPlayers()) do
savePlayerData(player)
end
end

midnight kraken Aug 12, 2025, 10:35 AM

#

still not working it says saved data but when i open the game agian data doesnt save

📎 message.txt

#

that thing is output

tiny pond Aug 12, 2025, 10:39 AM

#

midnight kraken still not working it says saved data but when i open the game agian data doesnt ...

Dm le

#

Me

ashen temple Aug 12, 2025, 10:49 AM

#

midnight kraken still not working it says saved data but when i open the game agian data doesnt ...

Are you trying to access the datastore from the client???

midnight kraken Aug 12, 2025, 10:49 AM

#

No it is a normal script in server script servixe

keen turtleBOT Aug 12, 2025, 10:49 AM

#

studio ** You are now Level 1! ** studio

midnight kraken Aug 12, 2025, 10:49 AM

#

@ashen temple

ashen temple Aug 12, 2025, 10:50 AM

#

Also, how are you editing the data when testing

midnight kraken Aug 12, 2025, 10:50 AM

#

Changing in leaderstats folder

#

Inside a player

ashen temple Aug 12, 2025, 10:50 AM

#

You're making sure to swap to the server before editing it, right

#

by pressing this

midnight kraken Aug 12, 2025, 10:51 AM

#

Oh thats why

#

I will check i its working and tell u

#

It works tyyy

ashen temple Aug 12, 2025, 10:53 AM

#

You'd be surprised how many times the problem is just that lol

gilded badge Aug 12, 2025, 12:52 PM

#

@midnight kraken Hello, you still need help?

midnight kraken Aug 12, 2025, 1:36 PM

#

No it workshop now

#

Works

#

Not workszop

gilded badge Aug 12, 2025, 3:01 PM

#

midnight kraken No it workshop now

you should use Profile Store instead of basic data store

midnight kraken Aug 12, 2025, 3:01 PM

#

Idk how to do it

#can someone tell me how to fix or fix my leaderstats savedata script?