character pivot position after swapping characters

[spiral nexus]

i am attempting to replicate the genshin character swapping mechanic, but the issue is that after swapping characters, the player's pivot point locks in place and no longer follows the model (video). this breaks future swaps as well as parkour mechanics, and i don't know why. vaulting also seems to reset the pivot point. how can i fix this?

client:

Switch = function() events.Combat.Switch:FireServer(chr:GetPivot()) end,

server:

local ReplicatedStorage = game:GetService("ReplicatedStorage")
local ServerStorage = game:GetService("ServerStorage")
local events = ReplicatedStorage.Events

local CharacterStats = require(ServerStorage.CharacterStats)
local PlayerWatcher = require(ServerStorage.PlayerWatcher)

local function Transfer(old, new)
    for _, i in pairs(old:GetChildren()) do
        if i:IsA("BaseScript") then
            i.Parent = new
        end
    end
end

events.Combat.Switch.OnServerEvent:Connect(function(plr, location: CFrame)
    local chr = plr.Character
    local hum = chr:FindFirstChildOfClass("Humanoid")
    local Player = PlayerWatcher:GetPlayer(plr)
    if not Player.CanSwitchCharacters then return end
    
    PlayerWatcher:Update(plr, "CanSwitchCharacters", false)
    PlayerWatcher:Update(plr, "CurrentCharacter",  (Player.CurrentCharacter % 3) + 1)
    plr:SetAttribute("Switching", true)
    
    task.delay(1, function()
        PlayerWatcher:Update(plr, "CanSwitchCharacters", true)
    end)
    
    local NextName = CharacterStats.Characters[Player.CurrentCharacter].Name
    local found: Model = ServerStorage.Characters:FindFirstChild(NextName == "Player" and plr.Name or NextName):Clone()
    
    local ScriptHolder = Instance.new("Folder")
    ScriptHolder.Parent, ScriptHolder.Name = script, plr.UserId
    hum.Parent = script
    Transfer(chr, ScriptHolder)
    for _, ToArchive in pairs(found:GetDescendants()) do ToArchive.Archivable = true end
    found:PivotTo(location)
    chr:ClearAllChildren()
    for _, instance in pairs(found:GetChildren()) do instance.Parent = chr end
    hum.Parent = chr
    Transfer(ScriptHolder, chr)
    found:Destroy()
    ScriptHolder:Destroy()
    
    plr:SetAttribute("Switching", false)
end)

for reference, this is what it normally looks like

this is the vaulting logic as well, i don't know what could be reseting the pivot point to the new location here

Jump = function()
        if not plr:GetAttribute("CanJump") then return end
                
        if plr:GetAttribute("Sprinting") then
            local hrp: Part = chr:WaitForChild("HumanoidRootPart")
            local lv = hrp.CFrame.LookVector
            
            local params = RaycastParams.new()
            params.FilterDescendantsInstances = {chr}
            params.FilterType = Enum.RaycastFilterType.Exclude
            
            local step = 0.5
            local dLen = 1.26
            local studs = 8
            
            local p = hrp.Position - Vector3.new(0, dLen, 0)
            local VaultCheck = workspace:Raycast(p, lv * (studs - 2), params)
            visualize.Line(p, VaultCheck and VaultCheck.Position or p + (lv * (studs - 2)))
            
            local VaultCheck2 = workspace:Raycast(p + Vector3.new(0, dLen, 0), lv * (studs - 2), params)
            visualize.Line(p + Vector3.new(0, dLen, 0), VaultCheck2 and VaultCheck2.Position or (p + Vector3.new(0, dLen, 0)) + (lv * (studs - 2)))
            if VaultCheck2 and VaultCheck2.Position then hum.JumpPower = 50 return end
            
            if VaultCheck and VaultCheck.Position then
                visualize.Point(VaultCheck.Position)
                
                local CheckPart = Instance.new("Part")
                CheckPart.CanCollide, CheckPart.CanTouch, CheckPart.CanQuery = false, false, false
                CheckPart.Transparency = 1
                CheckPart:PivotTo(CFrame.new(VaultCheck.Position + Vector3.new(0, dLen, 0)) * hrp.CFrame.Rotation)
                CheckPart.Rotation = hrp.Rotation
                CheckPart.Parent = workspace
                
                local CheckPos = CheckPart.Position
                visualize.Point(CheckPos)
                
                local CanVault, endPos

for i = 0, studs / step, 1 do
                    local sPos = CheckPos + lv * i * step
                    local ray = workspace:Raycast(sPos, lv * step, params)
                    local ePos = ray and ray.Position or sPos + lv * step
                    visualize.Line(sPos, ePos)

                    if ray and ray.Position then
                        CanVault, endPos = true, ePos
                        visualize.Point(ePos)
                        break
                    else
                        local sPos2 = ePos
                        local down = workspace:Raycast(sPos2, Vector3.new(0, -dLen, 0), params)
                        local ePos2 = down and down.Position or sPos2 + Vector3.new(0, -dLen, 0)

                        visualize.Line(sPos2, ePos2)

                        if not down then
                            CanVault, endPos = true, sPos2
                            break
                        else visualize.Point(ePos2); continue end
                    end
                end

                if CanVault and endPos then
                    plr:SetAttribute("CanJump", false)
                    plr:SetAttribute("Vaulting", true)
                    chr:PivotTo(CheckPart:GetPivot())
                    local VaultOver, elapsed = nil, 0
                    VaultOver = RunService.Heartbeat:Connect(function(dt)
                        if not hrp then VaultOver:Disconnect() return end
                        elapsed += dt * 5
                        if elapsed > 1 then VaultOver:Disconnect() end
                        chr:PivotTo(CheckPart.CFrame:Lerp(CFrame.new(endPos) * CheckPart.CFrame.Rotation, elapsed))
                    end)
                    task.delay(0.5, function()
                        plr:SetAttribute("CanJump", true)
                    end)
                else hum.JumpPower = 50 end
                CheckPart:Destroy()
            else hum.JumpPower = 50 end
        else hum.JumpPower = 50 end
    end,

[cinder owl]

i'd imagine you could duplicate the new charactermodel, set its pivot to the same as the current player character, change the model name, then just do

player.Character = *yourcharactermodel*

afterwards delete the old character model

[spiral nexus]

that would trigger stuff that happens on .CharacterAdded

[torpid timber]

Are you selecing the player model again?

*selecting

it seems like you arent

try selecting it again after switching

[spiral nexus]

what would that have to do with the code?

[torpid timber]

Well, sometimes if something is deleted, the pivot will stay the same until deletedunselection

[spiral nexus]

either way, i just did this and it still is locked at the location where the first swap happened

[cinder owl]

is there anyway you could create a character swapping indicator that blocks the .characteradded event from running?

[torpid timber]

ah

[spiral nexus]

i would have to rework everything

that would also reset the gui

[cinder owl]

you can disable the "resetonspawn" property to fix that im pretty sure

[spiral nexus]

what about the red vignette that appears on death

[cinder owl]

do you mean the healthbar? you could temporarily disable it during the character swap

[spiral nexus]

the vignette that appears for like 1 frame upon death would ruin the immersion

[cinder owl]

fair enough, im out of ideas, sorry. 😔

[solemn idol]

similar post ive seen: https://devforum.roblox.com/t/how-to-achieve-a-character-swap-system/2483558/2

i mean you would prob use plr.Character = newModel

that way roblox camera and stuff would rebind to the new model

[spiral nexus]

not a good idea for what im trying to do

[cinder owl]

i suggested that but as OP said the death vignette ruins immersion

[solemn idol]

prob by making a custom death vignete

i remember making a custom death vignette last time

heck it was 10x better because of custom tweening

[cinder owl]

you could also make a slight "fake" loading screen that pops up for a second or so when you swap characters

[spiral nexus]

i would also have to rework all the main combat systems if i just did this

[spiral nexus]

the player will be swapping characters often in combat as the games combat is heavily reliant on character combos

[solemn idol]

atleast its more optimized otherwise stick to making a custom vignette and stuff

[waxen jolt]

** You are now Level 5! **

[cinder owl]

you can do that? could you link a thread, i really wanna learn this.

[spiral nexus]

not that its more optimized it would just be more annoying to work with

its more convenient to have the advanced stuff in one event

rather than having to change everything else

[solemn idol]

fair workaround. i guess make a custom vignette is more ideal

[spiral nexus]

i just said that making a custom vignette would be more work since all other systems will need to be rework

[spiral nexus]

one line.

one

fucking line

chr.PrimaryPart = chr:WaitForChild("HumanoidRootPart")

💔

[solemn idol]

oh that worked?

W