Script ignoring the loop, gives only 1 item instead of desired quantity

[dull mauve]

Player press purchase button > player recieves 1 item, if they didnt press the up or down arrows the price is 1 even though its supposed to be 15, it gives 1 item instead of giving the desired quantity.

loop at lines 34 to 40

[spiral flume]

can you print out the qunum variable and amountloop variable before the loop?

[grave moon]

maybe

 for i = 1, qnum do
-- code here
end

also why you doing code on the client for purchasing things

use a remote event to the server to check if plr has enough money for the transaction and then clone stuff on the server

cause if you do it on a local script, only you (the client) will see it

[dull mauve]

i'll try that

[dull mauve]

convienence

[dull mauve]

alright

[grave moon]

yummy double ping

triple*

[dull mauve]

mb

[grave moon]

nah its ok

[dull mauve]

shitty wifi

[dull mauve]

im aware

i'll paste the entire code into a server side script

except the button:connect bit

[grave moon]

yeah but tey to fix ur bug first

try

I suggested a for loop which will loop till it reaches the max provided index

that being qnum

[dull mauve]

bad idea

i'll just cut out the clone bits

[dull mauve]

problem is i dont know what to use as a fire

or something

[dull mauve]

alright

so like this?

[grave moon]

create a remote event somewhere in replicated storage, and the on a Script, use RemotEvent.OnServerEven:Connect(function(player,data)
-- code here
end)

[grave moon]

don't change quantity balue

value

[dull mauve]

alright

[dull mauve]

im making it into a remotefunction instead of a remote event

[grave moon]

alr

[grave moon]

you connect remote functions differently so:
RemoteFunction.OnServerInvoke = function(plr,data)

end

[dull mauve]

yeah

that was my intention

[dull mauve]

so like thi

or

[grave moon]

yeah remove the ")" at the end

idk

[dull mauve]

no thats the end)

for the button:connect

[grave moon]

then whys the buystock underlined

wth red

[dull mauve]

i dunno

fixed it tho

[grave moon]

alr

[digital osprey]

** You are now Level 8! **

[dull mauve]

alright on the serverside script i dunno

is this correct?

[grave moon]

no

[dull mauve]

oh so i do local function?

[grave moon]

proxy.OnServerInvoke = function(player,productClone)

return "Successfully bought item " .. productClone.Name
end

for remote functions u need to return

@dull mauve

[dull mauve]

yeah ik

ive seen

[dull mauve]

wait is that it

oh wait

[grave moon]

yes

[dull mauve]

really

[grave moon]

yes

[dull mauve]

huh

[grave moon]

proxy.OnServerInvoke = function(player,productClone)

 

return "Successfully bought item " .. productClone.Name
end

[dull mauve]

thought i was gonna have to add productclone:Clone()

in the serverside script

[grave moon]

you then just need to add the rest of code

i was just showing how to connect the onserverinvoke @dull mauve

[dull mauve]

oh

lmao

mb

[grave moon]

also

[dull mauve]

indexing nil with :clone()

[grave moon]

don't clone the product 2 times, u can just send the tool

[dull mauve]

im presuming the serverside script isnt reading productclone as a instance

[grave moon]

yh cuz u cloned it 2 times

[dull mauve]

oh

so this is once

[grave moon]

u don't need to clone it anymore on the client

[dull mauve]

right

i see

[grave moon]

you can just provide the product and the server will clone it

if money

[dull mauve]

okay so it fixed the problem... kind of

didnt really give me the desired quantity

[grave moon]

can u send output

[dull mauve]

oh and same error

when buying twice

[grave moon]

check line 30

of local script

[dull mauve]

thats invoking the server

wait cant i move productclone

[grave moon]

use invoke with the product, u don't need productclone anymore

[dull mauve]

yeah i was thinking of that

still isnt giving me the desired quantity

[grave moon]

hmmmm maybe instead of doing a for loop on the client

[dull mauve]

also same issure

[grave moon]

we can invoke the server the amount of products we want to clone

so

.OnServerInvoke = function(plr,product,amount)

[dull mauve]

alright

its still not reading product as an instance

[grave moon]

is it a tool

ur sending

@dull mauve

[dull mauve]

yeah

it is

[grave moon]

can it find the product

Try printing the product

[dull mauve]

it can

weirdly the second time I buy the product

it comes up with an error

[grave moon]

r u not doing
local newtool = tool:Clone()

and just doing tool:Clone() on the server

and it's just removing the tool entirely

[dull mauve]

yeah im not

i'll do local

like

[grave moon]

that should be the solution prolly

[dull mauve]

local newtool = tool:Clone()

[dull mauve]

i hope

OH IT FIXED IT

[grave moon]

yep

[dull mauve]

LES GOOOO

finally

a modular shop system

[grave moon]

@dull mauve make sure you're doing the currency math on the server

[dull mauve]

im not

sob

but the leaderstats are serversided

[grave moon]

can u show the serverscript

rq

[dull mauve]

wait

the leaderstats one

or

[grave moon]

not that

[dull mauve]

oh

[grave moon]

the shop one

[grave moon]

on the client u can send the item values

and on the server u can do a for loop

to then clone in player if has enough MONEY for the items

[dull mauve]

this local script does the math calculating

[dull mauve]

hmm i can do a if statement

[grave moon]

well if u get a hacker

he can maybe exploit it

and get infinite toolz

[dull mauve]

oh

[grave moon]

tools

[dull mauve]

so do i move the if statement to the server?

[grave moon]

yeah

[dull mauve]

alright

[dull mauve]

@grave moon

like this?

[grave moon]

yeah but place the return statement at the end at if the player has the cash

[dull mauve]

yeah i did

[dull mauve]

okay they now cost $1

but it says $15

[grave moon]

though if u get the due from startergui

it will get the default value

[dull mauve]

huh

do i send a

actually no im doing the serverinvoke

[grave moon]

you should maybe have a uhhhhhh

values of all the items cost in replicated storage

wait

set attributes on the tools

[dull mauve]

wdym

[grave moon]

Price: 1 (number)

go to ur tools

[dull mauve]

right

[grave moon]

And then set a price attribute

[dull mauve]

done

[grave moon]

then get the price times the amount

[dull mauve]

is this in the local script

[digital osprey]

** You are now Level 9! **

[dull mauve]

or the serverside

[grave moon]

Server side

[dull mauve]

right

[dull mauve]

im guessing like this

[grave moon]

get the cash by productclone:GetAttribute("Price")

[dull mauve]

oh okay

[grave moon]

and paste the productclone.parent when the player has enough money

[dull mauve]

i never really fiddled with attributes

[grave moon]

also do a for loop for the amount

for i=1, amount do end

then clone it and parent it to the player backpack @dull mauve

[dull mauve]

so like this?

[grave moon]

set the cash BEFORE the for loop

[dull mauve]

wdym

[grave moon]

and after the loop then return successfully purchased

[dull mauve]

OH

[dull mauve]

ah okay

[dull mauve]

alright is this better?

[grave moon]

Yep

and at the bottom if there's not enough cash

Return "not enough cash"

[dull mauve]

i think its the for i = 1 loop

in the local script

so i removed that

still nothing

[grave moon]

uhhhhhhhh

try printing the price and players cash @dull mauve

[grave moon]

oh ur not sending the amount

[dull mauve]

oh

wdym by amount

[grave moon]

the amount player wanna buy

invoke server with tool and amount of it

[dull mauve]

oh

oh wait

there we go

anddd

nope

[grave moon]

which line

did it error

[dull mauve]

29

same issue

[grave moon]

send img

[dull mauve]

just me being an idiot on accident

still nothing?

[grave moon]

send the server script

[grave moon]

don't do amount.Value

bru ur sending a number

no need for .value

[dull mauve]

oh

still the same error

on the local script

[grave moon]

show me it

[grave moon]

the script

[grave moon]

what's the amount thing ur sending

@dull mauve

[grave moon]

send the qnum

[dull mauve]

so which one do i put, amount or qnum

[grave moon]

try qnum

@dull mauve

[grave moon]

oh so qnum is a number

[dull mauve]

i think its beacuse of the

moneydue

[grave moon]

try to do

[dull mauve]

yep

[grave moon]

Tonumber() all of it

[dull mauve]

it was the moneydue

[grave moon]

now it doesn't get the tool

huh

[dull mauve]

no it doesnt get the tool on the second time someone buys it

[dull mauve]

alright fixed it

but still not giving the desired quantity

[dull mauve]

fixed it by adding :Clone() to product

[grave moon]

still?

[grave moon]

no you need to clone it in the for loop

[dull mauve]

yeah

[dull mauve]

so what do i remove local productclone = product**:Clone()**

(the bold text)

[grave moon]

you could remove it entirely
and then use it in the for loop

[dull mauve]

I cant

[grave moon]

wym

[dull mauve]

oh wait i can set

moneydue to product

anyways I gtg i'll be back in an hour or so

[grave moon]

Alr

hope i helped

[dull mauve]

yeah you did

but then ruined it i guess but whatever

We'll continue in the next hour

[dull mauve]

@grave moon

im back

[grave moon]

@dull mauve did you manage to fix it

[dull mauve]

nope

[grave moon]

What's the problem now

[dull mauve]

okay nevermind

[grave moon]

you fixed it?

[dull mauve]

yep

[dull mauve]

@grave moon

getting the same issue

[dull mauve]

but i dont know whats causing it

oh i see the issue