piece of code running unprovoked>

[inner jasper]

** You are now Level 6! **

[fair coyote]

local storage = script.Parent.Parent.current
local inzone = script.Parent.Inzone
local zone = script.Parent

zone.Touched:Connect(function(hit)
    local player = game.Players:GetPlayerFromCharacter(hit.Parent)
    if player then
        if hit.Parent:FindFirstChild("Humanoid") then
            inzone.Value = true
        end
    end
end)

zone.TouchEnded:Connect(function(hit)
    local player = game.Players:GetPlayerFromCharacter(hit.Parent)
    if player then
        if hit.Parent:FindFirstChild("Humanoid") then
            inzone.Value = false
        end
    end
end)

while task.wait() do
    local enemynum = #storage:GetChildren()
    
    if inzone.Value == true and enemynum < 5 then
        local enemy = game.ServerStorage.enemy:Clone()
        
        enemy.Parent = storage
        print("there is " ..enemynum.. " enemies!")
        task.wait(1)
    elseif inzone.Value == false and enemynum > 0 then
        print("Cleared "..enemynum.." enemies!")
        storage:ClearAllChildren()
    end
end

This is the main spawning lines

while task.wait() do
    local enemynum = #storage:GetChildren()
    
    if inzone.Value == true and enemynum < 5 then
        local enemy = game.ServerStorage.enemy:Clone()
        
        enemy.Parent = storage
        print("there is " ..enemynum.. " enemies!")
        task.wait(1)
    elseif inzone.Value == false and enemynum > 0 then
        print("Cleared "..enemynum.." enemies!")
        storage:ClearAllChildren()
    end
end

[quasi heath]

I'm imagining that the NPCs all manage to trigger TouchEnded at the same time, causing the "InZone" flag to be put down

There is a better way to approach this. A way that does not struggle with this issue

Use Zone.playerEntered and Zone.playerExited to learn when the player enters and leaves the zone

[fair coyote]

ill definitely be trying this out, though I will ask, how is it the NPCs if they never leave the zone either?

[fair coyote]

wait, what are these terms? They arent showing up

[quasi heath]

https://1foreverhd.github.io/ZonePlus/api/zone/#playerentered
https://1foreverhd.github.io/ZonePlus/api/zone/#playerexited

[fair coyote]

like this? Because this isnt printing anything

local zone = script.Parent

zone.playerEntered:Connect(function(player)
    print(player.. "touched zone")
end)

[fair coyote]

oh nevermind i see i need the plugin thing

[quasi heath]

Oh, lmfao

Sorry. I've slept poorly the past couple days. I thought you already were using this technology

[fair coyote]

all good, this is really my first time trying to make an actual game and scripting it by myself

[fair coyote]

So i fiddled with it, and it kinda works but now the delay between each enemy spawn is now gone unlike before

local field = workspace.field
local storage = field.current
local replicatedStorage = game:GetService("ReplicatedStorage")
local zonePlus = require(replicatedStorage.Zone)

local spawnZone = field.zone

local zone1 = zonePlus.new(spawnZone)

while task.wait(1) do
    zone1.playerEntered:Connect(function(player: Player)
        local enemynum = #storage:GetChildren()

        if enemynum < 5 then
            local enemy = game.ServerStorage.enemy:Clone()

            enemy.Parent = storage
            task.wait(1)
            print("there is " ..enemynum.. " enemies!")
        end    
    end)

    zone1.playerExited:Connect(function(player: Player)
        local enemynum = #storage:GetChildren()
        print("Cleared "..enemynum.." enemies!")
        storage:ClearAllChildren()
    end)
end

[cloud chasm]

why are you making connections inside while loop

[fair coyote]

does that not work? I just need it to constantly know someone is in the zone or not

[cloud chasm]

it works but will overwrite everything since you're creating 1000 connection per second

move it outside

same as the old code but with the ZonePlus

instead of roblox's touched and touchended

[cloud chasm]

plus memory leak

[fair coyote]

but wont i have to use 2 loops?

[cloud chasm]

no

what made you think you need another loop

[fair coyote]

well because i need to loop the playerEntered and playerExited no?

[cloud chasm]

no

[fair coyote]

?

[cloud chasm]

ZonePlus already have it handled internally

you jsut need to connect to that playerentered/exited event

[fair coyote]

wait im n=still not very good at arranging script. How do I put the connects on the outside of the loop while letting each function of them connect to their respective piece?

[cloud chasm]

^^

replace zone with ZonePlus's object

[fair coyote]

i did, but that script was before it was in ReplicatedStorage, so "field.zone" is the zone, and "zone1" is ZonePlus's objest connected to it if im understanding u right

pardon me if I sound oblivious, I've never even touched or heard of ZonePlus

[cloud chasm]

yes

[fair coyote]

thats what i have here right?

local field = workspace.field
local storage = field.current
local replicatedStorage = game:GetService("ReplicatedStorage")
local zonePlus = require(replicatedStorage.Zone)

local spawnZone = field.zone

local zone1 = zonePlus.new(spawnZone)

zone1.playerEntered:Connect(function(player: Player)
    local enemynum = #storage:GetChildren()

    if enemynum < 5 then
        local enemy = game.ServerStorage.enemy:Clone()

        enemy.Parent = storage
        task.wait(1)
        print("there is " ..enemynum.. " enemies!")
    end    
end)

zone1.playerExited:Connect(function(player: Player)
    local enemynum = #storage:GetChildren()

    print("Cleared "..enemynum.." enemies!")
    storage:ClearAllChildren()
end)

[cloud chasm]

local field = workspace.field
local storage = field.current
local replicatedStorage = game:GetService("ReplicatedStorage")
local zonePlus = require(replicatedStorage.Zone)

local spawnZone = field.zone

local zone1 = zonePlus.new(spawnZone)

zone1.playerEntered:Connect(function(player: Player)
    inzone.Value = true
end)

zone1.playerExited:Connect(function(player: Player)
    inzone.Value = false
end)

while true do
    local enemynum = #storage:GetChildren()
    
    if inzone.Value == true and enemynum < 5 then
        local enemy = game.ServerStorage.enemy:Clone()
        
        enemy.Parent = storage
        print("there is " ..enemynum.. " enemies!")
        task.wait(1)

    elseif inzone.Value == false and enemynum > 0 then
        print("Cleared "..enemynum.." enemies!")
        storage:ClearAllChildren()
    end
end

[fair coyote]

oh i feel stupid now. I was also watching a video on zoneplus and the part where they put the extra logic in ZonePlus's playerEntered/Exited's function threw me off thinking thats everything that happens upon touch

[fair coyote]

got it working! Thanks so much! I had gotten rid of alot of my old code after working with zoneplus so i didnt even think to go back

[cloud chasm]

did you even take a look at their documentation?

[fair coyote]

a little bit, I was trying to read and implement as I go

[quasi heath]

This code has the potential to crash, and will not work in multiplayer

--!strict
local ReplicatedStorage = game:GetService("ReplicatedStorage")
local ServerStorage     = game:GetService("ServerStorage")


local ZonePlus = require(ReplicatedStorage.ZonePlus)

local Field   = workspace.Field
local Enemies = Field.Enemies
local Enemy   = ServerStorage.Enemy


local MAX_ENEMIES      = 5
local ENEMY_SPAWN_RATE = 1

local enemyZone         = ZonePlus.new(Field.Zone)
local enemySpawnProcess = nil :: thread?



local function spawnEnemies()
    for _ = 1, MAX_ENEMIES do
        Enemy:Clone().Parent = Enemies
        
        task.wait(ENEMY_SPAWN_RATE)
    end
end

local function onPlayerEntered()
    if not enemySpawnProcess then
        enemySpawnProcess = task.defer(spawnEnemies)
    end
end

local function onPlayerExited()
    if #enemyZone:getPlayers() > 0 then
        return
    end
    
    task.cancel(enemySpawnProcess :: thread)
    enemySpawnProcess = nil
    
    Enemies:ClearAllChildren()
end



enemyZone.playerEntered:Connect(onPlayerEntered)
enemyZone.playerExited:Connect(onPlayerExited)