Tool data store

[raw mantle]

local datastoreservice = game:GetService("DataStoreService")
local toolsdata = datastoreservice:GetDataStore("toolsdata")
game.Players.PlayerAdded:Connect(function(plr)
    local tools_folder = plr:WaitForChild("Tools_Folder")
    local Backpack = plr:WaitForChild("Backpack")
    local success , toolstable = pcall(function()
        return toolsdata:GetAsync(plr.UserId)
    end)
    
    if success and toolstable then
        for _ , eachtool in pairs(toolstable) do
            local tool = game.ServerStorage.Folder:FindFirstChild(eachtool)
            if tool then
                local newtool_folder = tool:Clone()
                local newtool_back = tool:Clone()
                newtool_folder.Parent = tools_folder
                newtool_back.Parent = Backpack                
            end
        end
    end
end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local tools = {}
    local tools_folder = plr_leave:FindFirstChild("Tools_Folder")
    for _, eachtool in pairs(tools_folder:GetChildren()) do 
        table.insert(tools , eachtool.Name)
    end
    
    local success , error = pcall(function()
        return toolsdata:SetAsync(plr_leave.UserId , tools)
    end)
    
    if not success then
        warn(plr_leave.Name .."Didn't save tools data: ".. error)
    end
end)
```Here idk why tools come to toolsfolder but not backpack

[vagrant gull]

Not sure if the newtool_folder is supposed to clone the tool

local newtool_folder = tool:Clone()
local newtool_back = tool:Clone()
newtool_folder.Parent = tools_folder
newtool_back.Parent = Backpack                

[honest dove]

he just creates 2 variables cause he didnt know how to else to clone it 2 times thats why its like this prolly, but that part is correct

@raw mantle did you check the explorer if the player has the tool there?

[raw mantle]

ok i will delete first clone and keep backpack to see if its problem

[honest dove]

no thats fine

[raw mantle]

yep still

[honest dove]

tool:Clone().Parent = tools_folder
tool:Clone().Parent = Backpack                

y could just simplify it

[raw mantle]

and when i say print backpack getchildern output: [1] = Tool

[raw mantle]

ok i will try

[honest dove]

look at the explorer and go into the backpack

[raw mantle]

no tool apear

[honest dove]

hm

[raw mantle]

yep this is what makes my brain error lol

[honest dove]

wait make the tool a variable

and then print the tool to see where it is and after parenting it print it again

this way we can see if it clones right

and parents right

[raw mantle]

ok u mean i do print newtool_back.parent ?

[honest dove]

local backpackTool = tool:Clone()
tool:Clone().Parent = tools_folder

print(backpackTool)
backpackTool.Parent = Backpack    
print(backpackTool)

like this

[raw mantle]

if tool then
                
                tool:Clone().Parent = tools_folder
                tool:Clone().Parent = Backpack           
                
            end
```i edit this part

[honest dove]

paste this to debug

[raw mantle]

ok wit i delete what i do

[honest dove]

if tool then
    local backpackTool = tool:Clone()
    tool:Clone().Parent = tools_folder

    print(backpackTool)
    backpackTool.Parent = Backpack    
    print(backpackTool)        
end

[raw mantle]

if success and toolstable then
        for _ , eachtool in pairs(toolstable) do
            local tool = game.ServerStorage.Folder:FindFirstChild(eachtool)
            if tool then
                local newtool_folder = tool:Clone()
                local newtool_back = tool:Clone()
                newtool_folder.Parent = tools_folder
                
                print(newtool_back.Parent)
                newtool_back.Parent = Backpack  
                print(newtool_back.Parent)
            end
        end
    end
```like this ?

[honest dove]

yes

[raw mantle]

oh

[honest dove]

and now see where its located before and after

[raw mantle]

output nothing

[honest dove]

then the folder isnt working aswell

[raw mantle]

oh wit there is no data i will resave it

[honest dove]

print the tool before your if statement

o okay

[raw mantle]

output: nil
output: Backpack

hooow Y_Y

i print backpack.parent ?

ok idk what is problem is it bug ? @honest dove

[honest dove]

nono just print newtool_back not the parent

but i think how you are trying to save ur tools is the problem

[raw mantle]

when player leave u mean ?

[honest dove]

you cant actually save the whole tool you have to give every tool an ID save the IDs and then wehn it loads you have to convert these IDs to the tools again

you can only save tables, strings, bools, numbers

no tools/instances

[raw mantle]

uhmm idk this is problem and i save tools.name

[honest dove]

o

[raw mantle]

table.insert(tools , eachtool.Name)

[honest dove]

wait

[raw mantle]

ok

[honest dove]

mb ur correct

[raw mantle]

i am sure that problem not when player leave bec when i test tool.parent = folder_tools and its tool

but dont go to backpackk

[honest dove]

okay so i want you to print newtool_back now

and not the parent

so we can see if it clones and where its then located and where its located after parenting

[raw mantle]

what ?

if i remove parent it will print tool name

[honest dove]

it will print the tool instance

and wehn you click it it will show you the position of it in the explorer

[raw mantle]

if tool then
                local newtool_folder = tool:Clone()
                local newtool_back = tool:Clone()
                newtool_folder.Parent = tools_folder
                
                print(newtool_back)
                newtool_back.Parent = Backpack  
                print(newtool_back)
            end

like this ?

[honest dove]

yes

[raw mantle]

output Tool

but 2 lines bec i say print 2 times

[honest dove]

zes

now click on it like i did

and see where its located

[raw mantle]

ok

sorry i went afk

[honest dove]

all good

[raw mantle]

doesnt show any thing

like its parent = nil

i print backpack get children ?

[honest dove]

so it doesnt show the tool in the explorer

[raw mantle]

nope

Can i give u game files so u can see problem better ?

this game i didnt do any thing on it lol

[honest dove]

alr

[raw mantle]

ohh i see maybe problem

print(newtool_back.Parent)
Here output backpack but when i press it nothing apear

that means backpack is nil too

[honest dove]

local Backpack = plr:FindFirstChildOfClass("Backpack") or plr:WaitForChild("Backpack")

try this

[thin dragon]

just asking but have you tried putting the tool in the character

[raw mantle]

yep no change

[thin dragon]

because im pretty sure its going to do what you want

[raw mantle]

what u mean ?

u mean put tool for example in my player name ?

[thin dragon]

like get the player's character and put the tool there

[vast veldt]

** You are now Level 6! **

[honest dove]

i mean thats a workaround but the save wont work then

[raw mantle]

idk if its possible bec when plr join there is only 4 things on it StraterGear , Backpack , and other thing

[thin dragon]

wait how long have you been scripting?

because that is not true

[raw mantle]

if i want the humanoid or anything inside charcter then i could make charcter but backpack not inside charcter

[honest dove]

he meant that you just put the tools in your char

this works

but will completly fuck up your saving

I wanna know why it wont work in the backpack tho

[raw mantle]

it works inside folder and goes to it but backpack nope

ok so what i do is local charc = plr.cha......
and then put newtool_back.parent = char ?

[thin dragon]

ig but it would make the player equip it on added

and adding multiple would break it

so

uhh

[raw mantle]

ohh wit !!

newtool_back.Parent = game.StarterPack

here its goes to starterpack

soo problem in backpack not clone

newtool_back.Parent = plr:FindFirstChild("Backpack") or plr:WaitForChild("Backpack")

also this dont work

i will just keep it at folder maybe there is bug

[thin dragon]

ok how about just put a breakpoint and see if anything goes wrong

[raw mantle]

like ?

[raw mantle]

i forgot to tell u , 15-20 days

[thin dragon]

the tools_table has nothing in it or the if statements catch something

[honest dove]

mb u where right the char wont break shit

and startpack also just puts it in the char

but why the hell wont the backpack work

[raw mantle]

ok i have diffrante idea maybe roblox do when player join i cant give tool to backpack soo i will add diffrante script and put task.wait(1) then add this tool

if it worked soo there was a bug

[thin dragon]

is this a local or a server script just asking

[raw mantle]

server

[honest dove]

i already tried that that works

[raw mantle]

oh so its a stupid roblox bug lol

[thin dragon]

i don't think so

[honest dove]

i also dont think so the problem is in how your getting the backpack

im trying to figure it out rn

whats ur code now fake_name1?

[raw mantle]

is there any other way to call back pack not from player ?

[raw mantle]

same

it works so problem here is on backpack bec when i say print backpack and press it nothing happen

[thin dragon]

local datastoreservice = game:GetService("DataStoreService")
local toolsdata = datastoreservice:GetDataStore("toolsdata")
game.Players.PlayerAdded:Connect(function(plr)
    local tools_folder = plr:WaitForChild("Tools_Folder")
    local Backpack = plr:WaitForChild("Backpack")
    local success , toolstable = pcall(function()
        return toolsdata:GetAsync(plr.UserId)
    end)

    print(success)    
    print(toolstable) 

    if success and toolstable then
        for _ , eachtool in pairs(toolstable) do
            local tool = game.ServerStorage.Folder:FindFirstChild(eachtool)
            if tool then
                print("passed nil tool check") 
                local newtool_folder = tool:Clone()
                local newtool_back = tool:Clone()
                newtool_folder.Parent = tools_folder
                newtool_back.Parent = Backpack                
            end
        end
    end
end)
``` just try this and see what the prints are

i dont think its something to do with the backpack

[raw mantle]

ok output is:

[honest dove]

it legit has 😭

[thin dragon]

wait was the toolstable print empty

[raw mantle]

True
{
[1] = Tool
}

passed nil tool check

[raw mantle]

this is output

[thin dragon]

wait can we have the whole code again

[raw mantle]

?

[thin dragon]

like the script

[raw mantle]

i do or u do ?

[thin dragon]

your code

[raw mantle]

local datastoreservice = game:GetService("DataStoreService")
local toolsdata = datastoreservice:GetDataStore("toolsdata")
game.Players.PlayerAdded:Connect(function(plr)
    local tools_folder = plr:WaitForChild("Tools_Folder")
    local Backpack = plr:WaitForChild("Backpack")
    local success , toolstable = pcall(function()
        return toolsdata:GetAsync(plr.UserId)
    end)

    if success and toolstable then
        for _ , eachtool in pairs(toolstable) do
            local tool = game.ServerStorage.Folder:FindFirstChild(eachtool)
            if tool then
                local newtool_folder = tool:Clone()
                local newtool_back = tool:Clone()
                newtool_folder.Parent = tools_folder
                newtool_back.Parent = Backpack                
            end
        end
    end
end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local tools = {}
    local tools_folder = plr_leave:FindFirstChild("Tools_Folder")
    for _, eachtool in pairs(tools_folder:GetChildren()) do 
        table.insert(tools , eachtool.Name)
    end

    local success , error = pcall(function()
        return toolsdata:SetAsync(plr_leave.UserId , tools)
    end)

    if not success then
        warn(plr_leave.Name .."Didn't save tools data: ".. error)
    end
end)
```this ?

[thin dragon]

yeah that

wait no

the newest one

not the old one

[raw mantle]

new one is only print to knnow where tools locate

and tools. parent = nil

when i print(backpack) and click on it nothing happen so tat means backpack also nil

[honest dove]

local datastoreservice = game:GetService("DataStoreService")
local toolsdata = datastoreservice:GetDataStore("toolsdata")
game.Players.PlayerAdded:Connect(function(plr)
    local tf = Instance.new("Folder")
    tf.Name = "Tools_Folder"
    tf.Parent = plr
    
    local tools_folder = plr:WaitForChild("Tools_Folder")
    local Backpack = plr:WaitForChild("Backpack")
    local success , toolstable = pcall(function()
    return toolsdata:GetAsync(plr.UserId)
end)

    if success and toolstable then
        for _ , eachtool in pairs(toolstable) do
            local tool = game.ServerStorage.Folder:FindFirstChild(eachtool)
            if tool then
                local newtool_folder = tool:Clone()
                local newtool_back = tool:Clone()
                newtool_folder.Parent = tools_folder
                
                task.spawn(function()
                    task.wait(5)
                    newtool_back.Parent = plr.Backpack
                end)
            end
        end
    end
end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local tools = {}
    local tools_folder = plr_leave:FindFirstChild("Tools_Folder")
    for _, eachtool in pairs(tools_folder:GetChildren()) do 
        table.insert(tools , eachtool.Name)
    end

    local success , error = pcall(function()
        return toolsdata:SetAsync(plr_leave.UserId , tools)
    end)

    if not success then
        warn(plr_leave.Name .."Didn't save tools data: ".. error)
    end
end)

this works and i have no idea why it does

[raw mantle]

omgggg

i fix it Y_Y

omg

[thin dragon]

what

[raw mantle]

i dare u guys found problem

local datastoreservice = game:GetService("DataStoreService")
local toolsdata = datastoreservice:GetDataStore("toolsdata")
game.Players.PlayerAdded:Connect(function(plr)
    task.wait(2)
    local tools_folder = plr:WaitForChild("Tools_Folder")
    local Backpack = plr:WaitForChild("Backpack")
    local success , toolstable = pcall(function()
        return toolsdata:GetAsync(plr.UserId)
    end)

    if success and toolstable then
        for _ , eachtool in pairs(toolstable) do
            local tool = game.ServerStorage.Folder:FindFirstChild(eachtool)
            if tool then
                local newtool_folder = tool:Clone()
                local newtool_back = tool:Clone()
                newtool_folder.Parent = tools_folder
                newtool_back.Parent = Backpack                
            end
        end
    end
end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local tools = {}
    local tools_folder = plr_leave:FindFirstChild("Tools_Folder")
    for _, eachtool in pairs(tools_folder:GetChildren()) do 
        table.insert(tools , eachtool.Name)
    end

    local success , error = pcall(function()
        return toolsdata:SetAsync(plr_leave.UserId , tools)
    end)

    if not success then
        warn(plr_leave.Name .."Didn't save tools data: ".. error)
    end
end)

task.wait(2) make it work when player added Y_Y

i will really cry

[honest dove]

thats what i legit just said

[raw mantle]

but how and i say :WaitForChild ?

[honest dove]

idk why but its a diffrent backpack wehn you instantly get the backpack and 1 second later

@royal canyon do you know why this happens?

[raw mantle]

who @royal canyon ?

[honest dove]

very good scripter and also very got at explaining it

[thin dragon]

no but using task.wait() should'nt change anything

game.Players.PlayerAdded:Connect(function(plr)
    local tools_folder = plr:WaitForChild("Tools_Folder")
    local Backpack = plr:WaitForChild("Backpack")

    local newTool = Instance.new("Tool")
    
    newTool.Parent = Backpack
end)

this works

[honest dove]

ysry read this

[honest dove]

this shouldnt work actually

[thin dragon]

it does though

[raw mantle]

oh i change task.wait(1) and didnt work so i must write task.wait(2) ?

[honest dove]

local datastoreservice = game:GetService("DataStoreService")

game.Players.PlayerAdded:Connect(function(plr)
    local tools_folder = plr:WaitForChild("Tools_Folder")
    local Backpack = plr:WaitForChild("Backpack")

    local tool = game.ServerStorage.Folder:FindFirstChild("Tool")

    tool:Clone().Parent = Backpack
end)

and this doesnt work again 😭

[raw mantle]

ohh maybe i know problem

[honest dove]

this doesnt make any sense

[raw mantle]

ok i know

[thin dragon]

works for me

[honest dove]

this doesnt even work

[raw mantle]

oh but i use wait so idk why

[honest dove]

it doesnt work for me

[raw mantle]

yep same

[honest dove]

this aint making any sense ong

[raw mantle]

ok problem that game need like 2 sec to load plr backpack ?

[raw mantle]

yep i was right its a bug !!!

so i just keep task.wait(2) ? bec task.wait(1) dont want to work too

[honest dove]

no it finds it but after 2 secs its not the exact same backpack

so im assuming the backpack parenting works fine but it gets deleted and recreated?

[raw mantle]

yes hoow this will blow my mind

[thin dragon]

maybe instead just wait for the players character to load before declaring any variables

or doing anything really

[honest dove]

how will this fix that we are waiting for the backpack to load with WaitForChild

[raw mantle]

problem that when i say task.wait(1) didnt work and charcter spawn in less than 1 sec

[thin dragon]

without waitforchild it has suggested code but with waitforchild it doesn't

[honest dove]

game.Players.PlayerAdded:Connect(function(plr)
    local tf = Instance.new("Folder")
    tf.Name = "Tools_Folder"
    tf.Parent = plr

    local tools_folder = plr:WaitForChild("Tools_Folder")
    local Backpack = plr:WaitForChild("Backpack")

    local newTool = Instance.new("Tool")

    newTool.Parent = Backpack
end)

this doesnt work

[thin dragon]

and its just worth a shot

[honest dove]

game.Players.PlayerAdded:Connect(function(plr)
    task.wait(2)

    local tf = Instance.new("Folder")
    tf.Name = "Tools_Folder"
    tf.Parent = plr

    local tools_folder = plr:WaitForChild("Tools_Folder")
    local Backpack = plr:WaitForChild("Backpack")

    local newTool = Instance.new("Tool")

    newTool.Parent = Backpack
end)

and this does

[honest dove]

but its legit printing the backpack 😭

[raw mantle]

now try task.wait(1) lol

the problem that its same backpack Y_Y

idk why this happen to me when i start learn tool data store

[honest dove]

FUCK I KNOW WHATS THE PROBLEM IS

THE CLIENT HASNT CREATED ITS BACKPACK YET THATS WHY IT FAILS

[thin dragon]

maybe because adding a tool to a backpack that the character requires is impossible because the character doesn't exist yet

[raw mantle]

but i say Wait

[thin dragon]

and waitforchild doesn't work for that

[honest dove]

look the server creates the backpack but then the client creates the backpack which ig overwrites the servers backpack

[vast veldt]

** You are now Level 21! **

[raw mantle]

[thin dragon]

why would the client create a backpack

[honest dove]

you are waiting for the server backpack with :WaitForChild

[honest dove]

idk 😭

thats the only solution that makes sense

[raw mantle]

okk i will just stick with task.wait(2) there is nothing else we can do

[thin dragon]

if the client made the backpack it wouldn't show for the server so why would waiting 2 seconds work

[raw mantle]

and when i go to ai it says it should work without task.wait()

[raw mantle]

yes and why waiting 1 sec not work

[thin dragon]

try just do .Backpack and remove the task.wait()

[raw mantle]

and wait for child ?

[thin dragon]

remove the waitforchild too

[raw mantle]

uhmm ok

[honest dove]

game.Players.PlayerAdded:Connect(function(plr)
    local tf = Instance.new("Folder")
    tf.Name = "Tools_Folder"
    tf.Parent = plr

    local backpack1 = plr:WaitForChild("Backpack")
    print("Backpack 1:", backpack1)

    task.wait(2)

    local backpack2 = plr:FindFirstChild("Backpack")
    print("Backpack 2:", backpack2)

    print("Same?", backpack1 == backpack2)
end)

my theory is correct

[raw mantle]

yep no tool inside backpack

[raw mantle]

ohh

but how Y_Y

[honest dove]

idk

[raw mantle]

roblox studio is suck

[honest dove]

chatgpt said it could be a temporary backpack and roblox replaces it afterwards

[raw mantle]

yes but why like server create backpack then delete it , it doesnt make sense

[honest dove]

ima make a new thread for this and ask if anyone is aware of this problem

[raw mantle]

i dont want to blow my mind more i just too happy that i solve it

oh wit @royal canyon with us

@royal canyon can u help us on that ?

[thin dragon]

nope its just this thread that proves my theory correct: https://devforum.roblox.com/t/tool-wont-be-added-in-backpack-when-player-joins/2229215

[honest dove]

ooo

[thin dragon]

Just wait for the player's character to load

[honest dove]

that makes sense so roblox deletes the backpack and recreates it wehnever the character reloads / in our scenario first loads

that also explains why we cant compare them

[thin dragon]

and waiting 2 seconds doesn't completely fix it because of different loading times

[raw mantle]

ohhhhh

local datastoreservice = game:GetService("DataStoreService")
local toolsdata = datastoreservice:GetDataStore("toolsdata")
game.Players.PlayerAdded:Connect(function(plr)
    local charcter = plr.Character or plr.CharacterAdded:Wait()
    if charcter then
        local tools_folder = plr:WaitForChild("Tools_Folder")
        local Backpack = plr:WaitForChild("Backpack")
        local success , toolstable = pcall(function()
            return toolsdata:GetAsync(plr.UserId)
        end)

        if success and toolstable then
            for _ , eachtool in pairs(toolstable) do
                local tool = game.ServerStorage.Folder:FindFirstChild(eachtool)
                if tool then
                    local newtool_folder = tool:Clone()
                    local newtool_back = tool:Clone()
                    newtool_folder.Parent = tools_folder
                    newtool_back.Parent = Backpack                
                end
            end
        end
    end
    
end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local tools = {}
    local tools_folder = plr_leave:FindFirstChild("Tools_Folder")
    for _, eachtool in pairs(tools_folder:GetChildren()) do 
        table.insert(tools , eachtool.Name)
    end

    local success , error = pcall(function()
        return toolsdata:SetAsync(plr_leave.UserId , tools)
    end)

    if not success then
        warn(plr_leave.Name .."Didn't save tools data: ".. error)
    end
end)

this work so yeah i need to wait charcter to load

[honest dove]

finallz

only needed us 241 messages to figure out 🙏

[raw mantle]

lol

[thin dragon]

you don't need the if character btw

because you're waiting for it already

[raw mantle]

yeah but to make sure

more safety

[honest dove]

what if it never loads

[raw mantle]

hoow ?

[thin dragon]

then characterAdded:Wait() will never end

[raw mantle]

like when u join game u must load or roblox kick u right ?

[honest dove]

ig

[honest dove]

idk

[raw mantle]

so i change or to and ?

[thin dragon]

oh and you spelt character wrong

[raw mantle]

oh lol

but finnaly it worked

tysm guys

But

this code will work fine like its ? /10 ?

[thin dragon]

i would use profileStore but it should work at like a solid 6/10

[honest dove]

fine for saving tools

bad for expanding

[raw mantle]

i did other one for leaderstats

[raw mantle]

when i go to profile store i got shocked and leave it

[thin dragon]

😭

[honest dove]

profile service is just a more secure method but it also uses DataStoreService so if you use DataStoreService correct it doesnt really make a diffrence

[raw mantle]

it needs module

and i understand way of module but when i use it my brain start to get errors

[honest dove]

its pretty simple

[raw mantle]

then i will make it every 60 sec save plr to make u rate me higher lol

[honest dove]

it was also confusing at the start for me but its really helpful for making things organized

[honest dove]

I also do that then nothing should go wrong

[raw mantle]

i know it is confusing at first so i will wait like 1 year practise script then go to it

[honest dove]

nah with your knowledge you should be able to learn them

[thin dragon]

it should reduce people losing save data but do it less often (eg 10-5m)

[raw mantle]

yep but problem is source

like i cant read 3 pages to understand it

[raw mantle]

oh not every 60 sec ?

[thin dragon]

no

[raw mantle]

ok

[honest dove]

https://github.com/zyosqq/Roblox/tree/main/DataService

and thats what i meant with expandable

this is what i use as my datastore

it doesnt work for tools tho might have to rewrite that

or arrays at all actually

[raw mantle]

yeah but bro its very goood

[vast veldt]

** You are now Level 19! **

[raw mantle]

like i cant understand the script lol

[honest dove]

yeah the loops are pretty nested

but it just saves/loads data from the dataTree thats all

[raw mantle]

u use module script ?

[honest dove]

yeah these are both module scripts

[raw mantle]

oh

bec this i cant understand it

[honest dove]

local SSS = game:GetService("ServerScriptService")
local MDLS = SSS:WaitForChild("Modules")

local dataService = require(MDLS.dataService)  

PLRS.PlayerAdded:Connect(function(plr)
    dataService:_initPlayer(plr)
end)

PLRS.PlayerRemoving:Connect(function(plr)
    dataService.dataSave(plr)
end)

game:BindToClose(function()
    for i,v in pairs(game.Players:GetPlayers()) do
        dataService.dataSave(v)
    end
end)

task.spawn(function()
    while true do
        task.wait(60)
        for _, plr in pairs(game.Players:GetPlayers()) do
            dataService.dataSave(plr)
        end
    end
end)

i would run them like this

[thin dragon]

wait does yours reconcile

[raw mantle]

local datastoreservice = game:GetService("DataStoreService")
local toolsdata = datastoreservice:GetDataStore("toolsdata")
local runservice = game:GetService("RunService")
game.Players.PlayerAdded:Connect(function(plr)
    local waittime = 0
    local Character = plr.Character or plr.CharacterAdded:Wait()
    if Character then
        local tools_folder = plr:WaitForChild("Tools_Folder")
        local Backpack = plr:WaitForChild("Backpack")
        local success , toolstable = pcall(function()
            return toolsdata:GetAsync(plr.UserId)
        end)

        if success and toolstable then
            for _ , eachtool in pairs(toolstable) do
                local tool = game.ServerStorage.Folder:FindFirstChild(eachtool)
                if tool then
                    local newtool_folder = tool:Clone()
                    local newtool_back = tool:Clone()
                    newtool_folder.Parent = tools_folder
                    newtool_back.Parent = Backpack                
                end
            end
        end
        local tools = {}

        runservice.Heartbeat:Connect(function(deltatime)
            waittime += deltatime
            if waittime >= 60*5 then
                waittime = 0
                if plr.Parent ~= nil then
                    for _, eachtool in pairs(tools_folder:GetChildren()) do 
                        table.insert(tools , eachtool.Name)
                    end

                    local success , error = pcall(function()
                        return toolsdata:SetAsync(plr.UserId , tools)
                    end)

                    if not success then
                        warn(plr.Name .."Didn't save tools data: ".. error)
                    end
                end
                
            end
        end)
        
        
    end
    
end)

this will work fine right ?

oh i forgot to add disconnct

[thin dragon]

60 * 5 = 300 btw

[vast veldt]

** You are now Level 7! **

[raw mantle]

yep i know for sure lol

[honest dove]

wdym

[raw mantle]

but if i want to make it like 7 , 8 i think that i will do local min = 1

[royal canyon]

Why have I been @ed 4 times?

[honest dove]

we figured it out mb 😭

[raw mantle]

local datastoreservice = game:GetService("DataStoreService")
local toolsdata = datastoreservice:GetDataStore("toolsdata")
local runservice = game:GetService("RunService")
game.Players.PlayerAdded:Connect(function(plr)
    local waittime = 0
    local Character = plr.Character or plr.CharacterAdded:Wait()
    if Character then
        local tools_folder = plr:WaitForChild("Tools_Folder")
        local Backpack = plr:WaitForChild("Backpack")
        local success , toolstable = pcall(function()
            return toolsdata:GetAsync(plr.UserId)
        end)

        if success and toolstable then
            for _ , eachtool in pairs(toolstable) do
                local tool = game.ServerStorage.Folder:FindFirstChild(eachtool)
                if tool then
                    local newtool_folder = tool:Clone()
                    local newtool_back = tool:Clone()
                    newtool_folder.Parent = tools_folder
                    newtool_back.Parent = Backpack                
                end
            end
        end
        local tools = {}
        local connect
        connect = runservice.Heartbeat:Connect(function(deltatime)
            waittime += deltatime
            if waittime >= 60*5 then
                waittime = 0
                if plr.Parent ~= nil then
                    for _, eachtool in pairs(tools_folder:GetChildren()) do 
                        table.insert(tools , eachtool.Name)
                    end

                    local success , error = pcall(function()
                        return toolsdata:SetAsync(plr.UserId , tools)
                    end)

                    if not success then
                        warn(plr.Name .."Didn't save tools data: ".. error)
                    end
                else
                    connect.Disconnect()
                end
            end
        end)
    end
    
end)

this will work fine ?

[royal canyon]

https://www.youtube.com/watch?v=CFRhGnuXG-4

[honest dove]

[raw mantle]

wtf

[honest dove]

i would recommend you to watch the video

the stuff ziffix sends is actually pretty useful

alr fake_name1 gl on your scripting journy ima go now

[raw mantle]

okk cya ty for helping

[raw mantle]

@royal canyon ty alot this video make me learn alot of things

[honest dove]

told ya hes great

[raw mantle]

yep

[honest dove]

function dataService:_initPlayer(plr)
    local data = dataService:_loadPlayerData(plr)
    
    for i, folder in dataTree.Folders do
        dataService:_createFolder(plr, folder, data)
    end
end

function dataService:_loadPlayerData(plr)
    if not dataTree.DataStoreName then return end
    
    local success, result = pcall(function()
        DSS:GetDataStore(dataTree.DataStoreName):GetAsync(plr.UserId)
    end)
    
    return success and result or {}
end

function dataService:_createFolder(plr, folderDef, data)
    local newFolder = Instance.new("Folder")
    newFolder.Name = folderDef.Name
    newFolder.Parent = plr
    
    for i, value in folderDef.Values do
        dataService:_createValue(value, newFolder, data)
    end
end

function dataService:_createValue(valueDef, newFolder, data)
    local value = Instance.new(valueDef.Instance)
    value.Name = valueDef.Name
    
    if data and valueDef.Save and data[valueDef.Name] then
        value.Value = data[valueDef.Name]
    else
        value.Value = valueDef.StartValue
    end
    
    value.Parent = newFolder
end

i already unnested the load section

[raw mantle]

broo dont make me watch those module script

ohh i have really really bad thing

my memory usage is 2409MB Y_Y @honest dove

[honest dove]

its cause of studio dw

I also got 1600mb

idk why u got 800mb more tho 💀

[raw mantle]

and my game is very very basic

[honest dove]

https://github.com/zyosqq/Roblox/blob/main/DataService/dataService.lua @raw mantle im finished what do y think

[raw mantle]

just fps and when plr buy toon then gives item all those 2409mb

[honest dove]

o

[raw mantle]

there is way i can show u my game ?

[raw mantle]

lol

i will join roblox normall

[honest dove]

screenshare or invite me

or make it puplic and send me the link yea

[raw mantle]

ok screen share

i dm ?

[honest dove]

z

y

go for it