hitbox only looping once

[patent stone]

.

the print only goes once

so im assuming that it does the for loop only once for some reason

[normal palm]

ok and

[patent stone]

https://tenor.com/view/sybau-ts-pmo-gif-2102579015947246168

[normal palm]

bro came to scripting help and expected us to magically know what's happening

[patent stone]

no i just expect you not to not do troll messages 💔

its obvious that you are trolling instead of helping by saying "ok and"

[normal palm]

so you came here to say nothing specific about your problem but you expected me not to shame you

hideous logic

[patent stone]

i did say smthn specific though?

[normal palm]

you really haven't

[patent stone]

the for loop only goes once and thats the problem

[normal palm]

and how does that help anyone

that's like saying that you smelled something distasteful in the air and you want someone to identify the smell third-hand

[patent stone]

and how does you saying "ok and" help anyone 💔

if you aint gonna help then dont message in here

[clear timber]

can you show the script

[patent stone]

scroll up its at the top

[normal palm]

it helps everyone actually

[patent stone]

oh wait

discord didnt send it for some reason

[normal palm]

Because it is supposed to get you to say something

[patent stone]

my bad

brody...

ok pastebin it is

https://pastebin.com/vWdGrz5h

[normal palm]

lowkey pisses me off when people write shit like "hitted" like bro do you even know what the past tense of hit is

[patent stone]

ion put much thought into my variable names lowkey 😭

sometimes i just name them a singular letter if im lazy

[normal palm]

ok so first of all

the reason it is one loop is because you literally return within the loop

like it's not even conditional

It just returns after one iteration

second, table.find is mid as fuck and you should use the humanoid as the key. that will be better than table.find

third, pairs is pointless

[patent stone]

is it because table.find is slower or somethin?

[normal palm]

linear time with table.find vs constant time with hashing

fourth, why the hell did you create a part only to do getpartboundsinbox

that will include that part you just generated, for one

you do not need a part for getpartboundsinbox

[patent stone]

so i can visualize the hitbox

[normal palm]

I would recommend excluding it from params then

[patent stone]

from the function params or what

[normal palm]

if you want to create it outside of the hitbox function, which makes a lot more sense to me, or else just put it into the params if it isn't already there

that being said, if you have overlapping hitboxes, one of those visual parts is bound to be queried for

so you should account for it in all of your functions by having them parented to some base parameters structure

or, y'know, physics service's collisiongroups

[patent stone]

also the whole looping once part is because of the gaurd clauses stopping the loop right?

[normal palm]

there is one guard clause

And one explicit, unconditional return

right, actually no two guard clauses, because I read that wrong

same reason

[open reef]

But where script ?!

Thats what he meant

[open reef]

🚨‼️AI generated‼️🚨

[patent stone]

? I legit coded myself I just had to comment over it cuz I wanted to submit some stuff for a ranking

[patent stone]

yeah no mb it showed that i sent the script but it was the red message retry thing and i didnt notice it. mb

[open reef]

The scripters who can’t understand others’ scripts without comments should not rank at all imo

[patent stone]

true but i just wanted to be safe

would be a pain to make another one