Data storage | Roblox Studio Community | Page 1

lunar belfry Jun 2, 2025, 4:10 PM

#

i just test data storage so i dont add tables or like this bec the only value is coins, but can someone see my code and say to me if there is any improvements need ?

#

local DataStoreService = game:GetService("DataStoreService")
local coinsdata = DataStoreService:GetDataStore("coindata")
local runservice = game:GetService("RunService")


game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = plr:WaitForChild("leaderstats")
    local coins = leaderstats:WaitForChild("Coins")
    
    local success , savedcoins = pcall(function()
        return coinsdata:GetAsync(plr.UserId)
    end)
    
    if success and savedcoins then
        coins.Value = savedcoins
        
    else
        coins.Value = 0
        print("New Player !")
    end
    
    local time_wait = 0

    
    runservice.Heartbeat:Connect(function(deltatime)
        if plr.Parent ~= nil then
            time_wait += deltatime
            if time_wait >= 60 then
                time_wait = 0
                pcall(function()
                    coinsdata:SetAsync(plr.UserId , coins.Value)
                end)
                print("Saved !")
            end
        end
        
    end)
end)

game.Players.PlayerRemoving:Connect(function(plr)
    local leaderstats = plr:FindFirstChild("leaderstats")
    local coins = leaderstats:FindFirstChild("Coins")
    pcall(function()
        coinsdata:SetAsync(plr.UserId , coins.Value)
    end)
end)

wild veldt Jun 2, 2025, 4:12 PM

#

retries if the get or set fails and game:bindtoclose, maybe session locking, otherwise fairly traditional leaderstats/datastore script

lunar belfry Jun 2, 2025, 4:15 PM

#

wild veldt retries if the get or set fails and game:bindtoclose, maybe session locking, oth...

oh wsp @wild veldt

lunar belfry Jun 2, 2025, 4:15 PM

#

wild veldt retries if the get or set fails and game:bindtoclose, maybe session locking, oth...

uhmm i dont understand

#

so u mean if player left the game and cant save ?

wild veldt Jun 2, 2025, 4:18 PM

#

lunar belfry so u mean if player left the game and cant save ?

wat if a player joins and datastore servers are down or overloaded like grow a garden hits 10mil ccu again? you have no retry load data if it fails

lunar belfry Jun 2, 2025, 4:19 PM

#

wild veldt wat if a player joins and datastore servers are down or overloaded like grow a g...

how ?

wild veldt Jun 2, 2025, 4:20 PM

#

lunar belfry how ?

google is your friend Thumbs

mental lintel Jun 2, 2025, 4:20 PM

#

Also 1 heartbeat per played?

#

Plater

lunar belfry Jun 2, 2025, 4:20 PM

#

i go to it he just add on local success , saveddata ....
if not success then warn("didt save ")

lunar belfry Jun 2, 2025, 4:21 PM

#

mental lintel Also 1 heartbeat per played?

i am new at run service what u mean ?

lunar belfry Jun 2, 2025, 4:21 PM

#

mental lintel Also 1 heartbeat per played?

each player have its own fps

wild veldt Jun 2, 2025, 4:21 PM

#

lunar belfry so u mean if player left the game and cant save ?

also yes if player leave then heartbeat connection is still there, you never disconnect it. memory leak

#

it doesn't do anything but it's still going to take up 0.0001 of a frame, every frame.

lunar belfry Jun 2, 2025, 4:22 PM

#

wild veldt also yes if player leave then heartbeat connection is still there, you never dis...

when player leave heartbeat stop bec i add if plr.parent ~= nil

mental lintel Jun 2, 2025, 4:22 PM

#

lunar belfry when player leave heartbeat stop bec i add if plr.parent ~= nil

Never disconects

#

Still exists

lunar belfry Jun 2, 2025, 4:23 PM

#

mental lintel Never disconects

ok i will add else disconnect() ?

wild veldt Jun 2, 2025, 4:23 PM

#

lunar belfry when player leave heartbeat stop bec i add if plr.parent ~= nil

that's what you would use for infinite while loop paired with a task.wait() but you connect to heartbeat instead

mental lintel Jun 2, 2025, 4:23 PM

#

Sure

lunar belfry Jun 2, 2025, 4:24 PM

#

mental lintel Sure

ok 1 sec

lunar belfry Jun 2, 2025, 4:25 PM

#

mental lintel Sure

local DataStoreService = game:GetService("DataStoreService")
local coinsdata = DataStoreService:GetDataStore("coindata")
local runservice = game:GetService("RunService")


game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = plr:WaitForChild("leaderstats")
    local coins = leaderstats:WaitForChild("Coins")
    
    local success , savedcoins = pcall(function()
        return coinsdata:GetAsync(plr.UserId)
    end)
    
    if success and savedcoins then
        coins.Value = savedcoins
        
    else
        coins.Value = 0
        print("New Player !")
    end
    
    local time_wait = 0

    
    local connect = runservice.Heartbeat:Connect(function(deltatime)
        if plr.Parent ~= nil then
            time_wait += deltatime
            if time_wait >= 60 then
                time_wait = 0
                pcall(function()
                    coinsdata:SetAsync(plr.UserId , coins.Value)
                end)
                print("Saved !")
            end
        else
            connect:Disconnect()
        end
        
    end)
end)

game.Players.PlayerRemoving:Connect(function(plr)
    local leaderstats = plr:FindFirstChild("leaderstats")
    local coins = leaderstats:FindFirstChild("Coins")
    pcall(function()
        coinsdata:SetAsync(plr.UserId , coins.Value)
    end)
end)
```like this ?

#

there is problem here connect:Disconnect()

#

problem on connect why ?

#

here is error

#

ServerScriptService.Datastore:36: attempt to index nil with 'Disconnect'

wild veldt Jun 2, 2025, 4:29 PM

#

lunar belfry ServerScriptService.Datastore:36: attempt to index nil with 'Disconnect'

local connect
connect = ...```

#

if connect then connect:Disconnect() connect=nil end

#

etc

lunar belfry Jun 2, 2025, 4:32 PM

#

if connect then

#

connect still problem

#

local connect = runservice.Heartbeat:Connect(function(deltatime)
        if plr.Parent ~= nil then
            time_wait += deltatime
            if time_wait >= 60 then
                time_wait = 0
                pcall(function()
                    coinsdata:SetAsync(plr.UserId , coins.Value)
                end)
                print("Saved !")
            end
        if plr.Parent == nil then
            connect:Disconnect()
        end
            
        end
        
    end)

#

here still connect problem idk why

#

there is orange line under connect in connect:Disconnect()

solar bay Jun 2, 2025, 4:34 PM

#

inline your heartbeat event

#

to connect variable

#

wait hold on

#

do what pyrofire said

lunar belfry Jun 2, 2025, 4:34 PM

#

i did there is problem

#

error *

#

i will just add else print("plr left ") to see if heartbeat stop or no

solar bay Jun 2, 2025, 4:35 PM

#

the issue is the connect variable

lunar belfry Jun 2, 2025, 4:36 PM

#

solar bay the issue is the connect variable

?

#

can u edit it ?

solar bay Jun 2, 2025, 4:36 PM

#

local connect
connect = heartbeat

wild veldt Jun 2, 2025, 4:36 PM

#

must be 2 lines

lunar belfry Jun 2, 2025, 4:37 PM

#

solar bay local connect connect = heartbeat

its same thing as local connect = runservice....

wild veldt Jun 2, 2025, 4:37 PM

#

lunar belfry its same thing as local connect = runservice....

nope

solar bay Jun 2, 2025, 4:37 PM

#

the function doesnt recognise the variable

wild veldt Jun 2, 2025, 4:38 PM

#

tho i am pretty sure it should work, eh, just do both

lunar belfry Jun 2, 2025, 4:38 PM

#

wild veldt tho i am pretty sure it should work, eh, just do both

yes it worked but what is the diffrance

solar bay Jun 2, 2025, 4:38 PM

#

nae

lunar belfry Jun 2, 2025, 4:39 PM

#

solar bay nae

wtf is this code i cant understand line lol

wild veldt Jun 2, 2025, 4:39 PM

#

lunar belfry yes it worked but what is the diffrance

avoids recursive variable

solar bay Jun 2, 2025, 4:39 PM

#

not part of your code

wild veldt Jun 2, 2025, 4:39 PM

#

works just fine for functions but apparently it's an issue there

lunar belfry Jun 2, 2025, 4:39 PM

#

solar bay not part of your code

yeah but its very hard man

#

local DataStoreService = game:GetService("DataStoreService")
local coinsdata = DataStoreService:GetDataStore("coindata")
local runservice = game:GetService("RunService")


game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = plr:WaitForChild("leaderstats")
    local coins = leaderstats:WaitForChild("Coins")

    local success , savedcoins = pcall(function()
        return coinsdata:GetAsync(plr.UserId)
    end)

    if success and savedcoins then
        coins.Value = savedcoins

    else
        coins.Value = 0
        print("New Player !")
    end

    local time_wait = 0

    local connect
    connect = runservice.Heartbeat:Connect(function(deltatime)
        if plr.Parent ~= nil then
            time_wait += deltatime
            if time_wait >= 60 then
                time_wait = 0
                pcall(function()
                    coinsdata:SetAsync(plr.UserId , coins.Value)
                end)
                print("Saved !")
            end
        else
            connect:Disconnect()
            print("stop")
        end
    end)
end)

game.Players.PlayerRemoving:Connect(function(plr)
    local leaderstats = plr:FindFirstChild("leaderstats")
    local coins = leaderstats:FindFirstChild("Coins")
    pcall(function()
        coinsdata:SetAsync(plr.UserId , coins.Value)
    end)
end)

#

here is final code all thing will work correctly right ?

solar bay Jun 2, 2025, 4:51 PM

#

idk does it

#Data storage