I want to improve my script

[pure trench]

this is my data store script but i want to make it better and for sure when i wand to add more data like points ,tools, not only coins , i dont want to add many lines , and make it (readable)

i cant copy text here so here is link https://pastebin.com/nZgEne6W

[mint mural]

why is that a problem? you only have to write it once 👍

[pure trench]

like if i want to add more data so i need to add many lines and repeat same thing over and over again

there is no way i can just collect all data and make it 1 thing

like how to add a table that have all data ? @mint mural

[mint mural]

yeah and sometimes certain pieces of data need to be treated differently to others.

numbers are easy. tables like inventory data is more involved. you maybe haven't reached that point yet, but you will 🙂

[pure trench]

oh u mean like tools cant be inside table coins or leaderstats ?

[mint mural]

yes leaderstats are numbers that are treated like numbers but they get extra-special treatment as leaderstats

[pure trench]

oh ok

[mint mural]

it's a bit like that

[pure trench]

so like is my data store good or need some fixes ?

[mint mural]

tbh this looks like your first data store thing, and for a first it looks good enough 👍

[pure trench]

ty 🙂

but i want to improve it

all videos i see just do my way i do it so how i make it better ?

[mint mural]

you won't be able to properly improve it, or understand how, short of me telling you exactly what code to put, because you don't yet understand how or why this isn't enough. i can tell you it is (mostly) enough and any forseeable problems are very niche.

[mint mural]

in short, you don't need to make it better, until you first understand how and/or why it needs to be better in the first place, assuming it needs to be better at all

[pure trench]

ohh okk

[mint mural]

the only forseeable problem at this level is if roblox datastore servers crash and tbh you probably don't need to care about that

[pure trench]

i know why it need to be better , first i dont use function but idk how i use it , 2nd i just to while plr.parent do and i know its not that efficient

[mint mural]

that's a very hard problem. your code is good enough 👍

[mint mural]

lol that's small fry

[pure trench]

ok ty and sorry for wasting your time

[mint mural]

not a waste, i chose to spend this time how i decided 🙂

[pure trench]

ok cya

[mint mural]

you can learn a lot by studying the docs https://create.roblox.com/docs/cloud-services/data-stores. anyway ok cya

[pure trench]

my nightmare is reading i just cant focus Y_Y

[mint mural]

programming is 90% reading docs and code, 10% actually writing code ~_~

[pure trench]

watching yt ?

[mint mural]

close enough to reading, but with pictures ;p

[pure trench]

ok make sense

[mint mural]

just dont take the code at its face value, its like copying code out of a 20 year old book, dont expect it to work first try without your input

from tutorials or ai etc that is

[pure trench]

oh why people add also local success , errormassege = pcall ?

[pure trench]

yeah

[mint mural]

you tell me

everything is in the docs

[pure trench]

i know pcall to protect from any mistake like if there was weak wifi , or game is laging alot but i know i just use success , saved coins not success , error

[mint mural]

look up every keyword, you just never know what you might learn

[pure trench]

yeah it will be very helpful

ohh people use success and error bec if there was any error , so can i put it inside while plr.parent do and add it ? @mint mural

local datastoreservice = game:GetService("DataStoreService")
local coinsdata = datastoreservice:GetDataStore("coinsdata")
game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = plr:WaitForChild("leaderstats")
    local coins = leaderstats:FindFirstChild("Coins")
    local success , savedcoins = pcall(function()
        return coinsdata:GetAsync(plr.UserId)
    end)
    
    if success and savedcoins then
        coins.Value = savedcoins
    else
        coins.Value = 0
    end
    
    while plr.Parent do 
        task.wait(60)
        local success , error_massege = pcall(function()
            return coinsdata:SetAsync(plr.UserId , coins.Value)
        end)
        if not success then
            print(error_massege)
        end
        pcall(function()
            coinsdata:SetAsync(plr.UserId , coins.Value)
        end)
    end
end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local leaderstats = plr_leave:WaitForChild("leaderstats")
    local coins = leaderstats:FindFirstChild("Coins")

    pcall(function()
        coinsdata:SetAsync(plr_leave.UserId , coins.Value)
    end)
end)

like this @mint mural i added while plr.parent

[mint mural]

that works

[pure trench]

ohh yess i just do something with my own !

[mint mural]

idk about calling setasync twice in a row but

you'll get there 🙂