Can someone see my datastore and say to me if will be any issue later ?

[hallow meadow]

i am kinda new at scripting but i want to know if datastore i did will have any issue later or its good

local datastoreservice = game:GetService("DataStoreService")
local pointsdata = datastoreservice:GetDataStore("pointsdata")
game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = plr:WaitForChild("leaderstats")
    local points = leaderstats:FindFirstChild("Points")
    
    local success , savedpoints = pcall(function()
        return pointsdata:GetAsync(plr.UserId)
    end)
    if success and savedpoints then
        points.Value = savedpoints
    end
    
    while task.wait(60) do 
        pcall(function()
            pointsdata:SetAsync(plr.UserId , points.Value)
        end)
    end

end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local leaderstats = plr_leave.leaderstats
    local points = leaderstats:FindFirstChild("Points")

    pcall(function()
        pointsdata:SetAsync(plr_leave.UserId , points.Value)
    end)
end)

[past crow]

disconnect "while task.wait(60) do" when player exits game

[hallow meadow]

i just do it when player join bec if there was any problem happens inside game , bec game has limits of datastore and if it was too much it will not save

[red oyster]

no they mean it will continue saving even after the player has left

[past crow]

ye the command always runs

[hallow meadow]

oh

right

ok what should i do ?

i say playerleave then for example stop = false and up we start stop = true ?

[past crow]

create a table with the current game players or just find the player name in the game.Players

while game.Players:FindFirstChild(plr.Name) do
task.wait(60)
pcall function ( ... )

(...)
end

it's the easiest way

[hallow meadow]

local datastoreservice = game:GetService("DataStoreService")
local pointsdata = datastoreservice:GetDataStore("pointsdata")
local stop = true
game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = plr:WaitForChild("leaderstats")
    local points = leaderstats:FindFirstChild("Points")
    
    local success , savedpoints = pcall(function()
        return pointsdata:GetAsync(plr.UserId)
    end)
    if success and savedpoints then
        points.Value = savedpoints
    end
    
    while stop do 
        pcall(function()
            pointsdata:SetAsync(plr.UserId , points.Value)
        end)
        task.wait(60)
    end

end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local leaderstats = plr_leave.leaderstats
    local points = leaderstats:FindFirstChild("Points")
    stop = false
    pcall(function()
        pointsdata:SetAsync(plr_leave.UserId , points.Value)
    end)
end)
```this way right ?

[past crow]

No

there will be on average 4+ players and not just one player

[hallow meadow]

ohh right i am dumb sorry

[past crow]

local stop = {}
you can use tables but is a little more "hard"

[hallow meadow]

local datastoreservice = game:GetService("DataStoreService")
local pointsdata = datastoreservice:GetDataStore("pointsdata")
game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = plr:WaitForChild("leaderstats")
    local points = leaderstats:FindFirstChild("Points")
    
    local success , savedpoints = pcall(function()
        return pointsdata:GetAsync(plr.UserId)
    end)
    if success and savedpoints then
        points.Value = savedpoints
    end
    
    while plr.Name do 
        pcall(function()
            pointsdata:SetAsync(plr.UserId , points.Value)
        end)
        task.wait(60)
    end

end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local leaderstats = plr_leave.leaderstats
    local points = leaderstats:FindFirstChild("Points")
    pcall(function()
        pointsdata:SetAsync(plr_leave.UserId , points.Value)
    end)
end)
```now good ?

[past crow]

No, use the easiest way

Plr.Name is a String

the string will not change

[hallow meadow]

oh i mean id i forgot

plr.userid

[past crow]

Plr.UserID is a string/number too

so it will never change even if the Player leaves

[hallow meadow]

can u edit me code

[past crow]

I already sent you the answer

[past crow]

.

[hallow meadow]

i can just write plr not game.player right ?

[past crow]

No

[red oyster]

while player.Parent and taskwait

[past crow]

ye

[past crow]

also game.Players is a service not a Player

[hallow meadow]

plr.parent is service and will never be false so code will work even if player leave right ?

[past crow]

plr.Parent: if the player leaves the game the plr will be Nil so it is much more optimized

[hallow meadow]

my brain X_X

[past crow]

just pretend that Plr is an instance too (Part)

[hallow meadow]

plr.parent is players service right ?

[past crow]

yes

but you can't get the Parent of something NIL

[hallow meadow]

ok so i like this say while players service do
and its always true

[red oyster]

don't quit your day job

[hallow meadow]

ohhh okk

[past crow]

-_-

[hallow meadow]

local datastoreservice = game:GetService("DataStoreService")
local pointsdata = datastoreservice:GetDataStore("pointsdata")
game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = plr:WaitForChild("leaderstats")
    local points = leaderstats:FindFirstChild("Points")
    
    local success , savedpoints = pcall(function()
        return pointsdata:GetAsync(plr.UserId)
    end)
    if success and savedpoints then
        points.Value = savedpoints
    end
    
    while plr.Parent do 
        pcall(function()
            pointsdata:SetAsync(plr.UserId , points.Value)
        end)
        task.wait(60)
    end

end)

game.Players.PlayerRemoving:Connect(function(plr_leave)
    local leaderstats = plr_leave.leaderstats
    local points = leaderstats:FindFirstChild("Points")
    pcall(function()
        pointsdata:SetAsync(plr_leave.UserId , points.Value)
    end)
end)

so it will be like this ?

[past crow]

yes at least it works

[hallow meadow]

ok so data store will not have any problems later right ?

[past crow]

maybe

[hallow meadow]

?

[past crow]

because there is profile service too but you better use the DataStore

[hallow meadow]

wtf u mean profile profile service

[past crow]

search in api or video

[hallow meadow]

nah i will just be happy what i learn lol

[past crow]

that's what i said

[hallow meadow]

okk

[red oyster]

this thread is a disaster

[past crow]

what you want from a scripting-help

[red oyster]

that's tru

[hallow meadow]

so when u start scripting u never need help ?

[red oyster]

correct, i never got help from anyone

docs only

[hallow meadow]

bruh

[red oyster]

not even youtube tutorials because those didnt exist when i started lol

[hallow meadow]

ok but atleast script help is soo much faster

[past crow]

use forums and the API

[hallow meadow]

ok that means now we can learn things 2x faster than it was

[past crow]

are the best

[red oyster]

helping others is how i help learn for myself

[hallow meadow]

okk

[red oyster]

coz people ask weird things that i might never see otherwise

[hallow meadow]

ok ty guys for helping

[past crow]

but you waste a little time with that

[red oyster]

anyway your code sucks but it works good enough, aside from the not cancelling when the player leaves but you got that condition in there now so it should be better. saving every 60 seconds is going to hit request limit so as long as this is your only datastore its fine

[hallow meadow]

so if i want to add more what should i do

[red oyster]

plr will never be nil. when a player disconnects, they are parented to nil, which is why checking if plr.Parent works. there's an example of this in the docs where they also use plr.ancestrychanged:Wait() to detect a disconnect https://create.roblox.com/docs/reference/engine/classes/Player#CharacterAppearanceLoaded

[past crow]

you can upgrade the datastore or use another service

[past crow]

That's what I meant..

because otherwise there would be no way to save the date of whoever left

[hallow meadow]

i will go continue episode i watch and if there any upgrade, i will do it for sure

[past crow]

(from function)

[red oyster]

tbh the only thing i would change is how fast it autosaves, i'd make it 2 minutes instead of 1.

you don't want to be exactly on the request limit, always want to be slightly under it

[past crow]

it would be better to change after 2 minutes after there is a change in leaderstats ?

[red oyster]

if you wanted to get fancy you could add session locking but tbh you're probably better off using profileservice which does that for you

profileservice is a 3rd party module made by community to handle datastores for newbies and beginners

[red oyster]

that would be even better, so you're not saving identical data for no reason

but then you'd need to structure all that

and add a bunch of control code

a beginner can barely handle simple use of datastore let alone complex control code and timing stuff

so... tune suggestions accordingly ;p

[hallow meadow]

for how many years u been scripting ? @red oyster

i am 8 days right now

[past crow]

It's not that complex if he learned how to use basic data store

I have some questions too

@hallow meadow What do you want to do by learning scripts?

[hallow meadow]

doing any thing i think about it like doing my own game and helping people in futre if i was good at script

and u ?

[past crow]

oh

I make my own games and take some commissions

[hallow meadow]

nicee

for robux right ?

[past crow]

yes

[hallow meadow]

woow

10 robux ?

[past crow]

10?

[hallow meadow]

more ?

[past crow]

10k you say?

[hallow meadow]

10 only

[past crow]

i get 1k-2k per comm

[hallow meadow]

fuck

hooooowowowowowoow

[past crow]

It depends on how long it takes to do it too

[hallow meadow]

what things u do ?

[past crow]

uhh I script?

[hallow meadow]

no like waht tasks u do

[past crow]

oh

any type of system

[hallow meadow]

can u become my teacher lol

[past crow]

inventory, tool, gun, game system, npc, every thing in roblox

It's easy to create any Roblox game but the hard part is having time and promoting it

[hallow meadow]

bro its not easy

or maybe bec i am at day 8 of learning

[past crow]

It depends, I don't have much free time but if you want you can become my friend

[past crow]

It is

[hallow meadow]

yess ty