Ok, I'm a bit indecisive if this is a good idea. I'm planning to store all the player's data in a dictionary in a modulescript in serverscriptservice. (Only serverscripts can access it) This way I can easily recall it and i'm just wondering if it's safe/efficient.
#Is this secure and good?
wet island
vagrant kindle
Ok, I'm a bit indecisive if this is a good idea. I'm planning to store all the p...
It is safe
wet island
finally someone
vagrant kindle
Efficiency I have no idea, but you're basically storing a table of information globally instead of in one script
wet island
It is safe
alr
vagrant kindle
Of course you can also make a module script have util functions too
wet island
what is the point of that
vagrant kindle
Instead of let's say 4 separate scripts having their own saving, loading, ect logic, you just have one DataStoreModule that does that for you, those scripts will just have to call those functions themselves
Another useful example:
You won't need to have a script that handles the player leaving and joining, that can also be handled in the module script
wet island
Instead of let's say 4 separate scripts having their own saving, loading, ect lo...
thats all done on one datastoreservice script
they just recall it from this dictionary
vagrant kindle
thats all done on one datastoreservice script
That's bad
wet island
That's bad
why
vagrant kindle
I'd personally separate the modules into categories
wet island
the datastore getasyncs the data
and puts it in this modulescript
and each script takes what they need
vagrant kindle
Example of my Forwards-And-Backwards-Inverse-Kinematics module.
The main module, works as a loader basically, it connect the smaller modules, which in my case are "Segment" and "Chain", making the different parts easy to modify.
wet island
its like 1 line of code to recall it
vagrant kindle
I am just telling you good practices, especially for someone with an s1
wet island
I am just telling you good practices, especially for someone with an s1
hmm
so like under a modulescript
theres more modulescripts
vagrant kindle
Pretty much yeah
wet island
this modulescript
vagrant kindle
It would let you edit different parts of your logic without cluter
vagrant kindle
Okay, gimmie a sec, I'll show you an example of how I would personally handle DataStoring in my games
wet island
clutter reminds me of clutterfunk
smh
I already have this system implemented
im just seeing if its actually as secure and efficient as I think
vagrant kindle
There isn't much of a security risk
Since modules aren't replicated across server-client
minor nest
Ok, I'm a bit indecisive if this is a good idea. I'm planning to store all the p...
This is what profile service does
vagrant kindle
This is what profile service does
If that's a someone-else made module
minor nest
Profile service is pretty good
vagrant kindle
Get out of here
vagrant kindle
If you're gonna get spoon-fed other's people work, you'll never improve
I am trying to teach him here and you come and just say "Use someone else's work"
minor nest
Sorry but I don’t have the knowledge to make such a good data system but I also don’t want it to hold me back from game dev
vagrant kindle
It's fine, but not the current point of this convo
minor nest
I’m not telling him to use profile service
I just said that’s what profile service does
wet island
ive heard of profileserver but was too lazy to research it
minor nest
It’s very reliable
wet island
bc datastoreservice was already known to me
minor nest
From what I heard
wet island
Okay, gimmie a sec, I'll show you an example of how I would personally handle Da...
continue.
minor nest
The main reason to use something like profile service is session locking
But I looks at profile service code and there’s so much other shit
Which is there for good reason most likely
wet island
is that like
minor nest
And idk how todo all that stuff
wet island
the spr library module
minor nest
So I just use the module
vagrant kindle
@wet island Also, here's what my approach would basically look like:
DataStore is the main module that holds the data and has utility methods of "getPlayerValue(plr, category, value)" for example or "getPlayerCategory(plr, category)"
wet island
<@759059524606099476> Also, here's what my approach would basically look like:
D...
but
why make a function
when you can recall it from a dictionary
minor nest
<@759059524606099476> Also, here's what my approach would basically look like:
D...
What if there’s more than 1 nested table
In a table
vagrant kindle
when you can recall it from a dictionary
it's cleaner and there may be a moment where there isn't an object in that spot of the dictionary.
minor nest
<@759059524606099476> Also, here's what my approach would basically look like:
D...
Do u have session locking in this
If not then u can lose data
wet island
it's cleaner and there may be a moment where there isn't an object in that spot ...
hm
what is session locking
like bindatclose
or whatever its called
minor nest
No
vagrant kindle
Since it's easier to:
local data = module:GetPlayerData()
if not data then return end
rather than
local data = module[categoryName][valueName]
if not data then return end
it makes your code cleaner and what not
minor nest
If player leaves server and data is in middle of being saved but before data is done being saved player is already in another server so the previous data is loaded
wet island
Since it's easier to:
```lua
local data = module:GetPlayerData()
if not data the...
true
vagrant kindle
what is session locking
It doesn't let players change their data if it's still being saved pretty much
wet island
I can see that
minor nest
I think session locking kicks the player if their data is in middle of being saved after they left on another server
That’s what it does for profile service at least
vagrant kindle
I think session locking kicks the player if their data is in middle of being sav...
There are numbers of different ways to do it
Some wait for the data to be saved before loading it, others kick the player
wet island
<@759059524606099476> Also, here's what my approach would basically look like:
D...
what's the stuff under it
self-explanatory?
minor nest
I never rly had to worry about data since I began using profile service a while ago so if u want to save urself a headache id suggest that but if u wanna be innovative and not be “spoon-fed” code feel free to make ur own stuff
vagrant kindle
what's the stuff under it
Basically if data isn't there it doesn't do anything
wet island
I never rly had to worry about data since I began using profile service a while ...
I make games for fun
vagrant kindle
Profiles module would handle each individual profile of a player.
Saving would well... handle saving. Such as making sure data is saved.
Loading would make sure the data from another server has saved before loading it
wet island
and a serverscript would handle the saving and loading?
vagrant kindle
No
They'll only get data of the players.
Or set it
Though you still would need 1 ServerScript to "Turn On" the module
wet island
ill implement the modulescript to be functions
vagrant kindle
For example:
The leaderboard script's playerAdded event could look like this:
local playerData = module:getPlayerCategory(player, "leaderboard") --in a get method, you could add a wait of sorts so that this script waits for the data to load.
if not playerData return end --Player doesn't have data.
--Do stuff
ah
isn't modulescripts used when a function is used more than once
getting/saving data is only like once
vagrant kindle
isn't modulescripts used when a function is used more than once
Yes\
vagrant kindle
getting/saving data is only like once
no
If you want clean scripts, then no, getting/saving data isn't done once
wet island
😨
vagrant kindle
Which is why you'd want a module script to do that
since a clean script only does what it needs to do
wet island
so
vagrant kindle
and having a script that you need to constantly update with new player data isn't a clean script
vagrant kindle
pro scripters have everything in modulescripts
Very roughly said, yes.
wet island
scary stuff
vagrant kindle
Modularity is very important in high-levels
vagrant kindle
Since it's easier to look through 300-ish lines of code in a module script than 2k-ish lines of code in a normal script to debug
vagrant kindle
is used *once*
That one would require context
wet island
Since it's easier to look through 300-ish lines of code in a module script than ...
highest i have is 550
vagrant kindle
Since if you're making let's say an IK script, yes, everything will be a module, since IK isn't something that would usually be done for 1 script
wet island
the hell is ik
vagrant kindle
Inverse Kinematics
wet island
ah
vagrant kindle
highest i have is 550
That was an extreme example, I'll admit but it's still accurate
Since let's say I made an AI with 7 states and I am having issue with only 1 of those states.
Would it be easier for me to look through hundreds of lines of code, jumping between the very top and the very bottom to find the issue or just look through the lines of code that only handle that one specifc state?
wet island
this is what im doing
vagrant kindle
this is what im doing
Why are the functions in an if statement 
and imo, you could separate them into a utility module
wet island
Why are the functions in an if statement <:evilcat:1161027214645665842>
bc there are 4 cases
equipping/unequipping
adding an item
removing an item
and moving around items in the inventory
I wanted them to be together
vagrant kindle
I wanted them to be together
That's the point you make them a module
Since code usually follows a structure of
Variables > Functions > Connections
And if you want them to be grouped together, you can just make them a module.
Though that would still need context if you should or not
wet island
I don't get the point of this being a module
knotty stag
Maybe use a table in a module that saves it to a profile store, so you when you need it the module auto updates it, I could be stupid but that’s my take
vagrant kindle
Grouping the code?
wet island
Maybe use a table in a module that saves it to a profile store, so you when you ...
dang everyone loves profileservice
vagrant kindle
dang everyone loves profileservice
Because they're scared of data storing
knotty stag
dang everyone loves profileservice
Or datastore, idc
wet island
Because they're scared of data storing
datastoring is scary
knotty stag
Because they're scared of data storing
It’s not that hard idk why people don’t like it
Save and upload, google, cry, discover you were stupid then fix and repeat
vagrant kindle
People prefer to be spoon-fed stuff rather than work for it.
knotty stag
Datastore workflow guys
knotty stag
People prefer to be spoon-fed stuff rather than work for it.
I work for it cuz I only can read my own code
Cuz I’m bad like that
vagrant kindle
@wet island Actually, I remember one of my first attempts at data-storing and I used several bad practices, I'll show you
vagrant kindle
Not minding the "LoadPasses" function, I've basically repeated the same code 3 times.
wet island
my initial idea was
vagrant kindle
Which I could of easily made into a module system like I shown an example before
vagrant kindle
Setting once is questionable
vagrant kindle
I prefer to have a auto-save every 2 minutes?
wet island
I prefer to have a auto-save every 2 minutes?
im doing 100seconds
vagrant kindle
If you want, you can add me if you're 17 and up, otherwise just a simple dm when you have a question will suffice
wet island
If you want, you can add me if you're 17 and up, otherwise just a simple dm when...
I am in fact not 17 and up
vagrant kindle
And to remind you of the answer:
Yes, it is secure and most of the time it's good enough.
wet island
yay
vagrant kindle
But for cases like the default roblox leaderboard, you'd need the Leaderboard script to update the values in the leaderstats and the dictionary at the same time.
wet island
datastoreservice
wet island
But for cases like the default roblox leaderboard, you'd need the Leaderboard sc...
I do not use default
I like things done all by me
auto-saving
vagrant kindle
I do not use default
It's literally just a folder named "leaderstats" parented to the player with a few values inside.
wet island
It's literally just a folder named "leaderstats" parented to the player with a f...
yeah I used it when I was starting
vagrant kindle
Dude
wet island
?
vagrant kindle
what the fuck are you doing with coroutine.resume(coroutine.create)
wet island
what the fuck are you doing with coroutine.resume(coroutine.create)
its a coroutine
I'm not that good with them
vagrant kindle
You can just use task.spawn()
Since I assume you're doing it so that it wouldn't block code that comes after it.
wet island
You can just use task.spawn()
ah
vagrant kindle
good luck gang
minor nest
Yall still here
wet island
https://cdn.discordapp.com/attachments/962002531360333917/1150575488083955783/818984049787666432.gif
minor nest
O
wet island
post closed