Help - variable not incrementing? | Roblox Studio Community | Page 1

light wind Apr 14, 2025, 2:21 PM

#

local item = game.Workspace.Cube
local ClickDetector = item:WaitForChild("ClickDetector")
local fireclientgui = game.ReplicatedStorage.Events.InventoryEvents.FireClientGui
local firepurchasegui = game.ReplicatedStorage.Events.InventoryEvents.FirePurchaseGui
local itemList = require(game.ServerScriptService.Inventory.ItemsModule)
local itemID = item:GetAttribute("ItemID")
local ItemName = itemList[itemID].Name
local ItemPrice = itemList[itemID].Price
local ItemCategory = itemList[itemID].Category
local DataManager = require(game.ServerScriptService.DataStore.Data.DataManager)

ClickDetector.MouseClick:Connect(function(player)
    firepurchasegui:FireClient(player, ItemName, ItemPrice)
end)

firepurchasegui.OnServerEvent:Connect(function(player)
    local Stack = 0

    if player.leaderstats.Coins.Value < ItemPrice then
        player.PlayerGui.Inventory.PurchaseFail.Visible = true
        task.wait(2)
        player.PlayerGui.Inventory.PurchaseFail.Visible = false
    else        
        DataManager.removeCoins(player, ItemPrice)
        
        local ItemCreate = Instance.new("NumberValue")
        ItemCreate.Name = itemID
        ItemCreate.Parent = player.owneditems

        --IMPORTANT PART HERE--
        for _, v in pairs (player.owneditems:GetChildren()) do
            print(v.Name)                                       --line 31
            print(itemID)                                       --line 32
            if v.Name == itemID then
                Stack += 1
            end
        end
        
        print(Stack)                                            --line 37
        --]]

        ItemCreate.Value = Stack
        fireclientgui:FireClient(player, ItemName, ItemCategory, itemID, Stack)
        player.PlayerGui.Inventory.PurchaseSuccess.Visible = true
        task.wait(2)
        player.PlayerGui.Inventory.PurchaseSuccess.Visible = false
    end
end)

#

The Output when firepurchasegui event is called:
1 - Server - InventoryHandler:31
1 - Server - InventoryHandler:32
0 - Server - InventoryHandler:37

if v.Name is equal to itemID then increment Stack by 1
Stack does not increment
.

#

The Output when called twice:
1 - Server - InventoryHandler:31
1 - Server - InventoryHandler:32
1 - Server - InventoryHandler:31
1 - Server - InventoryHandler:32
0 - Server - InventoryHandler:37

Stack should print '2' (line 37)

#

please help

gleaming mauve Apr 14, 2025, 3:14 PM

#

you got to give more detail

light wind Apr 14, 2025, 3:15 PM

#

sorry i didnt mean to ask in someone elses thread

gleaming mauve Apr 14, 2025, 3:15 PM

#

ok nvm i just need to read it

#

well you did, but its whatever

#

ill read

#

yeah because Stack is reset to 0 every time you call the event

light wind Apr 14, 2025, 3:16 PM

#

thats fine i want it to be 0

gleaming mauve Apr 14, 2025, 3:16 PM

#

oh right, i see

#

send the place file if it's small, it'll be easier

#

how many items are actually in player.ownedItems?

rose terrace Apr 14, 2025, 3:17 PM

#

light wind sorry i didnt mean to ask in someone elses thread

intresting

light wind Apr 14, 2025, 3:17 PM

#

let me recreate it in another place cuz its in a big game rn

rose terrace Apr 14, 2025, 3:18 PM

#

what game

gleaming mauve Apr 14, 2025, 3:18 PM

#

sure

rose terrace Apr 14, 2025, 3:18 PM

#

are you making

light wind Apr 14, 2025, 3:18 PM

#

this is an inventory system

gleaming mauve Apr 14, 2025, 3:18 PM

#

actually don't recreate it yet

#

lets bug test

#

add a print after your v.Name == itemID to see if it gets past there

light wind Apr 14, 2025, 3:21 PM

#

okayy

#

no it didnt print

gleaming mauve Apr 14, 2025, 3:24 PM

#

print what the itemID is at the start, and then what it is that you're actually comparing it to

#

to get a better picture of what's going on

light wind Apr 14, 2025, 3:24 PM

#

here i actually cloned this post because the first person to help me was not understanding me but i have a bunch of images that will help

#

the itemID is 1

#

hold on

#

woven saddle Apr 14, 2025, 3:25 PM

#

Wait

obtuse rootBOT Apr 14, 2025, 3:25 PM

#

studio ** You are now Level 3! ** studio

woven saddle Apr 14, 2025, 3:25 PM

#

is thisa local script?

light wind Apr 14, 2025, 3:25 PM

#

was

obtuse rootBOT Apr 14, 2025, 3:25 PM

#

studio ** You are now Level 5! ** studio

light wind Apr 14, 2025, 3:26 PM

#

but i chucked it into a regular script and still broken

#

this is old photo

woven saddle Apr 14, 2025, 3:26 PM

#

in the click detector?

gleaming mauve Apr 14, 2025, 3:26 PM

#

if v.Name == tostring(itemID) then

#

try that ^

#

maybe an issue with numbers vs strings

light wind Apr 14, 2025, 3:27 PM

#

okk yeah when i hover over both its v.Name: any and itemID: any

#

njot sure if that means much

woven saddle Apr 14, 2025, 3:27 PM

#

yk what i usually do?

gleaming mauve Apr 14, 2025, 3:27 PM

#

try it

woven saddle Apr 14, 2025, 3:27 PM

#

I onetime got stuck with this for hours

#

when i wasnt as good with scripting

#

when i made an amusement park I put in in starterplayerscripts THEN fired to serverscriptservice as an event -

`local userInputService = game:GetService("UserInputService")
local player = game.Players.LocalPlayer
--Variables

---Main Client For Starting Sunburst Express
game.Workspace:WaitForChild("StartTestRide").ClickDetector.MouseClick:Connect(function()
local Speed = game.Workspace.RideTweenScript.Speed
game.ReplicatedStorage.StartRide1:FireServer(Speed.Value)
end)`

light wind Apr 14, 2025, 3:29 PM

#

gleaming mauve if v.Name == tostring(itemID) then

legend

gleaming mauve Apr 14, 2025, 3:29 PM

#

fixed it?

woven saddle Apr 14, 2025, 3:29 PM

#

works?

light wind Apr 14, 2025, 3:29 PM

#

it actually works thankyou

gleaming mauve Apr 14, 2025, 3:29 PM

#

banger

light wind Apr 14, 2025, 3:29 PM

#

yes

woven saddle Apr 14, 2025, 3:29 PM

#

oh vcool

gleaming mauve Apr 14, 2025, 3:29 PM

#

yeah, just an issue of types

#

annoying one to debug tbf

light wind Apr 14, 2025, 3:30 PM

#

#

thanlkyouy so much man

gleaming mauve Apr 14, 2025, 3:30 PM

#

beautiful

#

no prob bob

#

how long you been stuck on that?

light wind Apr 14, 2025, 3:30 PM

#

lucky not too long about 2 days

gleaming mauve Apr 14, 2025, 3:30 PM

#

dang still

#

anyways

light wind Apr 14, 2025, 3:30 PM

#

since early yesterday

woven saddle Apr 14, 2025, 3:31 PM

#

anyone wanna check out my github page

gleaming mauve Apr 14, 2025, 3:31 PM

#

no brother

light wind Apr 14, 2025, 3:32 PM

#

you know i actually did try
local name = tostring(itemID)
v.Name == name

#

and that didnt work

gleaming mauve Apr 14, 2025, 3:33 PM

#

really?

light wind Apr 14, 2025, 3:33 PM

#

so yeah scripting really picky sometimes

gleaming mauve Apr 14, 2025, 3:33 PM

#

seems like it should

#

unless you did it the other way around?

light wind Apr 14, 2025, 3:33 PM

#

this was back on localscript tho

gleaming mauve Apr 14, 2025, 3:33 PM

#

¯_(ツ)_/¯

light wind Apr 14, 2025, 3:33 PM

#

yeah i think ur right

woven saddle Apr 14, 2025, 3:33 PM

#

light wind so yeah scripting really picky sometimes

fr

gleaming mauve Apr 14, 2025, 3:33 PM

#

mustve been the other way around yeah

#

thats a shame, you were so close to solving it then

#

lol

light wind Apr 14, 2025, 3:33 PM

#

i think i set tostring(v.Name)

woven saddle Apr 14, 2025, 3:34 PM

#

I used to think Roblox studio was just not working

light wind Apr 14, 2025, 3:34 PM

#

something liek that

gleaming mauve Apr 14, 2025, 3:34 PM

#

ryan why are you here

woven saddle Apr 14, 2025, 3:34 PM

#

idk

#

I've been helping other people

light wind Apr 14, 2025, 3:34 PM

#

i was also reading over other peoples scripts to see if i could help while waiting

#

which was why i was in the other thread

#

cheers again lightlim youre a legend

gleaming mauve Apr 14, 2025, 3:35 PM

#

no prob bob

#Help - variable not incrementing?