datastorage not functioning

[round cairn]

Hi so i have a datastorage for my game, and it wont save for some reason? its the XP/LEVELING part that wont save. so if i reach like level 2 and rejoin i am back at level 1. and idk if its my datastorage script or a localscript please help me figure it out someone! (idk which script isnt working)

[round cairn]

uhm

so idk what to look for..

[little gale]

uh

the datastore

[round cairn]

alr

local Players = game:GetService("Players")

local playerDataStore = DataStoreService:GetDataStore("XPLevelData")

Players.PlayerAdded:Connect(function(player)
    -- Setup leaderstats
    local leaderstats = Instance.new("Folder")
    leaderstats.Name = "leaderstats"
    leaderstats.Parent = player

    local XP = Instance.new("IntValue")
    XP.Name = "XP"
    XP.Value = 0
    XP.Parent = leaderstats

    local Level = Instance.new("IntValue")
    Level.Name = "Level"
    Level.Value = 1
    Level.Parent = leaderstats

    -- Load saved data
    local success, data = pcall(function()
        return playerDataStore:GetAsync(player.UserId)
    end)

    if success and data then
        XP.Value = data.XP or 0
        Level.Value = data.Level or 1
        print("Loaded data for", player.Name, "| XP:", XP.Value, "| Level:", Level.Value)
    else
        if not success then
            warn("Error loading data for", player.Name)
        else
            print("No saved data found for", player.Name)
        end
    end
end)

Players.PlayerRemoving:Connect(function(player)
    local success, err = pcall(function()
        playerDataStore:SetAsync(player.UserId, {
            XP = player.leaderstats.XP.Value,
            Level = player.leaderstats.Level.Value
        })
    end)

    if success then
        print("✅ Saved data for", player.Name, "| XP:", player.leaderstats.XP.Value, "| Level:", player.leaderstats.Level.Value)
    else
        warn("❌ Failed to save player data for", player.Name, ":", err)
    end
end)

i used chatgpt to help me but yeah didnt work

i got API enabled n etc

[little gale]

any erros?

[round cairn]

none..

after getting level 2

and i rejoin i get sent back to level 1

both on studio and on roblox

[little gale]

lemme see

[round cairn]

how

do i invite to studio or

[little gale]

Ill just tell you whats wrong

[round cairn]

okk

[little gale]

just use indexes for loading and saving instead of data.XP and data.Level

wait

lemme look up if that makes a difference, not sure

[round cairn]

im new to scripting as well.. so idk how that works..

and do you feel like joining my project? 😭

[little gale]

not if your using chatgpt to make it

unless your paying me

[round cairn]

i aint that good at scripting man

[round cairn]

500rs?

[little gale]

wait what game even is this

[round cairn]

dark fantasy type of game

i already have a "zone" ish area

so once u enter like a dark area it becomes mystic and dark

and i have the stamina, health, and xp bar done

which works

as well as a keybinds ig? for mute, settings etc

[little gale]

is this your first project tho?

[round cairn]

no

ive made multiple

this time i want to make a somewhat small project or a actual game

and if it goes somewhat successful i will focus on it

i already got like 1k visits on a old game from 2019

no scripting nothing, just simple toolbox items

and dark fantasy is kind of a trend on tt rn

[little gale]

are you using toolbox items for this one?

[round cairn]

only the animals and maybe trees for XP

[little gale]

well then no

[round cairn]

??

i cant fully invest into this yet xd

[little gale]

free models are so dangerous bruh

[round cairn]

if it gets 5-10+ active players or so then ofc i will invest more and get actual modelers/builders

[little gale]

also is your script printing anything

because

you have print statements

[round cairn]

no it didnt print anything

[little gale]

yea but you only have error and warning enabled

enable it all

[round cairn]

ah f

[little gale]

what is it saying

[round cairn]

i ended up deleting the orginal playerdatasave script

and made a new one

and it ended up printing

i used indexes

local DataStoreService = game:GetService("DataStoreService")

local playerDataStore = DataStoreService:GetDataStore("XPLevelData")

-- === Load Data on Player Join
Players.PlayerAdded:Connect(function(player)
    -- Setup Attributes (safe defaults)
    player:SetAttribute("XP", 0)
    player:SetAttribute("Level", 1)

    -- Try to load data
    local success, data = pcall(function()
        return playerDataStore:GetAsync(player.UserId)
    end)

    if success and data then
        print(":white_check_mark: Loaded data for", player.Name, data)

        player:SetAttribute("XP", data["XP"] or 0)
        player:SetAttribute("Level", data["Level"] or 1)
    else
        if not success then
            warn(":x: Failed to load data for", player.Name)
        else
            print(":detective: No saved data found for", player.Name)
        end
    end
end)

-- === Save Data on Player Leave
Players.PlayerRemoving:Connect(function(player)
    local data = {
        ["XP"] = player:GetAttribute("XP"),
        ["Level"] = player:GetAttribute("Level")
    }

    local success, err = pcall(function()
        playerDataStore:SetAsync(player.UserId, data)
    end)

    if success then
        print(":floppy_disk: Saved data for", player.Name, data)
    else
        warn(":x: Failed to save data for", player.Name, err)
    end
end)

-- === Save Data on Server Shutdown
game:BindToClose(function()
    for _, player in ipairs(Players:GetPlayers()) do
        local data = {
            ["XP"] = player:GetAttribute("XP"),
            ["Level"] = player:GetAttribute("Level")
        }

        local success, err = pcall(function()
            playerDataStore:SetAsync(player.UserId, data)
        end)

        if success then
            print(":floppy_disk: (Shutdown) Saved data for", player.Name, data)
        else
            warn(":x: (Shutdown) Failed to save", player.Name, err)
        end
    end
end)

[little gale]

um

why are you using attributes

[pastel cairn]

look for errors, and chatgpt forgot to add game:bindtoclose. classic chatgpt

[little gale]

also did the old script print anything?

[round cairn]

for my XP i believe

[blazing spruce]

** You are now Level 6! **

[pastel cairn]

lol chatgpt added it on the second try

[round cairn]

old scrip uh

no

it didnt print anything

[little gale]

are you sure

[round cairn]

ye

[little gale]

you checked all the boxes

[round cairn]

no

yes it did print

[little gale]

because here it says there are 5 in log

[round cairn]

my bad

[little gale]

bruh

what does it say

[round cairn]

idk if i should use the new script or js the old one

[little gale]

and you left the game with 2 levels before running again

?

[round cairn]

i joined the game with level 1, and i got to level2, and left

its supposed to save automatically no?

[little gale]

what did it print after you left with level 2

[pastel cairn]

is this your game?

[round cairn]

let me see

[round cairn]

yes

[pastel cairn]

how are you adding levels and xp?

[round cairn]

after leaving with levle2

[pastel cairn]

i'd wager you're doing player:AddXP() on the client

[little gale]

welp

your changing data on the client

most likely

[pastel cairn]

ye looks like you're adding levels/xp on the client

[little gale]

that screenshot says it all

[pastel cairn]

which the server doesnt know about

[round cairn]

believe it or not this chatgpt actually is somewhat accurate, it made me a somewhat of a decent advanced system and more which a typical normal chatgpt doesnt

[round cairn]

oh

[pastel cairn]

which didn't work

[round cairn]

for this yes

[little gale]

I was about to say

[little gale]

well then it should save

💀

[round cairn]

how can i resolve this..

[pastel cairn]

ask the guy who wrote the code

[fast spoke]

first rule in testing data saving, dont change data in client

[little gale]

use a remote event to send a message to change data on the server

or re-write the system

[pastel cairn]

knowing the problem is one thing, fixing it is a whole different problem, specially in cases like this

[pastel cairn]

yeah anywhere that works with levels/xp needs to be reworked

[round cairn]

playerdatasave?

[little gale]

huh?

[round cairn]

the script

oh wait

i have my XP/leveling on

local script

so i should make it local ye?

[little gale]

thats literally what we said

[round cairn]

script*

[little gale]

not to make it local

[round cairn]

yeah script **

[pastel cairn]

frankly if you don't do it properly you're opening your game wide to exploiters. lol remoteevent.OnServerEvent:Connect(function(plr,item,cost) plr.Money-=cost plr:GiveItem(item) end)

[little gale]

yea people gonna be getting to endgame instantly

[round cairn]

dont believe people would want to cheat in a unknown game, but if it do get succesful somehow i will invest robux and make it better

[round cairn]

no endgame honestly

open world game

[pastel cairn]

bruh my game has less than 1k visitors and my automatic anti-skid system autobanned an exploiter.

[little gale]

so no gameplay loop?

because

[pastel cairn]

less than 1k visits, already first exploiter, and that's only the one that was caught

[round cairn]

there will eventually be a end but not yet

[little gale]

well when there is one then someone will cheat to the end asap

[pastel cairn]

that's a 100% guaranteed confirmed exploiter btw, there ain't no false positives with the way that skid got banned

[round cairn]

then he aint gonna get the experience of the game so idc abt him

[pastel cairn]

so yeah, believe it or not

[little gale]

other players will 😂

[blazing spruce]

** You are now Level 17! **

[round cairn]

the whole point is to go through a adventure, defeat bosses, side quests, so if he goes to end then no point?

[little gale]

ruins it for others

people leave because of it

dead game

[round cairn]

how abt i worry about that once i receive like 5+ daily active players or so?

right now its a small project/test

[pastel cairn]

smooth brain approach but hey, ngl, if you'd rather prioritize the actual gameplay than correcting for exploiters, honestly if your game does any decently you can probably just hire a scripter later on to seek, locate, and squash and exploitability in your code

[round cairn]

if it goes somewhat decent i will invest for scripters

[little gale]

great idea, now you have to add a new system super quickly when the game gets some players

[pastel cairn]

that's a good approach 💯

[little gale]

and by that point it will be too late

[little gale]

fun fact: it wont go decent without scripters

[pastel cairn]

eh you never know

[round cairn]

again i will hire scripters once i see some action going on

[little gale]

I guess

[little gale]

https://tenor.com/view/movie-one-eternity-later-gif-7900643

[round cairn]

if i hire rn, it can be a waste or success

[little gale]

or just like find willing people and give revenue share

[round cairn]

u want %?

[little gale]

nope

[round cairn]

exactly nobody wants %

[little gale]

A. I already lead a team
B. You gave me a bad impression as a planner

[round cairn]

?? this isnt my final game dude

im literally trying and testing

and if my test goes good i will invest

[little gale]

I know

[round cairn]

u want me to add super high end anticheat for my test game?

[little gale]

yes but your plan for the game kinda is not the best

[pastel cairn]

it is a very fair idea to prioritize developing the actual game first. anticheat can come in at a close second. it's not uncommon for brand new games to completely reset player data (with consideration given to player robux purchases) so i mean if you state that somewhere people won't mind the exploiters until the game has an opportunity to first have that as a problem it needs to care about and then second have a chance to do something about it

[pastel cairn]

so actually it's a better plan than most other people have who trap themselves in analysis paralysis trying to figure out how to make the game they want to make while also accounting for exploiters at the same time. nah, game first bruh.

[round cairn]

odds of them even cheating at a unknown game is really low imo

but again even if cheaters ruin my game

it will ruin for a couple people

[little gale]

honestly just do what you think is best

[round cairn]

by that time i can hire scripers

so again about the uhm local script, how do i change it to a script?

[little gale]

trial and error is best

[little gale]

probably best to rewrite some of the XP system considering you have it changing on the client

[pastel cairn]

practice makes perfect follow the fun

[little gale]

yup

[round cairn]

this is my uhh Xphandler is this the one?

although i have high hopes it will succeed

[pastel cairn]

it has userinputservice which is clientside only, so yeah that's a script you'll probably need to change, particularly since it has this function in it:

-- === Award XP Function
local function awardXP(amount)```

awardXP should usually happen on server not client

[round cairn]

ah

guess chatgpt thought it was gonna be single player game

do i ask it to rewrite the local into a script, that isnt single player but rather multi or?

[pastel cairn]

it did sound like a singleplayer game. pick your priorities i guess. i think you're right to follow the fun and simply make a working game first, you can worry about this later

[round cairn]

the brain capacity of my 2 braincells is too much to handle here

[round cairn]

it was meant for a multiplayer game

like survival,open world etc

[little gale]

But I do have a tip in case your not doing so already: Learn a skill or 2 (Scripting, Builder, Gfx, Vfx, music, etc.) and practice practice practice. Dont overwhelm yourself learning a whole bunch of stuff all at once especially as a new aspiring dev

[round cairn]

any chance i could hire you if this goes well? and how much would it cost?

[little gale]

I tried that once, burnout in the first 2 weeks

[round cairn]

i mainly focus on building

to master a language can take a year or more

smth i dont plan on doing tbh

[little gale]

also if you have the option, find a friend that wants to make games so that you can help each other figure things out. The more the better

its always much more fun working with someone else

but its your choice still

[pastel cairn]

i would need to see more than a fantasy game wishlist and ai code to agree to anything you can even theoretically afford

[round cairn]

meaning

[pastel cairn]

i don't care much for builders since i can build myself, you'd have to have a very dashing portfolio that competes with other builders in #👷︱for-hire in your price range. if you had related building skills like modelling, texturing, csg, or non-humanoid animation, maybe i'd have work for you, but.. yea building can mean a lot of different things.

if your best work is a gas station, that isn't good enough for what i'm looking for

it's good, but i need more than a few days of tedium putting together a storefront

[little gale]

Welp ima head out, good luck on your journey

[round cairn]

no its not a gas station xd

but uhm i believe we are on wrong track, so could u help me out w the script?..

[pastel cairn]

didn't we already do that?

[round cairn]

so i gotta redo everything?..

[pastel cairn]

i mean let's be honest here you know nothing about coding, ai is doing all the heavy lifiting, so even if i told you how to solve it, you wouldn't even know where to start. chatgpt is doing it for you. that's why i say maybe try asking the person who wrote this code for you we helped you with the problem, but if we just simply do it for you, that's not help anymore, that's just free labor

[round cairn]

thought u were being sarcastic w the ask the person who wrote it..

[pastel cairn]

half and half not sarcastic in the sense that if you don't know how to code and don't want to learn, then go back to the ai with knowing what the problem is, or hire someone 👍

[round cairn]

alright thanks for letting me know