[✓1.17.17] Stabling Sensor - Not all reachable platforms offered for use in shunting queue

[obsidian ice]

Game version: 1.17.15
OS: Win 10

Steps to reproduce:

1. Select Stabling Sensor (e.g. Wilson Pl. 6)
2. Add commands to shunt a train from the platform to the shunting track
3. After the Reverse Train command, it's possible to shunt the train back to the stations

Wrong behaviour:
Following step 3 of reproduction, only one platform (in this case 8) is given as a platform alternative although platforms 4, 6 and 8 can be reached from the shunting track

Expected behaviour:
It would make much more sense for all possible (reachable) platforms to be offered as alternatives, in this case platforms 4, 6 and 8

Map:
The default Prague map (the one delivered with the game)

Screenshot:
Attached

Save:
Attached

Log:
Attached

[full vale]

Nice build-up!

It is our design decision to show only one command icon for all platforms & for each shunting group.

However, all reachable platforms and all reachable tracks in shunting group should be highlighted on hover. That is the actual bug here

[wild topaz]

Issue RR-3115 has been assigned to this thread.
https://bitrich.youtrack.cloud/issue/RR-3115

Mišo

Other reachable platforms & shunting tracks are not highlighted when Go to platform / Go to shunting group command is hovered

1. Load save prague_notall-17_02-18-00_df00a.mp.lz4
2. Edit command queue for Wilson Station #7 stabling sensor
3. Hover shown Go to Shunting Group candidate
4. Edit command queue for Wilson Station #6 stabling sensor
5. Hover shown Go to platform candidate

Expected behavior: both shunting tracks of group C / all reachable platforms are highlighted

Actual behavior: only track where command is displayed is highlighted

Open Discord Thread

State

Open

Assignee

Unassigned

Priority

Normal

Created

Thu Nov 16 2023 07:50:58 GMT+0000 (GMT)

Updated

Thu Nov 16 2023 07:51:55 GMT+0000 (GMT)

Issue ID: RR-3115 | Last updated: Thu Nov 16 2023 07:52:03 GMT+0000 (GMT)

[stoic hinge]

great! that would clear up some confusion i initially had with shunting groups. this would also make it more visible if there's an error in the tracks and one of the shunting group tracks cannot be reached

[wild topaz]

no it was not like that

we always offer only one icon with go to platform and highlight one path

[stoic hinge]

FWIW i need at least some visual indication that makes it clear that a go to platform command is not necessarily specific for that platform (it isn't, right?)

[full vale]

no, it is not

[obsidian ice]

@full vale: Not sure if I understood the bug about the hover correctly... but, for me, the issue is that the manual shunting instructions work differently...

[marsh crypt]

Because it reads the trains departure platform when you use the "manual" shunting commands. The sensor can't know that upfront, but we still should be able to choose freely what platform to include in the queue 👍

[obsidian ice]

Referring to the 2 screenshots, when using manual shunting instructions, you are also only offered one alternative for the Go to Platform command but the system intuitively 'offers' the platform which is specified in the train's timetable.

[full vale]

Yes, as @marsh crypt wrote, the game "knows" the train, can trace its leg switch and offers its future platform

In sensor, the game does not know the train, so offers the platform but with indiscirminate placement.

[obsidian ice]

Yes that's true, didn't think of that, so I suppose what I'm really asking for is a "Go to Platform according to the train's timetable" option... And if the timetable says "Any" then I suppose we'd need to allocate manually.

[marsh crypt]

For a start, I want to be able to choose freely among the reachable platforms when using the sensor. Not just be given a default one and stick with that. I can't f.ex guide it to different platforms based on next destination as it is now. Or so it seems anyway, since we only get one platform option.

Without using the go to signal (end of platform) method as I have been using until now.

[full vale]

You are using GoToSignalShuntingCommand correctly to do what you want.

GoToPlatformShuntingCommand is indeed GoToPlatformByTrainTimetableOrAnyAvailableAndReachablePlatformIfPlatformNotDesignatedShuntingCommand

[marsh crypt]

Fair enough and don't necessary disagree on the choices here! But maybe not so intuitive, specially for new players? Then the question is, do we need the go to platform command at all? Or can we make it with just the go to signal command... (On the sensor, I mean)

[stoic hinge]

GoToPlatform is necessary because different trains that are stabled at the same shunting group may have different platforms assigned in their schedule

a GoToSignal in that case feels like an abuse - we want the train to stop centered at the platform, not directly at the signal

[marsh crypt]

This is for the command queue at the stabling sensor - it doesn't take the schedule in account anyway as with manual shunting commands per train. It was more like a question of - If they do not intend to show us all reachable platforms when setting up the sensors commands and only giving us the default one, why have it there as an option if it just confuses 😛 But yeah, I rather want this #1174476504164466708 message

[stoic hinge]

it doesn't take the schedule into account in the definition at the stabling sensor but it does when executing the command for a specific train, which is correct for me

[stoic hinge]

exactly this semantics from the long name is right for me. it's the train schedule's responsibility to define the target platform after shunting

[wild topaz]

@full vale Why we did not show the go to platform on all platforms actually?

that could solve it

the bad was that when you select one, the resulted queue was on diferent one (as we dont store the concrete platform / group). I feel this is the reason. You would click on some platform but the line would be then drawn on diffeernt one

[full vale]

I remember we thought one icon with all platforms highlighted when hovered will be cleaner than 10 icons to add the same command.

[marsh crypt]

OK, seems I have mixed up what the command did - It works as intended for each train according to timetable. The confusion comes from having the icon sitting on one of the platforms and you not understanding that it works similar to the shunting group command. Maybe there is a need in the UI to differentiate the 2 (manual shunting command and stabling sensor) in the UI to understand what the gotoplatform command does. Or with a tooltip...

[wild topaz]

Issue RR-3115 changed state from To Verify to Done.
https://bitrich.youtrack.cloud/issue/RR-3115

Mišo

Highlight other reachable platforms & shunting tracks when Go to platform / Go to shunting group command is hovered

1. Load save prague_notall-17_02-18-00_df00a.mp.lz4
2. Edit command queue for Wilson Station #7 stabling sensor
3. Hover shown Go to Shunting Group candidate
4. Edit command queue for Wilson Station #6 stabling sensor
5. Hover shown Go to platform candidate

Desired behavior: both shunting tracks of group C / all reachable platforms are highlighted

Actual behavior: only track where command is displayed is highlighted

Open Discord Thread

State

To Verify ➡️ Done

Assignee

Unassigned

Priority

Normal

Created

Thu Nov 16 2023 07:50:58 GMT+0000 (GMT)

Updated

Mon Nov 20 2023 08:08:50 GMT+0000 (GMT)

Issue ID: RR-3115 | Last updated: Mon Nov 20 2023 09:03:24 GMT+0000 (GMT)

[full vale]

@marsh crypt @stoic hinge @obsidian ice

UPDATE: All platforms and all shunting tracks in a group light up when hovering over a got to platform or shunting group command
BUILD: 1.17.17

[✓1.17.17] Stabling Sensor - Not all reachable platforms offered for use in shunting queue

[obsidian ice]

Fix verified as working in 1.17.17. Great bit of functionality as it routes the trains to the timetabled platform.