Bounce jellyfish crash

[steep delta]

I've been messing around with the Bounce Jellyfish in Bounce Helper, and for a while it worked just fine, but today it randomly crashed a few times for me. It usually happened when I threw the jelly and died shortly after, not sure if it has any correlation. Any ideas?

ok i've noticed that it happens consistently if i throw the jelly and just die to a spinner in a very specific way

[grizzled fable]

@brittle sphinx hihi, this is your bug.
To resolve this, simply add a player is null check at the beginning of the function:
https://github.com/FlynnSC/BounceHelper/blob/main/Entities/BounceJellyFish.cs#L162
Player player = getPlayer(); if(player == null) yield break; var playerData = new DynData<Player>(player);

this should resolve it

[steep delta]

so that happens in a specific moment when the player dies?

i was able to do it somewhat consistently but not sure what exactly causes it. Maybe it was dying to the barrier at the same point i was dying, idk

[grizzled fable]

i think

its when you try to dash when player is ded

[steep delta]

ohhh that makes sense cuz i use jelly dashes to go past some obstacles

[brittle sphinx]

huh, a strange one. Thanks @steep delta for finding this and @grizzled fable for diagnosing it and even providing a fix . I should be able to push the fix along with a couple other changes some time in the next couple days

[undone yew]

I submitted a pr for peformance, hope it will be merged in the next release
https://github.com/FlynnSC/BounceHelper/pull/1

[brittle sphinx]

oh wtf, that's great! Never thought I'd get a pr on this 😅 Thanks a bunch, yeah I'll include these changes for sure

this is pretty interesting though

oh wait, I just realised that's the everest version rather than the version of bouncehelper, never mind

[brittle sphinx]

So did you actually experience a noticeable performance improvement due to the switch to DynamicData? Also what was the rationale behind changing onLevelEnter to onLevelBegin?

ah I assume the latter was this

[undone yew]

performance impact is not obvious for normal play, but beneficial to tas fast forward
the onLevelBegin change was used to fix bounce is still enabled when load into other chapter via command

for example, if you enter load 1 command in your test map, the bounce should be disabled

onLevelEnter is only called when entering a chapter via overworld, not when using the command

[brittle sphinx]

yeah makes sense, thanks again for the changes, experiencing the beauty of OSS first-hand here 😳. Are you currently TASing a map that uses bounce helper?

[undone yew]

No, I'm just maintaining the tas mod