Celeste Publicizer did a funny | Mt. Celeste Climbing Association | Page 1

odd spruce Feb 22, 2024, 5:02 AM

#

I had a working entity about a year ago, and recently tried it out after upgrading to Core, and it seems to have broken with an inscrutable error message.

System.ArgumentException: Undefined resource string ID:0x80070057
   at Celeste.Mod.ClonazepamHelper.Entities.OverlayManager.Unload(String tag)
   at Celeste.Mod.ClonazepamHelper.Entities.FestivalController.<>c__DisplayClass8_0.<TransitionRoutine>b__2()
   at Monocle.Scene.AfterUpdate()
   at DMD<System.Void Monocle.Engine:Update(Microsoft.Xna.Framework.GameTime)>(Engine this, GameTime gameTime)
   at ExtendedVariants.Variants.NoFreezeFrames.onEngineUpdate(orig_Update orig, Engine self, GameTime gameTime)
   at Hook<System.Void ExtendedVariants.Variants.NoFreezeFrames::onEngineUpdate(On.Monocle.Engine+orig_Update,Monocle.Engine,Microsoft.Xna.Framework.GameTime)>(Engine , GameTime )
   at SyncProxy<System.Void Monocle.Engine:Update(Microsoft.Xna.Framework.GameTime)>(Engine , GameTime )
   at Celeste.Celeste.Update(GameTime gameTime)
   at Microsoft.Xna.Framework.Game.Tick()
   at Microsoft.Xna.Framework.Game.RunLoop()
   at Microsoft.Xna.Framework.Game.Run()
   at Monocle.Engine.RunWithLogging()

The Unload function is as follows:

public static void Unload(string tag) {
    if (tag == null) {
        throw new ArgumentException("Tag must not be null");                                                                             }
    var player = Engine.Scene.Tracker.GetEntity<Player>();
    foreach (var entity in TaggedEntities(tag)) {
        if (entity is Trigger t && t.PlayerIsInside && player != null) {
            t.OnLeave(player);
            player.triggersInside.Remove(t);
        }
        entity.RemoveSelf();
    }
}

Which is itself being called by: this.Level.OnEndOfFrame += () => OverlayManager.Unload(oldRoom);

Not sure what to make of this error message. Any pointers?

#

Linux/x86_64, everest 4607

odd spruce Feb 24, 2024, 1:45 PM

#

Bumping this in the hopes that someone who knows what’s up will see it…

astral apex Feb 24, 2024, 10:48 PM

#

That Undefined resource string ID:0x80070057 isnt from an error message, but rather the runtime not being able to find the string
I assume tag was null and your exception was thrown

#

however i dont know why it might not find the string

odd spruce Feb 26, 2024, 4:31 AM

#

I think that's not the issue

#

I think this is an issue with the private member access player.triggersInside

#

I determined this by realizing that it was also crashing in a different method, an entity constructor which not only threw no exceptions but also used no string literals

#

and then removing the private member access made everything work

#

here's my csproj - is there anything weird that looks like the private linkage wouldn't work?

📎 ClonazepamHelper.csproj

astral apex Feb 26, 2024, 7:31 AM

#

No that should work thinkeline

dark sierra Feb 26, 2024, 12:41 PM

#

That error ID is ERROR_INVALID_PARAMETER btw, and considering it seems to break resource localization I have a feeling this is the JIT throwing an exception during method compilation which is so rarely seen that they didn't implement it right catresort

#

Can you try to manually compile the method using RuntimeHelpers.PrepareMethod and see if that throws?

odd spruce Feb 26, 2024, 5:44 PM

#

teehee

#

System.ArgumentException: Undefined resource string ID:0x80070057
   at System.Runtime.CompilerServices.RuntimeHelpers.PrepareMethod(RuntimeMethodHandle method, RuntimeTypeHandle[] instantiation)
   at Celeste.Mod.ClonazepamHelper.Entities.BouncyBooster.Load() in Code/Entities/BouncyBooster.cs:line 69
   at Celeste.Mod.ClonazepamHelper.ClonazepamModule.Load() in Code/ClonazepamModule.cs:line 23
   at DMD<System.Void Celeste.Mod.Everest:Register(Celeste.Mod.EverestModule)>(EverestModule module)
   at Celeste.Mod.MaxHelpingHand.Module.MaxHelpingHandModule.onModRegister(Action`1 orig, EverestModule module)
   at Hook<Celeste.Mod.Everest::Register>?17045391(EverestModule )
   at SyncProxy<System.Void Celeste.Mod.Everest:Register(Celeste.Mod.EverestModule)>(EverestModule )
   at Celeste.Mod.Everest.Loader.LoadModAssembly(EverestModuleMetadata meta, Assembly asm)
   at Celeste.Mod.Everest.Loader.LoadMod(EverestModuleMetadata meta)
   at Celeste.Mod.Everest.CheckDependenciesOfDelayedMods()
   at Celeste.Mod.Everest.Loader.LoadAuto()
   at Celeste.Mod.Everest.Boot()
   at Celeste.Celeste..ctor()
   at Celeste.Celeste.orig_Main(String[] args)

odd spruce Feb 27, 2024, 8:30 AM

#

paging @dark sierra whenever you have time

dark sierra Feb 27, 2024, 8:31 AM

#

Uhhhhhhh, to be honest I have no idea what to do after that sunnyleave

odd spruce Feb 27, 2024, 8:31 AM

#

so true

#

I tried running celeste under dotnet8 and it did the same thing

unreal canyon Feb 27, 2024, 8:55 AM

#

everest still runs on .net 7 behind the scenes

dark sierra Feb 27, 2024, 9:39 AM

#

You might wanna try creating a runtime log using something along these lines

#

https://github.com/dotnet/runtime/issues/4084#issuecomment-87098562

odd spruce Feb 27, 2024, 5:59 PM

#

I tried it on windows and got a real error message!

#

System.ArgumentException: Value does not fall within the expected range.
   at System.Runtime.CompilerServices.RuntimeHelpers.PrepareMethod(RuntimeMethodHandleInternal method, IntPtr* pInstantiation, Int32 cInstantiation)
   at System.Runtime.CompilerServices.RuntimeHelpers.PrepareMethod(RuntimeMethodHandle method, RuntimeTypeHandle[] instantiation)
   at Celeste.Mod.ClonazepamHelper.Entities.BouncyBooster.Load()
   at Celeste.Mod.ClonazepamHelper.ClonazepamModule.Load()
   at DMD<System.Void Celeste.Mod.Everest:Register(Celeste.Mod.EverestModule)>(EverestModule module)
   at Celeste.Mod.MaxHelpingHand.Module.MaxHelpingHandModule.onModRegister(Action`1 orig, EverestModule module)
   at Hook<Celeste.Mod.Everest::Register>?56349145(EverestModule )
   at SyncProxy<System.Void Celeste.Mod.Everest:Register(Celeste.Mod.EverestModule)>(EverestModule )
   at Celeste.Mod.Everest.Loader.LoadModAssembly(EverestModuleMetadata meta, Assembly asm)
   at Celeste.Mod.Everest.Loader.LoadMod(EverestModuleMetadata meta)
   at Celeste.Mod.Everest.CheckDependenciesOfDelayedMods()
   at Celeste.Mod.Everest.Loader.LoadAuto()
   at Celeste.Mod.Everest.Boot()
   at Celeste.Celeste..ctor()
   at Celeste.Celeste.orig_Main(String[] args)

#

I popped it open in a decompiler. nothing looks weird about this?

#

    IL_0129: ldarg.0      // this
    IL_012a: ldfld        class [Celeste]Monocle.Wiggler [Celeste]Celeste.Booster::wiggler
    IL_012f: callvirt     instance void [Celeste]Monocle.Wiggler::Start()

granite lintel Feb 27, 2024, 6:09 PM

#

just as a sanity check, does it work with only the bepinex publicizer without the custom celeste one?

odd spruce Feb 27, 2024, 6:11 PM

#

can you link that

#

https://github.com/BepInEx/BepInEx.AssemblyPublicizer ?

GitHub

GitHub - BepInEx/BepInEx.AssemblyPublicizer

Contribute to BepInEx/BepInEx.AssemblyPublicizer development by creating an account on GitHub.

unreal canyon Feb 27, 2024, 6:13 PM

#

yup

odd spruce Feb 27, 2024, 6:15 PM

#

holy shit. it works

unreal canyon Feb 27, 2024, 6:16 PM

#

@astral apex widergladeline3 ?

#

apparently celeste publicizer did a funny

odd spruce Feb 27, 2024, 6:19 PM

#

Celeste Publicizer did a funny

astral apex Feb 27, 2024, 6:52 PM

#

Whar?!

#

I have no idea how it would cause that?!

astral apex Feb 27, 2024, 7:42 PM

#

@odd spruce can you send your project and steps to reproduce

#Celeste Publicizer did a funny