[Lua cutscenes] choiceDialog() not working? | Mt. Celeste Climbing Association | Page 1

unborn inlet Nov 30, 2023, 11:55 AM

#

choiceDialog({
        {"Dzhake_Cuteline_1_6_1"},
        {"Dzhake_Cuteline_1_6_2"},
        {"Dzhake_Cuteline_1_6_3"},
        {"Dzhake_Cuteline_1_6_4"},
        {"Dzhake_Cuteline_1_6_5"}
    })

And error in log.txt is:

System.InvalidCastException: Object cannot be stored in an array of this type.
   at System.Array.InternalSetValue(Object value, IntPtr flattenedIndex)
   at NLua.MetaFunctions.CreateParamsArray(Lua luaState, ExtractValue extractValue, Type paramArrayType, Int32 startIndex, Int32 count) in /home/vsts/work/1/s/external/NLua/src/Metatables.cs:line 1509
   at NLua.MetaFunctions.MatchParameters(Lua luaState, MethodBase method, MethodCache methodCache, Int32 skipParam) in /home/vsts/work/1/s/external/NLua/src/Metatables.cs:line 1523
   at NLua.Method.LuaMethodWrapper.CallMethodFromName(Lua luaState) in /home/vsts/work/1/s/external/NLua/src/Method/LuaMethodWrapper.cs:line 205
   at NLua.Method.LuaMethodWrapper.Call(IntPtr state) in /home/vsts/work/1/s/external/NLua/src/Method/LuaMethodWrapper.cs:line 310
   at NLua.MetaFunctions.RunFunctionDelegate(IntPtr luaState) in /home/vsts/work/1/s/external/NLua/src/Metatables.cs:line 112
   at KeraLua.NativeMethods.lua_pcallk(IntPtr luaState, Int32 nargs, Int32 nresults, Int32 errorfunc, IntPtr ctx, IntPtr k)
   at NLua.Lua.CallFunction(Object function, Object[] args, Type[] returnTypes) in /home/vsts/work/1/s/external/NLua/src/Lua.cs:line 847
   at NLua.LuaFunction.Call(Object[] args) in /home/vsts/work/1/s/external/NLua/src/LuaFunction.cs:line 46
   at Celeste.Mod.LuaCoroutine.MoveNext() in /home/vsts/work/1/s/Celeste.Mod.mm/Mod/Helpers/LuaCoroutine.cs:line 21
   at Celeste.Mod.LuaCutscenes.LuaHelper.SafeMoveNext(LuaCoroutine enumerator)

#

that's english.txt

#

mellow frost Nov 30, 2023, 2:30 PM

#

use table.unpack in choiceDialog

unborn inlet Nov 30, 2023, 2:59 PM

#

mellow frost use table.unpack in choiceDialog

like this?

#

(this didn't work)

mellow frost Nov 30, 2023, 2:59 PM

#

at least i'm pretty sure it should

#

see https://discord.com/channels/403698615446536203/1178709972499038259

unborn inlet Nov 30, 2023, 3:02 PM

#

there is old choice widegladeline2

#

i use choiceDialog()

mellow frost Nov 30, 2023, 3:02 PM

#

the crash is the same

unborn inlet Nov 30, 2023, 3:02 PM

#

unborn inlet Nov 30, 2023, 3:02 PM

#

mellow frost the crash is the same

oh, yes

#

hhm?

#

but then this should work

#

shouldn't it?

#

but it doesn't

#

let me try with just two values

#

maybe 5 is too much

#

nah

mellow frost Nov 30, 2023, 3:08 PM

#

well nvm

#

it doesn't take varargs

mellow frost Nov 30, 2023, 3:11 PM

#

unborn inlet ```lua choiceDialog({ {"Dzhake_Cuteline_1_6_1"}, {"Dzhake_Cuteli...

yea no this should work

#

it takes in a table

unborn inlet Nov 30, 2023, 3:13 PM

#

but it doesn't

#

pausefrogelineatthephone

mellow frost Nov 30, 2023, 3:15 PM

#

is this your entire cutscene or is the something more

unborn inlet Nov 30, 2023, 3:15 PM

#

there is something more but i commented everything

#

that's how does it look

#

literally

#

"say"

#

"choiceDialog"

#

it errors after say end

mellow frost Nov 30, 2023, 3:17 PM

#

after say("1_5")?

unborn inlet Nov 30, 2023, 3:18 PM

#

yes.

#

(dzhake.say() it auto-adds Dzhake_Cuteline_ before text)

mellow frost Nov 30, 2023, 3:19 PM

#

evenwidergladeline1

#

i have no clue

unborn inlet Nov 30, 2023, 3:19 PM

#

~~ping Cruor~~

mellow frost Nov 30, 2023, 3:19 PM

#

@upbeat snow do you perhaps have a number to an exorcist, since i don't understand this

#

neither of the used functions use varargs

#

my only suspicion is that luaCutscenes's choiceDialog uses a vararg function

unborn inlet Nov 30, 2023, 3:21 PM

#

Popax: 💤

#

i'll wait

mellow frost Nov 30, 2023, 3:22 PM

#

WAIT

unborn inlet Nov 30, 2023, 3:22 PM

#

?????? :shokeline:

mellow frost Nov 30, 2023, 3:22 PM

#

https://github.com/Cruor/LuaCutscenes/blob/master/LuaCutscenes/Assets/LuaCutscenes/helper_functions.lua#L137
sobeline

GitHub

LuaCutscenes/LuaCutscenes/Assets/LuaCutscenes/helper_functions.lua ...

Celeste mod that adds cutscenes written in Lua. Contribute to Cruor/LuaCutscenes development by creating an account on GitHub.

#

choiceDialog uses choice without table.unpack

#

@strong raptor lua cutscenes bug in core
nlua doesn't like it when you call a vararg function (in this case dialog) without table.unpack and this crashes on core

see https://discord.com/channels/403698615446536203/1178709972499038259 for the crash caused by using dialog without table.unpack

unborn inlet Nov 30, 2023, 3:24 PM

#

gladstare

#

thanks for seeing problem

#

i'll wait for cruor

#

oh, wait, he closed discord t-

#

?

mellow frost Nov 30, 2023, 3:25 PM

#

unborn inlet ?

this is for cruor

#

for context

unborn inlet Nov 30, 2023, 3:26 PM

#

ah ok

mellow frost Nov 30, 2023, 3:27 PM

#

@unborn inlet in the meantime try copy pasting the code from choiceDialog and modifying it to work, and to use table.unpack on the helpers.choice line

#

mmm but it uses some local functions

unborn inlet Nov 30, 2023, 3:29 PM

#

ok, i'll try, but i have to run rn, i'll say if it works or not after about half-hour.

mellow frost Nov 30, 2023, 3:30 PM

#

mellow frost <@562171438396604416> in the meantime try copy pasting the code from choiceDialo...

(not me quickly checking whether you can do that, fortunately luacutscenes has an MIT license)

unborn inlet Nov 30, 2023, 3:37 PM

#

It worked, thank you!

mellow frost Nov 30, 2023, 3:40 PM

#

so that's the culprit here

#

okay

strong raptor Nov 30, 2023, 9:39 PM

#

see if that does the trick

📎 LuaCutscenes.zip

mellow frost Nov 30, 2023, 9:49 PM

#

@unborn inlet

unborn inlet Dec 1, 2023, 8:30 AM

#

i should replace zip in mods folder, right?

#

ok, launching celeste

unborn inlet Dec 1, 2023, 8:53 AM

#

lua cutscenes has update

#

and my version is uhh newer?

#

didn't really see

#

ig it's ok

#

doesn't work

#

maybe i should try to redownload lua cutscenes?

#

no, same error.

mellow frost Dec 1, 2023, 1:33 PM

#

unborn inlet lua cutscenes has update

don't update

#

it will replace the version you have with the one from gamebanana

#

which you don't want

unborn inlet Dec 1, 2023, 2:07 PM

#

it didn't update because my version is newer radeline

mellow frost Dec 1, 2023, 2:46 PM

#

automatic mod updates doesn't check the version

#

it literally just checks if your mod hash matches the one on gamebanana

some people forget to update their everest.yaml
some people don't do proper versioning
some other reasons

#

so if you have a 1.10.0 version of a mod, but the latest one is 1.9.0, the mod updater thinks 1.9.0 is a mod update and will ask you to replace your 1.10.0 version with 1.9.0, because it's the newest on gamebanana

unborn inlet Dec 1, 2023, 2:49 PM

#

anyway i use dzhake.choiceDialog() because after redownload choiceDialog() didn't work

mellow frost Dec 1, 2023, 2:52 PM

#

@strong raptor the offending line is still the same laugheline

#

@unborn inlet try this zip? i edited the lua file myself

📎 LuaCutscenes.zip

#

the only difference is that line 261 has table.unpack

unborn inlet Dec 1, 2023, 2:58 PM

#

uhh question.. what for? We know it'll work?

#

just "test anyway"?

#

(sure)

mellow frost Dec 1, 2023, 2:58 PM

#

i'm just wondering if the modification i did will work

unborn inlet Dec 1, 2023, 2:59 PM

#

why shouldn't it?

mellow frost Dec 1, 2023, 2:59 PM

#

from what i see cruor added some special handling to helpers.choice in case the first and only argument is a table

#

that still crashes nlua from what i see

unborn inlet Dec 1, 2023, 3:00 PM

#

oh, wai,t it would take a while..

#

i deleted everything

#

english txt, cutscene

mellow frost Dec 1, 2023, 3:00 PM

#

unborn inlet Dec 1, 2023, 3:00 PM

#

i didn't like it

mellow frost Dec 1, 2023, 3:01 PM

#

reading the stacktrace from the crash it has something to do with NLua.MetaFunctions.CreateParamsArray

unborn inlet Dec 1, 2023, 3:01 PM

#

huh? why does it work?

#

if choices are not table

#

it uses table.unpack() anyway?

#

oh wait.

#

ok.

mellow frost Dec 1, 2023, 3:02 PM

#

the problem is that choiceDialog doesn't

unborn inlet Dec 1, 2023, 3:02 PM

#

then.. why it doesn't work?

mellow frost Dec 1, 2023, 3:02 PM

#

well, because choiceDialog calls choice without table.unpack

#

so i suspect the crash occurs while calling a vararg function without table.unpack

unborn inlet Dec 1, 2023, 3:03 PM

#

vararg

#

...?

mellow frost Dec 1, 2023, 3:04 PM

#

varargs in lua are ... from what i see

unborn inlet Dec 1, 2023, 3:04 PM

#

(soo... fix is adding some random value like {},"fgladjflkgjlakf"?)

mellow frost Dec 1, 2023, 3:04 PM

#

no, the fix here is to make choiceDialog call choice with table.unpack

#

at least i think so

unborn inlet Dec 1, 2023, 3:05 PM

#

oh, so, do you really want me to test?

mellow frost Dec 1, 2023, 3:05 PM

#

line 261 is the culprit
first screenshot is what the original has
second is what i changed

unborn inlet Dec 1, 2023, 3:05 PM

#

~~i'm just toooo lazy to rewrite them all~~

mellow frost Dec 1, 2023, 3:06 PM

#

just check if

choiceDialog({
  -- insert some dialog ids, idk
})

works properly without crashing

unborn inlet Dec 1, 2023, 3:06 PM

#

ok.

#

#

it does

#

hhm

#

it's repeatable

#

it should not be i think

#

~~just going to keep using my version cuz uhh~~

#

💀

mellow frost Dec 1, 2023, 3:18 PM

#

unborn inlet

welp, it looks like my patch worked then

upbeat snow Dec 1, 2023, 3:37 PM

#

mellow frost reading the stacktrace from the crash it has something to do with `NLua.MetaFunc...

That's the Lua -> C# varargs marshaller

mellow frost Dec 1, 2023, 3:37 PM

#

it's not a nlua bug, just to be sure?

upbeat snow Dec 1, 2023, 3:38 PM

#

I mean NLua is a jank piece of garbage and it should definitely handle this error better cluelesseline

#

But yeah no it isn't

#

That error always means "Lua code tried to invoke C# varargs function with incompatible argument type"

mellow frost Dec 1, 2023, 3:40 PM

#

widergladeline1 ah

#

so wait

#

the issue would be in choice?

#

upbeat snow Dec 1, 2023, 3:41 PM

#

I don't see why this wouldn't work thonkeline

mellow frost Dec 1, 2023, 3:41 PM

#

this is the zip cruor sent

#

so i have no clue

mellow frost Dec 1, 2023, 3:41 PM

#

mellow frost line 261 is the culprit first screenshot is what the original has second is what...

here's my patch, and it worked

#

so like, from what i see it just dies trying to call choice with a vararg function

#

?????

unborn inlet Dec 1, 2023, 3:41 PM

#

~~ngl, i have only one question: lua cutscenes are so unpopular, that after using them for two days i already found a critical error?~~

unborn inlet Dec 1, 2023, 3:42 PM

#

mellow frost here's my patch, and it worked

*for some reason they were repeatable

#

(choice didn't disappear after i selected it)

#

(maybe problem is what second dialog key didn't exist thinkeline )

mellow frost Dec 1, 2023, 3:43 PM

#

just make your own cutscenes in c# cluegrin

unborn inlet Dec 1, 2023, 3:43 PM

#

annoyedeline

#

i want to use lua cuz uhh why not

strong raptor Dec 1, 2023, 4:25 PM

#

worked on my machine :p

mellow frost Dec 1, 2023, 4:28 PM

#

strong raptor worked on my machine :p

does it work on core?

#

since the crashes seem to happen on core

strong raptor Dec 1, 2023, 4:28 PM

#

literally installed core to test it haha

mellow frost Dec 1, 2023, 4:30 PM

#

widergladeline1

#

well then

candid zinc Dec 6, 2023, 2:50 PM

#

catstare ran into the same issue and solved with the version above

unborn inlet Dec 6, 2023, 2:51 PM

#

catplanet

#[Lua cutscenes] choiceDialog() not working?