Cant turn off invincibility

[leaden cove]

Entering map turns it on and says that i set it (orange color). Happens in every at least modded maps

[livid copper]

@austere nimbus is the code refactor meant to effect normal variants

[leaden cove]

it also sets back if i die with golden

[austere nimbus]

It is supposed to, because vanilla variant triggers are a thing, but I struggled to set that up

[livid copper]

unforseen consequences appearing suddenly

[austere nimbus]

Which map is that happening on?

(I know you said "almost every one of them" but what did you notice that on? )

[leaden cove]

strawberry jam int lobby: EAT GIRL, botany something; cave wish (which is my friend map, it is not uploaded anywhere)

[austere nimbus]

Though it is not supposed to do anything besides coloring the variants menu unless a vanilla variant is triggered

Also, are you actually invincible?

[leaden cove]

100%

it seems to affect only 1 save file

[austere nimbus]

And I'm guessing turning off the extended variants "master switch" in mod options fixes this?

[austere nimbus]

Can you send Saves/1.celeste too?

I'm not at PC today, but I can check what's happening tomorrow

[leaden cove]

there

[leaden cove]

also i dont quite understand where it is

[austere nimbus]

There's an "enabled" toggle in the extended variant mode section of mod options

[leaden cove]

i thought it enables whole mod

and turning off the mod fixed it yes

[austere nimbus]

I'll try replicating tomorrow, to see whether it's a mod conflict or a testing epic fail

[austere nimbus]

yeah that's some kind of mod conflict, now I just need to find which of the 52 strawberry jam dependencies is to blame here

... got it first try, isa grab bag

[austere nimbus]

yeah, seems like grab bag was the one reverting the variants because it didn't like what I did with the variants menu

that should be fixed in the next update

[austere nimbus]

just released

[wheat cradle]

if you're ever really bored, you could port your variant handling to grabbag, the code in there is very jank

[austere nimbus]

I'm wondering if extended variants should "take over" with a map data processor or something

[wheat cradle]

that's actually not the worst idea

[austere nimbus]

I've got a report that a variant enabled by the map was highlighted in orange, only because it was enabled by Isa's grab bag instead of extended variants

[austere nimbus]

The only (quite big) issue about that is that maps that depend on grab bag for variant triggers now depend on extended variants, or change when extended variants are also installed

[wheat cradle]

does grab bag have any features wrt variants that extvar couldn't replicate?

as long as extvar can replicate the grabbag behavior accurately, it shouldn't be an issue that extvar takes over if it's installed

[austere nimbus]

It could be an issue for session saving

Isa variant triggers have two settings: the variant to change, and this

const variantMod = String[
    "Enabled",
    "Disabled",
    "EnabledPermanent",
    "DisabledPermanent",
    "EnabledTemporary",
    "DisabledTemporary",
    "Toggle",
    "SetToDefault"
]

[wheat cradle]

ah yeah if extvar is enabled/disabled between s&qs