#Color picker

1 messages · Page 1 of 1 (latest)

cold mason
dark crag
#

Awesome. Now implement one in the OkLab color space.

cold mason
#

LOC 44-46

#

TODO some sliders to manipulate lightness chroma etc

dark crag
#

That's sick. Here's a star.

dark crag
#

I think I would honestly get rid of the MainWindow class. Just put all of that into main.

#

YAGNI principle.

cold mason
#

tbh i think its good separation and also in some way qt dictates u to use it

#

and in future if app gonna extend and in main window there would be actually more logic then it will come handy (but rn theres logic that actually needed, and nothing that is 'unused' rn)

#

to seperate it into 'main window'

#

i'll think about it more but for now i think its makes sense that im adding widgets in main window constructor setting up some settings etc

#

but now my focus onto adding more color spaces

#

in some way it might actually violate SRP

#

since its responsobility actually to manage 'main window' that exist in the top-level hierarchy and parenting of child widgets

#

but in constructor im loading settings

#

probably makes sense to seperate 'settings setup'

#

and put it in main

#

but ill think about it later