feedback on my first game in c++ (cli)

[lean tide]

Hi, i've now completed my blackjack cli game in c++, if y'all got any improvement tips i'd appreciate it!
main.cpp: https://hastebin.com/share/ropetimizo.cpp
library.cpp: https://hastebin.com/share/cisehemasi.cpp
library.hpp: https://hastebin.com/share/epudijubon.cpp

[wanton elk]

code looks really clean

you could use fallthrough to your advantage here ```cpp
int to_int(const Card &card) {
switch (card.rank) {
case Rank::jack:
case Rank::queen:
case Rank::king:
return 10;
default: return static_cast<int>(card.rank) + 1;
}
}

one minor formatting inconsistency, you write const Hand &hand but const Hand* winner

[lean tide]

the asterisk position?

[lean tide]

oh interesting, thanks

[wanton elk]

yep

[lean tide]

ok thanks

[wanton elk]

in the definition of Deck::Deck(), why do you write i != 4 rather than i < 4? imo, the latter is clearer in intention

[lean tide]

whats the difference between & and *, also, shoudl class/struct/enum names be PascalCase? also, should functions be snake_case or camelCase?

[lean tide]

hm good point

[wanton elk]

int& is a reference, int* is a pointer? or do you mean something else

[lean tide]

i.e in the case of const Hand &hand and const Hand *winner

[wanton elk]

like, one major difference is that pointers are reassignable and nullable

while references aren't

[lean tide]

i see

[wanton elk]

using PascalCase for class/struct/enum is indeed common

oh, SuitSymbols and RankSymbols aren't one of those but are PascalCase anyway

[lean tide]

what should it be?

also, should enum variants also be PascalCase?

[wanton elk]

entirely your own choice but i make my enum values PascalCase