#Cleaner Code

21 messages · Page 1 of 1 (latest)

torpid crown
#

Hi guys i implemented a protocoll (kinda?) with a server. I want to ask if i should write it cleaner.
Especially should i use variables for the data i send?

void performHandshake(int socket) {
    char buffer[BUFFFER_SIZE];
    readFromServer(socket, buffer);


    printf("Nachricht erhalten: %s\n", buffer);

    sendToServer(socket, "VERSION 2.4\n", sizeof("VERSION 2.4"));

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    sendToServer(socket, "ID 33uwj28t4xtv2\n", sizeof("ID 33uwj28t4xtv2"));

    readFromServer(socket, buffer);


    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    sendToServer(socket, "PLAYER\n", sizeof("PLAYER 0"));

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);
}
storm currentBOT
#

When your question is answered use !solved to mark the question as resolved.

Remember to ask specific questions, provide necessary details, and reduce your question to its simplest form. For tips on how to ask a good question use !howto ask.

floral tundra
#

why don't you use a loop if you are going to do the same instructions four times in a row ?

torpid crown
#

and over what im looping?

#

char message[][] ?

#

and put those messages in an array?

floral tundra
# 
    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

this, why don't you do :

for(int i = 0;i<4;i++){
    readFromServer(socket, buffer);
    printf("Nachricht erhalten: %s\n", buffer);
}

maybe I am missing something as I am a very beginner

torpid crown
#

jeah but i need

#

to send specific text

#

in between

floral tundra
#

? I am not sure to understand

#

I am actually interested

torpid crown
# 
void performHandshake(int socket) {
    char buffer[BUFFFER_SIZE];
    readFromServer(socket, buffer);


    printf("Nachricht erhalten: %s\n", buffer);

    sendToServer(socket, "VERSION 2.4\n", sizeof("VERSION 2.4"));

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    sendToServer(socket, "ID 33uwj28t4xtv2\n", sizeof("ID 33uwj28t4xtv2"));

    readFromServer(socket, buffer);


    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    sendToServer(socket, "PLAYER\n", sizeof("PLAYER 0"));

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);

    readFromServer(socket, buffer);

    printf("Nachricht erhalten: %s\n", buffer);
}
#

you see

#

im not just printing and reading

#

in between im sending message to a server

#

sendToServer(socket, "ID 33uwj28t4xtv2\n", sizeof("ID 33uwj28t4xtv2"));

floral tundra
#

yes but in the end you are not, or did you just shortened the code here ?

#

I was talking about the last 4 printf

torpid crown
#

oh thats true

#

good catch i try it