Made tictactoe all by myself | Together C & C++ | Page 1

lusty sand Mar 8, 2023, 5:24 PM

#

Hey, I've started learning c++ few days ago and I wrote tictactoe game. I'd say I made the code overcomplicated, but since it's my first c++ program, I think it's fine.

Just to clarify, I challenged myself to do it with everything I learnt so far, so I had exactly 0 help (no internet, nothing). I'm experienced with other languages (not c-like) tho, so I it would be way harder if some things didn't come naturally.
Anyways, here's the code:

#

the reason why I'm posting this, I would love if you could just point out unnecessary code and give me some tips to improve myself

#

I know I've done the checkState() function way to complicated and long, but I just couldn't figure out how to do it more efficiently

#

📎 tictactoe.cpp

slim escarp Mar 8, 2023, 6:14 PM

#

Do you want pointers on more advanced stuff you could have used or just basics?

lusty sand Mar 8, 2023, 6:27 PM

#

both if you don't mind

slim escarp Mar 8, 2023, 6:37 PM

#

i found a bug in void move(char player)

#

if you input invalid moves it calls move() again

#

it will take this path through the function if you enter incorrectly once and then correctly

#

the move(plrOnTheMove); at the bottom of the function doesnt have this problem since there is no code below it that is repeated

#

alright

#

global variables are bad, try to not use them

#

imo, it would look better if you used an enum instead of chars to mark the state of a square

#

XonTheMove is a pretty bad name, so is plrOnTheMove

#

you dont really check whether or not your input was alright in the start of move()

#

loads and loads of blank rows and inconsistent indentation

#

another idea instead of 2: (this is kinda unnecessary) if you had each square state as -1(x), 0(blank) or 1(o) you could check whether a column/row is finished by adding up all squares in that column/row. If the sum is -3 crosses won if it is 3 noughts won and otherwise no one won from that column/row

#

char &_weiner = weiner; doesn't really do anything. weiner = i does the same thing.

#

using namespace std is generally frowned upon

#

std::array would work well for the board

harsh egretBOT Mar 8, 2023, 7:08 PM

#

cppreference.com

std::array

template<class T, std::size_t N>
struct array;

Defined in

<array>

slim escarp Mar 8, 2023, 7:08 PM

#

i think thats all from me 🙂

#

great job! finishing your first project is the biggest hurdle

lusty sand Mar 8, 2023, 7:17 PM

#

I'll look into all those things and try to work on them, thanks a lot o7

#Made tictactoe all by myself