Hello, can you please help me with optimising this code? | Together C & C++ | Page 1

naive oak · 2022-09-04T11:12:02.081Z

```cpp class Solution { public: vector twoSum(vector &numbers, int target) { vector v; for (int i = 0; i target) r = m - 1; } } return v; } };```

naive oak Sep 4, 2022, 11:12 AM

#

class Solution
{
public:
  vector<int> twoSum(vector<int> &numbers, int target)
  {
    vector<int> v;
    for (int i = 0; i < size(numbers); i++)
    {
      int l = 0, r = size(numbers) - 1, m;
      while (l <= r)
      {
        m = (l + r) / 2;
        if ((numbers[i] + numbers[m] == target) and (i != m))
        {
          v.push_back(i + 1);
          v.push_back(m + 1);
          return v;
        }
        if (numbers[m] + numbers[i] < target)
          l = m + 1;
        else if (numbers[m] + numbers[i] > target)
          r = m - 1;
      }
    }
    return v;
  }
};```

grand coyoteBOT Sep 4, 2022, 11:12 AM

#

When your question is answered use !solved to mark the question as resolved.

Remember to ask specific questions, provide necessary details, and reduce your question to its simplest form. For more information use !howto ask.

naive oak Sep 4, 2022, 11:13 AM

#

green elbow Sep 4, 2022, 12:58 PM

#

@naive oak why are you making your own vector?

scenic creek Sep 4, 2022, 1:55 PM

#

@naive oak as I mentioned in the other server, you are solving in O(N log N) a problem that is solvable in O(N)

naive oak Sep 4, 2022, 2:32 PM

#

!solved

grand coyoteBOT Sep 4, 2022, 2:32 PM

#

[SOLVED] Hello, can you please help me with optimising this code?

grand coyoteBOT Oct 8, 2022, 4:03 PM

#

Hello, can you please help me with optimising this code?

#Hello, can you please help me with optimising this code?