#Matrix refactor
fiery cargo
thats a good plan! Depending on how the integration is set up it may be straight forward or it may be a huge mess 🤣
Is this integration already ConfigFlow configured or still yaml?
Matrix
Matrix refactor
snow basin
yaml-only right now, which did personally annoy me when I first tried setting it up
Definitely another thing I'd like to (eventually) try to modernize
fiery cargo
You can't change anything regarding the yaml config - it wouldn't be accepted. You may only deprecate it (I think 2 month) and add a ConfigFlow if you like to change config things...
It may be a good idea to do that upfront, but again, it depends
snow basin
But really, the biggest things are the fact that the old library doesn't support threaded messages, replies, or other modern features that matrix as a protocol has gone forward with. The old library's github (https://github.com/matrix-org/matrix-python-sdk) even says:
We strongly recommend using the matrix-nio library rather than this sdk. It is both more featureful and more actively maintained.
snow basin
You can't change anything regarding the yaml config - it wouldn't be accepted. Y...
That's good to know; I think I want to handle things in the order of my familiarity, and I'm definitely newer to component development than matrix bot/app development
So if yaml is the only configuration method for now, so be it 🤷🏾♂️
fiery cargo
So if yaml is the only configuration method for now, so be it 🤷🏾♂️
sure, that's fine I guess. Just be aware that you "have" to stick with the current Schema - so beware if the new lib requires something additional
snow basin
Thankfully the items needed from the yaml config are all definitely still needed, and it shouldn't require anything new at all
fiery cargo
are you codeowner of the current integration?
snow basin
Basic stuff like user/pass/homeserver
Not at all; current codeowner is @tinloaf
Who appears to be in this server, too 🤔
Hi @waxen moon!
I don't mean to bother anyone prematurely with all of this, this is definitely something I'd rather have an implementation of first before I hash things out with reviewers/etc, but I'm absolutely happy to discuss my overall goals/ideas for the integration!
My dms are open, and I can DM you my matrix id if preferred 🙂
fiery cargo
did you already contribute to HA?
snow basin
Nope! This'd be my first time 🙂
I've debugged a few HACS add-ons before, though, if that counts for anything 🤷🏾♂️
fiery cargo
Great 👍
Just be aware that CI runs have to be started by a member until you are marked "Contributor".
snow basin
Gotcha; by default I'll try to reach out to tinloaf for help with that, but if he turns out to be unavailable for some reason, what'd be my best way forward from there? I'm guessing getting some help from here/github?
fiery cargo
sure, pinging #devs_core-archived is probably the easiest way
https://developers.home-assistant.io/docs/integration_quality_scale_index may be interesting for you in the long run
TLDR: adding tests and type annotations is very appreciated
snow basin
I definitely love tests and type annotations 😁
This was all really helpful, thank you again! It's been encouraging
fiery cargo
Great! Feel free to ping me for a quick CI start when you are ready.