Custum Component - blocking HA startup | Home Assistant | Page 1

grim cloak Mar 2, 2022, 10:00 PM

#

@old jewel the subscriber messages come from hass.async_create_task().

https://github.com/iMicknl/ha-nest-protect/blob/9deaa44df95e91faf1b9de645fca2ad9323d5569/custom_components/nest_protect/__init__.py#L86

old jewel Mar 3, 2022, 12:29 AM

#

Does that register function exit? I see it re registers itself at the end. I guess this should be expected to be long running

grim cloak Mar 3, 2022, 12:10 PM

#

It does reregister when it is done. This can happen when an update comes in or when the session is open for too long.

old jewel Mar 3, 2022, 1:34 PM

#

So I see it did finish the first subscription round and started the second one

#

I'm curious if not resubscribing helps as a test

#

Also not sure why that task wouldn't lock startup

grim cloak Mar 3, 2022, 1:37 PM

#

I will give that a try indeed.

#

But indeed, it seems that it is really waiting until dhcp is configured / libcap.

old jewel Mar 3, 2022, 1:39 PM

#

Ok sure. You can disable defsult_config and add back the individual pieces if they is really what it is

#

My impression is the setting are has a list of load times per integration

grim cloak Mar 3, 2022, 1:41 PM

#

The weird thing is that it only shows 12 seconds in the settings area in hA

#

However, it is just this branch that is blocking in my dev and prod environment. So something is not right.

old jewel Mar 3, 2022, 1:53 PM

#

Is the data subscriber task referenced anywhere once it is assigned?

#

I feel like it's gotta be blocking the event loop somehow

#

And maybe the dhcp issue is a timeout after being blocked for two minutes

#

(a symptom not a cause)

grim cloak Mar 3, 2022, 2:53 PM

#

I will investigate, it really is related to the hass.async_create_task(_async_subscribe_for_data(hass, entry, data))

#

If I uncomment that one, it starts directly

#

    @callback
    def async_create_task(self, target: Awaitable[_R]) -> asyncio.Task[_R]:
        """Create a task from within the eventloop.

        This method must be run in the event loop.

        target: target to call.
        """
        task = self.loop.create_task(target)

        if self._track_task:
            self._pending_tasks.append(task)

        return task

#

I wonder if it is related to the track_task

old jewel Mar 3, 2022, 2:59 PM

#

oh _async_subscribe_for_data is not an async method

#

oh no im confusing it with the register method

#

ok so i think it makes sense..

#

async_block_till_done might never finish

#

One option is to create your own executor for running this

#

perhaps another is to start it after home assistant has started

#

i realize you need to be careful about managing shutdown

grim cloak Mar 3, 2022, 3:33 PM

#

Hmm that sounds indeed like the culprit

#

I hoped that HA would have a function available to hook into, so that it would be disposed automatically on stop.

old jewel Mar 3, 2022, 4:15 PM

#

maybe it cancels the tasks, i'm not sure

#

but i suspect you'd want to do that yourself

#

i don't think home assistant would aggressively cancel in case you're persisting data to a database or something

#

The global event EVENT_HOMEASSISTANT_STARTED may be worth a try

#

like https://github.com/home-assistant/core/blob/67e94f2b4ba614a37544f54ccb85984f0d600376/homeassistant/components/tplink/__init__.py#L74

grim cloak Mar 3, 2022, 6:01 PM

#

Thanks Allen!

grim cloak Mar 4, 2022, 1:12 PM

#

It's a pity that I cannot use the DataUpdateCoordinator for this, since now I would need to add my own retry logic as well.

#Custum Component - blocking HA startup