#Set UnitOfPower.WATT for inverse sensor if it's not set in registry

1 messages · Page 1 of 1 (latest)

ebon copper
#

@velvet crescent I don't really understand your comment on https://github.com/home-assistant/core/pull/168910 this is a pr to fix an issue when there is no unit set in the registry to actually fetch it or fall back to default WATT instead of leaving it None

GitHub

Proposed change

an inverse energy sensor for a battery shows up with a unit of kw for me when it reports WATT;
I believe this happens when source_entry.unit_of_measurement is None; the fix seems t...

crystal stone
#

No need to crosspost your PR related questions here on discord, you already asked in the PR. Just wait for an answer, especially since you commented on github just 6minues before

ebon copper
#

oh, ok, thx for the advice, it's just that on my last pr I got the remark (From other reviewers, fair) to be free to contact them on discord, I also thought it might be intresting to have a thread here since martin indicated they were going to check with other people.

surreal pilot
#

Oh no that question was specifically from me as we were about to merge an integration