#Broadlink IR

1 messages · Page 1 of 1 (latest)

tribal lodge
rotund crater
shadow shale
#

cc @subtle turret

waxen schooner
#

I'd agree with a revert for now, it just seems to violate too many of our principles

rotund crater
#

Yes, let's do it.

#

(The functionality as such is of course very welcome)

subtle turret
#

No problem. I will make a new PR soon and hope it will be better 😅
Sorry for the mess. First time...

shadow shale
#

No worries

rotund crater
#

Yeah, I didn't mean to put any blame on you @subtle turret. Adding IR support to the broadlink integration is for sure wanted.

#

It's just that our review process didn't work this time

tribal lodge
#

Should we have the label 'revert' be accepted by the required-labels bot? None of the available 'required lables' make sense in case of a revert IMO

shadow shale
#

Code quality I guess

#

A revert can also be a bugfix or breaking change

tribal lodge
#

hmm, I guess so

feral saffron
#

Sorry about that