#Add timer to generating translations

1 messages · Page 1 of 1 (latest)

winter abyss
#

Glad to share a PR is merged which makes generating of translations a bit faster (at least in a devcontainer). There was a discussion to leave out the total spent time of generating the translations, so in the merged PR it has been removed.

There's now a potential small follow-up PR with a timer: https://github.com/home-assistant/core/pull/167834

My personal preference is, when restarting debug I would enjoy seeing how long the overall restart cycle took; HA core and generating translation, which is part of it.
What do others think, is it worthwhile to proceed?

GitHub

Breaking change

Proposed change

Potential follow-up of: #166483 (comment)
Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
Ne...

pearl aspen
#

I have no strong opinion on this one

cedar arch
#

How will the information be used?

winter abyss
#

Good question. The idea is mainly to give insight into the total restart cycle during development (translation + generationcore restart).

This helped to benchmark where time was being spent and whether changes (like recent optimizations) actually improve iteration speed. So in the beginning it took around 3.9 seconds on my devcontainer and now only takes around 1.2 seconds. As stated, it's a bit of a personal preference now, so it might only be me. 🙂

cedar arch
#

I don't think the speed of generating translations is something we need to continuously keep an eye on. It's great that you sped it up.