Fail more tests when pytest_socket.Socke... | Home Assistant | Page 1

mortal crane Feb 28, 2026, 2:31 PM

#

OK, can you review the PR then?

#

Ah, but I think https://github.com/home-assistant/core/pull/155398 is a better solution

sharp gulch Feb 28, 2026, 2:55 PM

#

Sure but that one has a failing tests that I think is scoped/caused by that PR itself?

mortal crane Feb 28, 2026, 2:56 PM

#

Oh, right. That needs to be fixed

#

But I think the solution in the 2nd PR is better and we should merge the other one, because integrations can still catch and discard the pytest exception in the first PR

sharp gulch Feb 28, 2026, 2:57 PM

#

I don't mind either solution tbh. All I've done is fixed like 40 integration tests last night, so these can now be potentially enforced

plain quest Feb 28, 2026, 3:47 PM

#

I reviewed the preferred 155398.

#Fail more tests when pytest_socket.Socke...