Models and areas don't inherit indeed. | Home Assistant | Page 1

restive elm May 27, 2025, 9:11 AM

#

For Shelly devices you can change a switch to light by appliance type (gen1) and consumption type (gen2+)

latent nova May 27, 2025, 9:28 AM

#

Was too lazy to go into shelly interfaces tbh

#

But it shouldn’t drop existing entities

#

Or we need to declare breaking changes

restive elm May 27, 2025, 9:33 AM

#

This is not a breaking change for Shelly integration because the original entity (switch) is still present and it has the same entity_id

#

I don't know why "Switch to X" is losing the original entity. I will investigate this.

latent nova May 27, 2025, 10:34 AM

#

without looking at it: I guess it might include the device somehow

restive elm May 27, 2025, 11:04 AM

#

Yes, that's my guess too

primal hollow May 27, 2025, 11:35 AM

#

What I read in the switch_as_x code is that we do track changes, but only on runtime

coarse wadi May 27, 2025, 11:48 AM

#

I think it’s all helpers based on entities that moved

#

In that video the power of my Tesla charger moved to a sub device but the threshold helper linked to it did not

primal hollow May 27, 2025, 11:49 AM

#

This now got me wondering, with switch_as_x we definetly bind to the same device

#

but with a threshold helper, you select the device you want to connect with during setup right?

coarse wadi May 27, 2025, 11:50 AM

#

I do not remember but for sure I cannnot change it now

#

For Template helpers I can change it after the fact for exmaple

#

#

You do not

#

We infer it from the entity

#

(Which makes a lot of sense)

primal hollow May 27, 2025, 11:52 AM

#

oh no

#

you dont select a device in the threshold config flow

#

Looking at the code I would assume it worked

#

@coarse wadi can you try restarting?

coarse wadi May 27, 2025, 12:15 PM

#

REstarting HA ?

primal hollow May 27, 2025, 12:17 PM

#

ye

#

The threashold one might be a load order thing, because following the logic, it would create itself for the device the entity is at at boot

#

but if that happened before shelly was booted (and thus the entity moved) it would stay in the old one

coarse wadi May 27, 2025, 12:19 PM

#

restarting ⏳

#

#

So now it's on the correct device

#

But I lost configuration

#

eg. I lost the icon for exmaple

primal hollow May 27, 2025, 12:20 PM

#

if you reload the browser?

coarse wadi May 27, 2025, 12:20 PM

#

Extract fro before the restar

#

No

#

Even if I reload the browser / restart the browser

primal hollow May 27, 2025, 12:20 PM

#

why on earth would you lose config

coarse wadi May 27, 2025, 12:21 PM

#

Because it's attached to the other device somewhow?

primal hollow May 27, 2025, 12:21 PM

#

custom icons and such is on entity level

coarse wadi May 27, 2025, 12:21 PM

#

BEcuase it's uniquelely identified by a tuple that contains the device?

primal hollow May 27, 2025, 12:22 PM

#

cc @untold helm Do you have an idea on why entity configuration is lost when restarting/changing device_id?

coarse wadi May 27, 2025, 12:34 PM

#

Restarting one more time ... for some reasons

#

NOpe 🤣

#

It was worth a try

untold helm May 27, 2025, 1:18 PM

#

I don't understand the question, what does "restarting/changing device_id" mean?

#

short answer: it's not

#

are you sure it's the same entity?

primal hollow May 27, 2025, 1:20 PM

#

Okay so Shelly is now splitting up into more devices

#

Which means that helpers that are attached to those devices, should also move entity

untold helm May 27, 2025, 1:20 PM

#

primal hollow Which means that helpers that are attached to those devices, should also move en...

what does this mean?

#

why would a helper move entities?

primal hollow May 27, 2025, 1:21 PM

#

I have a power entity that measures if my tesla is currently being charged

untold helm May 27, 2025, 1:21 PM

#

are the entities not same before and after this change?

primal hollow May 27, 2025, 1:21 PM

#

and that entity is now being moved to a different device because in theory its a different device

untold helm May 27, 2025, 1:22 PM

#

primal hollow Which means that helpers that are attached to those devices, should also move en...

So this was a typo?

primal hollow May 27, 2025, 1:22 PM

#

as in, when a device has area significance, it's a reason to have separate devices

#

oh

#

yes

#

should also move device*

untold helm May 27, 2025, 1:22 PM

#

ah

#

ok

primal hollow May 27, 2025, 1:22 PM

#

So what now happened is that shelly loaded after the threshold helper, so it only got applied after another restart

#

the unique id of the threshold entity is the entry_id

untold helm May 27, 2025, 1:23 PM

#

joost, can we take a step back please

primal hollow May 27, 2025, 1:23 PM

#

yes

untold helm May 27, 2025, 1:23 PM

#

customizations of what is lost? is it things like user changed name that has changed?

primal hollow May 27, 2025, 1:24 PM

#

The icon in this case

untold helm May 27, 2025, 1:24 PM

#

OK, so why all the talk about helpers? what's the relevance of that?

primal hollow May 27, 2025, 1:24 PM

#

well, that was the direct thing that changed, which caused the icon to reset for some reason

untold helm May 27, 2025, 1:24 PM

#

that makes no sense

primal hollow May 27, 2025, 1:25 PM

#

I also think this doesn't make sense, but yet it happened

untold helm May 27, 2025, 1:25 PM

#

no

#

that was the direct thing that changed, which caused the icon to reset for some reason
This explanation makes no sense

#

what changed? and what icon was reset?

primal hollow May 27, 2025, 1:26 PM

#

Like, it's not that the icon suddenly dissapeared, something unrelated changed, causing it to dissapear

primal hollow May 27, 2025, 1:26 PM

#

coarse wadi

The tesla icon got removed after the entity moved devices

untold helm May 27, 2025, 1:27 PM

#

OK, and what does that have to do with helpers?

primal hollow May 27, 2025, 1:27 PM

#

The helpers are the cause of the moving devices

#

and that is something separate I am looking into

untold helm May 27, 2025, 1:28 PM

#

can we again take a step back then and start from the beginning

primal hollow May 27, 2025, 1:28 PM

#

okay

untold helm May 27, 2025, 1:29 PM

#

sorry, but I don't follow at all what problems are happening, could you try to explain what's happening?

primal hollow May 27, 2025, 1:32 PM

#

Okay so, an entity moved from one device to the other, and then lost the icon customization

untold helm May 27, 2025, 1:32 PM

#

OK, and what is that entity, is it a shelly entity or an entity provided by a helper?

#

Also, which helper?

primal hollow May 27, 2025, 1:33 PM

#

It's an entity provided by the threshold entity, which is monitoring a shelly entity

untold helm May 27, 2025, 1:33 PM

#

OK, so it's the threshold helper which looses the icon customization?

primal hollow May 27, 2025, 1:33 PM

#

yes

untold helm May 27, 2025, 1:33 PM

#

OK, and what does that have to do with switch_as_x which is mentioned above?

primal hollow May 27, 2025, 1:34 PM

#

There's a different issue where some helpers are listening to devicechanges on runtime, while some only set the entity to the right device on boot

untold helm May 27, 2025, 1:35 PM

#

ah, so that issue is about the helpers not appearing in the expected sub device after the shelly migration which changes sub devices?

primal hollow May 27, 2025, 1:36 PM

#

yes, since the shelly integration was loaded after the threshold one, so the helper only changed devices after a restart

untold helm May 27, 2025, 1:36 PM

#

ok, lazy helper authors. but that's understood and fixable?

primal hollow May 27, 2025, 1:36 PM

#

I think we can fix that yes

#

And the restart that Jlo did confirmed that this was the case

#

But then I could not explain why the icon suddenly dissapeared

#

as the unique id of the entity did not change

untold helm May 27, 2025, 1:37 PM

#

how do you know it did not change? has that been confirmed?

primal hollow May 27, 2025, 1:38 PM

#

the unique id of that entity is the entry_id

#

While I did not explicitly rule out that an entity moving a device removes an entry and creates a new one, looking at the code makes it highly unlikely that that happened

#

After the restart, it first deleted the entry from the device using dev_reg.async_update_device(device.id, remove_config_entry_id=entry_id), after which it now created the same entity as before, but then with a different DeviceInfo

untold helm May 27, 2025, 1:43 PM

#

ok, but deleting a config entry from a device may delete the device if there are no more config entries, and deleting a device deletes all its entities

#

so I think the device helpers (I mean what's in helpers/device.py) may be a bit misguided

#

I don't understand why the threshold sensor adds its config entry to the host device

primal hollow May 27, 2025, 1:44 PM

#

Oh right

#

@coarse wadi Do you still have that old device around?

primal hollow May 27, 2025, 1:45 PM

#

coarse wadi I think it’s all helpers based on entities that moved

From looking at this video, it does not look like it was the last config entry that was attached to that device

untold helm May 27, 2025, 1:45 PM

#

where's the shelly migration to the new device structure? does shelly delete itself from any device?

untold helm May 27, 2025, 1:46 PM

#

primal hollow From looking at this video, it does not look like it was the last config entry t...

Is that the same device(s) as before the migration though?

primal hollow May 27, 2025, 1:46 PM

#

I would assume so, as the threshold entity was still attached

primal hollow May 27, 2025, 1:46 PM

#

untold helm where's the shelly migration to the new device structure? does shelly delete its...

@restive elm

untold helm May 27, 2025, 1:47 PM

#

primal hollow I would assume so, as the threshold entity was still attached

what does "still attached" mean?

#

it's attached to A device, but is it the same?

coarse wadi May 27, 2025, 1:47 PM

#

(Catching up everything. Ping me if you want to test something meanwhile)

untold helm May 27, 2025, 1:47 PM

#

@coarse wadi could you share entity registry + device registry json files before and after the upgrade?

#

or have you already checked those and confirmed no device or entity is being deleted?

coarse wadi May 27, 2025, 1:48 PM

#

TL;DR :

I had a threshold helper attached to main_device
main device got split into main_device, subdevice_1 and subdevice_2
at first the helper stayed on main_device
after a restart it moved to subdevice_1 where it should be but I lost the icon I manually set.

restive elm May 27, 2025, 1:48 PM

#

untold helm where's the shelly migration to the new device structure? does shelly delete its...

the old device remains as the "main" device and sub-devices are created for the channels

coarse wadi May 27, 2025, 1:49 PM

#

@untold helm I can definitely share the registries I have now

#

The old one.... I can ... I just need to restore

#

It will take a bit of time, I am in a meeting and will have to jump out to take care of my daugther

#

So it will be later tonight

#

Wait .. I do not need to restore, I can simply unpack the backup, stupid me

#

One sec.

untold helm May 27, 2025, 1:51 PM

#

coarse wadi TL;DR : - I had a threshold helper attached to `main_device` - `main device` go...

Thanks, that's a very clear explanation 👍

coarse wadi May 27, 2025, 1:52 PM

#

Do entitiy and device registry contains critical personal info?

#

Can I share them here or do I share them provately to you @untold helm ?

untold helm May 27, 2025, 1:52 PM

#

as you wish

#

maybe better to share privately since this is not a DM

coarse wadi May 27, 2025, 1:53 PM

#

ONe sec

primal hollow May 27, 2025, 1:53 PM

#

it could contain user identifiers or coordinates

coarse wadi May 27, 2025, 1:59 PM

#

All shared to Erik!

untold helm May 27, 2025, 1:59 PM

#

thanks

#

the entity has indeed been deleted and then recreated

#

it also lost the area btw

untold helm May 27, 2025, 2:04 PM

#

restive elm the old device remains as the "main" device and sub-devices are created for the ...

Where is the migration implemented?

#

Or maybe there's no migration as such?

restive elm May 27, 2025, 2:05 PM

#

No migration, old device remains unchanged

primal hollow May 27, 2025, 2:06 PM

#

What I do find interesting, the main device still exists. In theory it would not have any loaded integration attached, but it would have entities. So I am not sure why it deleted the entity then

untold helm May 27, 2025, 2:06 PM

#

ok, so it's only entities' device_info that's changed so the entities are now part of a different device (which happens to be a sub device)

restive elm May 27, 2025, 2:07 PM

#

exactly, entities get new device_info

untold helm May 27, 2025, 2:10 PM

#

primal hollow What I do find interesting, the main device still exists. In theory it would not...

Probably because I f-ed up something when adding support for subentries

primal hollow May 27, 2025, 2:11 PM

#

I am now looking for it by the way, but how do entities get removed when a device gets removed? I suppose with an event?

#

nvm I found it

untold helm May 27, 2025, 2:12 PM

#

right. i think it's very likely the async_remove_stale_devices_links_keep_entity_device is to blame here. but not sure if it's because of a bug in that function or how it's used or if there's a bug in the device registry

#

I think this might be the problem: https://github.com/emontnemery/home-assistant/blob/24dae6d74b9bfd0217c0db7358df5f51f0243b28/homeassistant/helpers/entity_registry.py#L1039-L1049

#

I don't think the async_remove_stale_devices_links_keep_entity_device is sane

primal hollow May 27, 2025, 2:22 PM

#

I think that sounds about right

#

but I also think that we should be able to remove a config entry from a device without entities being removed

untold helm May 27, 2025, 2:22 PM

#

why?

primal hollow May 27, 2025, 2:23 PM

#

Hmm, now I think about it, this is probably the only use case

#

as other integrations don't work across each others devices, and when they then get removed, we do want to remove entities generally

untold helm May 27, 2025, 2:24 PM

#

Like I said before, i don't understand at all why these helpers are providing device info

primal hollow May 27, 2025, 2:25 PM

#

because now the helpers are attached to the same device, which IMO is a nice enahncement

untold helm May 27, 2025, 2:25 PM

#

No

#

~~it's not a pattern we want to encourage, and it will stop working when devices can only have a single config entry~~

#

~~the way switch_as_x does it is much more robust imo~~

#

~~i don't know why this second pattern was invented, instead of doing what switch as x does~~

#

Meh, never mind my rambling

#

I misremember how switch as x works

#

The way switch_as_x works was initially like I remembered, but it was changed by PR https://github.com/home-assistant/core/pull/89992 so it's now basically like the other helpers do it

#

Anyhow, I the problem is that async_remove_stale_devices_links_keep_entity_device results in the config entry link to the helper config entry being removed before the entity has moved itself to the correct device, the order is this:

Shelly config entry starts, and the entities are moved to new sub devices
The threshold config entry calls async_remove_stale_devices_links_keep_entity_device which removes itself from the main device, which means the threshold entity is removed from the entity registry
The threshold entity is set up, which results in a new entity registry item being created

coarse wadi May 27, 2025, 2:36 PM

#

From a user standpoint, the fact helpers are attacehd to devices is amazing 😄

#

I want that on even more of them. LIke inputs too

#

I'm adding them to soo many devices, it's my way of making a smart device smarter

untold helm May 27, 2025, 2:42 PM

#

I think the proper fix here is to make async_remove_stale_devices_links_keep_entity_device first update the entity's device link to match the source entity's device, and after that remove the helper config entry from any other devices.

#

@primal hollow does this make sense?

primal hollow May 27, 2025, 2:44 PM

#

I think that would make sense yes

untold helm May 27, 2025, 2:47 PM

#

OK

#

Like this maybe?

diff --git a/homeassistant/helpers/device.py b/homeassistant/helpers/device.py
index 16212422236..41fc04a8b39 100644
--- a/homeassistant/helpers/device.py
+++ b/homeassistant/helpers/device.py
@@ -90,6 +86,13 @@ def async_remove_stale_devices_links_keep_current_device(
     """

     dev_reg = dr.async_get(hass)
+    ent_reg = er.async_get(hass)
+    # Make sure all entities are linked to the correct device
+    for entity in ent_reg.entities.get_entries_for_config_entry_id(entry_id):
+        if entity.device_id == current_device_id:
+            continue
+        ent_reg.async_update_entity(entity.entity_id, device_id=current_device_id)
+
     # Removes all devices from the config entry that are not the same as the current device
     for device in dev_reg.devices.get_devices_for_config_entry_id(entry_id):
         if device.id == current_device_id:

#

The name of the device helper functions should also be updated IMO, unless they're used by custom integrations

untold helm May 27, 2025, 3:10 PM

#

PR: https://github.com/home-assistant/core/pull/145719

primal hollow May 27, 2025, 5:29 PM

#

I think we found that squeezebox is doing something interesting here

untold helm May 28, 2025, 5:50 AM

#

what's that?

primal hollow May 28, 2025, 6:37 AM

#

Nvm a test was just failing on CI

primal hollow Jun 8, 2025, 10:55 AM

#

restive elm I don't know why "Switch to X" is losing the original entity. I will investigate...

I think I might have found it https://github.com/home-assistant/core/pull/146329

restive elm Jun 9, 2025, 10:03 AM

#

Sorry I was almost unavailable for the last two weeks. I tested the update from 2025.5.3 to 2025.6.0b5 today and it looks like the switch_as_x entities are not created on the first HA run. After the next HA restart they appear correctly and are assigned to the correct device. The result is exactly the same with and without #146329.

primal hollow Jun 9, 2025, 10:06 AM

#

Oh interesting

untold helm Jun 9, 2025, 11:26 AM

#

Fix: https://github.com/home-assistant/core/pull/146387

#Models and areas don't inherit indeed.