Hello folks, I created a new integration | Home Assistant | Page 1

unique jay Dec 12, 2023, 8:49 PM

#

PR for context: https://github.com/home-assistant/core/pull/104342

heavy oyster Dec 12, 2023, 8:52 PM

#

There are still 2 major problems with the PR:

The device specific login isn't encapsulated in a library
The config flow needs to be 100% unit tested

hallow heath Dec 12, 2023, 10:57 PM

#

Also, please be aware many PRs take months to be merged, if not over a year. There is a PR backlog so do not expect something to be done in a couple of weeks.

heavy oyster Dec 12, 2023, 11:02 PM

#

Yep, that's also why I now directly pointed out the issues so there is a bit more guidance (instead of waiting a few weeks for the same answer)

unique jay Dec 13, 2023, 12:58 PM

#

Thank you for the reply @heavy oyster ! Regarding your comment:

Not sure I understand what does this mean. The integration is pretty much a grouping of different modbus registers and exposing it as climate/sensor/binary sensor (only climate is introduced in this PR, according to an earlier review suggestion). There is no authentication happening (thinking about the device specific login phrase in your comment). Could you expand more?
Makes sense, I will cover the config flow

heavy oyster Dec 13, 2023, 1:02 PM

#

well, The code in HA should only be about how HA should respond to device changes

#Hello folks, I created a new integration